Wednesday, October 4, 2023
9 changes · master
Resolved issues and error corrections
This update improves the wording of an accounting payment error so users better understand what went wrong. Clearer guidance can reduce confusion and help users resolve payment registration issues more quickly.
Original PR description
The message error was not clear, so I changed the message to a clearer explanation of the user error. Signed-off-by: Maximilien La Barre <malb@odoo.com> -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Messages now correctly highlight every mention when the same person or channel is mentioned more than once. This makes conversations clearer and helps users reliably see all intended mentions.
Original PR description
Before this commit, when mentioning a same user in a message twice, only the 1st `@` text was highlighted as a mention. This commit fixes the issue by highlighting all matching mentions of user and channel. Task-3531939
The self-order settings now show the “upgrade to enterprise” label in the correct place for the pay-after-selection option. This helps businesses clearly identify which payment setting requires Enterprise, reducing confusion during configuration.
Original PR description
After merging of the mobile and kiosk app for self order (https://github.com/odoo/odoo/pull/136051), the pay after selection that requires the "upgrade to enterprise" label was misplace. This fix restores the misplaced label. **Before:** <img width="446" alt="Screenshot 2023-10-03 at 14 14 25" src="https://github.com/odoo/odoo/assets/3245568/9220c0df-9ba2-4296-b819-860f78f6d348"> **After:** <img width="469" alt="Screenshot 2023-10-03 at 14 12 34" src="https://github.com/odoo/odoo/assets/3245568/4af2e1cb-c18a-472c-8ae2-302fe09fc39f">
This fixes an issue where Discuss call invitations and ringing conversations could fail to appear after recent internal data handling changes. Users should now reliably see incoming call cards and ringing thread status again.
Original PR description
Discuss model data that had commands have been simplified by [1]. Notably some `unlink` were replaced by `False` and or `DELETE`. Some code in Discuss calls was still expecting receiving command data in of `DELETE` while data received has become `false`. As a result, the state of ringing threads and showing call invitation card was not working. This commit fixes the issue by relying on recent improvements that commands can be passed immediately as data to relational fields [2]. Code in Discuss call still have some coupling between fields whenever some records are either added to or removed from a field. Hooks `onAdd` and `onDelete` on relational fields are added to support these cases. [1]: https://github.com/odoo/odoo/pull/136308 [2]: https://github.com/odoo/odoo/pull/137341
This fixes a livechat issue where visitors could remain tied to an outdated chat session if leaving the session failed. The chat state is now cleaned up reliably, and session restoration avoids sending duplicate initialization requests.
Original PR description
Before this PR, if an error occurred when leaving the session, the state of the livechat was not properly reset. This is an issue since this could lead to a visitor being stuck with an outdated session. This commit ensures the session state is reset even if an error occurs during the session leave rpc.
This fix prevents negative stock quantities from being copied into new detailed operation lines. When a negative stock entry is selected, the quantity now starts at zero, reducing the risk of confusing or incorrect inventory operations.
Original PR description
Choosing a negative quant to create a new move line in the detailled operation should not take the negative quantity. This commit set 0 instead. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix adjusts the stock availability display so the forecast icon lines up neatly with the related reservation text. It improves visual clarity for users reviewing stock moves without changing any business workflow or data.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where the copy-and-close action in appointment invitations could stay disabled even after users resolved the alerts blocking it. The button state now updates correctly as appointment invite conditions change, helping users complete the invite flow without refreshing or reopening the form.
Original PR description
Since the new Relational Model, if the <a> in AppointmentInviteCopyClose is disabled, it is not possible to enable it when you resolve alerts. Why: --- Before the new Relational Mode, the entire view was re-rendered each time the record was updated. AppointmentInviteCopyClose was therefore rendered and the callback in useEffect was called. This is no longer the case, only the Components that observe the data modified on the record are rendered. Solution: --------- We're going to use the dynamicProps.readonly which will be recalculated each time a change occurs in its condition. So we'll pass the readonly attribute to the <widget> with the condition the combination of all the conditions that can display an alert and cause the <a> to be disabled.
The timesheet list now shows the related helpdesk ticket field when users work from the My Timesheets menu. This helps teams link time entries to support tickets more easily and avoids missing context in timesheet records.
Original PR description
Steps: - Install Timesheets and Helpdesk - Open helpdesk and go to any project - Enable timesheet from settings - Now, go to timesheets - Go to my_timesheets list view Issue: - Ticket field is missing in dropdown. Cause: - List view inheriting the primary view. Fix: - Change the ref attribute in inherit field to extended view and add view for helpdesk_ticket_id. task-3478920