Odoo Changelog — 2023-10-05

Thursday, October 5, 2023

1 change · master

Removals(1)

Features or functions removed from Odoo

[REV] pos_self_order, product, website_sale: add product info popup

Coremasterpoint_of_salepos_self_orderproductwebsite_saleMedium

This change reverts a previously added product information popup for self-ordering and related product fields because the shared ecommerce content was not suitable for POS use. It prevents styling and display problems caused by website-only content being shown in POS or backend screens, while separate follow-up work will create a better POS-specific solution.

Original PR description

This reverts commit 3b9401c35423574b57f1081f9c80bd149d79d76b.

It shouldn't have been merged in the first place. The PR was `r-` but it seems like the mergebot bugged and still merged it because there was an occurence of `r+` in the sentence which asked robodoo to `r-`.

> robodoo r- just to be sure, since there was a random r+ not [...]

Rationale of the revert:
- Bad field name:
- "ecommerce" in product module
- "ecommerce" but used in POS
- Arguably very low value to share the field -> This field is used in ecommerce to add info exactly between the price and the name of a product. There is low chance that you want to share that exact information with the POS.
- Technically, it couldn't work. What you design in website builder on the product page is related to website assets JS and CSS, which are not loaded neither in the backend and neither in the POS. It was leading to multiple critical issues, mainly:
- Losing the whole style of the content (CSS)
- Breaking completly the snippets (visually and design wise) (CSS/JS)
- Not even show (JS is in charge of showing the content eg)

Note that the same issues were already existing in that field in the backend (it's shown in the product form view). The ecommerce team was looking for a solution to make it work, but it's impossible as to work, it would need the website / frontend assets, which can't be loaded in the backend / POS.

The cancel of this PR was validated with PO of POS and ecommerce following those explanation, which they weren't aware of.

Apart from this revert, further PR will be done to:
1. Remove the field from the product form view (ecommerce app)
2. Create a new field for POS

Revert of https://github.com/odoo/odoo/pull/136906

task-3524272

#revert#product information#POS#ecommerce

This reverts commit 3b9401c35423574b57f1081f9c80bd149d79d76b. It shouldn't have been merged in the first place. The PR was `r-` but it seems like the mergebot bugged and still merged it because there was an occurence of `r+` in the sentence which asked robodoo to `r-`. > robodoo r- just to be sure, since there was a random r+ not [...] Rationale of the revert: - Bad field name: - "ecommerce" in product module - "ecommerce" but used in POS - Arguably very low value to share the field -> This field is used in ecommerce to add info exactly between the price and the name of a product. There is low chance that you want to share that exact information with the POS. - Technically, it couldn't work. What you design in website builder on the product page is related to website assets JS and CSS, which are not loaded neither in the backend and neither in the POS. It was leading to multiple critical issues, mainly: - Losing the whole style of the content (CSS) - Breaking completly the snippets (visually and design wise) (CSS/JS) - Not even show (JS is in charge of showing the content eg) Note that the same issues were already existing in that field in the backend (it's shown in the product form view). The ecommerce team was looking for a solution to make it work, but it's impossible as to work, it would need the website / frontend assets, which can't be loaded in the backend / POS. The cancel of this PR was validated with PO of POS and ecommerce following those explanation, which they weren't aware of. Apart from this revert, further PR will be done to: 1. Remove the field from the product form view (ecommerce app) 2. Create a new field for POS Revert of https://github.com/odoo/odoo/pull/136906 task-3524272