Friday, October 6, 2023
7 changes · master
Code cleanup and technical improvements
This change replaces a temporary internal shortcut with the supported way to access web app information. It reduces maintenance risk in the web interface without changing day-to-day user behavior.
Original PR description
In a previous commit, we temporarily used the `__OWL__DEVTOOLS__` global variable to access the list of all apps. This was obviously not something that we want to do, so we introduced a proper hook in Owl. This commit changes the code to use the static apps object from the App class. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change removes an outdated internal workaround in Odoo's web rendering system and simplifies how server-side rendering is set up. It should make the web codebase easier to maintain without changing day-to-day user workflows.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A spreadsheet interface button style was renamed to stay aligned with the underlying spreadsheet component. This is an internal cleanup that helps keep the code consistent and should not change how users work with spreadsheets.
Original PR description
Commit odoo/o-spreadsheet@adcda84 renamed the button class. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change updates spreadsheet interface files to use a renamed button style from the underlying spreadsheet component. It keeps spreadsheet side panels and related tests aligned with the shared component changes, with no expected change to day-to-day user workflows.
Original PR description
Commit odoo/o-spreadsheet@adcda84 renamed the button class.
This change simplifies internal rendering setup for parts of Point of Sale preparation displays and Sign documents. It aligns these areas with a shared platform update, reducing custom code and helping future maintenance without changing day-to-day user workflows.
Some internal quality check logic has been moved from the general Quality app into Quality Control, where the related data is managed. This keeps the product structure cleaner and reduces the chance of future maintenance issues, with no expected change for users.
Original PR description
Both functions use the `measure_on` field of `quality.point` which is defined in the `quality_control` module. This didn't raise any issue as both functions are only used in `quality_control` and `quality_mrp` (which requires `quality_control`). Moved them to `quality_control` as this is where they should have probably been in the first place.
The way Odoo stores and displays change history in the chatter has been streamlined by removing redundant stored data and relying on existing field information when needed. This reduces internal complexity and should make tracking-related code easier to maintain, while preserving the same business behavior for users.
Original PR description
PURPOSE Simplify 'mail.tracking.value' model and code. Remove unnecessary fields and computation. Make code easier to handle and more batch-enabled. SPECIFICATIONS Remove 'tracking_sequence' on…
PURPOSE Simplify 'mail.tracking.value' model and code. Remove unnecessary fields and computation. Make code easier to handle and more batch-enabled. SPECIFICATIONS Remove 'tracking_sequence' on tracking values in DB. Consider insertion order should be done accordingly and display them based on ID DESC. Sequence is now used only for order records to insert in DB and can be used to resequence them using the field description at any time. Feature is still the same (order based on sequence) but without having to store the sequence itself. It was never updated anyway. Remove 'field_desc' and 'field_type' from 'mail.tracking.value' model. Those can be retrieved when necessary, as it is mainly used for frontend display in Chatter. Remove 'old_value_monetary' and 'new_value_monetary' as float value can be used instead. Rename 'field' to 'field_id' to better indicate it is a m2o, and not a char field holding a field name. Improve support of o2m / m2m tracking. Cleanup overall tracking code: try to make methods more consistent with I/O, cleanup formatting methods. While working on tracking, let us cleanup a bit tests and various code bits. Task-3345979 (Mail: Simplify tracking model)