Monday, October 9, 2023
13 changes · master
Enhancements to existing features
The referral application status label now has enough spacing to display clearly. This small visual improvement makes status information easier for users to read at a glance.
Original PR description
[IMP] hr_referral: make status readable The padding of the status pill is not enough to display the status correctly. task-3498668
Code cleanup and technical improvements
This update modernizes internal web request handling code across several Odoo Enterprise apps. It reduces outdated implementation patterns, making future maintenance easier without changing expected user-facing behavior.
Miscellaneous changes
The sale order report (and other reports) generated in the portal page does not render the images that could have been added with Studio Steps to reproduce: 1. Install Sales and Studio 2. Go to Sales and open any quotation 3. Toggle Studio and add an image field anywhere in the form 4. Go to reports and edit "Quotation / Order" 5. Add the new image field in the report and close Studio 6. Create a quotation for Joel Willis, add an image and a product 7. Send the quotation by mail 8. Op
Original PR description
The sale order report (and other reports) generated in the portal page does not render the images that could have been added with Studio Steps to reproduce: 1. Install Sales and Studio 2. Go to Sales…
The sale order report (and other reports) generated in the portal page does not render the images that could have been added with Studio Steps to reproduce: 1. Install Sales and Studio 2. Go to Sales and open any quotation 3. Toggle Studio and add an image field anywhere in the form 4. Go to reports and edit "Quotation / Order" 5. Add the new image field in the report and close Studio 6. Create a quotation for Joel Willis, add an image and a product 7. Send the quotation by mail 8. Open the sent mail (Settings > Technical > Email > Emails) 9. Open the sale order link in a new incognito tab 10. Download the sale order with the button at the top left of the page 11. The report doesn't contain the image Solution: Add the attribute `qweb_img_raw_data` on binary fields created in Studio in order to render the images as raw data directly in the html Problem: When generating the html that will be used to render the pdf, the image field is rendered with a src url. This url will then be resolved in the content_image route but the user is public so he has no rights on the field. Hence, the placeholder image is returned. opw-3100989 Forward-Port-Of: odoo/enterprise#47117 Forward-Port-Of: odoo/enterprise#46400
This change updates internal record selection components used in Accounting Reports and Studio to better match their purpose. Users should see the same overall workflows, with cleaner and more maintainable selection behavior behind the scenes.
Since odoo/odoo#109661 partial payments can confirm SO/subscriptions. For subscriptions, we have to force auto-invoice in this situation instead of waiting for the cron to invoice it with the risk of charging customer twice (as we do with payments in the portal). task-id : 3366756 Forward-Port-Of: odoo/enterprise#45572 Forward-Port-Of: odoo/enterprise#42925
Original PR description
Since odoo/odoo#109661 partial payments can confirm SO/subscriptions. For subscriptions, we have to force auto-invoice in this situation instead of waiting for the cron to invoice it with the risk of charging customer twice (as we do with payments in the portal). task-id : 3366756 Forward-Port-Of: odoo/enterprise#45572 Forward-Port-Of: odoo/enterprise#42925
To calculate the sum of the discounts and obtain the total for the EDI, the discount was recalculated considering the unit price. This calculation is wrong when we have a tax with the configuration of 'included in the price'. We fixed the calculation of the total discount using the '_l10n_ec_prepare_edi_vals_to_export_USD' method that returns the discount per line, in this way in the EDI both the total discount value matches the values in the lines Forward-Port-Of: odoo/enterprise#46361
Original PR description
To calculate the sum of the discounts and obtain the total for the EDI, the discount was recalculated considering the unit price. This calculation is wrong when we have a tax with the configuration of 'included in the price'. We fixed the calculation of the total discount using the '_l10n_ec_prepare_edi_vals_to_export_USD' method that returns the discount per line, in this way in the EDI both the total discount value matches the values in the lines Forward-Port-Of: odoo/enterprise#46361
Steps to reproduce: - Install sendcloud carrier and eCommerce - Create a new shipping method (with sendcloud as provider) - Enable other shipping method - visit /shop and cable box to cart and process to checkout Bug: user error page (delivery from US is not supported) Fix: if other carriers are avialable user should be able to proceed similar to "bpost_rate_shipment" Forward-Port-Of: odoo/enterprise#47550
Original PR description
Steps to reproduce: - Install sendcloud carrier and eCommerce - Create a new shipping method (with sendcloud as provider) - Enable other shipping method - visit /shop and cable box to cart and process to checkout Bug: user error page (delivery from US is not supported) Fix: if other carriers are avialable user should be able to proceed similar to "bpost_rate_shipment" Forward-Port-Of: odoo/enterprise#47550
When looking for a sales price and no product.pricing is found matching the product, recurrence, currency and price list the fallback must use the product variant sales price (product.product.lst_price) instead of the product template sales price (product.template.list_price), as the lst_price is computed using list_price of the template + price_extra of the variant. Forward-Port-Of: odoo/enterprise#42514
Original PR description
When looking for a sales price and no product.pricing is found matching the product, recurrence, currency and price list the fallback must use the product variant sales price (product.product.lst_price) instead of the product template sales price (product.template.list_price), as the lst_price is computed using list_price of the template + price_extra of the variant. Forward-Port-Of: odoo/enterprise#42514
Steps to reproduce: - Install eCommerce and sendcloud delivery - Add new shipping methods with sendcloud as provider and mondial relay 0/0.5/1/2 Kg - Add an item below 0.5Kg weight to the cart and proceed to checkout Bug: delivery product with minimum weight above the order are still displayed opw-3432905 Forward-Port-Of: odoo/enterprise#47579
Original PR description
Steps to reproduce: - Install eCommerce and sendcloud delivery - Add new shipping methods with sendcloud as provider and mondial relay 0/0.5/1/2 Kg - Add an item below 0.5Kg weight to the cart and proceed to checkout Bug: delivery product with minimum weight above the order are still displayed opw-3432905 Forward-Port-Of: odoo/enterprise#47579
Currently, if we have a really huge amount of `original_moves`, fetching their `deferred_move_ids` to add the newly created deferral entries will result in a MemoryError. This commit fixes this by creating the relation between the original deferred move and its deferral entry in SQL instead which speeds up the process. task-id 3349785 Forward-Port-Of: odoo/enterprise#48480
Original PR description
Currently, if we have a really huge amount of `original_moves`, fetching their `deferred_move_ids` to add the newly created deferral entries will result in a MemoryError. This commit fixes this by creating the relation between the original deferred move and its deferral entry in SQL instead which speeds up the process. task-id 3349785 Forward-Port-Of: odoo/enterprise#48480
Issue: ====== When an employee have canteen cost it doesnt show in the details of net salary. Steps to reproduce the error : ============================== - Install l10n_be_hr_contract_salary - Select My belgian company - Go to employees and select Laurie - Select in Contract Since smart button - Go to salary information and add a canteen cost - Click on generate offer and click save - Go to the created link in the offer form. - Click on details on net - There is no canteen cost
Original PR description
Issue: ====== When an employee have canteen cost it doesnt show in the details of net salary. Steps to reproduce the error : ============================== - Install l10n_be_hr_contract_salary - Select My belgian company - Go to employees and select Laurie - Select in Contract Since smart button - Go to salary information and add a canteen cost - Click on generate offer and click save - Go to the created link in the offer form. - Click on details on net - There is no canteen cost Solution: ========= In the override of the function , l10n_be_canteen _cost is always set to False , updating it with the value in the contract solved the problem. opw-3536125 Forward-Port-Of: odoo/enterprise#48466
### Steps - Log in as Marc Demo. - Upload a template and add elements. - Log out and log in with Mitchell. - Open the template (everything is ok, added elements appear). - Sign it, then open the template again. ### Issue The elements have disappeared but when log in with Marc Demo, they are there. ### Reason Security issue. BackPort-of: https://github.com/odoo/enterprise/pull/46087 opw-3520444 Forward-Port-Of: odoo/enterprise#48287
Original PR description
### Steps - Log in as Marc Demo. - Upload a template and add elements. - Log out and log in with Mitchell. - Open the template (everything is ok, added elements appear). - Sign it, then open the template again. ### Issue The elements have disappeared but when log in with Marc Demo, they are there. ### Reason Security issue. BackPort-of: https://github.com/odoo/enterprise/pull/46087 opw-3520444 Forward-Port-Of: odoo/enterprise#48287
When the user tries to export the translation of 'account_accountant, knowledge, web_studio' modules during that time errors will occur in the backend. To reproduce the issue of 'web_studio' module: 1) Install 'web_studio'. 2) Go to Settings -> Translations-> Eport Translation. 3) In the 'Apps To Export', select 'Studio' and Click on the 'Export' button Trancback will appear. The same steps are applied to other modules for their issue. https://github.com/odoo/enterprise/blob/45
Original PR description
When the user tries to export the translation of 'account_accountant, knowledge, web_studio' modules during that time errors will occur in the backend. To reproduce the issue of 'web_studio' module:…
When the user tries to export the translation of 'account_accountant, knowledge, web_studio' modules during that time errors will occur in the backend. To reproduce the issue of 'web_studio' module: 1) Install 'web_studio'. 2) Go to Settings -> Translations-> Eport Translation. 3) In the 'Apps To Export', select 'Studio' and Click on the 'Export' button Trancback will appear. The same steps are applied to other modules for their issue. https://github.com/odoo/enterprise/blob/4533bb91ef2d81f3e639784858469f73790470df/account_accountant/static/src/components/bank_reconciliation/bank_rec_widget.xml#L270 In the above line, The opening tag was a 'span' but closed with a 't-tag'. In knowledge, the closing of the 'templates' tag is mismatched https://github.com/odoo/enterprise/blob/4533bb91ef2d81f3e639784858469f73790470df/knowledge/static/src/components/html_field/html_field.xml#L2-L8 In the above line, The opening tag was 'template' instead of 'templates'. In web_studio, the closing of the 'Dialog' tag is not added. https://github.com/odoo/enterprise/blob/4533bb91ef2d81f3e639784858469f73790470df/web_studio/static/src/client_action/components/menu_creator.xml#L53-L71 In the above line, Added closing of the 'Dialog' tag This commit will apply the correct closing tag. sentry-3951803776 Community PR-https://github.com/odoo/odoo/pull/128221 Forward-Port-Of: odoo/enterprise#48412 Forward-Port-Of: odoo/enterprise#43975