Odoo Changelog — 2023-10-10

Tuesday, October 10, 2023

60 changes · master

New Features(1)

New functionality added to Odoo

[ADD] base: add en_NZ language

Coremasterbase

Odoo now includes New Zealand English as a selectable language. This helps New Zealand users get locale settings that better match their region instead of relying on United States English defaults.

Original PR description

To avoid using the default en_US (which has different locale settings)

#language#locale#New Zealand

Improvements(6)

Enhancements to existing features

[IMP] mail: remove legacy code in `patch_ui_size`

PR #135273

Coremastermail

Removes outdated support code from the mail module's test helpers because the newer interface environment now covers that need. This is an internal cleanup that reduces maintenance overhead without changing day-to-day user behavior.

Original PR description

As the comment says:
> This function must be removed when the WOWL env will be available in
> the form_renderer.

This code seems not needed anymore.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#cleanup#mail#tests

[IMP] account_auto_transfer: create move only when lines exists

Bug Fixes(4)

Resolved issues and error corrections

[FIX] Fix focus view with searchpanel

PR #138085

Coremasterweb

This fixes an issue where pages with a search panel would automatically jump back to the top. Users now get consistent scrolling behavior whether or not a search panel is shown, making navigation less disruptive.

Original PR description

Before this commit, if a view contained a searchPanel the scrollbar went at the top automatically; now the behavior of the scrollbar in a view with or without a searchPanel is the same.

task : 3503894

with help of @Arcasias 
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#scrolling#search panel#usability

[FIX] mail: style mention without `@extend`

Removals(1)

Features or functions removed from Odoo

[REM] web: redundant escapeHTML function

PR #137216

Coremastermailweb

This change removes a little-used duplicate text escaping function and makes the standard escaping behavior more complete. It helps keep web and mail-related code simpler while maintaining safer handling of quotes in displayed values.

Original PR description

In https://github.com/odoo/odoo/commit/a6fea376bb2e75f2ca617811f41d83768c078f85, escapeHTML was introduced to replace the corresponding
underscore.js function. It is very similar to the widely used escape
function, except it additionally escapes single (') and double (")
quotes.

The additional escaping is not generally harmful, and is necessary to
safely inject values into attributes. As escapeHTML is almost unused,
remove it and update escape to include quotes.

taskId : 3522892

#cleanup#web#mail

Refactoring(8)

Code cleanup and technical improvements

[REF] web,*: make draggable hook builder independant from Owl

PR #136116

Coremasterim_livechatweb

This change reorganizes the drag-and-drop building blocks so they no longer depend on one specific front-end framework. It makes the same behavior easier to use in more areas of Odoo, including places where that framework is not available, with little expected visible change for users.

Original PR description

This commit removes Owl hooks from the draggable hook builder file and introduces a new parameter attribute (`setupHooks`) to specify which functions must be used to set up, update and tear down the draggable hook.

This has been done to allow the draggable hook builder function to be used in environments where Owl is not available.

Enterprise: https://github.com/odoo/enterprise/pull/47693

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#drag-and-drop#frontend

Other(40)

Miscellaneous changes

[FW][PERF] sale_project: speed up reads on `tasks_ids`

PR #138007

Coremastersale_project

Original PR description

## Issue
Reading on the field `tasks_ids` of the `sale.order` model in some context can be slow, leading to really slow creation and duplication of tasks on a medium sized database.

## Analysis
After creation of a task, when the ORM flushes the model, it recomputes all the inverse dependencies that needs to be recomputed.
Currently `task_ids` doesn't implement a `search` routine on the field, so `task_ids` needs to be recomputed for *all* sales orders, since we don't know which sales order needs computation. So for *all* sales orders, we trigger the compute `_compute_tasks_ids`, which is badly implemented using the general performance anti-pattern
```py
for record in records:
    field = self.env['model'].search(domain)
```
which makes 1 query per record that we are computing.

## Solution
Correct the implementation of `_compute_tasks_ids`, which now uses a `_read_group` instead so we do 1 query for the whole recordset. And implement the `search` on the non-stored `tasks_ids` field, which speeds up the context of re-computations. This allows the ORM to know for which sales order the field `task_ids` needs re-computation.

## Results
In the context a mid-size database (less than 10k records for the concerned models)

Task creation/duplication:

|             | Before | After |
|-------------|--------|-------|
| Time        | 1 min  | 1 sec |
| Query count | 40k    | 300   |

## Reference
opw-3445565

Forward-Port-Of: odoo/odoo#137542
Forward-Port-Of: odoo/odoo#136255

As the comment says: > This function must be removed when the WOWL env will be available in > the form_renderer. This code seems not needed anymore. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Before this commit, if a view contained a searchPanel the scrollbar went at the top automatically; now the behavior of the scrollbar in a view with or without a searchPanel is the same. task : 3503894 with help of @Arcasias --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

In https://github.com/odoo/odoo/commit/a6fea376bb2e75f2ca617811f41d83768c078f85, escapeHTML was introduced to replace the corresponding underscore.js function. It is very similar to the widely used escape function, except it additionally escapes single (') and double (") quotes. The additional escaping is not generally harmful, and is necessary to safely inject values into attributes. As escapeHTML is almost unused, remove it and update escape to include quotes. taskId : 3522892

This commit removes Owl hooks from the draggable hook builder file and introduces a new parameter attribute (`setupHooks`) to specify which functions must be used to set up, update and tear down the draggable hook. This has been done to allow the draggable hook builder function to be used in environments where Owl is not available. Enterprise: https://github.com/odoo/enterprise/pull/47693 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

## Issue Reading on the field `tasks_ids` of the `sale.order` model in some context can be slow, leading to really slow creation and duplication of tasks on a medium sized database. ## Analysis After creation of a task, when the ORM flushes the model, it recomputes all the inverse dependencies that needs to be recomputed. Currently `task_ids` doesn't implement a `search` routine on the field, so `task_ids` needs to be recomputed for *all* sales orders, since we don't know which sales order needs computation. So for *all* sales orders, we trigger the compute `_compute_tasks_ids`, which is badly implemented using the general performance anti-pattern ```py for record in records: field = self.env['model'].search(domain) ``` which makes 1 query per record that we are computing. ## Solution Correct the implementation of `_compute_tasks_ids`, which now uses a `_read_group` instead so we do 1 query for the whole recordset. And implement the `search` on the non-stored `tasks_ids` field, which speeds up the context of re-computations. This allows the ORM to know for which sales order the field `task_ids` needs re-computation. ## Results In the context a mid-size database (less than 10k records for the concerned models) Task creation/duplication: | | Before | After | |-------------|--------|-------| | Time | 1 min | 1 sec | | Query count | 40k | 300 | ## Reference opw-3445565 Forward-Port-Of: odoo/odoo#137542 Forward-Port-Of: odoo/odoo#136255

This traceback arises when the user changes the `end_date` without the `employee` value, while creating a new `Work Entry`. To reproduce this issue: 1) Install `hr_work_entry_contract` 2) Open `payroll` and create a new `Work Entry` 3) Select `Work Entry Type` as `Unpaid` and change the `To` date Error:- ``` KeyError: False File "odoo/http.py", line 2134, in __call__ response = request._serve_db() File "odoo/http.py", line 1710, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "odoo/service/model.py", line 133, in retrying result = func() File "odoo/http.py", line 1737, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 1938, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 191, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 717, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/web/controllers/dataset.py", line 30, in call_kw return self._call_kw(model, method, args, kwargs) File "addons/web/controllers/dataset.py", line 26, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "odoo/api.py", line 461, in call_kw result = _call_kw_multi(method, model, args, kwargs) File "odoo/api.py", line 448, in _call_kw_multi result = method(recs, *args, **kwargs) File "odoo/models.py", line 6781, in onchange todo = [ File "odoo/models.py", line 6784, in <listcomp> if name not in done and snapshot0.has_changed(name) File "odoo/models.py", line 6584, in has_changed return self[name] != record[name] File "odoo/models.py", line 6211, in __getitem__ return self._fields[key].__get__(self, type(self)) File "odoo/fields.py", line 1157, in __get__ self.recompute(record) File "odoo/fields.py", line 1367, in recompute apply_except_missing(self.compute_value, recs) File "odoo/fields.py", line 1340, in apply_except_missing func(records) File "odoo/fields.py", line 1389, in compute_value records._compute_field_value(self) File "odoo/models.py", line 4553, in _compute_field_value fields.determine(field.compute, self) File "odoo/fields.py", line 101, in determine return needle(*args) File "addons/hr_work_entry/models/hr_work_entry.py", line 84, in _compute_duration durations = self._get_duration_batch() File "home/odoo/src/enterprise/saas-16.4/hr_work_entry_contract_planning/models/hr_work_entry.py", line 46, in _get_duration_batch res.update(super(HrWorkEntry, super_we)._get_duration_batch()) File "addons/hr_work_entry_contract/models/hr_work_entry.py", line 119, in _get_duration_batch result[work_entry.id] = mapped_contract_data[(date_start, date_stop)][calendar][employee.id]['hours'] ``` On the `_get_duration_batch` method when the user is not given employee value, there will be no `contract_id` as it is getting value from `employee_id`. It leads to the above traceback as `result[work_entry.id]` is getting value through `employee.id`. See:- https://github.com/odoo/odoo/blob/a277faa2ffab7559fcbad95fcc1e8fd6a26d756b/addons/hr_work_entry_contract/models/hr_work_entry.py#L110-L112 Will resolve this issue by calculating duration without employee sentry-4514970596 Forward-Port-Of: odoo/odoo#137699

Install auth_oauth and via the /web/login, click the "Log in using Odoo.com" button. You are redirected on odoo.com which ask you for your odoo.com login and password. When the login form on odoo.com is submited, you are redirected back on your local database. The problem is that, in case a new account was created on-the-fly, then the login fails with a cryptic error. The actual error is that `request.env.user._is_internal` fails because `user` is an empty recordset where it should had been the just-authenticated user. The problem is an inconsistent transaction state between the cursor of the request, the cursor used with `auth_oauth` (which created a new user) and the cursor used with `authenticate` (which authenticated the new user). Yes, there are 3 cursors. The newly created user just isn't present in the transaction of the request's cursor. Here is the lifetime of the 3 cursors: * request.env.cr, it begins when the http request enters Odoo, it is commited when a http response exits Odoo. * /auth_oauth/signin, it begins roughly at the beginning of the controller, it is commited once after the user is created (so before the authenticate transaction begins but AFTER the request transaction begun), it is commited again when the controller exits. * authenticate, begins when authenticate is called, is commited when it returns. Because the request transaction started before, it cannot access user created by /auth_oauth/signin. Because the route is `auth='none'`, if system administrators append the `auth_oauth` module via `--load` (cli) or `server_wide_modules` (odoorc) then the controller can be accessed without database. This is the reason for the explicit registry/cursor/environment inside this controller, we needed to make sure we are connected to a database, we cannot rely on request. The new approach used in this work is to benefit from `ensure_db()`, the function that is used by various web `auth='none'` controllers such as /web and /web/login. It makes sure that the database we want to connect to is already present on the request, otherwise it repeats the request but this time connecting it to the database. Using this approach we can have a `auth='none'` controller whose request.env is guaranteed to be connected on the right database. We can avoid to create explicit new registry/cursor/environment within the controller and just use request's ones. Because the /auth_oauth/signin controller now simply use the request transaction, the above point: > Because the request transaction started before, it cannot access user > created by /auth_oauth/signin. just doesn't stand anymore as the user is created within the same transaction. The extra `cr.commit()` must still be present for `authenticate` to see the newly created user. opw-3421701 Forward-Port-Of: odoo/odoo#137579

Description of the issue/feature this commit addresses: When opening a view with the quick filters available with a domain which returns no data, a message shows up saying that no filter is available for the data that has been retrieved and tells the user that updating the filters will allow him to display more records and maybe make the quick filter available. This message is displayed in a way which is not so great for user experience as it is written in a very thin column making the text being written one word per line. The example used to point out that problem is using the mexican localization, going in the accounting app, in the tax report and clicking on any value equals to zero. Desired behavior after the commit is merged : This commit replaces that message with a "All" button like it would be if the domain had returned data and some filters were available. Only this time, no filter is available under the button as there is still no data to filter. Adding this fix, there is no messy message showing up in the quick filters column when the query was not able to retrieve any data with the given domain. task-3462024 Enterprise PR : https://github.com/odoo/enterprise/pull/46422 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#133358

#### [REV] core: remove ORM `display_name` fallback This reverts commit 4573ca0c83eb63785016f4389a5157efb21fa9a4. Because now, `display_name` is implicitly on every form (last breadcrumb item). Then it will be queried by `onchange` calls. When we create a new record, `_rec_name` can be `False` and the display_name will be a technical one: '<model_name>,<NewId0x...>' which is uglier than the previous situation showing 'New'. #### [FIX] web: take in account `false` as a valid `display_name` The previous commit reverts the ORM fallback of `display_name`. Then the `display_name` can legitimately be `False` again. But the `Many2one` and `Many2XAutocomplete` components don't handle this case (and generate a traceback see task-3424154). This commit adds the same fallback ('Unnamed record') for these two problematic components; one when the name_search returns `False` as `display_name` (autocomplete for Many2Xfields) and another when we read the many2one `display_name`. This name is not user friendly, but for the business model it shouldn't happen anyway. It is also better than the empty string which is confusing with no value. Note that there is already a fallback for `display_name` that is used in the broadcrumb (https://github.com/odoo/odoo/blob/50b2a24f22cb470bcc1a9befe677cf794211d7b2/addons/web/static/src/views/form/form_controller.js#L282). #### [FIX] web: display_name "New" fallback should only target new record. There is a fallback in the control panel (https://github.com/odoo/odoo/blob/c22cb6bbadd38ecb050f6d4dc14672868beda20b/addons/web/static/src/search/control_panel/control_panel.xml#L137) if the display_name of the record is empty. But it is never actually used because there is another fallback in the form_controller ("New"). This latter fallback should only be used for new records, not for existing ones. ## Alternative fix The other way is to have a nice fallback in the `_compute_display_name` (ORM side, see https://github.com/odoo/odoo/pull/133923). Unfortunately, the performance cost is not small (each `display_name` should be context-dependent and may generate extra queries to be computed) and the model name (`_description`) is not meant to be user friendly. Instead, a simpler solution is to have fallbacks on the JS side for each case. Forward-Port-Of: odoo/odoo#137098

This PR contains two commits each of which fixes a different unwanted behavior. --- 1. The account_reports module's commit fixes a bug happening in the reports. When unfolding a report which contains lines which have children but are not foldable, the unfolding process would not unfold those lines as they are not unfoldable and it would result in the report missing all the subsections and lines under that one. This is fixed by modifying the unfolding process of such lines. More information about that change can be found in the first commit's message. --- 2. The l10n_lt module's commit fixes a behavior happening in the Lithuanian BS and P&L. In those reports, the first lines of each section are not properly styled. This is due to them having the wrong hierarchy level assigned. This is fixed by forcing the assignment of the right hierarchy level to the lines that are concerned. More information about that change can be found in the second commit's message. --- task-3462024 Community PR : https://github.com/odoo/odoo/pull/133358 --- I confirm I have signed the CLA and read the PR guidelines at [www.odoo.com/submit-pr](http://www.odoo.com/submit-pr) Forward-Port-Of: odoo/enterprise#46422

New Features(1)

[ADD] base: add en_NZ language

Improvements(6)

[IMP] mail: remove legacy code in `patch_ui_size`

[IMP] account_auto_transfer: create move only when lines exists

Bug Fixes(4)

[FIX] Fix focus view with searchpanel

[FIX] mail: style mention without `@extend`

Removals(1)

[REM] web: redundant escapeHTML function

Refactoring(8)

[REF] web,*: make draggable hook builder independant from Owl

Other(40)

[FW][PERF] sale_project: speed up reads on `tasks_ids`

New Features(1)

[ADD] base: add en_NZ language

Improvements(6)

[IMP] mail: remove legacy code in `patch_ui_size`

[IMP] account_auto_transfer: create move only when lines exists

Bug Fixes(4)

[FIX] Fix focus view with searchpanel

[FIX] mail: style mention without `@extend`

Removals(1)

[REM] web: redundant escapeHTML function

Refactoring(8)

[REF] web,*: make draggable hook builder independant from Owl

Other(40)

[FW][PERF] sale_project: speed up reads on `tasks_ids`

[IMP] account_accountant: remove unused and overgenerative SCSS rules

[IMP] planning: remove unused field overlap_slot_count

[DRAFT][IMP] hr_appraisal: add (copy) at the end when duplicating the plan

[IMP] *: views: deprecate active_* keys from evalContext

[FIX] product: fix duplicated barcode test

[FIX] pos_restaurant_appointment: Fix appointment name in floor screen

[REF] web,*: remove legacy service provider

[REF] web: remove getBundle usages (1)

[REF] web,crm: remove tempusdominus scss customization

[REF] web_enterprise: remove tempusdominus scss customization

[REF] *: make draggable hook builder independant from Owl

[REF] web_enterprise: remove enterprise legacy service provider

[REF] web_enterprise,web_studio: adapt useSortable to be used natively

[FW][IMP] l10n_fr: add a SIRET to demo data

[FW][CLA] signature for trungtuan88

[FW][CLA] signature for PallaviSrivastavaa

[FW][FIX] hr_work_entry_contract: compute duration without employee

[FW][FIX] calendar: modify template for resource appointment

[FW][FIX] auth_oauth: missing user in signin endpoint

[FW][FIX] website_forum: fix traceback on searching in help webpage

[FW][FIX] crm: allow lead creation without stage

[FW][REV] base_geolocalize: revert useragent selection

[FW][FIX] website_slides: hide suggested slides page slide when click prev

[FW][FIX] project: hide empty stages when user perform subtask action

[FW][IMP] web: No quick filter available message replacement

[FW][IMP] bus: better websocket error logging

[FW][FIX] base: use non-breaking spaces for thousand separators

[FW][FIX] web_editor: strange padding when background color is reset

[FW][FIX] point_of_sale: change check for tips default value

[FW][FIX] account: harmonize analytic search view

[FW] Saas 16.4 perf lul

[FW] Revert fallback `display_name` + add fallback into webclient

[FW][FIX] mail: turn twilio credentials method into a util function

[FW][FIX] sale_stock : Create backorder with inventory admin

[FW][FIX] mass_mailing: duplicate the "Send final on" field when copy

[FW][FIX] website_sale: shows correct product attribute `display_type`

[FW][CLA] signature for kevin11andrew

[FW][CLA] Add new contributors to C2C CLA

[FW][FIX] base: _get_multi fails when no company in env

[FW][FIX] point_of_sale: docids doesn't represent a session_id

[FW][FIX] event_sale: get the right number of registrations

[FW][FIX] sale_loyalty: prevent partial reward with loyalty points

[FW][IMP] l10n_ar: invoice report contact partner

[FW][FIX] account_reports: tax unit filter

[FW][FIX] l10n_lu_reports: fix xsd validation

[FW][FIX] {account,l10n_lt}_reports: Unfolding behavior correction

[FW][FIX] l10n_be_intrastat: export reports conditionally

[FW][FIX] sign: sign template not deleting sign item

[FW][FIX] appointment: modify template for resource appointment

[FW][FIX] l10n_dk_reports: make formula less restrictive

[FW][FIX] project_sale_subscription: set test project as billable

[FW][FIX] hr_appraisal: Fix request appraisal email template

[IMP] : views: deprecate active_ keys from evalContext