Friday, October 13, 2023
3 changes · master
Resolved issues and error corrections
This fix prevents live chat messages from being incorrectly shown as sent by the visitor when an agent has a customized live chat name. It preserves the correct author information so conversations are clearer and less confusing for support teams and customers.
Original PR description
Before this commit, the `_message_format` override of the live chat module would overwrite the author. Since [1], values provided by the live chat override are incomplete which result in incorrect message display in the discuss app. This commit modify the live chat override to enrich the author instead of totally overwriting it. Steps to reproduce: - Log in with mitchell admin - Change its live chat user name in its profile - Open a chat with a visitor - Send a message with mitchell - The message is incorrectly marked as sent by the visitor [1]: https://github.com/odoo/odoo/pull/137276
Search filters and fields that should be hidden based on context are now evaluated in the browser and hidden as intended. This prevents users from seeing irrelevant options, such as private task filters, improving consistency in search menus.
Original PR description
Since [1], invisible attributes on views are no longer evaluated server-side. In search views, field and filter nodes can have an invisible attribute which can be static ("1" or "True") or dynamic,…
Since [1], invisible attributes on views are no longer evaluated server-side. In search views, field and filter nodes can have an invisible attribute which can be static ("1" or "True") or dynamic, depending on the context (e.g. "context.get('something')"). Before [1], in the arch received by the client, the value of the invisible attribute was always static as "context.get(...)" expressions were evaluated server-side. This is no longer the case, and we thus have to evaluate the expression client side.
Before this commit, the invisible attributes in search archs were simply ignored if they weren't static. This could be observed for instance in Project > open a project: the "Private tasks" filter was available even though it is dynamically invisible, and shouldn't be there.
This commit ensures the invisible attributes are always taken into account and evaluated.
[1] odoo/odoo@ba1a5509fa49fd846739252d16083dd8cb334b53
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prProject settings can now be saved when projects from different companies are updated together. This prevents an error that previously interrupted users working in multi-company environments.
Original PR description
How to reproduce:
- Link 2 distinct projects to at least 2 different companies
- Modify and save any setting in project settings (this action
should trigger the write function of the project)
--> Traceback: expected singleton
Why?
- If projects associated with differing companies are updated
collectively, the condition self.company_id.id anticipates a
singular value, but it’s possible for there to be multiple.
Solution:
- When we want to write a company_id on some projects, take back the
ones already with the right companyc(as we don't have to change their
stage) and then write the first stage found on the other records (
by putting self.company_id.ids in order to avoid the singleton
exception).
taskid:3520107
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr