Monday, October 16, 2023
36 changes · master
Enhancements to existing features
Test emails for mass mailings now clearly show a [TEST] label in the subject, helping users avoid confusing previews with real campaigns. The test email form also remembers the last address used for testing, saving time for repeated checks.
Original PR description
When sending a test for a mass mailing Before this commit: - subject is the same as for a non-test - default email adress is the current user's After this commit: - subject is prepended with '[TEST]' - default email adress is the one used for a previous test if there is one, otherwise the current user's Task-3378043
The forum sidebar no longer uses a grey background that could clash with custom website designs, especially dark themes. This makes forum pages more consistent and easier to style in the website builder until a better background option is available.
Original PR description
The grey background on the sidebar isn't well supported by the website builder, especially if the user chooses a dark background. To avoid the issue, we've removed the background until a better solution works with the website builder. task-3555851 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Colombian accounting setup now includes default accounts for cash difference gains and losses. This helps companies record small cash discrepancies consistently and reduces manual configuration during accounting setup.
Original PR description
Adds 2 accounts in the Chart of Accounts for l10n_co for the cash difference gains and losses and set them as default accounts. task-3546441 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Colombian profit and loss reports now include the newly added accounts for cash difference gains and losses. This ensures those amounts are categorized correctly in financial statements, improving reporting accuracy for Colombian companies.
Original PR description
The related PR adds 2 accounts in the Chart of Accounts for l10n_co for the cash difference gains and losses. This commit modifies the Profit and Loss reports to properly match the newly created accounts task-3546441
This update keeps the WhatsApp integration aligned with a related platform change in Odoo Community. It helps ensure the feature continues to work smoothly after the underlying communication channel details were adjusted.
Original PR description
https://github.com/odoo/odoo/pull/137623
Resolved issues and error corrections
Live chat conversations now show the configured live chat user name instead of the agent's real account name. This keeps customer-facing chats consistent with the intended display identity and avoids exposing internal names.
Original PR description
Before this commit, the real user name was shown instead of the live chat user name. This PR corrects this behavior.
Code cleanup and technical improvements
This update removes an outdated template setting from the Point of Sale self-ordering module. It is an internal cleanup that keeps the module aligned with the current app structure and should not change the user experience.
Original PR description
As all the templates are now imported in the owl app, there is not need anymore to specify the owl="1" attribute in the templates. Ref-https://github.com/odoo/odoo/pull/130467 Related Enterprise PR-https://github.com/odoo/enterprise/pull/48964 task-3508331 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Before this commit, it crashes when giving the number 0 or 1 as path to the ModelFieldSelector in debug mode. This commit fixes the ModelFieldSelector's props validation. Forward-Port-Of: odoo/odoo#138334
Original PR description
Before this commit, it crashes when giving the number 0 or 1 as path to the ModelFieldSelector in debug mode. This commit fixes the ModelFieldSelector's props validation. Forward-Port-Of: odoo/odoo#138334
Portal users editing shared project tasks will no longer see image, video, or file insertion options that they cannot use. This avoids confusing access error messages and keeps the editing experience focused on actions available to them.
Original PR description
Steps: - Install project. - Create a project and it's task. - Share this project to portal user with editable rights. - Open that project from portal user. - In task description, using `/image`, add one image. Issue: - There comes an Access error: Sorry, you are not allowed to access this document. Solution: - We are passing `'allowCommandImage': false, 'allowCommandVideo': false, 'allowCommandFile': false}` so that portal user can't have the /image and related options. task-3463461
This update corrects a small wording issue in the HR settings by changing an awkward label related to “working.” It improves clarity for users configuring HR options without changing any functionality.
Original PR description
--- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes the file path used to load the TikTok icon font in the web interface. The correction helps ensure the icon displays properly instead of failing to load due to an incorrect location.
Original PR description
This updates the relative url of the 'woff' font that was one parent too far. Bug introduced in [1] [1] : https://github.com/odoo/odoo/commit/47c5a092196054359d82edbc79dea0caf213dd9f task-3477965
This update corrects layout problems in the Studio home menu after recent menu structure changes. It helps keep the interface usable and visually consistent for users working in Odoo Studio.
Original PR description
Commit[1] introduced some changes to the studio home menu to fix some layout and usability. These changes were applied on Master via a forward-port, but since the structure of the home studio menu changed, we need to modify a bit the way the layout and the classes applied to the elements. Commit[1]: 92bbabd92d320af639c18348e15f5999429e4822 task-3536769
The depreciation schedule report now displays its table shading correctly, removing unwanted gray squares while keeping alternating column backgrounds for readability. The table header styling has also been restored, making the report easier to review and consistent with earlier versions.
Original PR description
In the depreciation schedule report, multiple gray squares appear as a background color in multiple cells. This commit solves the issue and restore the gray background color for one column out of two to have a better visualization. The header of the table is also fixed as a class was missing. The SCSS code was therefore useless. The result is now similar to what was rendered in odoo 15. task: 3226777
This update corrects how the Documents Spreadsheet tests simulate browser information. It helps prevent test failures and reduces the risk of spreadsheet-related features behaving incorrectly when browser details are checked.
Original PR description
This commit fixes the patch made to the browser object. Before this commit, the navigator property only has the clipboard property defined, which could cause other issues, with the code using the browser.navigator object to define some properties. It is part of the task-3275275, when the feature detection is made using browser.navigator.userAgent. A test would fail without this fix.
Fixed display issues in the main Odoo home menu and Studio home menu so app icons and edit controls appear in the right place. This improves usability and keeps automated checks aligned with the updated layout.
A test tour selector was updated after an underlying interface markup change moved the kanban view icon inside the button. This keeps the helpdesk knowledge workflow validation reliable without changing customer-facing behavior.
Original PR description
Beforer this commit, the `button.o_switch_view.oi-view-kanban` no longer finds the button because of a changes done in community version. That is, the `oi-view-kanban` class has been moved into a new `i` tag displayed inside that button. This commit changes the selector to correcly select the button expected, that is, the kanban button in views switcher to display the kanban view. task-3376776
This update removes older internal asset-loading calls from the web editor and web areas, moving part of the mobile preview setup to a server-generated template. This helps simplify the underlying asset system, making future maintenance easier without introducing a direct user-facing feature change.
Original PR description
In this commit, we remove three usages of the getBundle function from @web/core/assets.js. The final goal is to remove it totally to simplify the understanding of assets's API. To replace the use of getBundle in mobile preview dialog, an xml template has been created on the server side and then called by http requests. During the request, we retrieve the list of assets (server side getbundle) to inject these into the xml template. taskId : 3266441 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update removes an old template marker that is no longer needed because templates are now handled automatically by the app framework. It should not change how users work with Odoo, but it helps keep the codebase cleaner and easier to maintain.
Original PR description
As all the templates are now imported in the owl app, there is not need anymore to specify the owl="1" attribute in the templates. Ref-https://github.com/odoo/odoo/pull/130467 task-3508331
Steps to reproduce: 1. install l10n_br and set up a Brazilian company with Brazilian customers 2. go to validate a sale as a Brazilian customer 3. fill in the CPF field w/ 11 digit number 4. error: "invalid CNPJ. Make sure that the CNPJ number is 14 digits" Issue: the code only accepts and validates CNPJ codes Fix: add support for CPF codes with its validation function according to: http://www.receita.fazenda.gov.br/aplicacoes/atcta/cpf/funcoes.js opw-3421476 Forward-Port-Of: odo
Original PR description
Steps to reproduce: 1. install l10n_br and set up a Brazilian company with Brazilian customers 2. go to validate a sale as a Brazilian customer 3. fill in the CPF field w/ 11 digit number 4. error: "invalid CNPJ. Make sure that the CNPJ number is 14 digits" Issue: the code only accepts and validates CNPJ codes Fix: add support for CPF codes with its validation function according to: http://www.receita.fazenda.gov.br/aplicacoes/atcta/cpf/funcoes.js opw-3421476 Forward-Port-Of: odoo/odoo#132533
1. sudo permission for _totp_check env.user is still public user which doesn't have access rights for self.login in Odoo 15 it was not a problem since self.login was in cache but in Odoo 16 it is not and as a result, returns an access error 3. format_timedelta the `lang` was used for `granularity` as the second argument not for `locale` Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I hav
Original PR description
1. sudo permission for _totp_check env.user is still public user which doesn't have access rights for self.login in Odoo 15 it was not a problem since self.login was in cache but in Odoo 16 it is not and as a result, returns an access error 3. format_timedelta the `lang` was used for `granularity` as the second argument not for `locale` Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#138458
With the option "Reception Report" enabled, a batch may contains done and ready pickings, which is inconsistent To reproduce the issue: 1. In Settings, enable Reception Report 2. Operations Types, edit Receipts: - Show Reception Report: True - Automatic Batches: True - Group by: Contact 3. Create two products P1, P2 4. Confirm a delivery with P1 5. Confirm two receipts, one for each product, both with partner P - It should create a batch 6. Partially process the receipt
Original PR description
With the option "Reception Report" enabled, a batch may contains done and ready pickings, which is inconsistent To reproduce the issue: 1. In Settings, enable Reception Report 2. Operations Types,…
With the option "Reception Report" enabled, a batch may contains done and ready pickings, which is inconsistent To reproduce the issue: 1. In Settings, enable Reception Report 2. Operations Types, edit Receipts: - Show Reception Report: True - Automatic Batches: True - Group by: Contact 3. Create two products P1, P2 4. Confirm a delivery with P1 5. Confirm two receipts, one for each product, both with partner P - It should create a batch 6. Partially process the receipt with P1, with backorder - It should open the reception report because of the delivery 7. Open the batch Error: The first receipt is done but is still part of the batch and the backorder is not attached to it. Worst: if the user now tries to confirm a third receipt with the same partner, he will got an error because of an inconsistency with the batch [1] is incorrect. The code assumes that if `res` is not `True`, there was an issue with the picking, so it's better to immediately return `res` without analyzing the batch. However, sometimes `res` can be a `dict` even when the picking has been processed correctly. This is the case here: the receipt is marked as done, but we return an action to open the reception report. As a result, in the above case, we directly return the report action, and we don't analyze the batch consistency (i.e., we don't remove the done receipt and add the backorder). Then, because of the batch inconsistency, the user is blocked and can not validate another receipt. [1] https://github.com/odoo/odoo/commit/0c7122d416a3669d1d42f66bef5b397e8b36a91b OPW-3346255 Forward-Port-Of: odoo/odoo#138607
Before this commit: we assumed an event's recurrence only contains RRULE, and we were getting the RRULE from the first element in the list. But it could have EXRULE, RDATE, and EXDATE, so in this case, the first element could be other items. https://developers.google.com/calendar/api/v3/reference/events#:~:text=default%20is%20False.-,recurrence%5B%5D,-list The solution is to iterate through all items and return the RRULE. opw-2797968 -- I confirm I have signed the CLA and read the
Original PR description
Before this commit: we assumed an event's recurrence only contains RRULE, and we were getting the RRULE from the first element in the list. But it could have EXRULE, RDATE, and EXDATE, so in this case, the first element could be other items. https://developers.google.com/calendar/api/v3/reference/events#:~:text=default%20is%20False.-,recurrence%5B%5D,-list The solution is to iterate through all items and return the RRULE. opw-2797968 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#87697 Forward-Port-Of: odoo/odoo#87559
Ensured that the reduce function returns the accumulator even when encountering 0 price lines. This prevents the function from breaking on subsequent iterations due to receiving 'undefined' instead of the expected array. opw-3528223 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#138645 Forward-Port-Of: odoo/odoo#138245
Original PR description
Ensured that the reduce function returns the accumulator even when encountering 0 price lines. This prevents the function from breaking on subsequent iterations due to receiving 'undefined' instead of the expected array. opw-3528223 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#138645 Forward-Port-Of: odoo/odoo#138245
Suppose a picking type in company C1 that uses a sequence in company C2. If a user then tries to install mrp/pos, it will lead to a Server Error because at some point, we write on the picking type: https://github.com/odoo/odoo/blob/c02df957d9f04c911f330aaaadd80fe97a601509/addons/stock/models/stock_warehouse.py#L332 It will trigger the company checking and lead to the error https://github.com/odoo/odoo/blob/a32c98beb5d57c3af481558c6db08767e9258959/odoo/models.py#L3548 When updating the pi
Original PR description
Suppose a picking type in company C1 that uses a sequence in company C2. If a user then tries to install mrp/pos, it will lead to a Server Error because at some point, we write on the picking type: https://github.com/odoo/odoo/blob/c02df957d9f04c911f330aaaadd80fe97a601509/addons/stock/models/stock_warehouse.py#L332 It will trigger the company checking and lead to the error https://github.com/odoo/odoo/blob/a32c98beb5d57c3af481558c6db08767e9258959/odoo/models.py#L3548 When updating the picking types, we should also update the sequences to ensure the data consistency. OPW-3501199 Forward-Port-Of: odoo/odoo#138643 Forward-Port-Of: odoo/odoo#138471
### 1. Flat colors The aim of this PR is to improve the impact and rendering of app icons in bright and dark mode. It also reduces the size of svg files. To achieve that, this commit updates the colors to flat colors. This change will make the icons stand out and improve their readability. ### 2. Fix dropdown dashboard icon Prior to this PR the Knowledge icon from the same dropdown was turned into an inline-svg but the dashboard one was not. This PR aims to use an inline-svg for th
Original PR description
### 1. Flat colors The aim of this PR is to improve the impact and rendering of app icons in bright and dark mode. It also reduces the size of svg files. To achieve that, this commit updates the…
### 1. Flat colors The aim of this PR is to improve the impact and rendering of app icons in bright and dark mode. It also reduces the size of svg files. To achieve that, this commit updates the colors to flat colors. This change will make the icons stand out and improve their readability. ### 2. Fix dropdown dashboard icon Prior to this PR the Knowledge icon from the same dropdown was turned into an inline-svg but the dashboard one was not. This PR aims to use an inline-svg for that icon and ensure it renders correctly. --- **Requires :** - https://github.com/odoo/enterprise/pull/48064 Other icons that should be merged after : - [16.4] Shop Floor : https://github.com/odoo/enterprise/pull/48071 - [16.4] WhatsApp : https://github.com/odoo/enterprise/pull/48082 - [16.3] pos_restaurant : https://github.com/odoo/odoo/pull/137976 - [16.3] payment methods icons : https://github.com/odoo/odoo/pull/137235 and https://github.com/odoo/enterprise/pull/48212 task-3072562 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#136917
Prior to this commit, when the user experienced an internet disconnection, after few seconds the PeerToPeer connection state would change to "closed" and the PeerToPeer connection would be removed permanently. Consequently, when the user reestablished their internet connection, the peers would remain disconnected to each other. With this commit, peers are now re-connecting to each other. task-3488166 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com
Original PR description
Prior to this commit, when the user experienced an internet disconnection, after few seconds the PeerToPeer connection state would change to "closed" and the PeerToPeer connection would be removed permanently. Consequently, when the user reestablished their internet connection, the peers would remain disconnected to each other. With this commit, peers are now re-connecting to each other. task-3488166 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#138435 Forward-Port-Of: odoo/odoo#136748
The kanban card do not display their outline on the bottom side of the card. This is due to a negative margin (used to compensate for the border bottom of the card). This commit removes the border top if the kanban_record as a prior kanban_record sibling, using its sibling border-bottom as its border top and getting rid of the negative margin. task-3488451 -------- Explored solutions: 1. Compensating the negative margin bottom on focus state (used in 16.2) → Cons it moves all
Original PR description
The kanban card do not display their outline on the bottom side of the card. This is due to a negative margin (used to compensate for the border bottom of the card). This commit removes the border…
The kanban card do not display their outline on the bottom side of the card. This is due to a negative margin (used to compensate for the border bottom of the card). This commit removes the border top if the kanban_record as a prior kanban_record sibling, using its sibling border-bottom as its border top and getting rid of the negative margin. task-3488451 -------- Explored solutions: 1. Compensating the negative margin bottom on focus state (used in 16.2) → Cons it moves all the kanbancard under the one being focus from 1px; 2. Using a box shadow to mimick and offset outline on the bottom of the card → Cons, doesn't work if we have only one kanban card, requires custom code to apply only if multiple cards (not worth it compared to sol.3) 3. (this PR solution) Removing kanbancard border bottom if not last card and getting rid of the negative margin → Cons as it checks if the kanban_record has a sibling kanban_record to manage borders, any inconsistencies in kanban layout will make this rule fail. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#133906
Current behaviour before commit: When cropping an image, pressing `ENTER` creates new paragraph behind the widget, due to this, changes are not getting applied on image and it disappears. Desired behaviour after commit: Now hitting `ENTER` works same as apply button, Changes are getting applied when pressing `ENTER`. task-3383447 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#138185 Forward-Port-Of: od
Original PR description
Current behaviour before commit: When cropping an image, pressing `ENTER` creates new paragraph behind the widget, due to this, changes are not getting applied on image and it disappears. Desired behaviour after commit: Now hitting `ENTER` works same as apply button, Changes are getting applied when pressing `ENTER`. task-3383447 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#138185 Forward-Port-Of: odoo/odoo#127254
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#138720
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#138720
Impacted modules: payment_custom, website_sale_picking Requires: - https://github.com/odoo/odoo/pull/136917 - https://github.com/odoo/enterprise/pull/48064 - https://github.com/odoo/enterprise/pull/48212 task-3514428 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#137235
Original PR description
Impacted modules: payment_custom, website_sale_picking Requires: - https://github.com/odoo/odoo/pull/136917 - https://github.com/odoo/enterprise/pull/48064 - https://github.com/odoo/enterprise/pull/48212 task-3514428 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#137235
Adds the translation in French en German of account groups of l10n_lu localization. task-3497904 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#137234
Original PR description
Adds the translation in French en German of account groups of l10n_lu localization. task-3497904 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#137234
Requires: - https://github.com/odoo/odoo/pull/136917 - https://github.com/odoo/enterprise/pull/48064 - https://github.com/odoo/odoo/pull/137235 task-3514428 Forward-Port-Of: odoo/enterprise#48212
Original PR description
Requires: - https://github.com/odoo/odoo/pull/136917 - https://github.com/odoo/enterprise/pull/48064 - https://github.com/odoo/odoo/pull/137235 task-3514428 Forward-Port-Of: odoo/enterprise#48212
the custom comparison was broken and the percentages were not displayed in the last column. This custom behavior is no longer wanted. task-3546445 Forward-Port-Of: odoo/enterprise#48664
Original PR description
the custom comparison was broken and the percentages were not displayed in the last column. This custom behavior is no longer wanted. task-3546445 Forward-Port-Of: odoo/enterprise#48664
In the Romanian Profit and Loss, the line "b) Expenses on insurance and social protection | 23" has wrong accounts set on it. task-3547190 Forward-Port-Of: odoo/enterprise#48661
Original PR description
In the Romanian Profit and Loss, the line "b) Expenses on insurance and social protection | 23" has wrong accounts set on it. task-3547190 Forward-Port-Of: odoo/enterprise#48661
Amazon sometimes allows user to type their state and/or state code instead of forcing the customers to choose in a list, and then send the information as typed. As such, before this commit, even if we already considered the case where the state code is in fact the complete state name, the search was case-sensitive. We now use the operator to match the state, as long as it at least doesn't have any typo. opw-3140019 Forward-Port-Of: odoo/enterprise#48292
Original PR description
Amazon sometimes allows user to type their state and/or state code instead of forcing the customers to choose in a list, and then send the information as typed. As such, before this commit, even if we already considered the case where the state code is in fact the complete state name, the search was case-sensitive. We now use the operator to match the state, as long as it at least doesn't have any typo. opw-3140019 Forward-Port-Of: odoo/enterprise#48292
The aim of this commit is to improve the impact and rendering of app icons in bright and dark mode. It also reduces the size of svg files. To achieve that, this commit updates the colors to flat colors. This change will make the icons stand out and improve their readability. Requires* : - https://github.com/odoo/odoo/pull/136917 task-3072562 Forward-Port-Of: odoo/enterprise#48064
Original PR description
The aim of this commit is to improve the impact and rendering of app icons in bright and dark mode. It also reduces the size of svg files. To achieve that, this commit updates the colors to flat colors. This change will make the icons stand out and improve their readability. Requires* : - https://github.com/odoo/odoo/pull/136917 task-3072562 Forward-Port-Of: odoo/enterprise#48064