Odoo Changelog — 2023-10-17

Tuesday, October 17, 2023

9 changes · master

Improvements(1)

Enhancements to existing features

[IMP] sale_subscription: view details button instead of download and print buttons

Enterprisemastersale_subscription

The subscription portal now presents a single “View details” action instead of separate download and print buttons. This makes the customer experience clearer and reduces confusion when users want to review subscription information.

Original PR description

task-3484125

#subscriptions#portal#customer experience

Other(8)

Miscellaneous changes

[FW][IMP] account_reports: Introduce new tag selection syntax into account_codes engine

PR #49011

Enterprisemaster

Original PR description

Some countries don't have a legally fixed chart of accounts, and hence cannot use the 'account_codes' engine in their Balance Sheet and P&L. Instead they have to rely on account.account.tag objects associated with the accounts of the database, and target them in the reports using the 'domain' engine.

However, the 'domain' engine lacks the feature achieved with the C and D suffixes in 'account_codes'. Indeed, in the latter, writing '123D' will consider all the accounts prefixed 123 if their balance on the period is positive (C means negative). This is not doable with a domain.

The financial reports engine, used pre-16.0, used to support that case with sum_if_pos_groupby and sum_if_neg_groupby. We mistakenly considered those syntaxes would not be required with tags, which is why we're making this commit in stable.

This commit introduces a new tag(...) selector, usable with the account_codes engine just like any regular prefix selector. It can take an xmlid (for data files) or an account.account.tag id (for custos in the UI; if the tag was created manually) as parameter, and can be used together with account codes in the same formula. It also supports C and D suffixes and prefix exclusion. It is hence possible to combine it with the pre-existing syntax; for example:

tag(account.some_tag)\\(42)D + 1234C + tag(42) - 456\\(4560)

Task 3524409

Forward-Port-Of: odoo/enterprise#48753
Forward-Port-Of: odoo/enterprise#48374

Some countries don't have a legally fixed chart of accounts, and hence cannot use the 'account_codes' engine in their Balance Sheet and P&L. Instead they have to rely on account.account.tag objects associated with the accounts of the database, and target them in the reports using the 'domain' engine. However, the 'domain' engine lacks the feature achieved with the C and D suffixes in 'account_codes'. Indeed, in the latter, writing '123D' will consider all the accounts prefixed 123 if their balance on the period is positive (C means negative). This is not doable with a domain. The financial reports engine, used pre-16.0, used to support that case with sum_if_pos_groupby and sum_if_neg_groupby. We mistakenly considered those syntaxes would not be required with tags, which is why we're making this commit in stable. This commit introduces a new tag(...) selector, usable with the account_codes engine just like any regular prefix selector. It can take an xmlid (for data files) or an account.account.tag id (for custos in the UI; if the tag was created manually) as parameter, and can be used together with account codes in the same formula. It also supports C and D suffixes and prefix exclusion. It is hence possible to combine it with the pre-existing syntax; for example: tag(account.some_tag)\\(42)D + 1234C + tag(42) - 456\\(4560) Task 3524409 Forward-Port-Of: odoo/enterprise#48753 Forward-Port-Of: odoo/enterprise#48374

This issue occurs when the user tries to upload an invalid file, at that time, an error will be generated. step to reproduce: - Install the `sign` module - Open sign app > Dashboard. - Click on the dropdown Menu of the template > Use Layout - Upload file > Confirm. - the error will be generated. PDF FILE - [sample.pdf](https://drive.google.com/file/d/1EFaigvjRhW8poY7EwBuzors8LVwi8Klp/view?usp=drive_link) sentry traceback- ``` ValueError: invalid literal for int() with base 10: b'>>' File "PyPDF2/pdf.py", line 1703, in read startxref = int(line) PdfReadError: startxref not found File "odoo/http.py", line 2134, in __call__ response = request._serve_db() File "odoo/http.py", line 1710, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "odoo/service/model.py", line 133, in retrying result = func() File "odoo/http.py", line 1737, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 1938, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 191, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 717, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/web/controllers/dataset.py", line 34, in call_button action = self._call_kw(model, method, args, kwargs) File "addons/web/controllers/dataset.py", line 26, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "odoo/api.py", line 461, in call_kw result = _call_kw_multi(method, model, args, kwargs) File "odoo/api.py", line 448, in _call_kw_multi result = method(recs, *args, **kwargs) File "home/odoo/src/enterprise/saas-16.4/sign/wizard/sign_duplicate_template_with_pdf.py", line 23, in duplicate_template_with_pdf if not self._compare_page_templates(self.original_template_id.datas, self.new_pdf): File "home/odoo/src/enterprise/saas-16.4/sign/wizard/sign_duplicate_template_with_pdf.py", line 44, in _compare_page_templates pages_new_file = PdfFileReader(io.BytesIO(base64.b64decode(new_file)), strict=False, overwriteWarnings=False).getNumPages() File "odoo/tools/pdf.py", line 191, in <lambda> old_init(self, stream=stream, strict=strict, warndest=None, overwriteWarnings=False) File "PyPDF2/pdf.py", line 1084, in __init__ self.read(stream) File "PyPDF2/pdf.py", line 1707, in read raise utils.PdfReadError("startxref not found") ``` After this commit, it will raise a validation error when uploading files is not valid. sentry-4517279848 Forward-Port-Of: odoo/enterprise#48772 Forward-Port-Of: odoo/enterprise#48314

Improvements(1)

[IMP] sale_subscription: view details button instead of download and print buttons

Other(8)

[FW][IMP] account_reports: Introduce new tag selection syntax into account_codes engine

Improvements(1)

[IMP] sale_subscription: view details button instead of download and print buttons

Other(8)

[FW][IMP] account_reports: Introduce new tag selection syntax into account_codes engine

[FW][FIX] l10n_es: set filter_multi_company to tax_unit in the modelo reports

[FW][FIX] sign: prevent traceback while upload file is not valid

[FW][IMP/FIX] LineChart: cumulative line chart

[FW][FIX] web_studio: set the background image for secondary company

[FW][FIX] account_report: sort and unfold

[FW][FIX] account_report: generate default values for reports with sections

[FW][FIX] spreadsheet_edition: wrong datasource in list/pivot side panel