Saturday, October 21, 2023
20 changes · master
Enhancements to existing features
This update makes chat channel creation methods return a more reusable result for backend code, while keeping the existing simplified response for remote calls. It reduces complexity for developers working with messaging-related features without changing the everyday user experience.
Original PR description
* = calendar,test_discuss_full, test_mail, test_mail_full Methods can be downgraded to channel_info when called by RPC. This increases the simplicity to use these methods in python. https://github.com/odoo/enterprise/pull/49326 Taken from https://github.com/odoo/odoo/pull/138330 to ease its diff.
This update adjusts how messaging channels are created so related enterprise features receive a complete channel reference. It supports smoother behavior in areas such as Frontdesk and enterprise mail tests without introducing visible workflow changes for users.
Original PR description
* = frontdesk, test_mail_enterprise Enterprise counter-part. https://github.com/odoo/odoo/pull/139341 Taken from https://github.com/odoo/odoo/pull/138330 to ease its diff.
Resolved issues and error corrections
This update improves test coverage for deleting attachments in public discussions, including checks that confirm access rules are respected. It helps reduce the risk of unauthorized attachment deletion while keeping the change limited to internal validation.
Original PR description
This allows better coverage of the feature and in particular its access check. Taken from https://github.com/odoo/odoo/pull/138330 to ease its diff.
Code cleanup and technical improvements
The expense management area was reorganized and cleaned up to make it easier to maintain, with outdated fields and deprecated template usage removed. The change is intended to have little to no visible impact for users while improving reliability through better-focused tests and fixing an employee search issue.
Original PR description
[REF] hr_expense: Technical refactor Accumulation of unused fields and naming conventions incoherence for models of a same file + depreciated code snippets + an overdose of tests that were either redundant or not testing real flow made expense a dull boy task-3358176 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Incorporate Andrea Gidalti (andreagidaltig) as Vauxoo's contributor. I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139100
Original PR description
Incorporate Andrea Gidalti (andreagidaltig) as Vauxoo's contributor. I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139100
This fixes a missing check used to identify managers in the Appraisals app's access rules. It helps ensure managers can access the appraisal goals they are supposed to manage without errors or blocked access.
Original PR description
Taken from https://github.com/odoo/enterprise/pull/49005 to ease its diff.
This change narrows a test mock in Web Studio so it only applies to the specific report editor search scenario it was meant to cover. This helps keep automated tests reliable without changing normal user-facing behavior.
Original PR description
This patch was designed to intercept a specific search call, not all of them. The scope of the patch is now arbitrary limited to when no params are given, which is how the expected intercept is calling it. It still makes no sense to do it this way but at least the test pass. Taken from https://github.com/odoo/enterprise/pull/49005 to ease its diff.
Portal users will no longer receive VoIP call information during startup. This avoids showing or processing call data for users who should not use the VoIP features, reducing confusion and unnecessary background work.
Original PR description
Taken from https://github.com/odoo/enterprise/pull/49005 to ease its diff.
This update makes an internal test independent from optional VoIP setup differences. It helps keep automated checks stable across environments, reducing maintenance effort and avoiding misleading test failures.
Original PR description
Depending on whether onsip is installed or not when the user setting is created this will have a different value, making the test harder to maintain than necessary.
This update cleans up and standardizes the internal expense-related code, including naming, obsolete fields, and test coverage. It should make future maintenance easier while having little to no visible impact for users.
Original PR description
Accumulation of unused fields and naming conventions incoherence for models of a same file + depreciated code snippets + an overdose of tests that were either redundant or not testing real flow made expense a dull boy task-3358176
Accessory product was showed to user in cart even when it was unpublished, now it's only showed to internal user if unpublished. task-3218286 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139231 Forward-Port-Of: odoo/odoo#137994
Original PR description
Accessory product was showed to user in cart even when it was unpublished, now it's only showed to internal user if unpublished. task-3218286 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139231 Forward-Port-Of: odoo/odoo#137994
The module does not depend on account_edi, but the test extends the test class defined in it. The problem only appears in saas-16.4, because before, account_edi was auto-installed with account. Linked to runbot error 24128 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139083
Original PR description
The module does not depend on account_edi, but the test extends the test class defined in it. The problem only appears in saas-16.4, because before, account_edi was auto-installed with account. Linked to runbot error 24128 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139083
Description of the issue/feature this PR addresses: Export button in export popup is always enabled, allowing users to click it more than one. steps to reproduce: export a large amount of data (or add a sleep in /web/export/xlsx) Current behavior before PR: button is not disabled during export, allowing users to spam the button Desired behavior after PR is merged: button is disabled during export, informing the user that we're processing his request --- I confirm I have signed
Original PR description
Description of the issue/feature this PR addresses: Export button in export popup is always enabled, allowing users to click it more than one. steps to reproduce: export a large amount of data (or add a sleep in /web/export/xlsx) Current behavior before PR: button is not disabled during export, allowing users to spam the button Desired behavior after PR is merged: button is disabled during export, informing the user that we're processing his request --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#137865
In commit 355250d062fb8dde558d21ea861b9af578545fe0 was improved the domain, to filter based on the document type, but was not considered that only is for sales documents. On the vendor bills could be used more document types, now is fixed. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139272
Original PR description
In commit 355250d062fb8dde558d21ea861b9af578545fe0 was improved the domain, to filter based on the document type, but was not considered that only is for sales documents. On the vendor bills could be used more document types, now is fixed. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139272
Description of the issue/feature this PR addresses: Error trying to call the check function for HU VAT. Current behavior before PR: Before the fix the check function is assigned a boolean, which causes an error when trying to call the function. Desired behavior after PR is merged: After the fix the check function is properly assigned and can be called. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139280
Original PR description
Description of the issue/feature this PR addresses: Error trying to call the check function for HU VAT. Current behavior before PR: Before the fix the check function is assigned a boolean, which causes an error when trying to call the function. Desired behavior after PR is merged: After the fix the check function is properly assigned and can be called. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139280
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139366
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139366
Steps ===== - Install module planning - Log in as an user with planning access but no hr access - Open planning main gantt view Issue ===== Empty avatars are displayed for employees. Cause ===== The model used to display avatar of employees is hr.employee. But user with no hr access have no read access to this model. Fix === If the current user has no hr access, the model hr.employee.public is used to display the avatar. Forward-Port-Of: odoo/enterprise#49333
Original PR description
Steps ===== - Install module planning - Log in as an user with planning access but no hr access - Open planning main gantt view Issue ===== Empty avatars are displayed for employees. Cause ===== The model used to display avatar of employees is hr.employee. But user with no hr access have no read access to this model. Fix === If the current user has no hr access, the model hr.employee.public is used to display the avatar. Forward-Port-Of: odoo/enterprise#49333
The authorization status could be "EN PROCESO" which means the document was processed by SRI but it didn't return anything. The normal process is blocked because an error message is displayed instead of a simple warning. The document should be sent on the next request and it should be handled by the cron job. It was detected through that many clients generate a lot of invoices per minute and the SRI leaves some documents in authorization status "EN PROCESO", that is where the error was detect
Original PR description
The authorization status could be "EN PROCESO" which means the document was processed by SRI but it didn't return anything. The normal process is blocked because an error message is displayed instead of a simple warning. The document should be sent on the next request and it should be handled by the cron job. It was detected through that many clients generate a lot of invoices per minute and the SRI leaves some documents in authorization status "EN PROCESO", that is where the error was detected. Forward-Port-Of: odoo/enterprise#48168
since #41579 the search on signer was done on the partner display_name this cause issue as it didn't filter anything. The original goal of the PR is accomplished by searching on complete_name instead. task-id: 3562215 Forward-Port-Of: odoo/enterprise#49225
Original PR description
since #41579 the search on signer was done on the partner display_name this cause issue as it didn't filter anything. The original goal of the PR is accomplished by searching on complete_name instead. task-id: 3562215 Forward-Port-Of: odoo/enterprise#49225
This commit adds the missing neutralisation necessary for the `whatsapp` module introduced in [1] The purpose of the standard neutralisation framework is to allow us to create database copies that will not interract with external systems in ways that could impact the production database (or if it is not possible to prevent the interractions, make sure that they are benign or wont result in actual changes), or impact the customers of the operator of the production database. This is mainly u
Original PR description
This commit adds the missing neutralisation necessary for the `whatsapp` module introduced in [1] The purpose of the standard neutralisation framework is to allow us to create database copies that will not interract with external systems in ways that could impact the production database (or if it is not possible to prevent the interractions, make sure that they are benign or wont result in actual changes), or impact the customers of the operator of the production database. This is mainly useful to allow safe support investigation on database duplicates. [1] https://github.com/odoo/enterprise/pull/45601 Forward-Port-Of: odoo/enterprise#47355