Wednesday, October 25, 2023
9 changes · master
Code cleanup and technical improvements
This update reorganizes automated Point of Sale test tours to make them easier for developers to maintain. It does not change customer-facing POS behavior, but it helps reduce future maintenance effort and supports more reliable testing across POS-related modules.
Original PR description
pos*: l10n_es_pos, point_of_sale, pos_hr, pos_loyalty, pos_online_payment, pos_online_payment_self_order, pos_restaurant, pos_sale, pos_self_order In this commit we refactor all the pos tours.…
pos*: l10n_es_pos, point_of_sale, pos_hr, pos_loyalty, pos_online_payment,
pos_online_payment_self_order, pos_restaurant, pos_sale, pos_self_order
In this commit we refactor all the pos tours.
Changes:
- Removed the `startSteps`, `getSteps` functions as they were
no longer serving a purpose. We now simply put the tours steps
in the array returned by the function given to `steps`. We
apply `flat()` to this array in order to be able to provide both
single steps and arrays containing multiple steps;
- removed the classes from the tours. Now each helper function
is simply exported from it's file and is consumed as `import * as myHelpers`;
- removed the `do`, `check`, `exec` subpaths as they were not providing
a clearer api. The functions themselves already have descriptive names.
( writing `ProductScreen.do.clickHomeCategory()` is not clearer than
`ProductScreen.clickHomeCategory()` )
- formatted all files.
Task: 3565443
https://github.com/odoo/enterprise/pull/49313
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis change removes an outdated internal way of fetching display names in the web interface and updates related fields to use the newer approach. It helps keep the web client aligned with recent platform changes, reducing maintenance risk without changing normal user workflows.
Original PR description
This commit removes all usages of the nameGet method of the orm service following changes introduced by https://github.com/odoo/odoo/pull/122085 task-3377209
This update reorganizes the Mexican electronic invoicing Send & Print setup so related files are in the right place and easier to maintain. It also reduces unnecessary background calculations, which can improve reliability and keep the invoicing workflow cleaner without changing the user experience.
Original PR description
- move files to the correct folder - clean computes to avoid unnecessary computation
This update streamlines how bank reconciliation screens apply table highlighting styles. It reduces unnecessary generated styling code, which helps keep the interface code lighter without changing user workflows.
Original PR description
´extends´ generates a lot of css rules. So in this commit, we remove it by replacing it by adding the class directly on the node.
This update aligns the Barcode inventory picking flow with recent stock quantity changes, preserving the familiar picking behavior for warehouse operators. It also updates related delivery, helpdesk, repair, and field service stock processes so they continue working with the new inventory structure.
Original PR description
This update reorganizes internal automated test steps for several point-of-sale related apps, making them simpler and easier for developers to maintain. It does not change business features or user workflows, but helps reduce maintenance effort and supports more reliable future updates.
Original PR description
pos*: l10n_mx_edi_pos, pos_iot, pos_preparation_display,
pos_restaurant_preparation_display, pos_sale_stock_renting
In this commit we refactor all the pos tours.
Changes:
- Removed the `startSteps`, `getSteps` functions as they were
no longer serving a purpose. We now simply put the tours steps
in the array returned by the function given to `steps`. We
apply `flat()` to this array in order to be able to provide both
single steps and arrays containing multiple steps;
- removed the classes from the tours. Now each helper function
is simply exported from it's file and is consumed as `import * as myHelpers`;
- removed the `do`, `check`, `exec` subpaths as they were not providing
a clearer api. The functions themselves already have descriptive names.
( writing `ProductScreen.do.clickHomeCategory()` is not clearer than
`ProductScreen.clickHomeCategory()` )
- formatted all files.
Task: 3565443
https://github.com/odoo/odoo/pull/139317Rental sales now includes the useful scheduling code that was previously kept in a separate module, reducing internal complexity. This keeps rental pricing and recurring rental behavior available while removing an unused dependency, with no major business process change expected.
Original PR description
Since sale_subscription does not inherit anymore from sale_temporal (https://github.com/odoo/enterprise/pull/46621), the latter became useless. This PR moves the useful code from sale_temporal to sale_renting, and drops sale_temporal. task-3527947 See also: - https://github.com/odoo/upgrade/pull/5265
Embedded views in Knowledge now store less extra setup information and add needed details only when opened. This keeps saved content cleaner while preserving the same user experience for embedded views.
Original PR description
When inserting an embedded view, the key `knowledge_embedded_view_framework` is saved in the context of the action that is encoded and saved in the HTML tag that will be recognized by the editor as an embedded view. Instead of saving that key, the embedded view behavior will now dynamically add the id of the embedded view in the context of the action before executing it. We can then determine whether the view is an embedded view by checking whether the id is defined. We therefore no longer need to add a special key in the context and save it in the HTML tag to distinguish the embedded view from the standard views. task-3334536
This update cleans up how Documents, Helpdesk, and Quality Control handle incoming and outgoing message data. It reduces the risk of errors when message details are missing or inconsistent, making communication-related workflows more reliable and easier to maintain.
Original PR description
Task ID-2477479 (identity task) Followup of Task ID-2070632 (channel members main task) Followup of Task ID-2419762 (channel members followup task) COM PR odoo/odoo#67395 ENT PR odoo/enterprise#17617 UPG BR odoo/upgrade#2382
Follow the refactor of the picking. Since the `stock.move.line` has now only one quantity field, here is the idea to keep the (almost) same behavior in the Barcode App than before the refactor: - Have a non-stored field `qty_done`: equals to 0 if not picked, equals to the `quantity` field otherwise. When the user writes on it, it will write on the `quantity` field and marks the line as picked; - As `reserved_uom_qty` doesn't exist anymore, we make it equals to `quantity` at the creation of the line in the Barcode App to be able to know the line's reservation. That means once the operation is closed, this info is lost. COM PR: odoo/odoo#137864 task: fp-request