Friday, October 27, 2023
7 changes · master
Resolved issues and error corrections
The 360 feedback resend action no longer relies on private employee email information that some users cannot access. This prevents access errors and helps managers or authorized users resend appraisal feedback requests smoothly.
Original PR description
This commit fixes the feedback resend feature as it was trying to access the private email of the employee, causing access errors for non hr-users.
This update removes unnecessary logging and unused attributes from the marketing automation area. It is a small cleanup that helps keep the system tidier and reduces irrelevant technical noise without changing business workflows.
Original PR description
Remove unnecessary logs and attributes
Fixes an issue that could cause the salary contract page to fail while loading. This helps HR users access contract salary information reliably without interruption.
The comparison filter in deferred accounting reports now keeps the styling needed to align the Apply button correctly. This restores a consistent layout with other reports and avoids a confusing visual issue for users.
Original PR description
Following 37798579dd5755f0e7f03e4f54782b0f632a3aaa, the class `filter_comparison` was missing because the div was replaced. Therefore some CSS was missing and the Apply button was misaligned. This is fixed by replacing the `<t>` element instead of the whole `<div>` **Before:**  **After (similar to other reports)** 
The automated rental product configuration checks were updated to match recent design changes. This helps keep quality checks reliable and prevents false failures during development, with no direct change for end users.
The Vendors menu has been updated to match the split of the Amounts to settle action into separate options. This prevents users from being sent to an overly broad reconciliation view and keeps the accounting reports aligned with the intended workflow.
Original PR description
Current behavior before PR: Currently, the "Amounts to settle" button in the "Vendors" drop-down menu opens a view showing all the account.move.line that are to be reconciled. Desired behavior after PR is merged: This commit is linked to a commit in community which splits the action responsible for this into two and therefore, the action should be renamed everywhere. Community:https://github.com/odoo/odoo/pull/139921 task-3572482
Portal users can now browse shop pages containing rental products without encountering an access error. This aligns their read access with public visitors, improving the rental shopping experience for logged-in customers.
Original PR description
Steps to reproduce: - Install website_sale_renting; - Log in as portal user; - Go to /shop on a page where there is a rental product; - Access error The error is raised because there is a missing access rule for portal user. As there is a read access to public user, we add it to portal user as well.