Saturday, October 28, 2023
4 changes · 17.0
Code cleanup and technical improvements
A method that was incorrectly named to suggest it deletes spreadsheet revisions has been removed and simplified. The method actually archives revisions rather than deleting them, and since the version history feature was added, permanent deletion is no longer possible. The single-line method has been inlined into the code for better clarity.
Original PR description
The method named `_delete_spreadsheet_reviions`: - the method archives instead of deleting - since the version history feature, we CANNOT delete them. Since it's only a single line, it can be inlined.
Miscellaneous changes
**Steps:** ------------- - Open Time-Off - Go to configuration - In public Holidays - Create a new public holidays **Issue:** ------------- - The validation error occurs. **Cause:** --------------- - It get employee from the company which is not selected due to this employee consider as a invalid employee. **Fix:** ---------- - Add domain in employees_groups so it consider only selected companies employee while creating public holiday. Task:3504636 Forward-Por
Original PR description
**Steps:** ------------- - Open Time-Off - Go to configuration - In public Holidays - Create a new public holidays **Issue:** ------------- - The validation error occurs. **Cause:** --------------- - It get employee from the company which is not selected due to this employee consider as a invalid employee. **Fix:** ---------- - Add domain in employees_groups so it consider only selected companies employee while creating public holiday. Task:3504636 Forward-Port-Of: odoo/odoo#139868 Forward-Port-Of: odoo/odoo#137052
Adaptations for enterprise's dark-mode Needed by : - https://github.com/odoo/enterprise/pull/44458 - https://github.com/odoo/o-spreadsheet/pull/3051 task-3201038 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139506 Forward-Port-Of: odoo/odoo#130991
Original PR description
Adaptations for enterprise's dark-mode Needed by : - https://github.com/odoo/enterprise/pull/44458 - https://github.com/odoo/o-spreadsheet/pull/3051 task-3201038 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139506 Forward-Port-Of: odoo/odoo#130991
Steps to reproduce: - Enable locations in Inventory settings - Edit Delivery on operation types - Set a default return location - Create and confirm an SO and its delivery - Create a return - default return location is ignored Bug: since commit[1] returns have been redesigned and the default location was not considered opw-3517921 [1]: https://github.com/odoo/odoo/pull/118568 Forward-Port-Of: odoo/odoo#138046
Original PR description
Steps to reproduce: - Enable locations in Inventory settings - Edit Delivery on operation types - Set a default return location - Create and confirm an SO and its delivery - Create a return - default return location is ignored Bug: since commit[1] returns have been redesigned and the default location was not considered opw-3517921 [1]: https://github.com/odoo/odoo/pull/118568 Forward-Port-Of: odoo/odoo#138046