Monday, October 30, 2023
40 changes · 17.0
Resolved issues and error corrections
Live chat visitors will no longer see two identical emoji buttons in message quick actions. The quick action menu is simplified so users have a clearer, less confusing chat experience while reaction viewing remains available in the expanded menu.
Original PR description
Before this commit, messages in livechat from visitor POV show 2 emoji icon in the quick actions. This is confusing and comes from 2 actions sharing this exact same icon: "Add a reaction" and "View reactions". This commit fixes the issue by reducing the number of quick message actions to 2 for the embed live chat. In other contexts there's "Reply-to" and "Mark as Favorite" in quick actions, so the "View reactions" item is always in expand menu. Note that this "dirty" fixes come from 2 actions with same icon. Eventually we should fix that by clearly making icons unique. This solution is decent for the time being, giving us more time to make a dedicate icon for one of the emoji actions. task-3498446
This fixes how SEPA payment methods are identified when using Stripe. It helps ensure customer bank debit payments are processed under the right payment method, reducing payment errors or confusion.
Repair orders now follow the same picking behavior as stock transfers: if no item is explicitly marked as picked, the system treats all items as picked. This reduces confusion for users and keeps repair workflows consistent with recent inventory changes.
Original PR description
Since PR #137864 We do not have quantity done anymore and we use the picked field to know if something is picked or not. But we remove the immediate transfer wizard and we consider instead than if nothing is mark as pick, everything is pick. We will do the same for repair because it would confusing to have a different behavior Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Corrects minor wording errors found during translation work in the fleet and payment areas. This improves clarity and consistency for users, especially in translated versions of Odoo.
Original PR description
Corrects typos found when translating Odoo 17. \* : hr_fleet, payment Enterprise: https://github.com/odoo/enterprise/pull/49831
The time off popup now displays its action buttons in proper alignment. This small visual fix makes the dialog easier to read and use for employees and managers.
Original PR description
Correct the view
Point of Sale now correctly shows the limited functionalities popup when the system is offline. This helps cashiers understand what is happening and continue with the appropriate reduced capabilities instead of facing unclear or broken error handling.
Original PR description
Before, error handling didn't work in point_of_sale when offline. This was due to poor error handling. Now, the "limited functionnalities" popup is displayed correctly.
This update keeps Polish localization records showing their names correctly after an underlying Odoo framework change deprecated the old naming method. It helps prevent automated test failures and avoids potential display issues for users working with Polish tax office data.
Original PR description
Since https://github.com/odoo/odoo/commit/3c62ca1eb96d571b2b686b5caee370324c589ab4, name_get is depreciated. We should replace it with a _compute_display_name. Linked to runbot error 25698 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes small usability issues in inventory and subcontracting workflows. It clarifies the subcontracting correction action, removes an unnecessary stock location warning, and improves the message shown when putting items into a package.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where changes made to an embedded record after opening and closing it in a dialog were not detected. Users will now see the save button correctly, helping prevent edits from being missed or lost.
Original PR description
Purpose:
-------
The "StockMoveX2ManyField" custom field has given rise to a new need, that of being able to edit a record in an x2many directly or from a dialog. This is the first use case to require the ability to do both at the same time.
This particular use case highlighted a bug preventing a change from being saved.
How to reproduce:
- Go to a form view with an x2m using a custom widget
- Open an x2m record in dialog mode
- Close the dialog
- No changes have been made to the record, so the save button is not displayed
- Edit a field in the same record
Before this commit:
The save button is not visible
After this commit:
The save button is visible.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prLivechat administrators can now view past chat threads in a mobile-friendly chat window instead of the broader Discuss screen. This fixes a broken mobile experience and makes session history easier and more consistent to use on small screens.
Original PR description
⚠️ Depends on: https://github.com/odoo/odoo/pull/137623 Description of the issue/feature this PR addresses: The UI is broken for mobile users using the session history feature of Livechat. Current behavior before PR: Thread is rendered in the Discuss app. Desired behavior after PR is merged: Thread is rendered in a ChatWindow component.
This update resolves several Point of Sale issues needed for Swedish and Belgian blackbox certification. It improves receipt and order handling so certified sales workflows remain compliant and reliable.
Original PR description
This PR fixes few issues needed for the certification of the sweden and belgian blackbox --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Editing certain list entries inside a form no longer causes the form status buttons to briefly disappear while the system updates related values. This provides a smoother, less confusing experience for users entering data.
Original PR description
Purpose:
--------
Before this commit, if you edit a char field with an onchange in
an x2many, the FormStatusIndicator buttons will flicker.
How to reproduce:
-----------------
- Go to a form view with an x2many field in list mode
- Type a char in the char field of a record
- The FormStatusIndicator buttons are visible
- Click outside the char field
- An onchange is triggered
Before this commit:
The FormStatusIndicator buttons will disappear until the onchange returns.
After this commit:
The FormStatusIndicator buttons remain visible.Self-order receipts now show the actual payment method name instead of the generic label "Bank". This makes receipts clearer for customers and helps staff reconcile payments more easily.
Original PR description
Fixes the receipt payment lines name (replacing "Bank" by the payment method name). task-id: 3572422
This fix ensures product categories appear properly in the self-order interface. It helps customers browse menu items more easily and reduces confusion during ordering.
Original PR description
Fixes the display of categories in the self-order UI. task-id: 3572141
This fix ensures the right employees are available to select when creating or editing time off requests, including new records. It also makes the selection logic more efficient, reducing the chance of incorrect choices and improving reliability for HR workflows.
Original PR description
Before this commit, the domain on ``employee_id`` and ``employee_ids`` would be computed in a computed method ``_compute_allowed_employee_ids``. However, due this compute method not triggering for new records, the domain was not correctly set. Additionally, this way of computing the domain was not very efficient. With this change, the domain is computed correctly and efficiently.
This update corrects several customer portal issues affecting accounting and sales documents. Users should see more accurate portal card counts, fewer misleading alerts for cancelled quotes, and more consistent editing behavior for sale order options.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents Firefox from crashing when users click certain linked fields while editing a form that uses the web editor. It improves stability for users working with rich text fields such as sale order notes, without changing visible functionality.
Original PR description
Follows commit: ffef01e327b0263a2af4892e9e438a2c0ef22184. It caused an issue in Firefox: On the sale order form view (with the field "notes" handled by the OdooEditor), clicking on a Many2one made the browser crash because the method getSelection did not exist on the target which was the input element. It did not crash in chrome as the event's target was always the Document. The added test actually tests the feature of the referenced commit, and checks, as much as possible, that there is no crash. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
POS receipts now include the customer linked to the order where needed. This supports India receipt requirements and ensures loyalty-related receipts have the necessary customer information.
Original PR description
In this commit, we are adding partner to the order receipt as it is needed for the receipt in india and for the loyalty module. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The manufacturing order overview report no longer fails when opened for completed orders. The report label was also clarified from "Reserved" to "Quantity" so users better understand the quantities shown.
Original PR description
A "quantity_done" removal was missed in the MO Overview report, which made it so the report would throw an error when opened for a done MO. Also replace "Reserved" with "Quantity" in the overview so that it is more consistent with pickings + is more intuitive since it is currently confusing that when the qty produced is updated, then it appears that the qty reserved changes (rather than a qty being done) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Graph view tooltips now display their items in the expected sorted order again. This restores a small but useful visual behavior that was lost after a charting library update, making graph data easier to read and compare.
Original PR description
Tooltip items are not correctly sorted anymore after migration to last Chart.js version in the commit eb530b83b06a057f96. This feature is fixed in this commit. task-3552948
This update addresses multiple issues in the deferred accounting system, including incorrect tax line grouping, missing vehicle tracking, and errors when generating deferral entries. It also adds the ability to drill down into aggregated report lines and improves the overall reliability of deferred entry generation with better date handling and validation.
Original PR description
This PR regroupes many fixes and improvements regarding the deferred: See the details in the commits :) task-id 3544877 Community https://github.com/odoo/odoo/pull/138959 Forward-Port-Of: odoo/enterprise#49656 Forward-Port-Of: odoo/enterprise#48631
This update corrects hyperlinks in automated marketing email templates used for customer communications like welcome messages, free trial offers, and partnership invitations. The fix ensures customers can properly click through to intended destinations, improving the reliability of marketing campaigns.
Original PR description
The commit modifies links on anchors. The commit also cleans up logging and unused props.
Fixed a bug that prevented users from previewing newly created reports in Studio. The issue occurred because the system required a record to exist when previewing reports, but new reports don't have records yet. The fix allows report previews to work without requiring existing data, making it easier for users to design and test new reports.
Original PR description
Currently, when the user tries to print a preview of the newly created report with Studio, an error occurs. Step to produce: - Create new app with Studio and click on reports - Click new > select any…
Currently, when the user tries to print a preview of the newly created report with Studio, an error occurs.
Step to produce:
- Create new app with Studio and click on reports
- Click new > select any type
- Click 'PRINT PREVIEW' from the sidebar >> error occur
Error:
```
TypeError: WebStudioReportController.print_report() missing 1 required positional argument: 'record_id'
File "odoo/http.py", line 2134, in __call__
response = request._serve_db()
File "odoo/http.py", line 1710, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "odoo/service/model.py", line 133, in retrying
result = func()
File "odoo/http.py", line 1737, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 1938, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 191, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 717, in route_wrapper
result = endpoint(self, *args, **params_ok)
```
This is because we received 'recordId' as 'undefined' at Line [1] because the model does not have any records.
In previous versions, Line [2], raised a user error when the related model of the report did not have a record because the record is mandatory in the drag-and-drop editor. After the https://github.com/odoo/enterprise/commit/cca11d1a7a5a77d38dc0d3121e5d79f6a171ec75 it changed to a new editor, and here the record is not required any more.
This commit solved the above issue by setting 'None' as the default value of the 'record_id'
and passing an empty list in the 'report_action' method when record_id is 'None'; see [Line](https://github.com/odoo/odoo/blob/7f35ed6cacead630ceb6aa445cf68a46a66b5ed9/odoo/addons/base/models/ir_actions_report.py#L924) it allows an empty list if the model does not have records.
Apart from this, since the record is not required for the preview report, this commit also
removes Line [3], because many times 'active_ids' is not found in context.
Line [1]-https://github.com/odoo/enterprise/blob/8f35db6ff2b41300837394a8279f2b55beef6f1f/web_studio/static/src/client_action/report_editor/report_editor_wysiwyg/report_editor_wysiwyg.js#L417
Line [2]-https://github.com/odoo/enterprise/blob/d71f5205d1099dec5a8f4cb7de80d173bd75d6f9/web_studio/controllers/report.py#L142
Line[3]-https://github.com/odoo/enterprise/blob/d36ce63629590acb8f221f782491a6ff5c213066/web_studio/static/tests/tours/web_studio_test_ui_unit_report_tours.js#L318
sentry-3965574308
Forward-Port-Of: odoo/enterprise#46879This update addresses multiple issues in the subscription module including payment processing problems, visibility issues with upsell options, and plan management bugs. The changes ensure customers can properly manage their subscriptions through the portal, see correct plan information, and that plan changes are accurately recorded in the system.
Original PR description
- [[FIX] sale_subscription: portal payment fix](https://github.com/odoo/enterprise/pull/49713/commits/448bb332ea551124126d1df43ee3a5dba871a875) - [[FIX] sale_subscription: hide upsell in…
- [[FIX] sale_subscription: portal payment fix](https://github.com/odoo/enterprise/pull/49713/commits/448bb332ea551124126d1df43ee3a5dba871a875) - [[FIX] sale_subscription: hide upsell in all_subscription](https://github.com/odoo/enterprise/pull/49713/commits/993a21d48ea0c6246aabbc1b2a7537615a55d705) - [[FIX] sale_subscription: small code improvement](https://github.com/odoo/enterprise/pull/49713/commits/2e41e9c277ba5238171cca25e8072faa2543334f) - [[FIX] sale_subcription: close change_plan doesn't update plan](https://github.com/odoo/enterprise/pull/49713/commits/51a9dc4526e03ed4e1bd31a532a8a12d21d20ebe) - [[FIX] sale_subscription: show plan if no template](https://github.com/odoo/enterprise/pull/49713/commits/aa60ef00fb7ac96752a33d73470e4f24d94c49ee) - [[FIX] sale_subscription: SO template hidden when no group](https://github.com/odoo/enterprise/pull/49713/commits/ee0fcad905f3afa2d48083ec22f07567e5ba2dd4) - [[IMP] sale_subscription: move from demo_data to data](https://github.com/odoo/enterprise/pull/49713/commits/3cf7d809c93443e18abb5b8902a100d5a9c9fd1c) PR COM: odoo/odoo#140051 PR ENT: odoo/enterprise#49713 task-id : 3571692
This update corrects how the billable time target field is accessed and displayed for employees. Previously, the field could be accessed by users who shouldn't have permission to view it. Now, only HR Users can access the field, and only Timesheet Approvers can see it in employee records. This ensures proper access control and data security.
Original PR description
Before this commit, the field is only visible if the user has no access to timesheet app. The problem is the field could be prefetched once the user has access to timesheet app even if he is not `HR User`. This commit changes the `groups` defined in definition of `billable_time_target` field to only fetch the field if the user is at least HR User, however, the field will be only visible in the form view of `hr.employee` model if the user is at least Timesheet Approver. task-3573317
This fix resolves an issue where paid orders were not being sent to the kitchen preparation display when the point of sale system was offline. Now when the system reconnects, all pending orders are properly synced to the preparation display, ensuring kitchen staff can see all orders that need to be prepared.
Original PR description
Previously, when PoS was in offline mode, paid orders were not sent to preparation display due to poor error handling. Now, when the PoS is offline and reconnects, paid orders are sent to the preparation display via the create_from_ui function.
This update resolves an issue where Mexican electronic invoices (CFDI) could not be generated when sales orders contained line items with zero quantities. The fix ensures these zero-quantity lines are properly excluded during the invoice generation process, allowing businesses to successfully create compliant tax documents.
Original PR description
Prior to 5f4b3ef2c8f62357d736f32702968668787e8e4c, it was possible to have SO lines with zero as quantity. This was broken with the `valor_unitario` computation in `_l10n_mx_edi_get_invoice_cfdi_values` because it was relying on those quantities. This fix will simply exclude the lines with 0 quantities when generating the cdfi values Forward-Port-Of: odoo/enterprise#49208
Fixed an issue where the dropdown menu in the Planning view was being hidden behind other content. The menu button was repositioned in the interface, causing a layering conflict that has now been resolved by adjusting the display order of elements.
Original PR description
**Steps:** - Open Planning without demo data - Click on the Week > dropdown menu will open **Issue:** - The dropdown menu is getting overlapped by the content helper. **Cause:** - Before the milky theme, this button was along with other buttons in the control panel, but now it's moved inside hence there is a conflict in the z-index of content helper and the dropdown menu **Fix:** - Changing the z-index of content helper **Task:** 3446994 Forward-Port-Of: odoo/enterprise#45461
This fix resolves an issue where users with Dutch localization installed encountered an error when downloading XAF files. The problem was caused by incorrect data type handling in the system parameters. The fix ensures the batch size parameter is properly converted to the correct format, allowing XAF file downloads to work without errors.
Original PR description
### Current behavior: When Dutch localization is installed creating `l10n_nl_reports.general_ledger_batch_size` in system parameters results in a traceback when trying to download XAF file. ### Error: Casting problem as `batch_size` is interpreted as a str. ### Expected behavior: Download XAF file with no traceback. ### Fix: we cast the variable `batch_size`. ### Affected versions: all > 14 opw-3296107 Forward-Port-Of: odoo/enterprise#49019
The asset accounting tests were incorrectly relying on demo data to run properly. This fix removes that dependency so tests can run independently and reliably. This improves the stability of our testing process and prevents failures when demo data is not available.
Original PR description
We rely on demo data to run the tests, while we should not. Linked to runbot error 27596, 27598, 27599, 27600, 27601, 27460, 27464, 27465, 27466, 27467, 27468, 26269, 26270, 26271, 26272, 26257, 26956, 26964, 26965, 26966, 26967 Forward-Port-Of: odoo/enterprise#49506 Forward-Port-Of: odoo/enterprise#49108
This update fixes a broken test in the Industry FSM Sales module that was failing when installed without certain accounting modules. The test now creates its own required accounting data during setup, making it work independently regardless of which other modules are installed. This ensures the test suite runs reliably in all installation scenarios.
Original PR description
**steps to reproduce:** make a fresh install with only industry_fsm_sale (-i industry_fsm_sale) and run tests **before this commit:** test_task is broken as some accounting data is missing on the current company `odoo.exceptions.UserError: No journal could be found in company YourCompany for any of those types: sale ` **after this commit:** the test is independent and create relevant accounting data during the setUpClass opw-3506568 Forward-Port-Of: odoo/enterprise#49429
This update fixes two issues in the appointment scheduling system: it corrects how resource parameters are handled when canceling appointments, and it prevents the system from considering linked resources that lack available capacity or weren't part of the original resource list. These fixes prevent errors when customers try to book appointment time slots.
Original PR description
Use the correct name for the resource selected in the URL param and don't take into account linked resources that don't have remaining capacity or that are not part of the initial resources available. task-3424035 Forward-Port-Of: odoo/enterprise#44101
This fix ensures that appraisals created automatically through scheduled tasks now behave the same as manually created appraisals. Specifically, feedback templates are now properly loaded and feedback responses remain unpublished until explicitly released, preventing premature visibility of evaluation feedback.
Original PR description
Purpose: The appraisal created from cron is already is confirmed state and it should have same bihavior as manually created and confirmed one. The feedback templates should be loaded and feedback not published. Prior this commit: When we create appraisal from cron, the template is not loaded. Also both feedbacks are published. After this commit: The appraisal that is created from cron, has loaded templates and employee and manager feedbacks are not published. Forward-Port-Of: odoo/enterprise#49773
This update simplifies the quality control interface by removing a secondary quality alert feature and replacing it with a server action. This change reduces visual clutter in the picking view, making the interface cleaner and easier to use for warehouse staff.
Original PR description
Replace it by a server action. The purpose is to lighten the picking from view
This update resolves a bug in the 360 feedback feature where non-HR users encountered access errors when attempting to resend feedback. The fix prevents the system from trying to access private employee email information that these users don't have permission to view, making the feedback resend feature work properly for all authorized users.
Original PR description
This commit fixes the feedback resend feature as it was trying to access the private email of the employee, causing access errors for non hr-users. Forward-Port-Of: odoo/enterprise#49803
This update fixes spelling and grammar errors discovered during the translation process for Odoo 17 across three modules: Appointment Account Payment, Maintenance Worksheet, and MRP Workorder. These corrections ensure that users see properly spelled text throughout the system, improving the overall quality and professionalism of the software.
Original PR description
Corrects typos found when translating Odoo 17. *: appointment_account_payment, maintenance_worksheet, mrp_workorder Community: https://github.com/odoo/odoo/pull/140282
This update fixes a critical issue in account reports where financial summaries would fail to load when child line items lacked codes. The fix ensures reports can be opened and properly audited, and includes new tests to prevent this problem from recurring in the future.
Original PR description
[FIX] account_reports: properly handle lines without codes in sum_children aggregations If some child lines did not have any code, sum_children did not work well, and the report could not be opened. --------------------------- [IMP] account_reports: add a test checking a sum_children aggregation can properly be audited This case was untested and broken (it entered an infinite loop when trying to expand the aggregation and loaded forever). The community counterpart of this PR fixes the bug ; this commit adds the proper test to ensure this does not happen again. Forward-Port-Of: odoo/enterprise#49365 Forward-Port-Of: odoo/enterprise#49133
A recent update changed how SEPA payment methods are identified in the system, but the code that displays bank account information in payment tokens wasn't updated accordingly. This caused bank account numbers to be hidden with dots (••••) instead of showing the actual account details. This fix restores the proper display of bank account information for SEPA direct debit payments.
Original PR description
Commit 9b729b15 changed the provider code of SEPA from 'sepa_direct_debit' to 'custom' but did not adapt the check on the provider code when computing the display name of tokens. This caused SEPA tokens' name to be padded •••• instead of using the bank account's number as name. Forward-Port-Of: odoo/enterprise#49748
This update resolves an issue where users on Safari browsers were unable to copy text or access the share feature in the Documents module. When clicking the share icon, Safari would display a "NotAllowedError" message. This fix ensures the Documents feature works consistently across all major browsers, including Safari on secure HTTPS connections.
Original PR description
Steps to reproduce ================== - On safari, go to an odoo instance with https (you can use browserstack + ngrok) - Install documents - Go to documents - Click on a document - Click on the share icon -> NotAllowedError opw-3556808 Forward-Port-Of: odoo/enterprise#49730 Forward-Port-Of: odoo/enterprise#49291
This update fixes two issues in the report editor: changes are now properly reset when you reset the report, and the toolbar correctly hides when dialog boxes appear. These fixes ensure a smoother and more reliable experience when editing reports in Odoo Studio.