Friday, November 3, 2023
27 changes · 17.0
Enhancements to existing features
The IAP settings widget now takes users directly to the in-app list of their services instead of sending them to the IAP website. This makes service management more consistent with the main settings button and reduces unnecessary navigation.
Original PR description
Description of the issue/feature this PR addresses: The "View My Services" button of the widget should open the IAP accounts tree view, just as the main "View My Services" button of the general settings. Current behavior before PR: View my services widget redirected to iap website Desired behavior after PR is merged: Updated the widget to redirect to tree view of services task-3580190 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Dropdown menus in the website editor now reposition automatically when they are near the bottom of the panel. This keeps options visible without forcing users to scroll, making page editing smoother and less frustrating.
Original PR description
Before this commit, there was an issue with the dropdowns in the editor panel. When the selector was at the bottom of the panel, the dropdown opened outside the viewport, requiring the user to scroll the editor panel to see it. After this commit, the dropdowns in the editor panel open above the selector if there is not enough space below for it to be visible without scrolling. task-3500768
This change makes two existing website tour utilities available for reuse. It helps developers build custom guided interactions, such as drag-and-drop steps, with less duplicated code.
Original PR description
Add export to 'getDifferentParents' and 'triggerPointerEvent'. It is useful for creating a custom drag and drop for example. Task-id 3419214 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
The attendance menu no longer shows a small non-zero value for today's hours when it should be zero. This prevents confusion for employees clocking in for the first time that day by correcting a rounding issue.
Original PR description
Due to rounding errors, the variable isFirstAttendance was not computed properly due to hours_today not being exactly 0, we apply a 3 digit precision rounding to solve this issue. task-3565209
Miscellaneous changes
Current behavior: if the user has no access to crm.lead, it shows the error ``` You are not allowed to access 'Lead/Opportunity' (crm.lead) records. This operation is allowed for the following groups: - Extra Rights/Contact Creation - Sales/Administrator - Sales/User: Own Documents Only - User types/Portal Contact your administrator to request access if necessary.' ``` With this fix, First check the access to the model to count the records or assign zero. **Error:**  Related ticket #3546713 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139404
Fixed an error that prevented Odoo Studio from opening from the Amounts to Settle view. Users can now customize this accounting view without encountering a traceback, improving reliability for finance teams using Studio.
Original PR description
Steps to reproduce: 1. Open the "Amounts to Settle" view of either the Customers of Vendors menu 2. Click on the Studio button on the top right of the window 3. A traceback appears. --- Issue/Feature this commits addresses: When on the "Amounts to Settle" view, when clicking on the Studio button, a traceback appears and the studio menu is not opened. This should not happen. --- Desired behavior after this commit is merged: This fix makes the event that would cause the error not possible anymore. The studio menu should always open and not cause that traceback anymore. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents guided tours from being started and resumed at the same time, which could cause conflicting behavior and multiple help prompts to appear. It makes the tour experience more reliable and avoids confusing duplicate tooltips for users.
Original PR description
Before this commit, tours could be resumed AND started in the same sequence, causing object mismatches in the tour service internals and resulting in multiple tooltips being displayed at the same time. This commit ensures that a tour instance can only be run once at a time. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes minor typos discovered during translation work for Odoo 17. The changes improve wording consistency and translation quality in automated actions and website wishlist content without affecting business workflows.
Original PR description
Corrects typos found when translating Odoo 17. Enterprise: https://github.com/odoo/enterprise/pull/49981
After confirming stock transfers, action buttons now stay correctly separated instead of overlapping with the delete icon. This prevents visual confusion and avoids needing to refresh the page to see the correct layout.
Original PR description
Currently after confirmation on picking. The details operations button is mixed in the trash icon. The view needs a refresh to be correct. This is cleaned by moving all the buttons together and introducing the custom column before the last buttons group. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
In self-ordering, customers can no longer interact with individual lines in past orders. This avoids unnecessary actions on orders that have already been paid, making the order history clearer and less confusing.
Original PR description
It's no longer necessary to interact with the orderlines in the order history because it's showing already paid orders.
This fix corrects a bug where WhatsApp message failure reasons were displaying an extra 'f' character at the beginning. When a WhatsApp message fails to send, users will now see the correct error message without the unwanted character. This improves the clarity of error reporting for failed message deliveries.
Original PR description
When the `failure_reason` comes from `webhookpost` then it adds an extra `f` to the message.
Steps to produce:
- Send a WhatsApp template to the phone number whose WhatsApp account has not been created to date
- Check `whatsapp.message` record
- failure_reason will have an extra f at starting
Problem:
`webhookpost` calls `_process_statuses` which calls `_handle_error` if status is failed. `_process_statuses` sends an extra `f` while sending `error_message` to `_handle_error`. Like `error_message=f"{error['code']} : f{error['title']}"`
Solution:
Extra `f` is removed. `f{error['title']}` is changed to `{error['title']}`
Task - 3576925
Forward-Port-Of: odoo/enterprise#50000
Forward-Port-Of: odoo/enterprise#49916This update fixes spelling and typing errors that were discovered during the translation process for Odoo 17. The corrections improve the quality and professionalism of the Knowledge and Sales Subscription modules by ensuring all text is properly spelled and formatted for users worldwide.
Original PR description
Corrects typos found when translating Odoo 17. Community: https://github.com/odoo/odoo/pull/140627
Since [1] when the layout of the theme options was reorganized, the button's font-family option was not displayed anymore. This commit restores the button's font-family inside the "Button" section, before the button "Padding" options. [1]: https://github.com/odoo/odoo/commit/388e4bb2bfcaebdd4ff30277fb49a034592d7086 task-3478355 Forward-Port-Of: odoo/odoo#136521
Original PR description
Since [1] when the layout of the theme options was reorganized, the button's font-family option was not displayed anymore. This commit restores the button's font-family inside the "Button" section, before the button "Padding" options. [1]: https://github.com/odoo/odoo/commit/388e4bb2bfcaebdd4ff30277fb49a034592d7086 task-3478355 Forward-Port-Of: odoo/odoo#136521
Steps to reproduce: (ETA API credentials required) - Install l10n_eg_edi_eta - Switch to an Egyptian company - Configure ETA API Integration - Create a tax with "Fixed" as "Tax Computation" - Create an invoice with the created fixed tax - Send the invoice to ETA => The invoice is rejected by ETA. Cause: The generated EDI document contains an entry looking like this: `"taxableItems": [{"taxType": "T1", "amount": 28.0, "subType": "V009", "rate": 14.0}]` where each element of "taxableI
Original PR description
Steps to reproduce: (ETA API credentials required)
- Install l10n_eg_edi_eta
- Switch to an Egyptian company
- Configure ETA API Integration
- Create a tax with "Fixed" as "Tax Computation"
- Create an invoice with the created fixed tax
- Send the invoice to ETA
=> The invoice is rejected by ETA.
Cause:
The generated EDI document contains an entry looking like this:
`"taxableItems": [{"taxType": "T1", "amount": 28.0, "subType": "V009", "rate": 14.0}]`
where each element of "taxableItems" is a dict with the details of each applied tax.
However, for fixed taxes, the "rate" key should not be there.
Solution:
Only populate the "rate" key if the tax is not a fixed one.
opw-3436422
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#140736
Forward-Port-Of: odoo/odoo#139306Forward-Port-Of: odoo/odoo#140681
Original PR description
Forward-Port-Of: odoo/odoo#140681
Prior to this commit, there was no space between tags and the label. This commit adapts the label margin to maintain layout consistency. task-3575796 | Before | After | |--------|--------| |  |  | --- I confirm I have signed the CLA
Original PR description
Prior to this commit, there was no space between tags and the label. This commit adapts the label margin to maintain layout consistency. task-3575796 | Before | After | |--------|--------| |  |  | --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140325
Reproduce Create some `expense`, approve some of them Expected: On journal dashboard, The `Expense Journal` need to display Number of Expense to process Actual: `number_expenses_to_pay` does not display on The `Expense Journal` because we haven't override the needed method yet Also this PR aim to improve the `open_expenses_action` to display correctly the number of expense on the journal dashboard Video to reproduce on runbot 25/09/2023 https://github.com/odoo/odoo/assets/5678
Original PR description
Reproduce Create some `expense`, approve some of them Expected: On journal dashboard, The `Expense Journal` need to display Number of Expense to process Actual: `number_expenses_to_pay` does not display on The `Expense Journal` because we haven't override the needed method yet Also this PR aim to improve the `open_expenses_action` to display correctly the number of expense on the journal dashboard Video to reproduce on runbot 25/09/2023 https://github.com/odoo/odoo/assets/56789189/6d4a4c14-1551-40af-84ae-9ce9a7e4a666 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#138598 Forward-Port-Of: odoo/odoo#136232
**Current behavior before PR:** When we try to click on element contenteditable=false then it is switch to nearest editable area. **Desired behavior after PR is merged:** When we try to click on element contenteditable=false then it will not switch to nearest editable area. Task-2977246 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139662 Forward-Port-Of: odoo/odoo#125180
Original PR description
**Current behavior before PR:** When we try to click on element contenteditable=false then it is switch to nearest editable area. **Desired behavior after PR is merged:** When we try to click on element contenteditable=false then it will not switch to nearest editable area. Task-2977246 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139662 Forward-Port-Of: odoo/odoo#125180
Same case as [1] but suppose the over-consumption is on the second raw SM. Then, in the loop: https://github.com/odoo/odoo/blob/165f8881e2850b4e2087bce77692965843609363/addons/stock/models/stock_move.py#L1705-L1713 On the first iteration, everything is ok, we add the SM to `moves_ids_todo`. Second iteration, there is an extra move, it will lead to the merge of both initial SM (see [1] for more details). Therefore, `moves_ids_todo` now contains a deleted SM: it will lead to the same error
Original PR description
Same case as [1] but suppose the over-consumption is on the second
raw SM. Then, in the loop:
https://github.com/odoo/odoo/blob/165f8881e2850b4e2087bce77692965843609363/addons/stock/models/stock_move.py#L1705-L1713
On the first iteration, everything is ok, we add the SM to
`moves_ids_todo`. Second iteration, there is an extra move, it will
lead to the merge of both initial SM (see [1] for more details).
Therefore, `moves_ids_todo` now contains a deleted SM: it will lead
to the same error ("Record has been deleted') when calling
`_check_company`.
Commit [1] is then too naive and can be reverted. We should rather
avoid "extra merge": when confirming a stock move SM01, we should avoid
the merge of SM02 and SM03 as side effect.
[1] https://github.com/odoo/odoo/commit/b870ffa65410435237a172a491ed1454957ce28a
OPW-3432293
Forward-Port-Of: odoo/odoo#140450
Forward-Port-Of: odoo/odoo#139590Fixup of odoo/odoo#138875 The active was on the wrong model Fixes odoo/odoo#140602 Forward-Port-Of: odoo/odoo#140639
Original PR description
Fixup of odoo/odoo#138875 The active was on the wrong model Fixes odoo/odoo#140602 Forward-Port-Of: odoo/odoo#140639
Steps to reproduce the bug: - Open the Menu Editor. - Add a menu item. - Type a URL (which will trigger the autocomplete). - Bug: You can't select the last URLs in the autocomplete dropdown because it goes off screen and can't be scrolled. This bug was introduced by the commit [1]. Since this commit, all modal dialogs are vertically centered, which is why the bug fixed in this commit occurred. [1]: https://github.com/odoo/odoo/commit/dd141a22f44ea88af18448c4a6089252daeba8cc task-3
Original PR description
Steps to reproduce the bug: - Open the Menu Editor. - Add a menu item. - Type a URL (which will trigger the autocomplete). - Bug: You can't select the last URLs in the autocomplete dropdown because it goes off screen and can't be scrolled. This bug was introduced by the commit [1]. Since this commit, all modal dialogs are vertically centered, which is why the bug fixed in this commit occurred. [1]: https://github.com/odoo/odoo/commit/dd141a22f44ea88af18448c4a6089252daeba8cc task-3580373 Forward-Port-Of: odoo/odoo#140729
backport of : https://github.com/odoo/odoo/commit/895dd1aee22885cd9d98957be32b7916f77009d0 related enterprise fix : https://github.com/odoo/enterprise/pull/48635 opw-3523557 Forward-Port-Of: odoo/odoo#140289 Forward-Port-Of: odoo/odoo#138056
Original PR description
backport of : https://github.com/odoo/odoo/commit/895dd1aee22885cd9d98957be32b7916f77009d0 related enterprise fix : https://github.com/odoo/enterprise/pull/48635 opw-3523557 Forward-Port-Of: odoo/odoo#140289 Forward-Port-Of: odoo/odoo#138056
Task Adhoc: 32844 Task Latam: 1053 Description of the issue/feature this PR addresses: 1. If the date is changed in the payment wizard don't update the check amount. 2. Payment currency should be the same as the check currency. 3. Warning in the payment register for example if the currency of the check is different than the currency of the payment. 4. Check on companies without country. Company without country should not use checks. 5. Not possible pay with a check with a date that is
Original PR description
Task Adhoc: 32844 Task Latam: 1053 Description of the issue/feature this PR addresses: 1. If the date is changed in the payment wizard don't update the check amount. 2. Payment currency should be the…
Task Adhoc: 32844 Task Latam: 1053 Description of the issue/feature this PR addresses: 1. If the date is changed in the payment wizard don't update the check amount. 2. Payment currency should be the same as the check currency. 3. Warning in the payment register for example if the currency of the check is different than the currency of the payment. 4. Check on companies without country. Company without country should not use checks. 5. Not possible pay with a check with a date that is prior to the check creation date (vendor bill payment date should be after the Customer Invoice payment date when the check was created). 6. If the payment amount is changed and it does not match the check amount then a warning pops up. Current behavior before PR: 1. If the date is changed in the payment wizard is updated the check amount. 2. Payment currency can be different than the check currency. 3. No warning in the payment register for example if the currency of the check is different than the currency of the payment. 4. Check on companies without country. Company without country can use checks. 5. Possible to pay with a check with a date that is prior to the check creation date (vendor bill payment date should be after the Customer Invoice payment date when the check was created). 6. If the payment amount is changed and it does not match the check amount then a warning not pops up. Desired behavior after PR is merged: 1. If the date is changed in the payment wizard the check amount is not updated. 2. Payment currency should be the same as the check currency. 3. Warning in the payment register for example if the currency of the check is different than the currency of the payment. 4. Check on companies without country. Company with country can`t use checks. 5. Not possible to pay with a check with a date that is prior to the check creation date (vendor bill payment date should be after the Customer Invoice payment date when the check was created). 6. If the payment amount is changed and it does not match the check amount then a warning pops up. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139869
Issue is translation of view which doesn't have website_id and website module is installed in thast case will be lost after upgrade due to this commit: https://github.com/odoo/odoo/pull/129518/commits/85940335216de8a4225793095ee2d9a165e3ef71 OPW: 3496112, 3478348 Forward-Port-Of: odoo/odoo#140620
Original PR description
Issue is translation of view which doesn't have website_id and website module is installed in thast case will be lost after upgrade due to this commit: https://github.com/odoo/odoo/pull/129518/commits/85940335216de8a4225793095ee2d9a165e3ef71 OPW: 3496112, 3478348 Forward-Port-Of: odoo/odoo#140620
Forward-Port-Of: odoo/odoo#140702
Original PR description
Forward-Port-Of: odoo/odoo#140702
This commit forces the color of all buttons in the header to have a better-look consistency. Steps to reproduce: * Open Odoo on small screen * Go to Sale * Create a new SO * Click on customer field to open the Kanban view => BUG the clear button is not visible Forward-Port-Of: odoo/enterprise#50123
Original PR description
This commit forces the color of all buttons in the header to have a better-look consistency. Steps to reproduce: * Open Odoo on small screen * Go to Sale * Create a new SO * Click on customer field to open the Kanban view => BUG the clear button is not visible Forward-Port-Of: odoo/enterprise#50123
backport of : https://github.com/odoo/enterprise/commit/12185458eb9f95b1e8afec5d91449a0532edee77 related community fix : https://github.com/odoo/odoo/pull/138056 opw-3523557 Forward-Port-Of: odoo/enterprise#49834 Forward-Port-Of: odoo/enterprise#48635
Original PR description
backport of : https://github.com/odoo/enterprise/commit/12185458eb9f95b1e8afec5d91449a0532edee77 related community fix : https://github.com/odoo/odoo/pull/138056 opw-3523557 Forward-Port-Of: odoo/enterprise#49834 Forward-Port-Of: odoo/enterprise#48635