Saturday, November 4, 2023
23 changes · master
Enhancements to existing features
When an HR plan is duplicated, the new plan name now automatically includes "(copy)" at the end. This helps users distinguish originals from duplicates, reducing confusion when managing and tracking HR plans.
Original PR description
This commit introduces a feature that automatically appends "(copy)" to the end of the plan name whenever it is duplicated. This change enhances clarity and separates the original plan from its duplicates, simplifying management and tracking. task-3544642
Miscellaneous changes
**Current behavior before PR:** Message type of rating messages for Livechat Session in demo data was not set, which led it to set default type `email`. Which would lead to display the `Show/hide original email` button. **Desired behavior after PR is merged:** Set `message_type` as `notification`. task-3502745 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140902
Original PR description
**Current behavior before PR:** Message type of rating messages for Livechat Session in demo data was not set, which led it to set default type `email`. Which would lead to display the `Show/hide original email` button. **Desired behavior after PR is merged:** Set `message_type` as `notification`. task-3502745 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140902
fix typo in #119813 for ormcache Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140946
Original PR description
fix typo in #119813 for ormcache Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140946
Before this commit, tours could be resumed AND started in the same sequence, causing object mismatches in the tour service internals and resulting in multiple tooltips being displayed at the same time. This commit ensures that a tour instance can only be run once at a time. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140664
Original PR description
Before this commit, tours could be resumed AND started in the same sequence, causing object mismatches in the tour service internals and resulting in multiple tooltips being displayed at the same time. This commit ensures that a tour instance can only be run once at a time. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140664
Steps to reproduce: 1. Open the "Amounts to Settle" view of either the Customers of Vendors menu 2. Click on the Studio button on the top right of the window 3. A traceback appears. --- Issue/Feature this commits addresses: When on the "Amounts to Settle" view, when clicking on the Studio button, a traceback appears and the studio menu is not opened. This should not happen. --- Desired behavior after this commit is merged: This fix makes the event that would cause the erro
Original PR description
Steps to reproduce: 1. Open the "Amounts to Settle" view of either the Customers of Vendors menu 2. Click on the Studio button on the top right of the window 3. A traceback appears. --- Issue/Feature this commits addresses: When on the "Amounts to Settle" view, when clicking on the Studio button, a traceback appears and the studio menu is not opened. This should not happen. --- Desired behavior after this commit is merged: This fix makes the event that would cause the error not possible anymore. The studio menu should always open and not cause that traceback anymore. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140671
Before this commit service threshold value for 'unit' unit of measure display (1 unit = 8.00 hours) but since https://github.com/odoo/odoo/pull/99785 PR we take 1 unit equals to 1 hours not 8 hours. This commit display (1 unit = 1.00 hour, 1 unit = 0.12 day) to display proper value according to calculation. task-3282848 Forward-Port-Of: odoo/odoo#119159
Original PR description
Before this commit service threshold value for 'unit' unit of measure display (1 unit = 8.00 hours) but since https://github.com/odoo/odoo/pull/99785 PR we take 1 unit equals to 1 hours not 8 hours. This commit display (1 unit = 1.00 hour, 1 unit = 0.12 day) to display proper value according to calculation. task-3282848 Forward-Port-Of: odoo/odoo#119159
**Steps:** - Open Settings > Users - Change the name of the user by typing it multiple times - Go to the portal view of the website - Among the Documents select Task > select a task where our user is set as an employee **Issue:** - When that particular task is chosen, under the Timesheets, the name is found repeatedly in the table. **Cause:** - The text is not truncated due to which the name overflows. **Fix:** - adding a class 'o_portal_my_doc_table' in the table which helps to
Original PR description
**Steps:** - Open Settings > Users - Change the name of the user by typing it multiple times - Go to the portal view of the website - Among the Documents select Task > select a task where our user is set as an employee **Issue:** - When that particular task is chosen, under the Timesheets, the name is found repeatedly in the table. **Cause:** - The text is not truncated due to which the name overflows. **Fix:** - adding a class 'o_portal_my_doc_table' in the table which helps to truncate the text **Task:** 3383519 Forward-Port-Of: odoo/odoo#140776 Forward-Port-Of: odoo/odoo#126414
=== ISSUE 1 === Prior to this commit, card colors in the index list were static, creating a contrast issue if the page background color changed. This commit fixes this issue. === ISSUE 2 === Prior to this commit, the popover text color and the shadow created color issues when the background color of the page was dark. To fix that and maintain consistency, we use the common Bootstrap shadow and force the text color to be dark. task-3097005 Part of task-3097005 | Before | After |
Original PR description
=== ISSUE 1 === Prior to this commit, card colors in the index list were static, creating a contrast issue if the page background color changed. This commit fixes this issue. === ISSUE 2 === Prior to…
=== ISSUE 1 === Prior to this commit, card colors in the index list were static, creating a contrast issue if the page background color changed. This commit fixes this issue. === ISSUE 2 === Prior to this commit, the popover text color and the shadow created color issues when the background color of the page was dark. To fix that and maintain consistency, we use the common Bootstrap shadow and force the text color to be dark. task-3097005 Part of task-3097005 | Before | After | |--------|--------| |  |  | |  |  | --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#138922
Problem --------- The compute_is_used function currently parses through a huge amount of data using the _read_group ORM function. Which causes some performance issues in large databases. Objective --------- Improve performance of the said function. Solution --------- Instead of reading the data on whole tables (ex.account_move_line), we read the relation table between the modules and the taxes. This is done using SQL queries with the EXISTS statement. Furthermore, the code logic
Original PR description
Problem --------- The compute_is_used function currently parses through a huge amount of data using the _read_group ORM function. Which causes some performance issues in large databases. Objective --------- Improve performance of the said function. Solution --------- Instead of reading the data on whole tables (ex.account_move_line), we read the relation table between the modules and the taxes. This is done using SQL queries with the EXISTS statement. Furthermore, the code logic is modified so that if all the taxes for which we compute `is_used` have been found, we don't look further in other modules since doing this cannot add any new relevant information and actually slows down the computation. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139497
This PR refactor the "inputs design system" by reverting the correlation `$input-bg == $light == color-3` initially introduced by https://github.com/odoo/odoo/pull/120302. Beside ensuring color-consistency, the former system aimed to simplify palette edition by clarifying how `color-3` was used (simply all the UI elements...). While the former system was responsive to user customization and color-presets, it didn't necessarily delight everyone's discerning taste, at least not with default
Original PR description
This PR refactor the "inputs design system" by reverting the correlation `$input-bg == $light == color-3` initially introduced by https://github.com/odoo/odoo/pull/120302. Beside ensuring…
This PR refactor the "inputs design system" by reverting the correlation `$input-bg == $light == color-3` initially introduced by https://github.com/odoo/odoo/pull/120302. Beside ensuring color-consistency, the former system aimed to simplify palette edition by clarifying how `color-3` was used (simply all the UI elements...). While the former system was responsive to user customization and color-presets, it didn't necessarily delight everyone's discerning taste, at least not with default settings/palette. This commit enforces a classic "white with borders" design that's independent from the color palette and doesn't adapt to color-presets. The rationale behind this decision is that the need for non-white inputs is nonexistent and exceptional cases should be addressed using the SCSS editor. As a workaround for users that still wants to challenge themselves with the creation of "not standard" palettes/designs, this commit introduce a colorPicker option assigned to `$input-bg`. The hope is that this new controller help users finding a "compromise color" that could work with any color-presets. Embracing flexibility and open collaboration. task-3568806 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139642
task-3285817 Forward-Port-Of: odoo/odoo#140372
Original PR description
task-3285817 Forward-Port-Of: odoo/odoo#140372
Description of the issue/feature this PR addresses: The "View My Services" button of the widget should open the IAP accounts tree view, just as the main "View My Services" button of the general settings. Current behavior before PR: View my services widget redirected to iap website Desired behavior after PR is merged: Updated the widget to redirect to tree view of services task-3580190 Description of the issue/feature this PR addresses: Current behavior before PR: Desired beha
Original PR description
Description of the issue/feature this PR addresses: The "View My Services" button of the widget should open the IAP accounts tree view, just as the main "View My Services" button of the general settings. Current behavior before PR: View my services widget redirected to iap website Desired behavior after PR is merged: Updated the widget to redirect to tree view of services task-3580190 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140904
Forward-Port-Of: odoo/odoo#140966
Original PR description
Forward-Port-Of: odoo/odoo#140966
This commit forces the color of all buttons in the header to have a better-look consistency. Steps to reproduce: * Open Odoo on small screen * Go to Sale * Create a new SO * Click on customer field to open the Kanban view => BUG the clear button is not visible (enterprise) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#141040 Forward-Port-Of: odoo/odoo#140921
Original PR description
This commit forces the color of all buttons in the header to have a better-look consistency. Steps to reproduce: * Open Odoo on small screen * Go to Sale * Create a new SO * Click on customer field to open the Kanban view => BUG the clear button is not visible (enterprise) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#141040 Forward-Port-Of: odoo/odoo#140921
**Before this commit** Open some popover then a dialog. The popover appears in front on the dialog. Examples: - Calendar > Click an event (popover opens) > Open command palette - Open a facet domain editor dialog in any app, then open any model field selector popover and open the command palette **After this commit** Each first-level child of the overlay container starts with the same z-index and with a value that is greater than the higher value we can find in the bootstrap z-inde
Original PR description
**Before this commit** Open some popover then a dialog. The popover appears in front on the dialog. Examples: - Calendar > Click an event (popover opens) > Open command palette - Open a facet domain editor dialog in any app, then open any model field selector popover and open the command palette **After this commit** Each first-level child of the overlay container starts with the same z-index and with a value that is greater than the higher value we can find in the bootstrap z-index master list. This solves the aforementioned overlaping issues. Forward-Port-Of: odoo/odoo#140875
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140979
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140979
See commits :) Forward-Port-Of: odoo/enterprise#50096 Forward-Port-Of: odoo/enterprise#49965
Original PR description
See commits :) Forward-Port-Of: odoo/enterprise#50096 Forward-Port-Of: odoo/enterprise#49965
This commit reviews the UI of the app and fixes issues related to the design consistency. task-3570261 Forward-Port-Of: odoo/enterprise#49781
Original PR description
This commit reviews the UI of the app and fixes issues related to the design consistency. task-3570261 Forward-Port-Of: odoo/enterprise#49781
This PR contains two commits each of which has a different purpose : --- The first commit is a cleanup of the Aged Payable audit as it can be improved a lot by using the new "action_audit_cell" method callable on any report. It is also done in order to fix an unwanted behavior on the Aged Receivable report where no amounts would appear in the different cells of the report. Find more information about it in the first commit's message --- The second commit makes the Aged Receivable
Original PR description
This PR contains two commits each of which has a different purpose : --- The first commit is a cleanup of the Aged Payable audit as it can be improved a lot by using the new "action_audit_cell"…
This PR contains two commits each of which has a different purpose : --- The first commit is a cleanup of the Aged Payable audit as it can be improved a lot by using the new "action_audit_cell" method callable on any report. It is also done in order to fix an unwanted behavior on the Aged Receivable report where no amounts would appear in the different cells of the report. Find more information about it in the first commit's message --- The second commit makes the Aged Receivable report auditable as well. The current behavior of the Aged Receivable is not to be auditable but the way the audit of the Aged Payable has been made makes it easy for the Aged Receivable to be auditable as well so let's do it. Find more information about it in the second commit's message. --- After both these commits are merged, the Aged Receivable report's cells show the amounts they are supposed to at every time, the Aged Payable report's audit system is cleaner and the Aged Receivable is now auditable. Forward-Port-Of: odoo/enterprise#49745
To reproduce ============ - install Inventory then `l10n_mx_edi_stock` - on Inventory settings enable Batch Transfers -> Error Problem ======= the view can't find some fields added by `l10n_mx_edi_stock`, these fields were added on the header of the view but when enabling Batch Transfers, the header is remplaced in `stock_picking_batch.picking.form`, so these fields are lost. Solution ======== put these fields out of the header to avoid loosing them. opw-3562995 Forward-Port-Of:
Original PR description
To reproduce ============ - install Inventory then `l10n_mx_edi_stock` - on Inventory settings enable Batch Transfers -> Error Problem ======= the view can't find some fields added by `l10n_mx_edi_stock`, these fields were added on the header of the view but when enabling Batch Transfers, the header is remplaced in `stock_picking_batch.picking.form`, so these fields are lost. Solution ======== put these fields out of the header to avoid loosing them. opw-3562995 Forward-Port-Of: odoo/enterprise#49569
- impacted modules: - sale_planning - sale_project_forecast Steps ===== - Install module sale_planning - Create a resource with no shift associated to it - In the main planning view, search the name of this resource Issue ===== No empty line is displayed for this resource. Cause ===== The main action of planning is overridden in sale_planning and sale_project_forecast to change is context. The context key 'planning_expand_resource' was not present in those overridden
Original PR description
- impacted modules:
- sale_planning
- sale_project_forecast
Steps
=====
- Install module sale_planning
- Create a resource with no shift associated to it
- In the main planning view, search the name of this resource
Issue
=====
No empty line is displayed for this resource.
Cause
=====
The main action of planning is overridden in sale_planning and sale_project_forecast to change is context. The context key 'planning_expand_resource' was not present in those overridden contexts.
Fix
===
The context key is simply added in the context of the main action in those two modules.
Forward-Port-Of: odoo/enterprise#50034
Forward-Port-Of: odoo/enterprise#49993To reproduce ============ - Go to helpdesk tickets in a list view - Add the "last updated on" field - The customer should be a portal user (e.g. Joel Willis) - Answer to the ticket from the portal account of Joel Willis --> the "last update on" field is not updated when it should be Problem ======= - when receiving multiple message from customer we don't modify anything on the record, that's why `write_date` is not updated. Solution ======== when receiving new message, trigger `wr
Original PR description
To reproduce ============ - Go to helpdesk tickets in a list view - Add the "last updated on" field - The customer should be a portal user (e.g. Joel Willis) - Answer to the ticket from the portal account of Joel Willis --> the "last update on" field is not updated when it should be Problem ======= - when receiving multiple message from customer we don't modify anything on the record, that's why `write_date` is not updated. Solution ======== when receiving new message, trigger `write` method without values to force updating `write_date` opw-3482215 Forward-Port-Of: odoo/enterprise#49648
Instead of having to create two PRs (one in Enterprise and one in IAP) every time we encounter a new error type in Codabox, we forward the Codabox error type to Odoo and handle it there so that we only need one PR in Enterprise to manage this new encountered error with a user friendly error message. Forward-Port-Of: odoo/enterprise#49968
Original PR description
Instead of having to create two PRs (one in Enterprise and one in IAP) every time we encounter a new error type in Codabox, we forward the Codabox error type to Odoo and handle it there so that we only need one PR in Enterprise to manage this new encountered error with a user friendly error message. Forward-Port-Of: odoo/enterprise#49968