Monday, November 6, 2023
59 changes · 17.0
Enhancements to existing features
The reaction controls now use a more recognizable icon for adding a reaction, so users can more easily tell it apart from viewing existing reactions. This reduces confusion in mail and emoji-related interactions.
Original PR description
Prior to this commit, "Add a Reaction" and "View Reactions" buttons had the same icon, which was confusing. This PR adapts the "Add a Reaction" icon to make it more recognizable. task-3577008 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A new documentation link was added to the PDF quote builder settings. This helps users quickly find guidance when configuring quote PDFs, reducing confusion and support needs.
This change enables development tooling for the web module in the 17.0 branch. It helps teams catch issues earlier during code preparation, improving consistency and reducing maintenance risk without changing business workflows.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Expense reports no longer show the attachment file name in the attachment view. This makes reports cleaner and keeps the focus on the receipt or supporting document itself rather than its stored filename.
Original PR description
The goal of this pr is to remove the name of the file on the expense report. task: 3473105 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The update moves automatic text box resizing into a dedicated web utility and updates survey pages to use it directly. This keeps the shared web code cleaner and helps maintain consistent survey form and print behavior with lower maintenance risk.
Original PR description
Part-of-task: 3439226
The website editor now stops waiting for AI-generated content after 30 seconds instead of 5 minutes. This gives users faster feedback when the service is slow or unavailable, reducing frustration and long blocked sessions.
Original PR description
The timeout for calls to the OLG API in the editor was set to 300 seconds, which is far too long for a chatbot. This reduces it to 30s. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
New websites will now use more relevant fallback images when the selected business industry does not have dedicated photos available. This helps keep generated website content aligned with the chosen business type instead of defaulting to less relevant theme imagery.
Original PR description
When creating a new website through the configurator, the images that will be used on the website will be the one specified by the selected industry. We recently introduced 2 new images with commit [1] for which the industries have no images set as we did not have time to do it. It would require going through the ~4000 industries and finding a relevant image on Unsplash for it. This commit is simply using another existing set image instead. Indeed, if an industry hasn't set an image, the theme one will be used instead, which is less ideal. Step to reproduce: - Create a new website - Select "Garden furniture store" - Select the Orchid theme (the one in the middle to this day) - Drag & drop the Banner snippet, 2 out of the 3 images used in this snippet will use the theme images (images about flowers) instead of images of furniture (related to the selected industry) [1]: https://github.com/odoo/odoo/commit/3cbdf754ff8fac8a77887c4307b658cb86b0be1d
This update refreshes translation source files (.pot files) across 20+ Odoo modules to capture the latest text strings that need translation. This ensures that translators have access to all current user-facing text in the system, enabling better support for multiple languages and improved user experience globally.
Resolved issues and error corrections
Creating a server action for webhook notifications without selecting a model no longer triggers an error. This helps users configure automations more smoothly and corrects the sample payload field naming shown for webhooks.
Original PR description
**Description of the issue/feature this PR addresses:** Fix _compute_webhook_sample_payload. **Current behavior before PR:** Create a new Server Action.Leave the model empty, change type to 'Send Webhook Notification', an error raised <img width="824" alt="image" src="https://github.com/odoo/odoo/assets/5561864/90fb78b8-eb24-4bb1-9d5a-e0e6593bad3b"> **Desired behavior after PR is merged:** Stop raise the error, also the 'id' should be '_id' --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
pricelist item variant group by filter to actually group by variant the variant field is `product_id`. Current behavior before PR:  Desired behavior after PR is merged:  @ForgeFlow --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: od
Original PR description
pricelist item variant group by filter to actually group by variant the variant field is `product_id`. Current behavior before PR:  Desired behavior after PR is merged:  @ForgeFlow --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#139747
Original PR description
Community: https://github.com/odoo/odoo/pull/141127
This update restores a missing mail service connection needed by the web mail component. It helps prevent failures when opening or interacting with message threads, improving reliability for users who depend on Odoo conversations.
Website editors can now edit links even when the linked page returns an error or is unreachable. Instead of showing an error, Odoo displays a simpler link popover without extra preview details such as the page title or favicon.
Original PR description
Since commit [1] removed `legacyRejectPromiseHandler()`, trying to edit a link leading to an HTTP error triggers an "Uncaught Promise" error. This commit makes sure such links do not cause a traceback: the link popover is just less detailed (no title, favicon). [1]: https://github.com/odoo/odoo/commit/fcb16a3b1bd373726ffb54f0fbe41fb6d1784769 task-3584686
This fixes an issue where newly created website shop categories could appear without their proper display name. It helps staff manage online store categories more reliably and avoids confusing labels in the website sales setup.
Original PR description
task-3582238
The website blog navigation now lines up correctly with the rest of the page layout. This creates a cleaner, more consistent browsing experience for visitors and fixes a visual issue in the portal and blog styling.
Original PR description
Extracted from https://github.com/odoo/odoo/pull/120302#discussion_r1346173626 Prior to this commit, the navigation of `website_blog` wasn't correctly aligned. This commit reworks the alignment to match the page layout. task-3097005
The accounting dashboard’s menu has been simplified by removing unclear options and showing certain journal actions only when they apply to the bank feed setup. This helps users find relevant actions faster and reduces confusion when managing accounting journals.
Original PR description
1. Remove some options from the burger menu to make it more clear. 2. Make some actions on the journal's dashboard card conditional on the Bank Feed type. task-id: 3573286
Fixes an issue where inserting analytic items into a spreadsheet could show errors in the header row. This helps accounting users export and review analytic data in spreadsheets without confusing or broken column labels.
Original PR description
How to reproduce: * Install Accounting and Documents * Accounting > Configuration > Settings > check Analytic Accounting * Accounting > Accounting > Analytic Items * Cogs > Spreadsheet > Insert List Issue: The header in the spreadsheet displays errors.
Reception screens now hide the source package column, which was not relevant for incoming deliveries. This reduces visual clutter and helps warehouse users focus on the information they need when receiving goods.
Original PR description
source package shouldn't be visible in reception --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The skills section now shows text alongside the report icon, making it easier for users to understand what the link does. This reduces confusion when opening employee skills reports.
Original PR description
Prior, there was only icon and it was not clear enough. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue in the website editor where saved snippets could lose their mobile or desktop visibility settings when reused. Users can now drop saved snippets without unintentionally showing content that was meant to stay hidden on specific devices.
Original PR description
Since [1] when device visibility became a visibility option, when dropping a snippet that contains device-invisible blocks, all those blocks were made visible. This commit makes that behavior limited to blocks that are not device-invisible. (E.g. when dropping a popup) Steps to reproduce: - drop a Columns snippet - hide a column on mobile - hide a column on desktop - save snippet - drop saved snippet in either desktop or mobile preview => All columns were shown with the `o_snippet_override_invisible` effect on the conditional ones. [1]: https://github.com/odoo/odoo/commit/3103e0553011b5c1f4078972d7a88fa3fd4068b2 task-3538535
Fixes an issue in the Website app where URL suggestions could be hidden behind the Add Menu Item dialog. This makes editing website menus smoother by ensuring users can see and select autocomplete suggestions as intended.
Original PR description
Since this fix[1] of the overlapping. The `UrlAutocomplete` wasn't working as expected, The `AutoCompleteWithPage` dropdown are displayed behind the dialog when it was inside a dialog. Steps to reproduce: * Open the `Website` app * Click on `Site` > `Edit Menu` > `Add Menu Item` * Start to type in the url field, the dropdown is displayed behind the dialog. => bug Link [1]: https://github.com/odoo/odoo/commit/9682cfa174fb39ec9d9874951ea9ee2884058d96
Opening a message thread no longer briefly jumps or flickers while messages and the saved scroll position load. This improves the user experience in Odoo Discuss and other mail-based conversations by making thread display feel steadier and more polished.
Original PR description
The `onWillStart` hook that was used in the thread component but was replaced by the `onMounted` hook. Indeed, fetching the messages in the `onWillStart` hook was leading to an infinite loop (props updated as a side-effect of the `onWillStart` hook). After messages are loaded, the scroll position of the thread is restored. Since this is done after the component is mounted, another render is triggered and results in a flicker when opening the thread. This commit fixes this issue by waiting for the thread to be mounted and for the scroll position to be restored before showing the message list. Before:  After: 
Imported modules that include their own icon now load that icon from the stored attachment instead of looking for a missing file on the server. This prevents an error during module import and makes the import process more reliable for administrators.
Original PR description
With normal module, the icon is always loaded from the filesystem but when importing a module that contains a module icon (by default in static/description/icon.png) it crash with a `FileNotFound` exceptions because the image is not available on the filesystem but as an ir.attachment. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a manufacturing order status display issue when generating serial numbers for finished products. Orders with all required components reserved now continue to show as ready to produce, avoiding unnecessary confusion for production teams.
Original PR description
To reproduce: - Set tracking mode on Table Leg to no tracking and add 100 to inventory - Create MO for table with quantity more than one and confirm - Click the "+" button to generate a serial Current behavior: The reservation state of the MO goes to "available" in orange, indicating its components are not all assigned. Expected behavior: The reservation state of the MO stays "available" in green, indicating the MO has all of its components assigned and is ready to produce. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change separates how imported module dependencies are collected from how they are displayed. It helps Odoo reuse the dependency list more reliably in SaaS-related flows while keeping the user-facing behavior unchanged.
Original PR description
Since we need to get the list of dependencies for the saas (and not noly a Text of the module names, we split the function to be able to easily get the list of dependencies. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forum user avatars now display with the correct proportions instead of appearing stretched when the original image is not square. The avatar image quality was also improved, making forum pages look cleaner and more professional.
Original PR description
This PR allows avatars that would not be squared to be rendered with a correct aspect ratio inside Forum. Before these changes, if the user avatar was not uploaded in a squared size, it would be stretched while being rendered inside the forum UI. To solve this issue, we simply add the `o_object_fit_cover` class to these avatars, ensuring they are well rendered. We also changed the resolution to 128x128, to provide a better render. task-358013
The search bar now keeps its icons and text properly aligned when users hover over filter chips, even when Discuss is not installed. A shared background style was moved into the core web interface so the behavior is consistent across setups.
Original PR description
When discuss is not installed, hovering a facet in the searchbar makes the cog overlap the icon/text. This is due to the `o-bg-inherit` class which is set in the mail module. Therefore if discuss is not installed, the SCSS for the background doesn't exist. This commit moves the `o-bg-inherit` as a new utility class `bg-inherit`, allowing it to be used even if no apps are installed. Therefore this commit also renames the occurences of `o-bg-inherit` into `bg-inherit`. task-3575837  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A portal alert link shown when customers preview quotations or invoices now uses the proper alert styling. This keeps the link color consistent with the message and avoids a distracting purple link in the customer portal.
Original PR description
When previewing a quotation or an invoice from a customer, an alert is displayed in the portal to go back to edit mode. The color of this link was previously using primary because it was missing the `alert-link` class. The primary being purple in the base theme since the frontend redesign it became more noticeable. task-3553146 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The point of sale combo configurator now presents items in a cleaner, more consistent layout. This makes product selection during checkout easier to read and more aligned with the rest of the interface.
Original PR description
This commit reviews the UI of articles in `ComboConfiguratorPopup` to maintain consistency with the rest of the layout. task-3582072 | Before | After | |--------|--------| |  |  | --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an internal automated test issue caused by a moved event registration desk menu. It helps keep nightly checks reliable and reduces noisy test logs without changing normal user workflows.
Original PR description
In f0b7838f the event_barcode was moved from enterprise to community, so the menu for the registration desk changed. As this menu was blacklisted in the clickbot, it started to fail in the nightly tests. While at it: * remove useless and noisy log * log when a menu is skipped instead of telling that it was tested
This fix prevents errors when setting employee homeworking locations on servers using non-English language settings. The system now identifies weekdays reliably, so location updates work consistently regardless of server locale.
Original PR description
After the rework of hr_homeworking, a traceback started occurring if the odoo server was running in an environment with a different locale. Since `.strftime("%A")` is a localized method, it wouldn't return the week name in english. This would cause a traceback because we would try to access fields that don't exist (e.g. jeudi_location_id). This commit changes the approach to get the weekday number and uses an array to access the correct field name.
task-3581762
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe Settings page on small screens now shows the active tab with clearer text contrast. This makes the interface easier to read and avoids a confusing visual mismatch for mobile users.
Original PR description
This PR fixes a contrast and readability issue on the active tab within Settings on small devices. Prior to this commit, an active tab on mobile view would use a primary background, while nothing would be declared for its text color. This would cause readability issue, with a dark text on a primary background. To avoid this kind of issue, we set a `text-bg-primary` class to our button to ensure it gets readable, and also set a `shadow-none` to prevent the `tip` of the tab to appear in mobile, since it would use another color. | 17.0 | This PR | |--------|--------| |  |  | task-3580676
The web test automation component now fully stops all background monitoring, including activity inside embedded frames. This prevents automated test runs from ending too early, helping ensure all relevant tests are executed and results are reliable.
Original PR description
The MacroEngine has a stop function that allows to completely disable it. Before this commit, it correctly disconnected the "main" mutation observer, but it didn't disconnect the mutation observer for iframes. In web_tour tests, we mock the MacroEngine to stop it at the end of tests, but this didn't stop the iframe mutation observer. This had an highly undesirable side-effect in tests: the qunit suite stopped during mass_mailing tests, because the iframe mutation observer detected a change which produced the log of "test successful", which ended the whole suite. Some tests were thus never run anymore (fortunately, we're only talking about a few qunit modules).
The Stock app now shows the parent location dropdown at the normal field text size instead of inheriting the oversized heading style. This makes the location form easier to read and keeps the interface visually consistent.
Original PR description
As the parent location in the location form is in an h2 tag, the dropdown was also using the h2 font size. It should not Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update simplifies the accounting dashboard by removing unnecessary menu options and making certain actions appear only when relevant to your bank feed type. This makes the dashboard cleaner and easier to navigate by showing only the options you actually need.
Original PR description
…ounting dashboard - burger menu cleanup 1. Remove some options from the burger menu to make it more clear. 2. Make some actions on the journal's dashboard card conditional on the Bank Feed type. task-id: 3573286
This update fixes a bug where automated tests were failing when run in months other than October due to hardcoded dates. The fix ensures tests work reliably regardless of the current month. Additionally, unnecessary logging has been removed to reduce log file sizes and improve performance.
Original PR description
This commit, fix the issue that some tests fails on other month than October, this occurs because the current date wasn't patched on the tests. Moreover, this commit removes the log "Clicking on: Control Panel menu", this log is not very important, and can increase significantly the size of the log.# with '#' will be ignored, and an empty message aborts the commit. Forward-Port-Of: odoo/enterprise#49988
This update fixes a visual spacing issue in the Frontdesk module where drink titles were appearing too close to their images in the kanban view. While not noticeable with the current white background images, this fix ensures proper spacing will display correctly if image backgrounds change in the future.
Original PR description
This PR adds a missing space between the image and its title in the kanban view of Frontdesk. Prior to this commit, the title of a drink within the kanban view of frontdesk had no spacing. This was not especially visible since the default images are using a white background, but this would become an issue as soon as the image stop having a white or transparent background. To prevent this unexpected renderer, we simply add a `ms-2` class to our title, ensuring it will always be spaced correctly. task-3580511 | 17.0 | 17.0-frontdesk-add-missing-spacing-chgo | | ------------- | ------------- | | <img alt="image" src="https://github.com/odoo/enterprise/assets/128030743/df215d03-0ddd-4a07-ab3d-84dc01b47093"> | <img alt="image" src="https://github.com/odoo/enterprise/assets/128030743/6ef253b6-af05-4319-8ba2-8659a4dbf4d8"> |
This fix restores the correct height of grouped total rows in the Gantt chart view, which had been inadvertently changed by a previous update. The adjustment ensures that grouped totals display properly and maintain their intended appearance in the scheduling interface.
Original PR description
This commit brings the height of grouped totals rows back to their original value before it was wrongly modified by https://github.com/odoo/enterprise/pull/47981 task-3558040
A configuration button next to report filters was not fully clickable - only the icon was responsive while the surrounding background was not. This fix makes the entire button area clickable, improving usability when accessing report configuration settings.
Original PR description
In this commit: https://github.com/odoo/enterprise/pull/50142/commits/1df7c45a2f56a70ae7d1d4aa90f9d0aa1a34cd36 We added a button next to the filters that will redirect to the configuration page of the report. The problem was that only the cogs was clickable and not the surrounding background.
This fix resolves an issue where LinkedIn demo posts were being logged twice in the activity feed. The problem was caused by the post status being updated in two different places, triggering duplicate logging. By removing the redundant status update, posts now log correctly only once.
Original PR description
**Before this PR:** When a user tries to post a new post with demo data of LinkedIn, the chatter is also logged twice. **Reason:** The state is updated twice (in the _post_linkedin and _post_demo methods) and due to that, the _check_post_completion method is called twice. We have solved this issue by removing the state update in the _post_linkedin method. **After this PR:** The Chatter will be only logged once. **Task**-3459739 Forward-Port-Of: odoo/enterprise#49047
This update fixes visual alignment issues in the Knowledge sidebar where buttons had inconsistent spacing and weren't properly aligned with other sidebar elements. The fix ensures all buttons use consistent styling and are properly aligned to the left, improving the overall appearance and usability of the Knowledge interface.
Original PR description
This commit fixes two alignment issues in the Knowledge sidebar. > Buttons with the same design having different styling to space the icon from the text ; > Buttons not being aligned with the rest of the sidebar element to the left. To fix these issues, we adapt our two buttons to make them use the same styling. We also have to adapt a bit the overall styling of the sidebar to allow our buttons to be correctly aligned to the left. task-3582600
This update fixes a technical issue in the Google Calendar integration where user names were losing their formatting when being processed. The system was converting formatted text to plain text, which could affect how user information displays in calendar appointments. This fix ensures the formatting is properly maintained throughout the process.
Original PR description
Doing `''.join(Markup)` converts to string
This update corrects the server address URL used by the Belgian CodaBox integration to follow proper URL formatting standards by removing underscores. This ensures the integration works correctly with the IAP (In-App Purchase) service and maintains compatibility with web standards.
Original PR description
URL should avoid _ in them, so the url was changed
Currently for the "Total" measure on the invoice analysis report the values in the currency of the invoice are used. This is a problem in multi-currency environments: Different currencies are added together leading to nonsensical sums. This commit converts the "Total" measure to company currency (at the time of the invoice). In multi-company case the "Total" measure is further converted to the currency of the active company (using the day of the report creation for the conversion rate). T
Original PR description
Currently for the "Total" measure on the invoice analysis report the values in the currency of the invoice are used. This is a problem in multi-currency environments: Different currencies are added together leading to nonsensical sums. This commit converts the "Total" measure to company currency (at the time of the invoice). In multi-company case the "Total" measure is further converted to the currency of the active company (using the day of the report creation for the conversion rate). The "Total" will also be displayed in company currency when viewing the invoices in the list view of an entry in the table (by clicking on the entry). task-3537868 Forward-Port-Of: odoo/odoo#139146
To reproduce the issue: 1. In Settings, enable: - Storage Locations - Storage Categories 2. Create and confirm a receipt with one product 3. Open the detailed operation 4. Add a line - To: WH/Stock/Shelf 1 - Done: 1 Error: Once the user sets the done quantity to 1, the destination location will be automatically set to WH/Stock Since the Storage Locations option is enabled, when updating the done quantity of the SML, it triggers an onchange in charge of applying the p
Original PR description
To reproduce the issue: 1. In Settings, enable: - Storage Locations - Storage Categories 2. Create and confirm a receipt with one product 3. Open the detailed operation 4. Add a line - To:…
To reproduce the issue: 1. In Settings, enable: - Storage Locations - Storage Categories 2. Create and confirm a receipt with one product 3. Open the detailed operation 4. Add a line - To: WH/Stock/Shelf 1 - Done: 1 Error: Once the user sets the done quantity to 1, the destination location will be automatically set to WH/Stock Since the Storage Locations option is enabled, when updating the done quantity of the SML, it triggers an onchange in charge of applying the putaway rules. Since the Storage Categories option is enabled, the putaway process starts from the SM's location (i.e. WH/Stock). Then, since there isn't any putaway rule, the process will simply return the initial location (WH/Stock) and we will use it as new destination location of the SML. Since the destination location has already been set by the user, we should avoid overriding it, otherwise he will have to set the location again. OPW-3511560 OPW-3549579 Forward-Port-Of: odoo/odoo#139843 Forward-Port-Of: odoo/odoo#139690
`purchase_tax_exp_0` tax is supposed to have 0 amount, which was changed in saas-16.2 to 18.0. This commit fixes the amount, changing it back to 0.0. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140709
Original PR description
`purchase_tax_exp_0` tax is supposed to have 0 amount, which was changed in saas-16.2 to 18.0. This commit fixes the amount, changing it back to 0.0. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140709
Enterprise: https://github.com/odoo/enterprise/pull/50247
Original PR description
Enterprise: https://github.com/odoo/enterprise/pull/50247
Current behavior: The PoS receipt was always showing SN on receipt even when the tracking method was set to Lot. Steps to reproduce: - Create a product with tracking method set to Lot - Create a PoS order with that product - Validate the order - The receipt is going to show SN XXXX instead of Lot Number XXXXX opw-3517788 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140822 Forward-Port-Of: odoo/odoo#139508
Original PR description
Current behavior: The PoS receipt was always showing SN on receipt even when the tracking method was set to Lot. Steps to reproduce: - Create a product with tracking method set to Lot - Create a PoS order with that product - Validate the order - The receipt is going to show SN XXXX instead of Lot Number XXXXX opw-3517788 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140822 Forward-Port-Of: odoo/odoo#139508
Steps to reproduce ================== - Go to invoices - Open studio > report > Invoices - Click on a field, for example "Due Date" - Click on the pencil next to "Visible if" on the sidebar - Click on "Add filter" - Click on the cross to remove the filter -> `RangeError: invalid array length` Cause of the issue ================== `_.times(length)` has been replaced by `new Array(length)`. In this case, the length is -1 opw-3560346 Forward-Port-Of: odoo/odoo#140755
Original PR description
Steps to reproduce ================== - Go to invoices - Open studio > report > Invoices - Click on a field, for example "Due Date" - Click on the pencil next to "Visible if" on the sidebar - Click on "Add filter" - Click on the cross to remove the filter -> `RangeError: invalid array length` Cause of the issue ================== `_.times(length)` has been replaced by `new Array(length)`. In this case, the length is -1 opw-3560346 Forward-Port-Of: odoo/odoo#140755
# Bug A previous commit b1ec81ed fixed an issue relating to wrong progression percentages when a survey was set as "one page per question" and "random selection". In doing so, it inadvertently added an issue in the following simplified case: 1. Create a new survey, and add 2 questions 2. Set layout (`question_layout`) to "one page per question" (`page_per_question`) 3. Set selection (`question_selection`) to "all questions" (`all`) 4. Now share the survey with a participant (send ou
Original PR description
# Bug A previous commit b1ec81ed fixed an issue relating to wrong progression percentages when a survey was set as "one page per question" and "random selection". In doing so, it inadvertently added…
# Bug A previous commit b1ec81ed fixed an issue relating to wrong progression percentages when a survey was set as "one page per question" and "random selection". In doing so, it inadvertently added an issue in the following simplified case: 1. Create a new survey, and add 2 questions 2. Set layout (`question_layout`) to "one page per question" (`page_per_question`) 3. Set selection (`question_selection`) to "all questions" (`all`) 4. Now share the survey with a participant (send out the email) 5. As the participant, start the survey and answer question one 6. In the backend, go and modify the survey template by adding a new question after question 2. Save modification. 7. Now, in the ongoing survey, answer question 2 and try to move on to the next question. This will create an error traceback. Example ''' 'page_number': page_ids.index(survey_data['question'].id) ValueError: 108 is not in list ''' The error arises because the added question will have an id that is not in the `survey.user_input.predefined_question_ids` field. This list gets initialized when the `survey.user_input` gets created and reflects all the question ids of the original survey template (or the random ids in case of a random selection). So in other terms the set of questions given to a participant, starting in `survey_survey._get_pages_or_questions` is not aligned with those used for the references in the progression template # Proposed fix: We add an extra check for `survey_sudo.questions_selection == 'random'` to decide if we use `survey.user_input.predefined_question_ids` or `survey.survey.question_ids` information to calculate the progession. opw-3516304 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#138736
Steps to reproduce ================== 1. Open course with enroll policy onInvitation or Click on three dot of any course in kanban view 2. Click on Invite > add a recipient 3. Go to mail template internal link 4. Go to setting tab 5. Disable the 'Auto delete' > save & close it 6. Click on Send 7. Go the Technical/Emails (in debug mode) 8. Send the mail by clicking 'Send now' Issue - Even if we unchecked auto delete still the mail is deleted automatically Technical ========= In the
Original PR description
Steps to reproduce ================== 1. Open course with enroll policy onInvitation or Click on three dot of any course in kanban view 2. Click on Invite > add a recipient 3. Go to mail template internal link 4. Go to setting tab 5. Disable the 'Auto delete' > save & close it 6. Click on Send 7. Go the Technical/Emails (in debug mode) 8. Send the mail by clicking 'Send now' Issue - Even if we unchecked auto delete still the mail is deleted automatically Technical ========= In the '_prepare_mail_values' method of the 'slide.channel.invite' model, the mail values for 'mail.mail' are prepared and the auto delete is set to True. After this commit ================= You can view the sent mails since the auto_delete is configured based on the template value for invitation. Task-3546212 Forward-Port-Of: odoo/odoo#140987 Forward-Port-Of: odoo/odoo#139693
Steps to reproduce the bug: - In website edit mode, drag and drop an 'Image-Text' snippet onto the page. - Click on the button in the second column of the snippet. - Type "/" in the URL input of the link options in the customize panel. - Open the 'Page Anchor' selector and select the '#top' anchor. - Bug: The anchor is not added to the link in the URL input. The bug was introduced by this commit [1]. Indeed, the events in the 'Start' of LinkTools were no longer attached to the main e
Original PR description
Steps to reproduce the bug: - In website edit mode, drag and drop an 'Image-Text' snippet onto the page. - Click on the button in the second column of the snippet. - Type "/" in the URL input of the link options in the customize panel. - Open the 'Page Anchor' selector and select the '#top' anchor. - Bug: The anchor is not added to the link in the URL input. The bug was introduced by this commit [1]. Indeed, the events in the 'Start' of LinkTools were no longer attached to the main element but directly to the event target. This means that in this particular case where the 'we-button' elements are created after the 'Start', the click event had no effect because no event was properly attached to it. This commit also includes test steps to prevent this bug from reoccurring in the future. [1]: https://github.com/odoo/odoo/commit/d7245d2abf528d093226c80e40975e63d61e8997 task-3580414 Forward-Port-Of: odoo/odoo#140772
No description available.
**[FIX] web_editor: fix custom snippets thumbnail** This commit fixes 3 issues with the custom snippets thumbnail: - The tooltip ("Drag and drop the building block") appears during edition of the name of the custom snippet, it should not. - There was no space between the "Confirm" and "Cancel" buttons when editing the name of the custom snippet. - Starting from version 16.2 (although already fixed in the 16.0 commit), the "Cancel" button was positioned below the "Confirm" button
Original PR description
**[FIX] web_editor: fix custom snippets thumbnail**
This commit fixes 3 issues with the custom snippets thumbnail:
- The tooltip ("Drag and drop the building block") appears during
edition of the name of the custom snippet, it should not.
- There was no space between the "Confirm" and "Cancel" buttons when
editing the name of the custom snippet.
- Starting from version 16.2 (although already fixed in the 16.0
commit), the "Cancel" button was positioned below the "Confirm" button
instead of being on the same line. This was due to JQuery 3.6.3, which
no longer correctly supported self-closing elements like `<we-button>`
for this particular issue.
task-3572270
Forward-Port-Of: odoo/odoo#140079Description of the issue/feature this PR addresses: - in project task form, allocated time of parent task. The 'incl. x on sub-tasks' field is taking allocated time of all the child task as well as sub-tasks of its child task. Field should only take into account time allocated to the first level of sub-tasks. Current behavior before PR: - field shows allocated hours of child task as well as sub-task of child-tasks. Desired behavior after PR is merged: - field shows allocated ho
Original PR description
Description of the issue/feature this PR addresses: - in project task form, allocated time of parent task. The 'incl. x on sub-tasks' field is taking allocated time of all the child task as well as sub-tasks of its child task. Field should only take into account time allocated to the first level of sub-tasks. Current behavior before PR: - field shows allocated hours of child task as well as sub-task of child-tasks. Desired behavior after PR is merged: - field shows allocated hours of only child-tasks. Fix: - removed child_task.subtask_planned_hour from the compute method of subtask_planned_hour fields so that its only add the hours of its child-tasks and not its sub-task of child-tasks. task-3277977 Forward-Port-Of: odoo/odoo#140834 Forward-Port-Of: odoo/odoo#120870
[FIX] website: prevent circular dependency of duplicated fields Steps to reproduce the bug: - Drop a "Form" snippet on the website. - Add three fields and rename them by "a", "b" and "b". - Change the conditional visibility of the first "b" and make it depend on "a". - Change the conditional visibility of "a" and make it depend on "b". - Save. -> Traceback "Maximum call stack exceeded" appears. A field with a conditional visibility is visible if at at least one field with the dep
Original PR description
[FIX] website: prevent circular dependency of duplicated fields Steps to reproduce the bug: - Drop a "Form" snippet on the website. - Add three fields and rename them by "a", "b" and "b". - Change…
[FIX] website: prevent circular dependency of duplicated fields
Steps to reproduce the bug:
- Drop a "Form" snippet on the website.
- Add three fields and rename them by "a", "b" and "b".
- Change the conditional visibility of the first "b" and make it depend
on "a".
- Change the conditional visibility of "a" and make it depend on "b".
- Save.
-> Traceback "Maximum call stack exceeded" appears.
A field with a conditional visibility is visible if at at least one
field with the dependency name is visible. The problem is that in our
case, it exists a circular dependency between "a" and one of the "b"
leading to an infinite loop during this check. Before this commit all
the fields of the form were checked and all the labels of the fields
that do not create a circular dependency were proposed in the file
visibility selector. The problem is that in our case, one of the "b"
field does not create a circular dependency while the other does. To
solve the problem, the `_recursiveFindCircular()` function has been
adapted in order to not propose a label that would create a circular
dependency in the file visibility selector.
task-3291044
-----------------------------------------------------------------------------------------------------------------------------------------------------------
[FIX] website: prevent circular dependency of renamed fields
Steps to reproduce the bug:
- Drop a "Form" snippet on the website.
- Change the "Label" of the first field (and put it to "test" for
example).
- Select the last field and change its visibility so that it depends on
the first field.
- Change the "Label" of the selected field and put it to the same than
the first one ("test").
- Save.
-> Traceback "Maximum call stack exceeded" appears.
At the end of the procedure, the last field visibility depends on itself
and a circular visibility dependency is created. To solve the problem,
this commit checks that the renamed field does not bring a circular
dependency while updating the dependencies. If it is the case, the
problematic dependency is deleted.
To resolve this bug, the `visitedFields` set has been introduced. Its
goal is to register the already visited fields to not enter an infinite
check loop. Let's take an example to illustrate this: Imagine there is a
form of type A->B->C->D. In this form, the field "A" depends on "B" that
depends on "C" that depends on "D". Imagine you rename "D" by "B". You
now have A->B->C->B. The system will check that the renamed field does
not create a circular dependency. To do so, it will apply
`_recursiveFindCircular` with "A" as the `targetFieldEl` and "B" as the
`dependentFieldEl`. Because there is a circular dependency between "C"
and "B", the system would enter in an infinite loop. Note that we do not
notify the system if such indirect circular dependency has been found as
it will be detected as a direct circular dependency while the system
will apply `_recursiveFindCircular` with `C` as the `targetFieldEl`.
task-3291044
-----------------------------------------------------------------------------------------------------------------------------------------------------------
[FIX] website: re-render the visibility selector on field label change
Steps to reproduce the bug:
- Add a form on the website.
- Add two fields on the form ("A" and "B").
- Change the conditional visibility of "B" and put it to "Visible only
if".
- Change the label of "B" and set it to "A".
- Try to change the dependent field.
-> "A" is still on the list of the eligible dependent fields. It should
not be the case as setting this field as a dependent field would create
a circular dependency.
To solve the problem, the file visibility selector is rerendered after
modifying a field label. Because of the `_findCircular()` check at the
rerendering, the problematic field will not be displayed in the list of
of the eligible dependent fields.
task-3291044
Forward-Port-Of: odoo/odoo#140635
Forward-Port-Of: odoo/odoo#133585Steps: - Install Project - Open project module - Active Task Dependencies - Select any project - Now select any task - Go to Sub-Task notebook - Add sub task - Select any other project in the sub task Issue: - Currently, we cannot create sub task of another project in the form view. Fix: - we can create sub task of any project. Task-3508241 Forward-Port-Of: odoo/odoo#136306
Original PR description
Steps: - Install Project - Open project module - Active Task Dependencies - Select any project - Now select any task - Go to Sub-Task notebook - Add sub task - Select any other project in the sub task Issue: - Currently, we cannot create sub task of another project in the form view. Fix: - we can create sub task of any project. Task-3508241 Forward-Port-Of: odoo/odoo#136306
This commit, fix the issue that some tests fails on other month than October, this occurs because the current date wasn't patched on the tests. Moreover, this commit removes the log "Clicking on: Control Panel menu", this log is not very important, and can increase significantly the size of the log.# with '#' will be ignored, and an empty message aborts the commit. Forward-Port-Of: odoo/odoo#140638
Original PR description
This commit, fix the issue that some tests fails on other month than October, this occurs because the current date wasn't patched on the tests. Moreover, this commit removes the log "Clicking on: Control Panel menu", this log is not very important, and can increase significantly the size of the log.# with '#' will be ignored, and an empty message aborts the commit. Forward-Port-Of: odoo/odoo#140638
Forward-Port-Of: odoo/odoo#140520 Forward-Port-Of: odoo/odoo#140440
Original PR description
Forward-Port-Of: odoo/odoo#140520 Forward-Port-Of: odoo/odoo#140440
If mrp_workorder_expiry module is installed a skip_expired context key is defined on the two buttons "Mark as Done" and "Mark as Done and Close MO". However, the context key was not transmitted properly to the backend because params.context is a string, whereas this.props.context is an Object, resulting in a new context were only the key/values from this.props.context were consistent, while the string in params.context was exploded in multiple characters. Forward-Port-Of: odoo/enterprise#48988
Original PR description
If mrp_workorder_expiry module is installed a skip_expired context key is defined on the two buttons "Mark as Done" and "Mark as Done and Close MO". However, the context key was not transmitted properly to the backend because params.context is a string, whereas this.props.context is an Object, resulting in a new context were only the key/values from this.props.context were consistent, while the string in params.context was exploded in multiple characters. Forward-Port-Of: odoo/enterprise#48988