Wednesday, November 8, 2023
44 changes · 17.0
Enhancements to existing features
Links across several Odoo screens and localization modules were updated to point to the correct 17.0 documentation or resources. This helps users access relevant guidance for their current version and reduces confusion from outdated references.
The new refactorings of the Italian EdI require updated translations. Task link: https://www.odoo.com/web#model=project.task&id=3263708 task-3263708
Original PR description
The new refactorings of the Italian EdI require updated translations. Task link: https://www.odoo.com/web#model=project.task&id=3263708 task-3263708
The website editor now lets add-ons mark specific page elements as movable. This gives third-party customizations more flexibility when arranging content in the editor, without changing standard editor behavior for most users.
Original PR description
In order to let third party code set a node to be movable, this commit adds a class to set a node to be movable in the OdooEditor. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update refreshes all documentation and reference links throughout the Odoo Enterprise system to point to version 17.0 resources. The changes ensure users and administrators access the correct, up-to-date documentation for their current software version, improving support and user experience.
Resolved issues and error corrections
The website editor iframe now loads only the assets it needs, avoiding hidden dependency failures. This helps prevent editing features from silently breaking and improves reliability for users working with web content.
Original PR description
Before this commit, some assets of the "web_editor.wysiwyg_iframe_editor_assets" bundle could not be loaded because of unmet dependencies. The loading of such modules failed silently because the module loader waits for the "DOMContentLoaded" event in order to replace the DOM's content by the error report, and such event is not triggered by the wysiwyg's iframe. This commit removes unnecessary assets from the mentioned bundle and solves the dependency errors.
Code cleanup and technical improvements
This update removes an outdated template marker that is no longer needed because templates are now loaded through the newer app framework. It is an internal cleanup that reduces maintenance overhead without changing how users interact with Odoo.
Original PR description
As all the templates are now imported in the owl app, there is not need anymore to specify the owl="1" attribute in the templates. Ref-https://github.com/odoo/odoo/pull/130467 Linked PR- https://github.com/odoo/enterprise/pull/50344 task-3508331 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
This fixes an issue in the online store checkout flow where address updates could be evaluated incorrectly. It also adds automated test coverage to help prevent the same checkout address problem from returning.
Original PR description
Added test for recent fix 495a5090a5bb96d4114690c61c5398282ec263c3 Also fixes a wrong recordset vs id comparison --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The reset button in the domain selector now displays with its intended styling again. This fixes a visual regression so users can more easily recognize and use the control when editing filters or conditions.
Original PR description
Styling for domain selector's reset domain button was lost in https://github.com/odoo/odoo/pull/128680. This commit simply brings it back.
The project list view now fully hides an internal name field that was only needed for sorting. This removes an unnecessary visible column area and makes the project list cleaner for users.
Original PR description
The name field has been to be able to order on it but it is added and just invisible instead of completely hide the column. This commit changes `invisible` attribute to `column_invisible` to completely hide that field in the project list view. X-original-commit: 62f49331ba4dc923031603c86931fa4c8b028f32
This update removes a recent website autocomplete adjustment because the related underlying change is also being rolled back. It avoids keeping a temporary workaround in place and leaves room for a more complete fix after the event period.
Original PR description
This reverts commit 6c749a4b0d460defd068774e51d007739861980e. This commit was fixing an issue raised after a fix [1] that is about to get reverted [2]. We will make a proper fix after the OXP2023 event. [1]: https://github.com/odoo/odoo/commit/9682cfa174fb39ec9d9874951ea9ee2884058d96 [2]: https://github.com/odoo/odoo/pull/141401
The Website editor toolbar now displays the AI, Animate, and Highlight buttons with more consistent spacing between icons and labels. This makes the editing interface look cleaner and easier to scan for users creating or updating website content.
Original PR description
This commit fixes the layout of icons and labels in the "AI", "Animate", "Highlight" buttons of the text toolbar in Website edit mode. Before this commit, there was too much space between the icon and the label of the "AI" button and not enough space between the icon and the label of the "Animate" and "Highlight" buttons. task-3586280
The web editor now handles empty history changes without crashing. This improves reliability when reviewing or processing editor history, with tests added to help prevent the issue from returning.
Original PR description
Change the history diff_util to be able to handle empty patch without crashing. Add unit tests accordingly. task-3583986 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The stock transfer type settings no longer show a field that is automatically calculated and cannot be edited. This reduces confusion for users by removing an unnecessary option from the configuration screen.
Original PR description
The field is now readonly and computed, so there's no reason keeping it. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an internal test setup issue in the mail module by clearing prior notification data before checking link preview notifications. It helps keep automated test results reliable and reduces false failures during development and release validation.
Original PR description
Before this PR, bus notification was not reset before testing the bus notification of link previews. https://runbot.odoo.com/web/#id=28333&view_type=form&model=runbot.build.error&menu_id=405&cids=1
The editor now hides website-specific text styling choices when used in other Odoo apps. This keeps backend editing menus cleaner and more relevant while preserving the full set of design options for Website pages.
Original PR description
This commit removes some text style options when the editor is used in the backend. In the website it makes sense to have all the options but in the other apps, it is not necessary to have all the options. task-1958098
Fixes an issue where changing a sub-plan into a main analytic plan could leave a required plan column missing. This prevents errors when opening analytic line views, helping users access reporting data reliably after reorganizing plans.
Original PR description
Reproduce: * create a sub-plan (with parent_id) * make that plan a main plan (void parent_id) * open the analytic line view Result: Traceback because the dynamic field was not created
This fix restores a missing text effects icon in the web interface that was accidentally removed during a previous icon update. It helps keep the user interface complete and prevents broken or missing icon displays where this option is used.
Original PR description
Commit 70f853aab9a7 introduces `oi-smile-add` UI icon but it also removes by mistake `oi-text-effect` icon. This commit reintroduces `oi-text-effect` icon. task-3586386 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes documentation links across multiple Odoo areas so they direct users to the correct Odoo 17.0 documentation. It helps customers and staff find version-appropriate guidance and avoids confusion caused by links to other versions.
Original PR description
See also: - https://github.com/odoo/enterprise/pull/50357
This update adds proper property definitions to the AccountReportButtonsBar component to eliminate system warnings. The change improves the stability and reliability of the accounting reports interface by ensuring all component properties are properly documented.
Original PR description
Add the `static props` variable on AccountReportButtonsBar (to remove owl warning).
This update corrects all documentation links throughout the system to point to version 17.0 instead of older versions. This ensures that users and administrators accessing help documentation from within the application are directed to the correct, current version of the documentation that matches their software version.
Original PR description
See also: - https://github.com/odoo/odoo/pull/141406
This update fixes a compatibility issue in the Manufacturing Workorder module where a field reference needed to be updated due to changes in the parent system view. The change ensures the workorder picking type interface continues to function correctly with the latest system updates.
Original PR description
Since the field is removed in the parent view, the xpath has to be adapted. see https://github.com/odoo/odoo/pull/141390
This update removes a call to a method that no longer exists in the Sendcloud delivery module. The functionality is now handled automatically by the existing action_assign method, so the redundant code has been cleaned up to prevent errors.
Original PR description
Since commit https://github.com/odoo/odoo/commit/7dda6bb92715ea25b2818a62fec5e646f3678b81, The method action_set_quantities_to_reservation doesn't exist anymore. `action_assign` will do quantity setting anyway
The demo data for Polish payroll was using Vilnius, a Lithuanian city, which was inconsistent with the Polish localization module. This fix updates the demo city to Krakow, a major Polish city, to provide more appropriate and relevant example data for users testing the Polish payroll features.
Original PR description
The current demo city in PL payroll demo data is Vilnius. It would be nicer to change it to a Polish city., so this commit changes it to Krakow. Forward-Port-Of: odoo/enterprise#50323 Forward-Port-Of: odoo/enterprise#50285
This update removes unnecessary technical attributes from template files across multiple Odoo modules. Since all templates are now automatically processed by the application framework, the redundant configuration markers are no longer needed, resulting in cleaner and simpler template files.
Original PR description
As all the templates are now imported in the owl app, there is not need anymore to specify the owl="1" attribute in the templates. Ref-https://github.com/odoo/odoo/pull/130467 task-3508331
Enterprise: https://github.com/odoo/enterprise/pull/50484
Original PR description
Enterprise: https://github.com/odoo/enterprise/pull/50484
Before this commit, a grouped kanban view with create="0" on the root node would still allow to quick create record in columns (i.e. the "+" icon would still be displayed). However, clicking on it would most likely raise an AccessError as the user isn't allowed to create records. This commit restores the pre 16.0 behavior, which is to disallow quick creation if the user can't create. Task 3559638 Description of the issue/feature this PR addresses: Current behavior before PR: Desir
Original PR description
Before this commit, a grouped kanban view with create="0" on the root node would still allow to quick create record in columns (i.e. the "+" icon would still be displayed). However, clicking on it would most likely raise an AccessError as the user isn't allowed to create records. This commit restores the pre 16.0 behavior, which is to disallow quick creation if the user can't create. Task 3559638 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#141538 Forward-Port-Of: odoo/odoo#141418
Impacted versions: 16.0+ How to reproduce: - create a lot of articles in Knowledge (i.e. 3000+) - click twice on the `Search Articles` fake search bar in the Knowledge Form view Current behavior: - the command palette does not open - the command palette is broken and won't open again (even with the `CTRL+K` shortcut) Expected behavior: - the command palette open once and should not break even if the user clicks multiple times. Technical explanation: - The promise given to the
Original PR description
Impacted versions: 16.0+ How to reproduce: - create a lot of articles in Knowledge (i.e. 3000+) - click twice on the `Search Articles` fake search bar in the Knowledge Form view Current behavior: -…
Impacted versions: 16.0+ How to reproduce: - create a lot of articles in Knowledge (i.e. 3000+) - click twice on the `Search Articles` fake search bar in the Knowledge Form view Current behavior: - the command palette does not open - the command palette is broken and won't open again (even with the `CTRL+K` shortcut) Expected behavior: - the command palette open once and should not break even if the user clicks multiple times. Technical explanation: - The promise given to the `onWillStart` hook of the `command_palette` can sometimes never be resolved by design (see `KeepLast`). i.e.: - `setCommandPaletteConfig` is called `onWillStart` - `setCommandPaletteConfig` is then called as a result of the `SET-CONFIG` bus event - the first promise will never be resolved since it uses a `KeepLast`, therefore `onWillStart` will never be resolved either. - In `command_service`, the variable `isPaletteOpened` is set to `true` before the command palette dialog is actually mounted. - If `onWillStart` is never resolved, the component will never be mounted, and as such the dialog can never be closed, therefore `isPaletteOpened` stays `true` forever resulting in a deadlock preventing any further opening of the command palette. The issue can be resolved by adding all `KeepLast` promises in a race, which is what `onWillStart` should actually be waiting for, since it will be resolved as soon as any `KeepLast` promise is resolved. task-3554068 Forward-Port-Of: odoo/odoo#141446 Forward-Port-Of: odoo/odoo#140545
Description of the issue/feature this PR addresses: Current behavior before PR: - When create a free product reward, reward and sale order line description use product's name so if many reward are variants of others, the description will be the same. It make portal user confusing when they chose reward in portal Image before commit:    Desired behavior after PR is merged: - the description will include display of product so that will contain name of variants's attributes Image after commit:   --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#138884
When the user tries to add properties field in domain of a model without property name the error occurs. To reproduce the issue: - Install knowledge module. - Go to Settings > Technical > User Defined Filters. - Enter a name, add 'Knowledge Article' as model and then add domain [('article_properties', '!=', False)]. - Click on save button and then on refresh button below code editor of domain. - The traceback will be generated Error: ``` File "odoo/http.py", line 2134, in __call_
Original PR description
When the user tries to add properties field in domain of a model without property name the error occurs. To reproduce the issue: - Install knowledge module. - Go to Settings > Technical > User…
When the user tries to add properties field in domain of a model without property name the error occurs.
To reproduce the issue:
- Install knowledge module.
- Go to Settings > Technical > User Defined Filters.
- Enter a name, add 'Knowledge Article' as model and then add domain [('article_properties', '!=', False)].
- Click on save button and then on refresh button below code editor of domain.
- The traceback will be generated
Error:
```
File "odoo/http.py", line 2134, in __call__
response = request._serve_db()
File "odoo/http.py", line 1710, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "odoo/service/model.py", line 133, in retrying
result = func()
File "odoo/http.py", line 1737, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 1938, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 191, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 717, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "addons/web/controllers/dataset.py", line 30, in call_kw
return self._call_kw(model, method, args, kwargs)
File "addons/web/controllers/dataset.py", line 26, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "odoo/api.py", line 457, in call_kw
result = _call_kw_model(method, model, args, kwargs)
File "odoo/api.py", line 430, in _call_kw_model
result = method(recs, *args, **kwargs)
File "odoo/models.py", line 1587, in search_count
query = self._search(domain, limit=limit)
File "odoo/models.py", line 5027, in _search
query = self._where_calc(domain)
File "odoo/models.py", line 4768, in _where_calc
return expression.expression(domain, self).query
File "odoo/osv/expression.py", line 777, in __init__
self.parse()
File "odoo/osv/expression.py", line 1012, in parse
if len(path) != 2 and "." in path[1]:
IndexError: list index out of range
```
The issue is occurring because we are getting single element in path over here -
https://github.com/odoo/odoo/blob/f4e60765db57fe3612f267e8fa44d10ccf5ff107/odoo/osv/expression.py#L649 but we are trying to access path[1] due to which IndexError is occurring over here -
https://github.com/odoo/odoo/blob/f4e60765db57fe3612f267e8fa44d10ccf5ff107/odoo/osv/expression.py#L683 and here -
https://github.com/odoo/odoo/blob/f4e60765db57fe3612f267e8fa44d10ccf5ff107/odoo/osv/expression.py#L687
The condition is also wrong over here -
https://github.com/odoo/odoo/blob/f4e60765db57fe3612f267e8fa44d10ccf5ff107/odoo/osv/expression.py#L683-L684 in which we are checking length of path is not equals to 2 and then also we are trying to access path[1], due to which ValueError becomes a dead code.
To fix this issue length of path has been checked and when it will be 2 then only path[1] will be accessed.
sentry-4499339271
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#138370When user removes the quantity of product and tries to confirm the product in configure wizard, a traceback will appear. Steps to reproduce the error: - Go to Sales > Configuration > Settings - Product Catalog > enable Variant Grid Entry - Pricing > enable Pricelists (Advanced price rules) - Go to products > pricelist > open any pricelist > Add a line > set value of Min. Quantity - Create new Quotation > Select that pricelist > Add a product > Select a product that has variants
Original PR description
When user removes the quantity of product and tries to confirm the product in configure wizard, a traceback will appear. Steps to reproduce the error: - Go to Sales > Configuration > Settings -…
When user removes the quantity of product and tries to confirm the product in configure wizard,
a traceback will appear.
Steps to reproduce the error:
- Go to Sales > Configuration > Settings
- Product Catalog > enable Variant Grid Entry
- Pricing > enable Pricelists (Advanced price rules)
- Go to products > pricelist > open any pricelist > Add a line > set value of Min. Quantity
- Create new Quotation > Select that pricelist > Add a product >
Select a product that has variants (ex. Conference Chair) >
In configure wizard, remove quantity > Confirm
Traceback:
```
TypeError: '<' not supported between instances of 'NoneType' and 'float'
File "odoo/http.py", line 2138, in __call__
response = request._serve_db()
File "odoo/http.py", line 1714, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "odoo/service/model.py", line 133, in retrying
result = func()
File "odoo/http.py", line 1741, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 1942, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "addons/website/models/ir_http.py", line 235, in _dispatch
response = super()._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 191, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 717, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "addons/sale_product_configurator/controllers/main.py", line 135, in sale_product_configurator_update_combination
return self._get_basic_product_information(
File "addons/sale_product_configurator/controllers/main.py", line 327, in _get_basic_product_information
price=pricelist._get_product_price(
File "addons/product/models/product_pricelist.py", line 111, in _get_product_price
return self._compute_price_rule(product, *args, **kwargs)[product.id][0]
File "addons/product/models/product_pricelist.py", line 205, in _compute_price_rule
if rule._is_applicable_for(product, qty_in_product_uom):
File "addons/product/models/product_pricelist_item.py", line 319, in _is_applicable_for
if self.min_quantity and qty_in_product_uom < self.min_quantity:
```
https://github.com/odoo/odoo/blob/fe79e1b5fdc408d55bbb3ac11209163436c1fa2c/addons/product/models/product_pricelist_item.py#L319 Here, when user removes quantity of product,
qty_in_product_uom will be None.
So it will lead to above traceback.
sentry-4547178082
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#139166Before this commit, in the settings page on mobile mode, when swiping between the different apps, on the app selector the current app stay selected on the right corner. The selected app will stay on top of the other apps, and the app selector itself didn't move. Now, when swiping between the different apps, the app selector moves to force the current app to be in the center of the selector. task-id: 3489756 Forward-Port-Of: odoo/odoo#141140
Original PR description
Before this commit, in the settings page on mobile mode, when swiping between the different apps, on the app selector the current app stay selected on the right corner. The selected app will stay on top of the other apps, and the app selector itself didn't move. Now, when swiping between the different apps, the app selector moves to force the current app to be in the center of the selector. task-id: 3489756 Forward-Port-Of: odoo/odoo#141140
This commit avoids a traceback when trying to install hr_timesheet post to "hours" uom deletion. Steps ===== - Install module sale_management - In Settings > Sales > Product Catalog section, activate the option Units of Measure - Go to Units of Measure configuration menu - Remove the unit of measure "Hours" - Install hr_timesheet Issue ===== A traceback appears indicating: "Cannot update missing record 'uom.product_uom_hour'" Cause ===== Since https://github.com/odoo/odoo/comm
Original PR description
This commit avoids a traceback when trying to install hr_timesheet post to "hours" uom deletion. Steps ===== - Install module sale_management - In Settings > Sales > Product Catalog section, activate…
This commit avoids a traceback when trying to install hr_timesheet post to "hours" uom deletion. Steps ===== - Install module sale_management - In Settings > Sales > Product Catalog section, activate the option Units of Measure - Go to Units of Measure configuration menu - Remove the unit of measure "Hours" - Install hr_timesheet Issue ===== A traceback appears indicating: "Cannot update missing record 'uom.product_uom_hour'" Cause ===== Since https://github.com/odoo/odoo/commit/ab76c421c279b26195396b61e66b3e8853785226, deletion of system uom is prohibited. An exception exists for uom "Hours" that can be deleted without warning. This exception is removed inside hr_timesheet as this uom is needed in this module. However, it can still be deleted prior to hr_timesheet installation. When it is deleted, the installation of hr_timesheet raises a traceback as the data file hr_timesheet_data tries to access and update this record. Fix === Before updating the record uom "hours" in the data file, a call to a method ensure_iom_hours is made. This method recreate this uom if it does not exist in the database anymore. task-3551315 Forward-Port-Of: odoo/odoo#141438 Forward-Port-Of: odoo/odoo#138541
This reverts commit 9682cfa174fb39ec9d9874951ea9ee2884058d96. The reverted commit introduced more issues than it resolved. The original issue [1] will still be present but we will take time to fix it properly after the OXP2023 event. Original issue:  [1]: https://github.com/odoo/odoo/assets/1159815/8d4c75c7-cb5f-4a84-8333-389971ab436d Forward-Port-Of: odoo/odoo#141401
Original PR description
This reverts commit 9682cfa174fb39ec9d9874951ea9ee2884058d96. The reverted commit introduced more issues than it resolved. The original issue [1] will still be present but we will take time to fix it properly after the OXP2023 event. Original issue:  [1]: https://github.com/odoo/odoo/assets/1159815/8d4c75c7-cb5f-4a84-8333-389971ab436d Forward-Port-Of: odoo/odoo#141401
With the mailing filter widget, a traceback was raised when unfocussing the domain editor. We now check if the format is correct and return early without raising a traceback. It is also now no longer possible to try to save the unsupported domain in the favorite. task-3569969 Forward-Port-Of: odoo/odoo#141281 Forward-Port-Of: odoo/odoo#139691
Original PR description
With the mailing filter widget, a traceback was raised when unfocussing the domain editor. We now check if the format is correct and return early without raising a traceback. It is also now no longer possible to try to save the unsupported domain in the favorite. task-3569969 Forward-Port-Of: odoo/odoo#141281 Forward-Port-Of: odoo/odoo#139691
[FIX] l10n_fr: Account 607 french translation edited Current behavior before PR: In chart of accounts in french localization the accounts with 607 was named "Ventes de marchandises" where it should be named "Achats de marchandises" Desired behavior after PR is merged: The translation has been updated and now it is named correctly opw-3536801 Forward-Port-Of: odoo/odoo#141174 Forward-Port-Of: odoo/odoo#138600
Original PR description
[FIX] l10n_fr: Account 607 french translation edited Current behavior before PR: In chart of accounts in french localization the accounts with 607 was named "Ventes de marchandises" where it should be named "Achats de marchandises" Desired behavior after PR is merged: The translation has been updated and now it is named correctly opw-3536801 Forward-Port-Of: odoo/odoo#141174 Forward-Port-Of: odoo/odoo#138600
On "small screen" (especially on Mobile), all dialogs are in fullscreen, so we don't allow moving the dialog as there is no enough space available on the screen. This commit disallows the use of `useDialogDraggable` on "small screen". Steps to reproduce: * Open Odoo in "small screen" * Go to Sale App * Create a new SO * Click on the Customer field * Use the mouse to move the fullscreen dialog (modal's header) => BUG --- I confirm I have signed the CLA and read the PR guidelines at w
Original PR description
On "small screen" (especially on Mobile), all dialogs are in fullscreen, so we don't allow moving the dialog as there is no enough space available on the screen. This commit disallows the use of `useDialogDraggable` on "small screen". Steps to reproduce: * Open Odoo in "small screen" * Go to Sale App * Create a new SO * Click on the Customer field * Use the mouse to move the fullscreen dialog (modal's header) => BUG --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#141244
When onboarding was updated to override web assets in 518a4e4c4308985e6beaed22521853cce87f8850 it should also have been updated to *depend* on web. Forward-Port-Of: odoo/odoo#141391
Original PR description
When onboarding was updated to override web assets in 518a4e4c4308985e6beaed22521853cce87f8850 it should also have been updated to *depend* on web. Forward-Port-Of: odoo/odoo#141391
in #124402 `update_field_translations` will call `write` to trigger all override logics. But for ir.model.fields, write will call setup model which may remove all translations. This commit fix the issue by adding a bypass for translate_only `write`. opw-3575512 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-
Original PR description
in #124402 `update_field_translations` will call `write` to trigger all override logics. But for ir.model.fields, write will call setup model which may remove all translations. This commit fix the issue by adding a bypass for translate_only `write`. opw-3575512 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140925 Forward-Port-Of: odoo/odoo#140695
Since [1] the behavior for double-clicking an image in an html field is displaying it "full-screen", and no longer opening the Media Dialog to edit it. But, when an image is (single) clicked, a tooltip is displayed with the misleading "Double-click to edit" message. This commit makes sure the tooltip is no longer displayed in HtmlField, while keeping its original behavior for other forms of use of the Wysiwyg component, like in website. [1]: https://github.com/odoo/odoo/commit/8ca115b3b9df
Original PR description
Since [1] the behavior for double-clicking an image in an html field is displaying it "full-screen", and no longer opening the Media Dialog to edit it. But, when an image is (single) clicked, a tooltip is displayed with the misleading "Double-click to edit" message. This commit makes sure the tooltip is no longer displayed in HtmlField, while keeping its original behavior for other forms of use of the Wysiwyg component, like in website. [1]: https://github.com/odoo/odoo/commit/8ca115b3b9dfe87b59b6b064a4d85ea152d9214c task-3542766 Forward-Port-Of: odoo/odoo#137832
Steps to reproduce: - Install Accounting - Create a fiscal position for a foreign country: * Country: [Any country that has group-type taxes] (e.g. Italy) * Foreign Tax ID: [any tax ID for that country] (e.g. IT12345670017) - Click on the "here" button appearing in the banner (Click "here" to create the taxes for this country.) => A ValueError is raised. "External ID not found in the system: account.1_22vsp" Cause: During the creation of the taxes, the xml_id of each tax is pref
Original PR description
Steps to reproduce: - Install Accounting - Create a fiscal position for a foreign country: * Country: [Any country that has group-type taxes] (e.g. Italy) * Foreign Tax ID: [any tax ID for that country] (e.g. IT12345670017) - Click on the "here" button appearing in the banner (Click "here" to create the taxes for this country.) => A ValueError is raised. "External ID not found in the system: account.1_22vsp" Cause: During the creation of the taxes, the xml_id of each tax is prefixed with the chart template code to avoid collision. However, when linking a group-type tax to its children taxes, it cannot find them because they are prefixed but the group-type tax is using their unprefixed value. opw-3518213 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#141380 Forward-Port-Of: odoo/odoo#140320
On the 'resource.calendar', attendance_ids is a computed field and computation is triggered when company_id is changed. Now, if we remove company_id, attendance_ids are left empty. Instead, attendance_ids should be updated only when there is a new company set. task - 3451264 Forward-Port-Of: odoo/odoo#141287 Forward-Port-Of: odoo/odoo#131912
Original PR description
On the 'resource.calendar', attendance_ids is a computed field and computation is triggered when company_id is changed. Now, if we remove company_id, attendance_ids are left empty. Instead, attendance_ids should be updated only when there is a new company set. task - 3451264 Forward-Port-Of: odoo/odoo#141287 Forward-Port-Of: odoo/odoo#131912
404 means that the thread was deleted Task-3577083 Forward-Port-Of: odoo/odoo#141229
Original PR description
404 means that the thread was deleted Task-3577083 Forward-Port-Of: odoo/odoo#141229
Before this commit, the test was trying to send mail for a past event. It would fail with the following error: ``` FAIL: TestCalendar.test_event_creation_mail Traceback (most recent call last): File "/data/build/odoo/addons/calendar/tests/test_calendar.py", line 329, in test_event_creation_mail _test_one_mail_per_attendee(self, partners) File "/data/build/odoo/addons/calendar/tests/test_calendar.py", line 311, in _test_one_mail_per_attendee self.assertEqual(len(mail), 1) As
Original PR description
Before this commit, the test was trying to send mail for a past event. It would fail with the following error:
```
FAIL: TestCalendar.test_event_creation_mail
Traceback (most recent call last):
File "/data/build/odoo/addons/calendar/tests/test_calendar.py", line 329, in test_event_creation_mail
_test_one_mail_per_attendee(self, partners)
File "/data/build/odoo/addons/calendar/tests/test_calendar.py", line 311, in _test_one_mail_per_attendee
self.assertEqual(len(mail), 1)
AssertionError: 0 != 1
```
https://runbot.odoo.com/web/#id=29871&view_type=form&model=runbot.build.error&menu_id=405&cids=1
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#141190Community: https://github.com/odoo/odoo/pull/141655
Original PR description
Community: https://github.com/odoo/odoo/pull/141655