Wednesday, November 22, 2023
17 changes · 17.0
Resolved issues and error corrections
This fix restores safe handling of missing number values so screens that depend on number formatting no longer crash. It is especially relevant for point of sale workflows, where creating a contact could fail after a recent change.
Original PR description
This commit addresses an issue introduced by a recent refactor of the formatFloat function (see https://github.com/odoo/odoo/commit/054ca0a19aaf297f420a1b478b93ae26f1b943b8). The refactor changed '(value || 0)' to 'value', which causes issues when the value is undefined. This bug affects several places where formatFloat was assumed to handle undefined values. A notable example is within the point_of_sale module, where creating a contact now raises an error. This fix restores the previous behavior of safely handling undefined values. opw-3594167 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where removing entries from Point of Sale settings could fail to actually delete them, leaving old configuration items in place. The fix makes the behavior consistent across POS-related settings and moves the related test coverage to the core Point of Sale area where it applies more broadly.
Original PR description
When removing an item in x2many fields from the res.config.settings form, the client interprets it as a set of link commands for the remaining items, as a result, the items that should have been removed are not removed. This generalizes the fix made for the splash screen images in pos_self_order by which this issue was first observed. The test is also moved to the point_of_sale module as it is not specific to pos_self_order. Also note that the test is manually doing what is observed from the client. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Users in a single-company setup can now create quotations from project tasks without encountering a missing company error. The task quotation flow now automatically uses the current company, removing a blocker for Field Service sales follow-ups.
Original PR description
Issue: In a mono-company setup, users trying to create a quotation from a task face an error message because the mandatory 'company' field in the 'other info' tab is not visible, unlike in multi-company setups. Steps to Reproduce: 1. Install the Field Service app. 2. Activate 'Extra Quotations' in the Field Service general settings. 3. Enable 'Extra Quotation' in the settings of the relevant project. 4. Try creating a quotation from a task in a mono-company environment. 5. Encounter an error. Resolution: Modified the functionality so that the 'company_id' field defaults to the current company. opw-3596984 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change restores the previous Point of Sale discount configuration to avoid creating duplicate discount products during upgrades or when discounts are enabled. It also prevents disruption to related industry features that depend on the existing setup.
Original PR description
…discount" This reverts commit 430f4904ed47778b4c45c30befaef467cbdfce5b. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix restores correct component usage when splitting or mass-producing manufacturing orders, especially for serial-numbered finished products. It ensures components are consumed as expected, keeping inventory and production records accurate.
Original PR description
Since https://github.com/odoo/odoo/commit/7dda6bb92715ea25b2818a62fec5e646f3678b81 _split_productions do not consume quantities anymore. For example, mass producing a serial finished product built from components moves the finished products but not the components. This restores the expected behavior. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures that all available fields remain visible and draggable in the search view editor, allowing users to place them in different locations within the view. Previously, fields were being filtered out after selection, which limited the flexibility of the search view configuration. This change makes the field management more intuitive and consistent.
Original PR description
This commit fixes the filtering applied once a field was selected from the studio sidebar in the search view editor. For this view, the fields must always be draggable since they can be put in different location in the view. Some search editor tests have been modified to this change, since more fields are available to add in the view. An assertion has also been added to verify that no filtering happens when dropping a field into the view. task-3474817 Forward-Port-Of: odoo/enterprise#50894
A copy-paste error prevented the Run action from appearing when bulk editing assets. This fix restores the ability to run actions on multiple assets at once, improving workflow efficiency for users managing asset operations.
Original PR description
Bad copy-paste caused the action to be named the same, which caused the Run action to not be available anymore. Forward-Port-Of: odoo/enterprise#51023
This fix resolves an issue where custom filters created in the Shop Floor module were not being saved and reloaded when users returned to the application. Users can now create filters, save them, close the Shop Floor, and have their saved filters available when they reopen it.
Original PR description
To reproduce ============ - Open Shop Floor - Create Filter + Save it (settings doesn't really seem to matter) - Close Shop Floor - Open Shop Floor - Check Saved Filters - --> Issue: Saved Filters are gone Problem ======= filters are not loaded Solution ======== load filters opw-3589718
This fix corrects how planned hours are calculated in project timesheet forecasting. Previously, the system was incorrectly counting holidays and non-working days as regular working days, resulting in inflated planned hour totals. The fix now properly accounts for employee calendars to show accurate planned hours for projects and tasks.
Original PR description
This fix reverts some changes of this commit : https://github.com/odoo/enterprise/commit/2711a3ad30bf306df35042d658c7b62a20fcb96f Issue: ====== The planned hours in project timesheet forecast is…
This fix reverts some changes of this commit : https://github.com/odoo/enterprise/commit/2711a3ad30bf306df35042d658c7b62a20fcb96f Issue: ====== The planned hours in project timesheet forecast is counting the holdiays as working days too , so the displayed hours are wrong. Steps to reproduce the issue: ============================= Activate timesheets and planning in project setting. Create a product with the following values: - Type : Service - Create on order : Project & task - Plan Services : active and select anything work planner for example - Unit of Measure / Purchase UoM: Days Create a sale order with that product and choose 10 quantities and confirm it. Click on smart button (8O hours to plan) Click on new and select a resource and start and end date that have 80 alloctated time and save it. Go to project , click on the 3 dots on the project related to the sale order and select Timesheets and Planning analysis You will get more planned hours than expected , you can groupby day to see the planned hours for each day. Origin of the issue: ==================== When creating the table we didn't take into account the calendar of the employee , so it will always count all days from start to end. Solution: ========= I reverted some of the changed of the commit mentioned above which was responsible for this. opw-3482252 opw-3563938 Forward-Port-Of: odoo/enterprise#51120 Forward-Port-Of: odoo/enterprise#49901
This fix corrects a bug in the Master Production Schedule (MPS) where updating demand for one product variant would incorrectly update replenishment quantities for all related components, instead of only the affected ones. Now when you change the forecast demand for a specific product variant (like "P1 red"), only the components that apply to that variant will be updated.
Original PR description
Steps to reproduce the bug:
- Create a storable product “P1”:
- attribute: color
- value: Red and blue
- Create a BoM for “P1”
- Components: - C1 -> apply on P1 red - C2 -> apply on P1 blue
- Go to MPS: - Add the product P1 blue and red
- the components C1 and C2 are added
- Updated the forecast demand of P1 red
Problem:
Both suggested replenishment components qty are updated when only C1 should be updated.
opw-3504423
Forward-Port-Of: odoo/enterprise#51149Fixed an issue where exporting the Journal Report to Excel would include all journals, even those that were folded (hidden) in the user interface. Now when you export the report, only the journals you've chosen to view will be included in the file, matching what you see on screen.
Original PR description
When exporting the journal report to xlsx, the folded journals are also exported, they souldn't. Steps: - Go to Accounting > Reporting > Journal Report - Unfold one journal, keep the others folded - Export to xlsx -> Folded journal are displayed. opw-3493622 Forward-Port-Of: odoo/enterprise#51189 Forward-Port-Of: odoo/enterprise#47348
Users without multi-company permissions were unable to create new salary offers due to a system error. This fix makes the company field invisible for these users while still allowing the system to access the necessary information to properly display offer details. This resolves the error and enables all users to create salary offers regardless of their company access permissions.
Original PR description
When you don't have the multi company group on the user that will create an offer, you get a traceback when you try to create a new offer. The issue is caused, because when it opens the form view of offer, it will compute the display name and for this computation it needs the currency_id which is a related to the company. As the company field is not present in the view when you don't have the multi-company group, the state sent by the onchange doesn't contains the company so it cannot get the currency for the display name. So we put this field in invisible for users that don't have the group to be able to compute the display_name. Forward-Port-Of: odoo/enterprise#51167
This update fixes a technical error that occurred when users tried to reschedule appointments through email invitations. The issue has been resolved by adjusting how the system handles appointment rescheduling requests, ensuring users can now successfully reschedule their appointments without encountering errors.
Original PR description
**Version:** - 15.0 **Steps to reproduce:** - Create an appointment - Confirm an appointment - Go to your email account - Click on the invitation mail and reschedule an appointment **Issue:** Traceback occurs when rescheduling an appointment. **Cause:** The controller's route, which redirects users to different views based on their the role, contains 'website=True', causing a bad request error in the traceback. **Solution:** By removing website=True from the controller's route, traceback can be minimized and a normal bad request will show. task-3510161 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/enterprise#48826
This update resolves layout overflow problems in the Knowledge editor that occurred when users typed long titles or resized the sidebar. The editor's right column and burger menu now properly adjust to available space, preventing content from extending beyond the screen boundaries on both desktop and mobile views.
Original PR description
This pull request tackles two layout-related issues within the Knowledge editor that lead to overflow problems: 1. The first issue pertains to the improper shrinking of the editor's right column when there's limited available space. Currently, the right column can overflow the layout when the user types a lengthy title or resizes the sidebar. 2. The second issue revolves around the burger menu being affected by the width set when resizing the sidebar. Presently, the burger menu can overflow the layout when the user resizes the sidebar on desktop and switch to mobile. task-3507172 Forward-Port-Of: odoo/enterprise#47422
This fix corrects an issue where field service task reports were displaying incorrect totals (showing 0) when using global rounding settings with timesheet-based service products. The report now accurately calculates and displays the correct financial totals, and removes an unnecessary column that was missing its header.
Original PR description
### Steps to reproduce * install `industry_fsm_report` and `industry_fsm_sale` * in the settings, switch to global rounding * create a product of type Service, and invoiced based on timesheets. * create and confirm a sales order with your product * create a field service task liked to your sales order * register some timesheet hours on that task * print the task report You should see that the total is 0. (One column is also missing a header. That column should actually not be displayed) opw-3566787 Before:  After:  Forward-Port-Of: odoo/enterprise#51040
This fix corrects how account balances are calculated during Swedish SIE file imports. Previously, canceled transactions were incorrectly included in balance calculations, leading to inaccurate financial data. The update ensures only active transactions are counted when determining account balances.
Original PR description
The balance moves were taking into account canceled entries in the query This make sure they are not included when fetching the account.move.line balances
The HR Referral module was failing to install when demo data was included, causing database locks and transaction failures. This fix resolves the installation issue by correcting the demo data configuration, allowing the module to install successfully with demo data enabled.
Original PR description
# Issue: The hr_referral application can't be installed with demo data. # Analyze: The db is locked. And transaction is not rollback due to the xml failure. # Fix: The name is a required field in hr.job and it is not recommended to use '.' in ids. # Related ticket: opw-3547638 # Affected version: 16.0 and above Forward-Port-Of: odoo/enterprise#50944 Forward-Port-Of: odoo/enterprise#48705