Saturday, November 25, 2023
8 changes · 17.0
Resolved issues and error corrections
This fixes a crash in the Accounting invoice analysis pivot report when users collapse a column group and then expand it by month. The report now uses the correct date grouping, so business users can analyze invoices by month without interruption.
Original PR description
Accounting > Reporting > Invoice Analysis Open Pivot View Collapse column group, expand by Date>Month StopInteration traceback will raise line: column = self._read_group_postprocess_aggregate(spec, next(column_iterator)) The error is caused by a missing interval attribute on the group by pivot view default search. This will make the view call `read_group` with a wrong groupby list ['invoice_date', 'invoice_date:month'], that will cause the error raise opw-3603433 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes an issue where module loading errors could make the web test suite appear blank instead of showing the problem. This helps teams diagnose test failures faster and keeps automated quality checks clearer.
Original PR description
Since the module loader rewrite, it now reports errors directly in the DOM. The error alert also has the class "modal" so that in case a tour comes accross a page with module loading errors, it will only look for elements inside it and fail. But in the QUnit test suite, modals are invisible by default, causing the page to be blank in those cases. This commit adds a css rule to make sure that this error alert is shown, and updates the code that was previously used to report these errors in the qunit suite to instead simply check for errors reported by the module loader.
Downloading a preview of an invoice that has not yet been confirmed no longer triggers an error. The system now only allows PDF download handling when the invoice is posted, improving reliability for users working with draft invoices.
Original PR description
Steps to reproduce: ------------------- - create an invoice without confirm it; - go to the preview and download it; Issue: ------ A traceback appears. Cause: ------ We try to get `ids` field of a non "record" object (not the root cause). The root cause is that we don't create an attachment if the invoice is not posted. And to post an invoice, we must add line before confirm it. Solution: --------- Make sure you are in the case of an invoice that is `posted` to download a pdf. sentry-4612532780
This fix prevents event website pages from showing an error when a visitor's browser does not support service workers. It keeps the experience stable for affected visitors instead of displaying a technical crash dialog.
Original PR description
PR [1] removed the legacy error handler that swallowed promise rejection errors with anything else than an error (namely, the "legacyRejectPromiseHandler"). As a consequence, promise rejections done as "control flow" now lead to error dialogs being displayed. In particular, it happened on the website (with website_event_track installed), if the browser doesn't support service workers. This commit simply leaves the promise pending if the feature is unavailable. [1] https://github.com/odoo/odoo/pull/137702 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures datetime range fields correctly understand when they are required. It prevents unnecessary extra date inputs from appearing and avoids validation issues in debug mode, improving form reliability for users.
Original PR description
Previously, the datetime field read the value for required directly in the attrs when extracting its props when available. This resulted in 2 separate bugs: - in debug mode, props validation of the…
Previously, the datetime field read the value for required directly in the attrs when extracting its props when available. This resulted in 2 separate bugs: - in debug mode, props validation of the datetime picker would fail, as it expects to receive a boolean for the `range` prop. This was caused by the fact that required was the raw attribute (a string) instead of the boolean and ended up being propagated to the `range` prop - outside of debug mode, the value for required did not cause a crash but any value for required that was not empty would be interpreted as truthy, causing the field to always be display itself as though it is required. In non-range mode, this is invisible, but in range mode, it would always show the second datetime input and the arrow between the beginning and end date, even with required being 0/False, or a python expression that may evaluate to false This commit fixes that by instead reading the value for required from the dynamic infos provided to `extractProps`, which will always be a boolean and contain the value of the evaluated expression when appropriate.
This update fixes a technical issue in the Planning module where an outdated translation function was replaced with the current standard. This ensures the module continues to work properly with the latest system updates and maintains compatibility with the current codebase.
Original PR description
In this commit we fix _lt with _t. Let's see more informations on https://github.com/odoo/odoo/pull/124157
Fixed a visual bug in the timesheet timer where selecting a project or task caused unwanted extra height to appear on mobile devices. The issue was caused by an oversized arrow button (1.3em) that was pushing content down. The fix reduces the button size through a new stylesheet to maintain consistent layout when making selections.
Original PR description
**Steps:** - Open timesheet - Switch to mobile view - Start the timer - Select a Project / Task from dropdown - (Appears in all the views) **Issue:** - When a project/task is selected, extra height appears beneath it **Cause:** - The extra height is caused due to the arrow button which has a size of 1.3em **Fix:** - Making a new scss file for this instead of changing in base files and adding style to reduce the size of the button. **Task:** 3387850 Forward-Port-Of: odoo/enterprise#43428
This update corrects how fuel type information is stored and displayed for company vehicles in the Belgian payroll system. The fix ensures that fuel type selections are handled properly without storing unnecessary data in the database, maintaining compliance with system policies while preserving the ability to show fuel types for new vehicles.
Original PR description
https://github.com/odoo/enterprise/pull/47717 fixed the display of the fuel type for a new car, as it was not being shown. However, the change from that PR was not respecting stable policy. This commit fixes this by changing the selection values from a static list to a lambda function that returns that list This makes the selection values not be stored in the database. Forward-Port-Of: odoo/enterprise#51297