Monday, November 27, 2023
10 changes · 17.0
Resolved issues and error corrections
This fix updates several Mexican tax group labels so they use the correct tax type and language. It helps users see accurate VAT and income tax withholding names in localized accounting records and reports.
Original PR description
Description of the issue/feature this PR addresses: This changes intend to update current tax group records to fix naming issues and add missing translations. Current behavior before PR: - "tax_group_iva_16" is missing translation. - "tax_group_iva_ret_1_25" current name is in Spanish and missing translation. - "tax_group_iva_ret_10" translation reads "ISR" when record is VAT. - "tax_group_isr_ret_10" name is "IVA" when records is "ISR". Desired behavior after PR is merged: - added "tax_group_iva_16" translation. - updated "tax_group_iva_ret_1_25" name to English and added translation. - updated "tax_group_iva_ret_10" translation. - updated "tax_group_isr_ret_10" name. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents copied databases from accidentally interacting with live Viva Wallet payment systems. It helps support teams investigate issues safely without affecting production data or customers.
Original PR description
This commit adds the missing neutralisation necessary for the `pos_viva_wallet` module introduced in [1] The purpose of the standard neutralisation framework is to allow us to create database copies that will not interract with external systems in ways that could impact the production database (or if it is not possible to prevent the interractions, make sure that they are benign or wont result in actual changes), or impact the customers of the operator of the production database. This is mainly useful to allow safe support investigation on database duplicates. [1] https://github.com/odoo/odoo/pull/140353
Fixed the website sharing button so email subjects show normal spaces instead of plus signs. This makes shared page titles look cleaner and more professional when visitors use the email share option.
Original PR description
Steps to reproduce: - Drop a "Share" snippet anywhere on the page and save. - Click on the email icon. - Your default email client should open with, as a subject line, the title of the page where…
Steps to reproduce: - Drop a "Share" snippet anywhere on the page and save. - Click on the email icon. - Your default email client should open with, as a subject line, the title of the page where spaces are replaced by +. => This should not be the case, spaces should show as spaces. Since the sharer refactoring in [1], the title of a page used in share buttons of the `s_share` snippet is encoded as a `URLSearchParams()`, which encodes spaces as "+" characters (see the specs [2] of the built-in method). This works fine for most share buttons, but not for email clients, which do not properly parse the "+". Typically, that means that the subject line of the mailto link is something like "Home+%7CMy+Website", which renders as "Home+|+My+Website" in a mail client, instead of showing spaces. This commit uses another way to encode the title parameter, so that it works for every share button. It also replaces a space that was encoded twice for Whatsapp. [1]: https://github.com/odoo/odoo/commit/5297388cd2aa1f693b04538c846c7025e243b09d [2]: https://url.spec.whatwg.org/#ref-for-urlsearchparams%E2%91%A4 task-3603556
Manufacturing orders can now use operations where the expected duration is set to 0.0 without causing an error when opening the overview. This prevents a customer-facing crash and allows businesses to keep zero-duration operations when needed.
Original PR description
This issue occurs when the customer creates an operation with a 0.0 expected duration fields. An error is then generated when the customer creates a manufacturing order and selects that operation due…
This issue occurs when the customer creates an operation with a 0.0 expected duration fields. An error is then generated when the customer creates a manufacturing order and selects that operation due to expected duration fields is set zero.
step to reproduce -
- Install the `Manufacturing`
- Click on `Configuration > Operations `
- Create New Operations.
- Select the Bill of Material (ex - [FURN_8621] Plastic Laminate)
- Default Duration fields must be 0.0
- click on `Operations > Manufacturing Orders`
- Create New Manufacturing Orders.
- Select the Product (select the product which you selects while creating operation ex. FURN_8621] Plastic Laminate)
- Click on the `Overview` button.
sentry traceback-
```
ZeroDivisionError: float division by zero
File "odoo/http.py", line 2157, in __call__
response = request._serve_db()
File "odoo/http.py", line 1732, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "odoo/service/model.py", line 133, in retrying
result = func()
File "odoo/http.py", line 1759, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 1960, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 207, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 722, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "addons/web/controllers/dataset.py", line 24, in call_kw
return self._call_kw(model, method, args, kwargs)
File "addons/web/controllers/dataset.py", line 20, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "odoo/api.py", line 462, in call_kw
result = _call_kw_model(method, model, args, kwargs)
File "odoo/api.py", line 435, in _call_kw_model
result = method(recs, *args, **kwargs)
File "addons/mrp/report/mrp_report_mo_overview.py", line 19, in get_report_values
'data': self._get_report_data(production_id),
File "addons/mrp/report/mrp_report_mo_overview.py", line 78, in _get_report_data
operations = self._get_operations_data(production, level=1, current_index='')
File "addons/mrp/report/mrp_report_mo_overview.py", line 268, in _get_operations_data
real_cost = expected_cost / workorder.duration_expected * bom_duration_expected
```
https://github.com/odoo/odoo/blob/8adb65993e77150ac711d8e64d1768284bfb49fb/addons/mrp/report/mrp_report_mo_overview.py#L268
after this commit, the customer will be able to set 0.0 in expected duration.
sentry-4657725988Radio and checkbox-style button groups using the light button style now show the selected state consistently. This prevents confusing visual feedback in redesigned frontend forms and controls.
Original PR description
The new frontend redesign includes the same logic for btn-light inside a button group but it applies only if the label gets the active class. btn-group can also be composed of checkbox or radio buttons, which rely on the checked attribute to define the active state. task-3551245 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Payment providers can now be uninstalled even if they were added to a journal but have not yet processed any payments. This removes an unnecessary blocker during cleanup or configuration changes, making payment setup maintenance smoother.
Original PR description
Improve the uninstallation of payment providers by allowing to uninstall payment providers that have a payment method line on a journal but no payment yet. Task id #3595006 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The closing entry helper text in the tax report now displays with proper formatting instead of appearing as plain text. This improves the readability and presentation of the helpful information shown to users when they interact with the closing entry button.
Original PR description
This fix makes the helper of the closing entry button of the tax report be markuped as it is currently not the case and its content is in plain text. Forward-Port-Of: odoo/enterprise#51085 Forward-Port-Of: odoo/enterprise#50914
A recently added error notification widget in the accounting reports module had a limitation that prevented it from working correctly with functions that accept multiple parameters. This fix enables the widget to properly handle these more complex function calls, improving the reliability of error reporting during file generation processes.
Original PR description
The newly added widget for file generation error added in this commit https://github.com/odoo/enterprise/commit/49c9dc9151435fddfc2e3b62ad397015f144a7b6 needs a minor fix to be able to handle methods that have multiple arguments. task-3610890
This update corrects the display width of the percentage field in the shift form view within the Planning module. The field was appearing wider than necessary due to inherited styling. By applying the proper percentage field styling class, the field now displays at the correct, more compact width, improving the visual layout of the shift form.
Original PR description
1) Step: - Install planning. - Go to form view of shift. Issue: - Percentage field has more width than needed. Cause: - `oe_inline` give mw inherit to float field. Fix: - Added `o_field_percentage` class to get 7ch width same as percentage field. task-3282848 Forward-Port-Of: odoo/enterprise#51466 Forward-Port-Of: odoo/enterprise#37155
This update adjusts automated tests in the Peru electronic invoicing module to align with a change that removes rounding from unit price calculations. The modification ensures tests accurately reflect how prices are now processed, maintaining the integrity of Peru's electronic document submission system.
Original PR description
As this community PR https://github.com/odoo/odoo/pull/143348 is removing the rounding on unit price amount, some tests have to be adapted. opw-3509940