Odoo Changelog — 2023-11-30

Thursday, November 30, 2023

71 changes · 17.0

Improvements(4)

Enhancements to existing features

[IMP] mail: validate discuss member fields when creating a channel

Core17.0mail

Odoo now checks which member details can be set when a new Discuss channel is created. This helps prevent unexpected or unintended member information from being accepted, making channel creation more reliable.

Original PR description

The goal is to prevent users to set unexpected fields for Discuss channel members when creating a new channel.

#discuss#channel#validation

[IMP] *_extract: set index content for expenses and resumes

PR #51674

Enterprise17.0account_invoice_extractiap_extract

Attachments for expenses and resumes now get searchable index content, similar to invoices. This makes these documents easier to find and process, improving document management across more workflows.

Original PR description

Previously, the index content of the attachment was only set for invoices, but it can be useful for expenses and resumes as well.

#attachments#search#expenses#resumes

[IMP] currency_rate_live: set default currency rate provider for India

PR #51648

Enterprise17.0currency_rate_live

The system now automatically uses xe.com as the default currency rate provider for companies operating in India. This improvement streamlines the setup process for Indian businesses by eliminating the need for manual configuration of currency exchange rate services.

Original PR description

In this PR
=======================
Currency rate provider service is set as xe.com as default for the companies in India.

task - 3614513

#india#currency#configuration#localization

[FW][IMP] delivery_ups: extract test XML and assets

PR #51810

Enterprise17.0delivery_ups

The UPS delivery module's test data has been reorganized by extracting hardcoded XML content and embedded files from the Python code into separate files on disk. This improves code readability and prevents search tools from incorrectly matching test data strings, while maintaining the same test functionality through efficient file loading.

Original PR description

The UPS http server is mocked to always returns mocked XML content. That mocked content was hardcoded inside the python code, which resulted in multiple huge unreadable strings. Because of their…

The UPS http server is mocked to always returns mocked XML content. That mocked content was hardcoded inside the python code, which resulted in multiple huge unreadable strings.

Because of their inclusion in python file, global regexp search inside the enterprise repository could match inside those string even if the search excluded non python file. This is the actual motivation of this work, to extract the XML hardcoded document inside XML files on disk so that global text search don't wrongly match those lines.

Inside the second XML document entitled "shipment_request.xml" were three assets inlined as very long base64 strings. Those assets have been extracted, base64 decoded and stored on disk in dedicated files. This ease understanding both the content of the XML files and to make it possible to open the assets. The original document (with inlined base64 assets) is reconstructed at runtime.

Using `functools.lru_cache` to lazily open and read the files upon first usage, this prevent loading the files in case the test is actually not run, this also loads the files only once for all test cases.

Forward-Port-Of: odoo/enterprise#51480

Bug Fixes(15)

Resolved issues and error corrections

[FIX] mail: avoid loading more messages than intended

PR #144228

Core17.0mail

This fix stops the mail thread from accidentally loading more messages than the user requested when returning to a previous scroll position. It improves responsiveness and avoids unnecessary data loading in message conversations.

Original PR description

The IntersectionObserver was sometimes started and called its callback before the scroll was restored, in which case the load more button was always visible, leading to loading more messages than intended.

To fix, delay the starting of the visible until the scroll is restored.

runbot-35533

#mail#messages#scrolling#performance

Refactoring(2)

Code cleanup and technical improvements

[FIX] iot: Remove the useless function start_client

PR #144134

Core17.0hw_drivers

The IoT connection startup flow was simplified by folding an unused helper step into the main process. This reduces internal complexity without changing how users interact with IoT devices.

Original PR description

Previously, there was a function called 'start_client' that was invoked by the 'run' function. As 'start_client' was solely invoked within 'run' and served no additional purpose, its functionality has been incorporated directly into the 'run' function.

#iot#cleanup#maintenance

[FIX] iot: change imports order in websocket_client

Other(50)

Miscellaneous changes

[FW][FIX] account: compute label according to payment ref

PR #144362

Core17.0account

Steps to reproduce: - create a bill - add a product line - add a payment reference - save it - change the payment ref - confirm - register a payment Issue: The memo is not the updated payment reference Cause: The memo is computed by taking in priority the `line.name` https://github.com/odoo/odoo/blob/a39050e15195eb095b3480899cedb5cb458fa6cc/addons/account/wizard/account_payment_register.py#L139-L145 And whenever we change the payment reference, the line.name is not recomputed

Original PR description

Steps to reproduce:
- create a bill
- add a product line
- add a payment reference
- save it
- change the payment ref
- confirm
- register a payment

Issue:
The memo is not the updated payment reference

Cause:
The memo is computed by taking in priority the `line.name`
https://github.com/odoo/odoo/blob/a39050e15195eb095b3480899cedb5cb458fa6cc/addons/account/wizard/account_payment_register.py#L139-L145

And whenever we change the payment reference, the line.name is not recomputed if it has already been set

opw-3476835

Forward-Port-Of: odoo/odoo#135923

The UPS http server is mocked to always returns mocked XML content. That mocked content was hardcoded inside the python code, which resulted in multiple huge unreadable strings. Because of their inclusion in python file, global regexp search inside the enterprise repository could match inside those string even if the search excluded non python file. This is the actual motivation of this work, to extract the XML hardcoded document inside XML files on disk so that global text search don't wrongly match those lines. Inside the second XML document entitled "shipment_request.xml" were three assets inlined as very long base64 strings. Those assets have been extracted, base64 decoded and stored on disk in dedicated files. This ease understanding both the content of the XML files and to make it possible to open the assets. The original document (with inlined base64 assets) is reconstructed at runtime. Using `functools.lru_cache` to lazily open and read the files upon first usage, this prevent loading the files in case the test is actually not run, this also loads the files only once for all test cases. Forward-Port-Of: odoo/enterprise#51480

The IntersectionObserver was sometimes started and called its callback before the scroll was restored, in which case the load more button was always visible, leading to loading more messages than intended. To fix, delay the starting of the visible until the scroll is restored. runbot-35533

Previously, there was a function called 'start_client' that was invoked by the 'run' function. As 'start_client' was solely invoked within 'run' and served no additional purpose, its functionality has been incorporated directly into the 'run' function.

How to reproduce: - install a new DB without demo data and crm: -i crm --without-demo=1 - go to settings and click on "Load demo data" at the end of the page - the demo data will not be installed and the following error will appear in the logs "Assigned user Marc Demo has no access to the document and is not able to handle this activity." - and "Marc Demo" has no access to the CRM app If the "crm" module is installed with the demo data at the module installation, it works and "Marc Demo" has access to the CRM app. The cause of the problem is that in the first case "Marc Demo" doesn't belong to group_sale_salesman while in the second case well. By reverting partially the change that remove the group_sale_salesman by removing group_sale_salesman_all_leads (see odoo/odoo#139731), the problem is solved. Technical note: the load of the demo data as a second step fails when creating an activity on a record for which "Marc Demo" has no access to because in the create method of mail_activity, we check that the user has access to the underlying record (_check_access_assignation). It works when installing the demo data while installing the module because in that case "Marc Demo" belongs to "group_sale_salesman" which give him the read access to the record. The solution here is to just re-add that group where it is removed indirectly by removing the group group_sale_salesman_all_leads from "Marc Demo". Another solution would have been to remove this check (_check_access_assignation) as we don't need it anymore (see odoo/odoo#139917 where we display activities for which the user has no access to the underlying record from the menu in the systray). But it won't solve the consistency between installing the demo data while installing the module vs installing the demo data afterward. That's why this solution has been chosen, but we plan also to remove the check (_check_access_assignation) as it is no longer needed. Note that planning activities from the interface even if the assigned user has no access to the underlying record works because the flag "automated" is set to true in that case (that flag will probably also be removed). Task-3600535

**Steps:** - Open Timesheet - Configuration > Time Encoding > Change Encoding Unit to Days - Now select Reporting > By Employee - When you select Measures, you can see Billable Days and Non-Billable Days - Now select Reporting > By Project / By Task - When you select Measures, you can see Billable Hours and Non-Billable Hours **Issue:** - Even after changing the Encoding Unit from Hours to Days, still we are able to have Measures in Hours instead of Days **Cause:** - Records are not made for project and task which changes on the change of encoding unit. **Fix:** - adding records in 'timesheet_analysis_views' for project and task for graph and pivot views so that it updates when changed the encoding unit. Technical Explanation: 'timesheet_uom' is used to define the unit of measure for time entries in a timesheet. It represents the measurement unit that is used to record and track time spent on specific tasks or activities. For example, it could be set to 'hours' or 'days' depending on the organisation's requirements. 'float_time' is used for representing time duration or intervals. It allows users to input and display time values in a decimal format, such as hours and minutes. The float_time widget provides a convenient way to handle time calculations and representations. These two concepts serve different purposes but can be related in the context of tracking time-related data. The timesheet_uom field determines the unit of measure for time entries, while the float_time widget allows for inputting and displaying time values in a convenient decimal format. If we use 'timesheet_uom', the data on the server side will always be displayed in hours or days, which could be confusing for the user. Another issue arises when the work hours for a day are not 8 hours but rather 7.5 hours. The conversion is not accurate since it assumes 8 hours per day in all cases. Hence, by using 'float_time', the process of exporting the data can be streamlined. Task-3387850 Forward-Port-Of: odoo/odoo#127030

Currently, the error occurs while updating a work contract without selecting any employee. Steps to reproduce: - Install a 'hr_work_entry_contract' module. - Go to Employees> Employees> Contracts, And create a new contract without selecting any employee and also the 'Contract Start Date ' and 'Contract End Date' fields should be after or before the current date. - Then save it . - Then change 'Working Schedule' field of the created contract and save it. - The error is generated. Traceback on sentry: ``` DatatypeMismatch: column "hr_employee_id" is of type integer but expression is of type boolean LINE 1: ...neration_wizard_id", "hr_employee_id") VALUES (1, false) ON ... ^ HINT: You will need to rewrite or cast the expression. File "odoo/http.py", line 2157, in __call__ response = request._serve_db() File "odoo/http.py", line 1732, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "odoo/service/model.py", line 133, in retrying result = func() File "odoo/http.py", line 1759, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 1960, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "addons/website/models/ir_http.py", line 235, in _dispatch response = super()._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 207, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 722, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/web/controllers/dataset.py", line 24, in call_kw return self._call_kw(model, method, args, kwargs) File "addons/web/controllers/dataset.py", line 20, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "odoo/api.py", line 466, in call_kw result = _call_kw_multi(method, model, args, kwargs) File "odoo/api.py", line 453, in _call_kw_multi result = method(recs, *args, **kwargs) File "addons/web/models/models.py", line 71, in web_save self.write(vals) File "home/odoo/src/enterprise/17.0/hr_payroll/models/hr_contract.py", line 416, in write res = super().write(vals) File "addons/hr_work_entry_holidays/models/hr_contract.py", line 89, in write return super().write(vals) File "addons/hr_work_entry_contract/models/hr_contract.py", line 443, in write contract._recompute_work_entries(date_from, date_to) File "home/odoo/src/enterprise/17.0/hr_payroll/models/hr_contract.py", line 427, in _recompute_work_entries super()._recompute_work_entries(date_from, date_to) File "addons/hr_work_entry_contract/models/hr_contract.py", line 448, in _recompute_work_entries wizard = self.env['hr.work.entry.regeneration.wizard'].create({ File "<decorator-gen-12>", line 2, in create File "odoo/api.py", line 414, in _model_create_multi return create(self, [arg]) File "odoo/models.py", line 4582, in create records = self._create(data_list) File "odoo/models.py", line 4828, in _create field.create([ File "odoo/fields.py", line 4310, in create self.write_batch(record_values, True) File "odoo/fields.py", line 4336, in write_batch self.write_real(records_commands_list, create) File "odoo/fields.py", line 4913, in write_real cr.execute(SQL( File "odoo/sql_db.py", line 332, in execute res = self._obj.execute(query, params) ```` There's an issue while updating the contract without selecting any employee; As the system is trying to recompute work entries without employee_id [1]. This commit solves this issue by adding a condition which states that recompute the work entries; if employee_id is available. [1]-https://github.com/odoo/odoo/blob/1b504038ce270540ddab28db4ab995d22f2ab2a7/addons/hr_work_entry_contract/models/hr_contract.py#L448-L452 sentry-4654142515 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#143322

[FIX] website: consider other media types for Social Media snippet icons When using the "Social Media" snippet, there are two situations leading to a traceback. Here are the steps: 1) First issue - In edit mode, drop the "Social Media" snippet. - Add a new social network. - Replace the icon by a real image (so not by an other icon). - Set the URL of the new social network to a "relevant" one (e.g. google, facebook). => traceback 2) Second issue - Drop "Social Media" and change the list in order to have the first social network with a real image as icon: either replace the first icon with an image, or add a custom one with an image an move it to the top. - Add a new social network. => traceback Both issues happen because only icons set as `` elements are taken into account when modifying a social network (`querySelector('i')`) and this element may not exist if the icon had another tag (like an image or a span or even a video (as the media dialog allows to upload them)). As there is no check ensuring that the element exists before changing the different social media classes, there is a traceback when the `` is not found. For the first issue, it happens because when changing the URL, we first check if it matches with relevant ones or if an icon matching it exists. If it is the case, we then update the social media classes to set the matching icon => it can only work if the icon is a ``. The second issue happens because when adding a new social network, it actually copies the style of the first one (unless there are none, a new one is created in that case). If the first one is an image, it fails when updating the classes because it is not a ``. This commit fixes these issues by simply adding checks ensuring the icon element exists before trying to modify it. It also adds tests, ensuring these use cases work as expected. opw-3538230 --- [FIX] website: consider `` icons in Social Media snippet In the Social Media snippet options, only icons with a `` tag are considered when updating the social media classes (when adding a new social network by copying the first one and when replacing the icon by another one matching the URL). However, there are cases where the icon is a `` element (with a `fa` class) and not a ``. For example: - Replace a social network icon by a real image. - Re-replace this image by an icon. => the icon element tag is `` and not ``. In this case, after setting its style correctly (e.g. adding the round shape) to make it look like the other icons, we notice that it does not behave like the other ones: - It is not aligned with the other icons, because the CSS rule aligning them only targets ``. - Its icon is not replaced by a matching one when changing the URL with a "relevant" one (e.g. google, facebook). This commit considers `` icons in the Social Media options, in addition to `` icons, in order for them to all behave the same way. opw-3538230 Forward-Port-Of: odoo/odoo#143730 Forward-Port-Of: odoo/odoo#142280

Steps to reproduce: ------------------- - be in UTC -5 (America/Lima for example) on the system (and so browser) and the user profile; - create an event from 4pm to 5pm the next day; - be at 2pm today; Issue: ------ We have a notification in activities for this event today, which is one day too soon. Cause: ------ To find the events that need to be notified to the user, we use a domain which, in this case, can be expressed as follows: ``` ( the `start` of the event must be after "now" (the event has not yet passed) OR the event `stop` must be after now (the event is in progress) ) AND the `start` of the event must be less than the end of the day (the event must be today) ``` The end of the day must be determined, but taking into account the user's timezone. As the domain has to work with UTC values (because the `start` and `stop` values of the event are in UTC in DB), in order to determine the end of the current day, we first need to determine which day the user is in UTC. Logic before this commit (using the example): ```py start_dt = datetime.datetime.utcnow() # 19:00 (because 14h in America/Lima -5) start_date = timezone(tz).localize(start_dt).astimezone(UTC).date() # 00:00 next day end_dt = datetime.datetime.combine(start_date, datetime.time.max) # 23:59 next day end_dt = timezone(tz).localize(end_dt).astimezone(UTC) # 4:59 second next day ``` The result (for an America/Lima timezone) is that if the event has its `start` in UTC before 4:59 two days later, the event will be notified. Solution: --------- Correct the values used to construct the domain. Logic after this commit (using the example): ```py start_dt_utc = now_utc.replace(tzinfo=UTC) # 19:00 (because 14h in America/Lima -5) start_dt = start_dt_utc.astimezone(user_tz) # 14:00 (because 14h in America/Lima -5) stop_dt = datetime.datetime.combine(start_dt.date(), datetime.time.max).replace(tzinfo=user_tz).astimezone(UTC) # 4:59 next day ``` Because 23:59 today using user timezone and then converted to UTC gives 4:59 next day. In fact, the day of a user in the America/Lima (UTC -5) timezone ends in UTC at 4:59 the next day. If this same user creates an event that starts at midnight (and therefore tomorrow), the activity must not be displayed before midnight and therefore 5:00 the next day in UTC. opw-3523558 Forward-Port-Of: odoo/odoo#143874 Forward-Port-Of: odoo/odoo#141949

This traceback arises when `write_date` is `False` in `max()` function https://github.com/odoo/odoo/blob/a5ace6fc50df06a30805e639e0e81d35e20d9f3e/addons/product/models/product_product.py#L136-L138 Error:- ``` KeyError: <NewId origin=1> File "odoo/api.py", line 965, in get cache_value = field_cache[record._ids[0]] CacheMiss: 'product.product(<NewId origin=1>,).write_date' File "odoo/fields.py", line 1160, in __get__ value = env.cache.get(record, self) File "odoo/api.py", line 972, in get raise CacheMiss(record, field) TypeError: '>' not supported between instances of 'datetime.datetime' and 'bool' File "odoo/http.py", line 2138, in __call__ response = request._serve_db() File "odoo/http.py", line 1714, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "odoo/service/model.py", line 133, in retrying result = func() File "odoo/http.py", line 1741, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 1942, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 191, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 717, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/web/controllers/dataset.py", line 30, in call_kw return self._call_kw(model, method, args, kwargs) File "addons/web/controllers/dataset.py", line 26, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "odoo/api.py", line 466, in call_kw result = _call_kw_multi(method, model, args, kwargs) File "odoo/api.py", line 453, in _call_kw_multi result = method(recs, *args, **kwargs) File "odoo/models.py", line 6788, in onchange snapshot1 = Snapshot(record, nametree) File "odoo/models.py", line 6565, in __init__ self.fetch(name) File "odoo/models.py", line 6573, in fetch self[name] = [Snapshot(line, tree[name]) for line in record[name]] File "odoo/models.py", line 6573, in <listcomp> self[name] = [Snapshot(line, tree[name]) for line in record[name]] File "odoo/models.py", line 6565, in __init__ self.fetch(name) File "odoo/models.py", line 6575, in fetch self[name] = record[name] File "odoo/models.py", line 6211, in __getitem__ return self._fields[key].__get__(self, type(self)) File "odoo/fields.py", line 1211, in __get__ self.compute_value(recs) File "odoo/fields.py", line 1389, in compute_value records._compute_field_value(self) File "addons/mail/models/mail_thread.py", line 395, in _compute_field_value return super()._compute_field_value(field) File "odoo/models.py", line 4553, in _compute_field_value fields.determine(field.compute, self) File "odoo/fields.py", line 101, in determine return needle(*args) File "addons/product/models/product_product.py", line 143, in _compute_write_date record.write_date = max(record.write_date, record.product_tmpl_id.write_date) ``` On the `_compute_write_date` when the `write_date` is `False` in `max()` function, It leads to the above traceback. After applying this commit will resolve the issue by computing with the `current date`, when `write_date` is `False`. sentry-4398163501 Forward-Port-Of: odoo/odoo#138177

This traceback arises when the current day of the date is `31` , while the schedule action `(Generate Monthly Sales Closing)` runs. Scenarios to produce the issue: `[1]` * Imagine the `date_stop` value is `31-10-2023` * When the scheduled action `('Generate Monthly Sales Closing')` runs * The value of the `month_target` will be `9` and `year_target` remains same * The value of `interval_from` will be `31-09-2023` (an invalid date). `[2]` * Imagine the `date_stop` value is `31-03-2023` * The value of `interval_from` will be `31-02-2023` (an invalid date) It leads to the traceback Error: ``` ValueError: day is out of range for month File "odoo/tools/safe_eval.py", line 365, in safe_eval return unsafe_eval(c, globals_dict, locals_dict) File "ir.actions.server(791,)", line 1, in <module> File "addons/l10n_fr_pos_cert/models/account_closing.py", line 163, in _automated_closing values = self._compute_amounts(frequency, company) File "addons/l10n_fr_pos_cert/models/account_closing.py", line 77, in _compute_amounts interval_dates = self._interval_dates(frequency, company) File "addons/l10n_fr_pos_cert/models/account_closing.py", line 134, in _interval_dates interval_from = date_stop.replace(year=year_target, month=month_target) ValueError: <class 'ValueError'>: "day is out of range for month" while evaluating "model._automated_closing('monthly')" File "odoo/addons/base/models/ir_cron.py", line 373, in _callback self.env['ir.actions.server'].browse(server_action_id).run() File "home/odoo/src/custom/trial/saas_trial/models/sentry.py", line 33, in run res = super().run() File "odoo/addons/base/models/ir_actions.py", line 688, in run res = runner(run_self, eval_context=eval_context) File "addons/website/models/ir_actions_server.py", line 61, in _run_action_code_multi res = super(ServerAction, self)._run_action_code_multi(eval_context) File "odoo/addons/base/models/ir_actions.py", line 558, in _run_action_code_multi safe_eval(self.code.strip(), eval_context, mode="exec", nocopy=True, filename=str(self)) # nocopy allows to return 'action' File "odoo/tools/safe_eval.py", line 379, in safe_eval raise ValueError('%s: "%s" while evaluating\n%r' % (ustr(type(e)), ustr(e), expr)) ``` See:- https://github.com/odoo/odoo/blob/5fb9825384895fd303bd15c3e4f8dbc55d35904f/addons/l10n_fr_pos_cert/models/account_closing.py#L124-L134 After applying this commit, it will resolve the issue by calculating a valid date in all scenarios. sentry-4589899768 Forward-Port-Of: odoo/odoo#140652

An error will be generated when a user tries to import or upload a file into the invoice module and the file is attached to an image via a URL form but the image is invalid or cannot be found. step to reproduce - - install the `Accounting`. - open Accounting > Vendors Menu > Products. - import file (image url must be invalid or not found - [file](https://drive.google.com/file/d/1ZpKfawnRYjLaqOicBiQMjr8N-MzUmjp8/view?usp=sharing)) - the error will be generated. sentry traceback- ``` UnidentifiedImageError: cannot identify image file <_io.BytesIO object at 0x7f54b322af20> File "addons/base_import/models/base_import.py", line 1269, in _import_image_by_url image = Image.open(io.BytesIO(content)) File "PIL/Image.py", line 3008, in open raise UnidentifiedImageError( ValueError: Không thể truy cập đường dẫn: https://cdn.lottemart.vn/media/catalog/product/cache/0x0/9/4/9415522285001.jpg.webp [image_1920: L10]: cannot identify image file <_io.BytesIO object at 0x7f54b322af20> File "odoo/http.py", line 2139, in __call__ response = request._serve_db() File "odoo/http.py", line 1715, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "odoo/service/model.py", line 133, in retrying result = func() File "odoo/http.py", line 1742, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 1943, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "addons/website/models/ir_http.py", line 235, in _dispatch response = super()._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 191, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 717, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/web/controllers/dataset.py", line 30, in call_kw return self._call_kw(model, method, args, kwargs) File "addons/web/controllers/dataset.py", line 26, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "odoo/api.py", line 466, in call_kw result = _call_kw_multi(method, model, args, kwargs) File "odoo/api.py", line 453, in _call_kw_multi result = method(recs, *args, **kwargs) File "addons/base_import/models/base_import.py", line 1319, in execute_import input_file_data = self._parse_import_data(input_file_data, import_fields, options) File "home/odoo/src/custom/trial/saas_base_import/models/base_import.py", line 37, in _parse_import_data return super(Import, self)._parse_import_data(data, import_fields, options) File "addons/base_import/models/base_import.py", line 1160, in _parse_import_data return self._parse_import_data_recursive(self.res_model, '', data, import_fields, options) File "addons/base_import/models/base_import.py", line 1194, in _parse_import_data_recursive line[index] = self._import_image_by_url(line[index], session, name, num) File "addons/base_import/models/base_import.py", line 1280, in _import_image_by_url raise ValueError(_("Could not retrieve URL: %(url)s [%(field_name)s: L%(line_number)d]: %(error)s") % { ``` At the time of solving the conflicts of FW mistakenly changed the "ImportValidationError" to "ValueError". Due to these changes, the error is shown in the log. FW - [link](https://github.com/odoo/odoo/pull/137596) sentry-4538772256 Forward-Port-Of: odoo/odoo#138788

Improvements(4)

[IMP] mail: validate discuss member fields when creating a channel

[IMP] *_extract: set index content for expenses and resumes

[IMP] currency_rate_live: set default currency rate provider for India

[FW][IMP] delivery_ups: extract test XML and assets

Bug Fixes(15)

[FIX] mail: avoid loading more messages than intended

Refactoring(2)

[FIX] iot: Remove the useless function start_client

[FIX] iot: change imports order in websocket_client

Other(50)

[FW][FIX] account: compute label according to payment ref

Improvements(4)

[IMP] mail: validate discuss member fields when creating a channel

[IMP] *_extract: set index content for expenses and resumes

[IMP] currency_rate_live: set default currency rate provider for India

[FW][IMP] delivery_ups: extract test XML and assets

Bug Fixes(15)

[FIX] mail: avoid loading more messages than intended

Refactoring(2)

[FIX] iot: Remove the useless function start_client

[FIX] iot: change imports order in websocket_client

Other(50)

[FW][FIX] account: compute label according to payment ref

[FIX] project,sale_timesheet: fix profitability section visibility

[FIX] account,hr_recruitment: disable OCR on demo documents

[FIX] web_editor: make new font size classes responsive

[FIX] web_editor: add link test cases

[FIX] iot: Build the url of iot_channel with dumps

[FIX] web_editor: add and update link test cases

[FIX] l10n_mx: tax group wrong name, missing translations

[FIX] website_slides: fix share copy link

[FIX] tools: test pot with nondeterminism

[FIX] account: journal check vals should have journal id as keys

[FIX] sales_team: load demo data

[FIX] hr_recruitment: realign kanban footer items

[FIX] account_invoice_extract: no auto extract on demo posted invoices

[FIX] test_mail_enterprise: load data and message once per chatter

[FW][FIX] website_sale: not cached breadcrumb

[FW][FIX] mrp: wrong consumption after merge

[FW][FIX] account_edi_ubl_cii: no tax exemption reason for NO customers

[FW][FIX] sale_timesheet: rectify billable time in reporting by project & task

[FW][FIX] mail: traceback when switch nav list

[FW][FIX] web_editor: traceback on copy paste table in firefox

[FW][FIX] sms: component getting destroyed

[FW][FIX] board: allow to save comparison

[FW][FIX] website_sale_loyalty: correct taxcloud taxes on 'shop/payment'

[FW][FIX] account: prevent currency rounding change through multi-company

[FW][FIX] web: fix alignment issue for feature names

[FW][FIX] purchase_requisition: Create purchase order

[FW][FIX] web_editor: fix reset when triggering scroll

[FW][FIX] hr_work_entry_contract: don't recompute work entries without employee_id

[FW][FIX] point_of_sale: filter journals by currency during PoS setup

[FW][FIX] point_of_sale: proper display of search bar with category images

[FW][FIX] web: prevent browser print to be limited to what's above the fold

[FW][FIX] website: fix animated text selection

[FW][FIX] spreadsheet_dashboard: inverse raw string

[FW][FIX] l10n_it_edi: partner_info_xml_import

[FW][FIX] website: consider other media types for Social Media snippet icons

[FW][FIX] account: fix performance issue and workaround for mixed currencies on invoice report

[FW][FIX] calendar: trigger activity according to timezone

[FW][FIX] product: compute with current date when write date is false

[FW][FIX] point_of_sale: maintain manual quantity for lot-tracked refunds

[FW][FIX] website_slides: prevent constraint error when changing the type

[FW][IMP] point_of_sale: limit pricelist item loading based on products

[FW][FIX] web_editor: fix font size dropdown on ipad / tablet

[FW][FIX] spreadsheet_dashboard: change search panel icon

[FW][FIX] purchase_mrp: avoid inconsistent test exchange rate

[FW][FIX] l10n_de: DIN5008: add margin between top edge and image below

[FW][FIX] account_check_printing: Add missing space for Checks.

[FW][IMP] account_edi_ubl_cii: Bis 3 products should have a name

[FW][FIX] l10n_fr_pos_cert: calculate valid previous month date

[FW][FIX] base_import: handle exception while import image in url form

[FW][FIX] web: tests: make mock fetch almost sync (micro-tick)

[FW][FIX] web_editor: move dragged grid item before dropzoneOver event

[FW][MERGE][IMP] mass_mailing: improve test tools

[FW][REV] website_sale: Revert #143108

[FW][FIX] website: fix visible cookies bar container

[FW][FIX] website: make forms work again when inside html fields

[FW][FIX] web_editor: ignore device visibility upon snippet drop