Thursday, November 30, 2023
15 changes · 17.0
Resolved issues and error corrections
This fix stops the mail thread from accidentally loading more messages than the user requested when returning to a previous scroll position. It improves responsiveness and avoids unnecessary data loading in message conversations.
Original PR description
The IntersectionObserver was sometimes started and called its callback before the scroll was restored, in which case the load more button was always visible, leading to loading more messages than intended. To fix, delay the starting of the visible until the scroll is restored. runbot-35533
The project profitability section is now shown only when the required accounting conditions are enabled. This prevents users from seeing financial information areas that are not relevant to their current configuration.
Original PR description
Steps: - Install project & accounting - Open project - Open project.update - There is profitability section - Go to accounting module configuration,settings - Analytic accounting field true or false Issue: - Analytic accounting feature true or false the profitability section always visible in project.update Cause: - There is no condition for profitability section visibility Fix: - Added required conditions for profitability section visibility Task-3484413
Demo documents in Accounting and Recruitment will no longer be sent for OCR processing just because they are opened. This prevents unintended digitization of sample records and keeps OCR use manual for demo data.
Original PR description
Previously, the demo documents were automatically sent to the OCR when opened in form view. It's not what we want, those demo documents should only be sent manually. This happened because, in the demo data, the main attachment isn't set. When reading the document, the attachment previewer would select an attachment as main attachment and, as the OCR relies on the `register_as_main_attachment` hook, it would be sent for digitization. Now, the main attachment is explicitly set in the demo data definition.
Text resized through the website editor now adjusts properly on different devices and screen widths. This helps keep edited website content readable and visually consistent for visitors on phones, tablets, and desktops.
Original PR description
Since [this other commit], we use classes to change the font size of text. Unfortunately, we forgot to make them responsive. This commit fixes that. [this other commit]: https://github.com/odoo/odoo/commit/194f73a9bbad8c3c3fb5c378e7bdfa704aaacdc0 task-3615976
This update adds automated checks for several ways users create links in the web editor, including keyboard shortcuts, typed URLs, toolbar actions, and the command menu. These tests help reduce the risk of future changes breaking link creation workflows.
Original PR description
Current behavior before PR: No test cases were there for dialog box based link creation. Desired behavior after PR is merged: Added Qunit test cases for various scenarios Cases Covered: * Making links with hotkeys. * Typing valid url + space should make link. * Making link with powerbox. * Selecting text and link button on the toolbar. task-3087957
The IoT connection URL is now built using safer JSON formatting instead of manual text assembly. This helps prevent malformed connection data and improves reliability for IoT device communication.
Original PR description
Before, the url was built with string comprehension. Now json.dumps is use to ensure that the JSON sent is valid
This update improves automated checks around creating links in the website editor, including links made from typed URLs, the command menu, and the toolbar dialog. It helps ensure common link creation flows keep working reliably for users while removing reliance on obsolete test coverage.
Original PR description
Specification: -The tests are not testing the actual OdooEditor behavior, but the `editorCommands.createLink()` function (which is not used anywhere). -CreateLink method was a dead code. -No test cases were there for dialog box based link creation. Cases Covered: -typing url + space -powerbox -selecting text and link button on the toolbar task-3087957
Updates Mexican localization tax group records to fix incorrect names and add missing translations. This helps users see clearer, properly localized tax labels in accounting screens and reports.
Original PR description
These changes intend to update current tax group records to fix naming issues and add missing translations.
The course sharing feature now correctly copies the share link to the clipboard. This fixes a small but user-visible issue where learners or visitors could not copy links from the website slides sharing tools.
Original PR description
With this commit 963842381e2449ee59e5cffd1bae8656f5477e7a ClipboardJS was removed to use the native clipboard api. But here the innerText was checked instead of the value so there was nothing to copy in the clipboard. This commit fix this. Task-3607299 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix makes a translation-related test produce consistent results instead of failing randomly. It helps maintain development reliability without changing customer-facing functionality.
Original PR description
The test added in 09a4762b will fail randomly, because of the nondeterministic os.walk access. This commit allows this nondeterminism in the test. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A bug prevented accounting dashboard totals for journal entries marked for review from appearing. The fix makes those review counts and amounts display correctly, helping finance teams spot entries that need attention.
Original PR description
This commit fixes the consistency issue missed in https://github.com/odoo/odoo/commit/a9dd388a1128ac406b6a5cec58b3833aadb04c62. Currently, to_check_vals dictionary has journal records as keys. Later, the total amount and count of account moves marked with `to_check` are retrieved by journal.id, which don't exist in the `to_check_vals` dictionary, so `to_check` value is never displayed on the dashboard. That dictionary should contain the actual ids instead. task-3611262 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes an issue where loading demo data after installing CRM without demo data could fail because the demo user lacked the right sales access. This makes demo data setup behave consistently whether it is loaded during installation or afterward.
Original PR description
How to reproduce: - install a new DB without demo data and crm: -i crm --without-demo=1 - go to settings and click on "Load demo data" at the end of the page - the demo data will not be installed and…
How to reproduce: - install a new DB without demo data and crm: -i crm --without-demo=1 - go to settings and click on "Load demo data" at the end of the page - the demo data will not be installed and the following error will appear in the logs "Assigned user Marc Demo has no access to the document and is not able to handle this activity." - and "Marc Demo" has no access to the CRM app If the "crm" module is installed with the demo data at the module installation, it works and "Marc Demo" has access to the CRM app. The cause of the problem is that in the first case "Marc Demo" doesn't belong to group_sale_salesman while in the second case well. By reverting partially the change that remove the group_sale_salesman by removing group_sale_salesman_all_leads (see odoo/odoo#139731), the problem is solved. Technical note: the load of the demo data as a second step fails when creating an activity on a record for which "Marc Demo" has no access to because in the create method of mail_activity, we check that the user has access to the underlying record (_check_access_assignation). It works when installing the demo data while installing the module because in that case "Marc Demo" belongs to "group_sale_salesman" which give him the read access to the record. The solution here is to just re-add that group where it is removed indirectly by removing the group group_sale_salesman_all_leads from "Marc Demo". Another solution would have been to remove this check (_check_access_assignation) as we don't need it anymore (see odoo/odoo#139917 where we display activities for which the user has no access to the underlying record from the menu in the systray). But it won't solve the consistency between installing the demo data while installing the module vs installing the demo data afterward. That's why this solution has been chosen, but we plan also to remove the check (_check_access_assignation) as it is no longer needed. Note that planning activities from the interface even if the assigned user has no access to the underlying record works because the flag "automated" is set to true in that case (that flag will probably also be removed). Task-3600535
The recruitment kanban card footer now displays its items with consistent vertical alignment. This minor visual fix makes applicant and job cards look cleaner and easier to scan.
Original PR description
The kanban's footer elements were misaligned vertically, specifically the status icon. task-3473010 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Posted demo invoices will no longer be automatically sent for OCR digitization. This keeps the digitization process focused on draft invoices only, avoiding unnecessary processing of invoices that are already finalized.
Original PR description
When checking if an invoice needs to be automatically sent to the OCR, we weren't checking the state of the invoice. Only draft invoices should be sent. In practice, it wasn't much of an issue as new invoices are created in the `draft` state, but for demo invoices, some of them are already in the `posted` state. Those shouldn't be sent for digitization.
This update optimizes the mail enterprise tests by loading data and messages more efficiently. The change reduces redundant loading operations in the attachment preview tests, making the test suite run faster and more reliably.
Original PR description
Test of fix in community commit. https://github.com/odoo/odoo/pull/143867