Thursday, November 30, 2023
4 changes · master
Resolved issues and error corrections
The portal search panel now avoids errors when a search option is used but not shown in the dropdown menu. This makes custom portal searches more reliable and prevents users from encountering a broken search experience.
Original PR description
The _search method of the portal search panel uses the currently selected dropdown item to retrieve the search criteria ; however, when using a search criteria that is not displayed in the dropdown menu, the replace method causes a traceback, since calling attr on the empty jquery selector object returns undefined. The _search method was changed to use optional chaining before accessing the replace method, and to replace the search_in value by an empty string in case the result of the expression is undefined.
This change removes outdated link-creation code and related tests that no longer match how Odoo's web editor works. It reduces maintenance overhead and helps keep future testing focused on the editor's current behavior, with no expected impact for end users.
Original PR description
Specification:
Revise link insertion test suite to conform to the updated OdooEditor behavior. The current tests depend on the createLink function, triggered by `editor.execCommand('createLink')`, which ultimately invokes editorCommands.createLink(). However, OdooEditor has transitioned away from using this function for link creation, opting for alternative methods such as `_createLink` or `Link.getOrCreateLink`. As a result, the existing tests no longer accurately reflect OdooEditor behavior; instead, they concentrate on the now-unused editorCommands.createLink() function, deeming it dead code except for its connection to these tests.
* The tests have been removed as they no longer assess the OdooEditor behavior.
* The dead code CreateLink method has been eliminated from commands.js.
* The createLink from test\utils.js was also unused and has been removed.
task-3087957Employees can now confirm “My Time Off” requests for leave types that do not require validation without seeing an incorrect error. This prevents unnecessary blockers when submitting time off and keeps the request flow consistent for automatically confirmed leave types.
Original PR description
User Error stating that user's trying to confirm My Time Off request that's not 'To Submit' for no-validation type was solved. It was caused by the fact that create method sets state to 'confirm' automatically for no-validation time offs which triggers mentioned error on confirmation. Problem was solved by adding in confirmation check if it's of no-validation type. task-3284380 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Planning publish dialog now displays its list content without extra empty space on the right. This makes the publish and send flow cleaner and easier to read when assigning shifts to employees without email addresses.
Original PR description
Steps: - Open planning - Assign a new employee to shift without email - Click on the 'Publish' button - Click on the 'Publish & Send' button Issue: - Dialog is sized weirdly compared to the list view inside of it. There is trailing space on the right side of the list view. Cause: - Improper group and colspan are given in the view. Fix: - As this fix is in the stable version, currently we are giving invisible=1 to that group which shall be removed in master and adding the code without group and colspan. task-3378532