Monday, December 4, 2023
2 changes · 17.0
Resolved issues and error corrections
Temporarily disables delayed translation in the website editor because it could erase page content when the main website language was not English. This restores safer editing behavior while a broader investigation and permanent fix are prepared.
Original PR description
Delay translation, when the website main language is not English, is not working alongside the HTML Editor. It seems to be multiple bugs, both in Odoo 16 and Odoo 17 following jsonb and then delay…
Delay translation, when the website main language is not English, is not working alongside the HTML Editor. It seems to be multiple bugs, both in Odoo 16 and Odoo 17 following jsonb and then delay translation. A full investigation will need to be done (and tests written for it) for all possible flows: 1. English DB + Website FR (only) 2. English DB + Website FR (main lang) + Website EN (translated version) 3. French DB + French Website (English is not even enabled on DB) 4. French DB + English website 5. Case 3. + Website EN (translated version) 6. Case 4. + Website FR (translated version) Also, for each of those flows, both the website builder and the HTML Editor need to behaves correctly (at least not wipe user content). This commit, for now, disables the delay translation to restore what we have in Odoo 16. The whole investigation, fixes and tests will be done after this commit in both Odoo 16 and Odoo 17. Step to reproduce (one of the flow, which is problematic for one of our big client to go in production): - Have DB and admin in English - Have FR only on the website - Enter edit mode on a page (website builder) - Drag & drop a snippet and save - Open HTML Editor, add a blank line - The page content is gone, user lost its page Related to PR [1] which is the Odoo 17 forward port of commit [2] introduced in Odoo 16.0. [1]: https://github.com/odoo/odoo/pull/144693 [2]: https://github.com/odoo/odoo/commit/f54aa6f58d494bca940a3e575d4092ee386d488c task-3621753 (where the deep investigation and fixes will happen)
The Knowledge app was missing a required dependency on the web_map module, which caused login failures and errors when users uninstalled web_map and then installed Knowledge. This fix adds the missing dependency to ensure the Knowledge app works properly regardless of web_map installation status.
Original PR description
#### Description Uninstalling the web_map module and installing the knowledge module results in a missing dependency error in 16.0 and a blocking screen when trying to log in from 16.1 onwards. This…
#### Description Uninstalling the web_map module and installing the knowledge module results in a missing dependency error in 16.0 and a blocking screen when trying to log in from 16.1 onwards. This commit fixes this issue by adding web_map to the dependencies of the knowledge app, as we are importing MapRenderer from the web_map module. See this [commit](https://github.com/odoo/enterprise/blob/16.0/knowledge/static/src/components/external_embedded_view_insertion/views_renderers_patches.js#L9) Issue is introduced from this [commit](https://github.com/odoo/enterprise/commit/0ffc548c0afa7434f40cccf91df62e5e5172e374#diff-94bdcbce3efa072706e30a6c3110a3b76dc8ce6d0a3e725155308a5cbe0794a2R9) #### Related Task opw-3522134 #### Reproducing the error in 16.0 - [Video](https://drive.google.com/file/d/1tRhJa07iIt46Ec-zj17jseB7Ws5MoqmY/view?usp=share_link) #### Reproducing the error in 16.1 - [Video](https://drive.google.com/file/d/1iM-VcxKCeX5bCKsrNDX6WZVQsrpljH6i/view?usp=share_link) Forward-Port-Of: odoo/enterprise#49199