Thursday, December 7, 2023
18 changes · 17.0
Enhancements to existing features
When the restaurant point-of-sale app is installed, the default demo shop is automatically archived if it has not been used in a session. This keeps restaurant databases cleaner by hiding an irrelevant sample shop before it creates confusion for users.
Original PR description
When restaurant is installed the demo shop is archived if no session has been made. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Resolved issues and error corrections
This update fixes two issues in the Web Studio report editor: it removes unwanted blank spaces that appeared when model names were too long in the field popover, and it corrects formatting issues with dropdown menu items. These fixes improve the user experience when working with dynamic tables and field selection in report design.
Original PR description
Before this commit, if the name of the current model on the field popover was to large, there was a blank space. In addition, in debug mode, there was a traceback when trying to add a field in the dynamic table because of props validation. After this commit, no more blank space and the format of the SelectMenu's items are corrected.
Documentation and clarification updates
This pull request records that GitHub user paulogomes has signed Odoo's Contributor License Agreement. It supports the legal process required before accepting contributions and has no direct effect on product features or users.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
This commit fixes an issue with the product configurator where if a subproduct contains an on sale warning, the subproduct won't be added to the quotation when the main product is added. In order to fix this issue, it was needed to provide a way for the allowWarning option to be passed from the addNew method of the basic_relational_model to the _applyX2ManyChange method of the basic_model. This is done by propagating the option through the command until it reaches the basic_model. opw-3462462
Original PR description
This commit fixes an issue with the product configurator where if a subproduct contains an on sale warning, the subproduct won't be added to the quotation when the main product is added. In order to fix this issue, it was needed to provide a way for the allowWarning option to be passed from the addNew method of the basic_relational_model to the _applyX2ManyChange method of the basic_model. This is done by propagating the option through the command until it reaches the basic_model. opw-3462462 Forward-Port-Of: odoo/odoo#144167 Forward-Port-Of: odoo/odoo#143615
This update fixes visual alignment issues in the Planning and Sign applications where table cells were inconsistently aligned. The changes standardize the vertical alignment of list items and ensure icons display properly centered. Additionally, a missing stylesheet reference in the Sign module has been corrected to prevent compilation errors.
Original PR description
Prior to this commit some td in the list renderer were vertically align on the middle while other are aligned on top. This comes from commit: https://github.com/odoo/odoo/commit/53f605399755f9355554c2582ea0f693c8f947b4. This commit removes the vertical-align: middle to rely on the inherited alignment from the `<td>` which is inherited until the `<table>` el which set the alignment on `top`. This commit adapts the wrench icon in planning to be centered vertically with the new `$o-line-size` variable introduced in community. The new variable created a compilation error with the sign app because the `function.scss` file was not included in the assets of the module. task-3557566 Community PR: https://github.com/odoo/odoo/pull/138915 Forward-Port-Of: odoo/enterprise#49823
Previously, the code that sets default tags on bank accounts was in l10n_de_reports, so was not yet loaded when the demo company is created at module init of l10n_de. As a result, the demo company was created without the necessary tags on the 1001 Cash and 1201 Bank accounts, which meant that the Balance Sheet would not be impacted by these accounts on the demo company. This commit fixes this. Enterprise PR: https://github.com/odoo/enterprise/pull/52143 taskid:none Forward-Port-Of:
Original PR description
Previously, the code that sets default tags on bank accounts was in l10n_de_reports, so was not yet loaded when the demo company is created at module init of l10n_de. As a result, the demo company was created without the necessary tags on the 1001 Cash and 1201 Bank accounts, which meant that the Balance Sheet would not be impacted by these accounts on the demo company. This commit fixes this. Enterprise PR: https://github.com/odoo/enterprise/pull/52143 taskid:none Forward-Port-Of: odoo/odoo#145286 Forward-Port-Of: odoo/odoo#145013
Since 16.0, the number of unread messages is not shown anymore on the tab title. This is due to the `set_title_part` event being sent on the wrong bus. The title service is the new preferred way to change the document title. This PR makes use of this service to restore the previous behavior. Forward-Port-Of: odoo/odoo#145216 Forward-Port-Of: odoo/odoo#144993
Original PR description
Since 16.0, the number of unread messages is not shown anymore on the tab title. This is due to the `set_title_part` event being sent on the wrong bus. The title service is the new preferred way to change the document title. This PR makes use of this service to restore the previous behavior. Forward-Port-Of: odoo/odoo#145216 Forward-Port-Of: odoo/odoo#144993
Before this commit, archiving a restaurant floor caused an error when opening a PoS restaurant session. This issue originated from the `get_tables_order_count` function, which executed a search based on `restaurant.table`. Since archiving a floor does not automatically archive its tables, the function returned information for archived floors, leading to errors. With this commit, we introduce an additional search to first identify active floors in a PoS config. This refined search is then used
Original PR description
Before this commit, archiving a restaurant floor caused an error when opening a PoS restaurant session. This issue originated from the `get_tables_order_count` function, which executed a search based on `restaurant.table`. Since archiving a floor does not automatically archive its tables, the function returned information for archived floors, leading to errors. With this commit, we introduce an additional search to first identify active floors in a PoS config. This refined search is then used to filter tables, ensuring that only tables from active floors are considered. opw-3619830 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#144771 Forward-Port-Of: odoo/odoo#144551
[FIX] stock: only resupply from a warehouse in the same company Steps to reproduce the bug: - Enable “multi steps routes” in inventory settings - Have two company “A” and “B” - Create another warehouse in company A - refresh the page Problem: You should not select a warehouse in another company, as it will lead to several errors later on. If the user wishes to use this option, they can activate 'Inter-Company Transactions' in the settings and then utilize this feature. opw-3604302
Original PR description
[FIX] stock: only resupply from a warehouse in the same company Steps to reproduce the bug: - Enable “multi steps routes” in inventory settings - Have two company “A” and “B” - Create another warehouse in company A - refresh the page Problem: You should not select a warehouse in another company, as it will lead to several errors later on. If the user wishes to use this option, they can activate 'Inter-Company Transactions' in the settings and then utilize this feature. opw-3604302 Forward-Port-Of: odoo/odoo#145079 Forward-Port-Of: odoo/odoo#144487
## Before this commit: Calling `env["stock.move.line"].write({"lot_id": lot_id})` with `lot_id` as a recordset instead of an id does not work. However, this is supported by the base model `write` method. ## Steps to reproduce: 1. Create a product A without tracking 2. Set product A's quantity to 10 3. Create an internal transfer to move 10 quantities of product A from Stock to Production 4. Change product A's tracking method to track by lot 5. Create a BoM for A with component B 6. Se
Original PR description
## Before this commit:
Calling `env["stock.move.line"].write({"lot_id": lot_id})` with `lot_id` as a recordset instead of an id does not work.
However, this is supported by the base model `write` method.
## Steps to reproduce:
1. Create a product A without tracking
2. Set product A's quantity to 10
3. Create an internal transfer to move 10 quantities of product A from Stock to Production
4. Change product A's tracking method to track by lot
5. Create a BoM for A with component B
6. Set product B quantity to 10
7. Produce 10 quantities of product A by creating a manufacturing
8. A traceback prevents marking the MO as done
Side effect introduced in https://github.com/odoo/odoo/commit/a14f8989bcf37e93232baeb39d71d4c125e33fc2
opw-3620539
Forward-Port-Of: odoo/odoo#144639Prior to this commit some td in the list renderer were vertically align on the middle while other are aligned on top. This comes from commit: https://github.com/odoo/odoo/commit/53f605399755f9355554c2582ea0f693c8f947b4. This commit removes the vertical-align: middle to rely on the inherited alignment from the `<td>` which is inherited until the `<table>` el which set the alignment on `top`. To visually center the icons previously centered by vertical-align, a new variable: `$o-line-si
Original PR description
Prior to this commit some td in the list renderer were vertically align on the middle while other are aligned on top. This comes from commit:…
Prior to this commit some td in the list renderer were vertically align on the middle while other are aligned on top. This comes from commit: https://github.com/odoo/odoo/commit/53f605399755f9355554c2582ea0f693c8f947b4. This commit removes the vertical-align: middle to rely on the inherited alignment from the `<td>` which is inherited until the `<table>` el which set the alignment on `top`. To visually center the icons previously centered by vertical-align, a new variable: `$o-line-size` is created. This variable accounts for the total size of a line which is the font size multiplied by the line height. In our case this ensure that the icons line height in the list view is the same as the <td> that are containing text. Enterprise PR: https://github.com/odoo/enterprise/pull/49823 task-3557566 | Before | After | | -- | -- | | |  | | Affected elements | | -- | |  | |  | |  | --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#138915
__Current behavior before commit:__ The logic to regenerate assets bundles is located in the frontend (i.e. the JS is making the calls to retrieve and unlink them) which is not very clean. Furthermore, when doing so, the old assets might still be included on cached views that called them with `t-call-assets`. Therefore, regenerating assets bundles can break the CSS or the JS as long as the view cache is not cleared. __Description of the fix:__ A new backend method is implemented
Original PR description
__Current behavior before commit:__ The logic to regenerate assets bundles is located in the frontend (i.e. the JS is making the calls to retrieve and unlink them) which is not very clean. Furthermore, when doing so, the old assets might still be included on cached views that called them with `t-call-assets`. Therefore, regenerating assets bundles can break the CSS or the JS as long as the view cache is not cleared. __Description of the fix:__ A new backend method is implemented for regenerating asset bundles. This provides a dedicated and maintainable approach. Additionally, the cache is explicitly cleared during the regeneration process. __Example of steps to reproduce the issue on runbot:__ 1. Check `Disable cache` in chrome dev tools. 1. Little bug icon > Regenerate Assets Bundles Forward-Port-Of: odoo/odoo#145000 Forward-Port-Of: odoo/odoo#143124
Current behavior before PR: When a table is created the selection is set to the first `TD` of the table. Desired behavior after PR is merged: When a table is created the selection is set to the `P` tag inside of first `TD` of the table. task-3610536 Forward-Port-Of: odoo/odoo#143518
Original PR description
Current behavior before PR: When a table is created the selection is set to the first `TD` of the table. Desired behavior after PR is merged: When a table is created the selection is set to the `P` tag inside of first `TD` of the table. task-3610536 Forward-Port-Of: odoo/odoo#143518
# Issue: A few internal developers (check related task) used file operations on IrAsset instead of IrAttachment. # Analyze: Nothing is done in order to prevent this and it should be clearer for everyone. # Fix: Assert that the instance is an IrAttachment in order to avoid a bad practice. # Related task: task-3594813 Forward-Port-Of: odoo/odoo#145156
Original PR description
# Issue: A few internal developers (check related task) used file operations on IrAsset instead of IrAttachment. # Analyze: Nothing is done in order to prevent this and it should be clearer for everyone. # Fix: Assert that the instance is an IrAttachment in order to avoid a bad practice. # Related task: task-3594813 Forward-Port-Of: odoo/odoo#145156
**Current behavior before PR:** Tab on link moves link table but the link popover stucks. **Desired behavior after PR is merged:** Tab outsided the link hides the linkpopover. task-3389015 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140881
Original PR description
**Current behavior before PR:** Tab on link moves link table but the link popover stucks. **Desired behavior after PR is merged:** Tab outsided the link hides the linkpopover. task-3389015 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#140881
Description of the issue/feature this commit addresses: Currently, if the price of an expense category which has expenses posted is modified, the total amount of those expenses is modified too. This is a wanted behavior but this might surprise the user and so it would be preferable to tell him that those amount will be modified when he is editing the category's price. --- Desired behavior after the commit is merged: Adding this commit, when a user modifies the standard_price on a exp
Original PR description
Description of the issue/feature this commit addresses: Currently, if the price of an expense category which has expenses posted is modified, the total amount of those expenses is modified too. This is a wanted behavior but this might surprise the user and so it would be preferable to tell him that those amount will be modified when he is editing the category's price. --- Desired behavior after the commit is merged: Adding this commit, when a user modifies the standard_price on a expense category, if this category has posted or draft expenses linked, a warning message will appear to tell the tell the user of what is going to happen. --- task-3506770 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#144895 Forward-Port-Of: odoo/odoo#138889
Before this commit, multiple toolbar instances would be created when switching between records via the form view pager. This commit fixes the issue by using and properly setting up the existing Toolbar child component, without the need to instantiate a new one. It also removes this module's dependency on the legacy ComponentWrapper. task-3495685 Forward-Port-Of: odoo/odoo#143387
Original PR description
Before this commit, multiple toolbar instances would be created when switching between records via the form view pager. This commit fixes the issue by using and properly setting up the existing Toolbar child component, without the need to instantiate a new one. It also removes this module's dependency on the legacy ComponentWrapper. task-3495685 Forward-Port-Of: odoo/odoo#143387
During the following FW, too much has been added to the pot file of the hr_expense module. This commit removes that useless content. Concerned FW : https://github.com/odoo/odoo/pull/143956 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#145249
Original PR description
During the following FW, too much has been added to the pot file of the hr_expense module. This commit removes that useless content. Concerned FW : https://github.com/odoo/odoo/pull/143956 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#145249