Thursday, December 7, 2023
15 changes · 17.0
Resolved issues and error corrections
This fix prevents errors when printing receipts for already paid restaurant orders in Point of Sale. Receipt header details are now taken from the specific order being printed, improving reliability across restaurant and localized POS receipt formats.
Original PR description
Prior to this commit, attempting to print a receipt for a paid order in the PoS restaurant resulted in an error. This issue was due to the 'getReceiptHeaderData' method in the PoS restaurant using 'this.get_order()' to retrieve the order, which is not applicable for paid orders. Additionally, this problem exists in other modules that override 'getReceiptHeaderData'. To resolve this, the order is now passed as an argument to the 'getReceiptHeaderData' function. Enterprise PR: https://github.com/odoo/enterprise/pull/52249 opw-3616997 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Point of Sale interface has been adjusted so screens switch to the mobile layout at the newly defined tablet-sized breakpoint. This keeps customer lists, receipts, tickets, and employee login views readable and usable on smaller devices.
Original PR description
A recent commit (https://github.com/odoo/odoo/pull/139686) changed the size of the mobile view in pos to <= 992px. This commit adapts the overall display to this change. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes several issues in the hierarchy view so users can drag, drop, and reorder items more reliably. It also improves scrolling behavior and spacing, helping users keep track of moved cards and avoiding confusing duplicate or ghost entries.
Original PR description
This is a preliminary work in order to introduce the Hierarchy view in Knowledge. The commits in this PR are generic fixes or improvements which are not directly related to Knowledge: - fix typo of a rendering context expression: `dataPointIdExpr` - recompute the `config` even if a `Record` is updated with pre-fetched values - fix the scrolling behavior in the Hierarchy view (auto-scroll and drag-scroll) - fix the model update when a hierarchy node is dropped at a new position See each commit for more details. task-3562116
Stock move confirmation now avoids errors when products using First Expiry First Out have stock records without lot information. This keeps warehouse operations moving smoothly by safely placing items without expiry data after those with known removal dates.
Original PR description
Before this commit, using the First Expiry First Out (FEFO) removal strategy led to a traceback error during stock move confirmation if a stock quant of a product was missing its lot. This issue arose because the removal strategy's sort key was based on `removal_date`, which is a field related to `lot_id`. To address this problem, the sorting logic has been modified. Now, it uses `removal_date` or `fields.datetime.max` as the sort key. opw-3625784 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes two issues in the Web Studio report editor: it removes unwanted blank spaces that appeared when model names were too long in the field popover, and it corrects formatting issues with dropdown menu items. These fixes improve the user experience when working with dynamic tables and field selection in report design.
Original PR description
Before this commit, if the name of the current model on the field popover was to large, there was a blank space. In addition, in debug mode, there was a traceback when trying to add a field in the dynamic table because of props validation. After this commit, no more blank space and the format of the SelectMenu's items are corrected.
Users encountered an error when trying to archive workspaces in the Documents module. This fix corrects a technical issue where the system was passing incorrect data to the archive function, allowing workspaces to be archived successfully without errors.
Original PR description
**Steps to Reproduce** 1. Open document module. 2. Go to Configuration > Workspaces 3. Open any workspace > Action button 4. Try to archive. **Technical** The function(action_archive) is expecting a list but here we are passing the integer value(ID). **After this commit** The workspace can be archived without traceback. **Task**-3579858
This fix corrects how default rental dates are calculated for daily rental products on the ecommerce product page. Previously, the dates and duration didn't match correctly. Now, when a product is rented by the day, the system properly calculates the full day period (from 00:00 on the first day to 23:59 on the last day), ensuring the dates and duration are consistent for customers.
Original PR description
Steps to reproduce: ------------------- - set a "Daily" period for a rented product; - go to ecommerce on the product page; Issue: ------ The default period is not correct. The dates and duration don't match. Cause: ------ For a product whose rental is counted in days, the duration is the number of days selected. For a product that can be rented by the hour, The duration is calculated using the difference between the datetimes. Solution: --------- When the product can be rented in days, take the whole day, i.e. 00:00:00 on the first day to 23:59:59 on the last day. After this commit: If the default period is 1 day and it's the 21st of the month, the dates will be from the 22nd to the 22nd with a duration of 1 day (on the datepicker, only one day is selected). opw-3573163 Forward-Port-Of: odoo/enterprise#51123
This update fixes an issue where printing receipts for paid orders in the Point of Sale system was causing errors. The fix ensures that receipt printing works correctly for all order statuses by improving how the system retrieves order information during the printing process.
Original PR description
Prior to this commit, attempting to print a receipt for a paid order in the PoS restaurant resulted in an error. This issue was due to the 'getReceiptHeaderData' method in the PoS restaurant using 'this.get_order()' to retrieve the order, which is not applicable for paid orders. Additionally, this problem exists in other modules that override 'getReceiptHeaderData'. To resolve this, the order is now passed as an argument to the 'getReceiptHeaderData' function. Community PR: https://github.com/odoo/odoo/pull/145252 opw-3616997
This fix corrects how asset reevaluations with decreases are handled. Previously, remaining depreciation entries were postponed, which was incorrect. Now they are properly spread across remaining periods, matching the behavior from version 15. The fix also resolves issues with lock dates and rounding errors in depreciation calculations.
Original PR description
After a reevaluation with a decrease, we postponed next entries. It was deemed a faulty behaviour. We decided to remake the behaviour from 15 that is, spread the remaining amount on the remaining period. While fixing this, we decided to fix the issue with lock dates, and by remaining amounts that were left after a reevaluation. To do so, we removed the dependency on asset_number_days and on dates. The problem with asset_number_days was that it is stored as an Integer, while doing computations as if it is a Float (so rounding issues). With date, it didn't take into account the fact that lock dates postpone the posting. Task - 3606047 Forward-Port-Of: odoo/enterprise#52178 Forward-Port-Of: odoo/enterprise#50152
A previous change to how rental product default dates are handled has been reverted. This fix restores the original date behavior for rental products in the website sales module, ensuring customers see the correct default rental dates when browsing rental items.
Original PR description
This reverts commit 95bc0589fdad8479f1288139989f3430837d5612.
This update fixes a display issue on mobile devices where the work order control panel was extending beyond the screen width, causing unwanted horizontal scrolling. The fix ensures the interface properly fits within mobile screens while maintaining all functionality.
Original PR description
Before: <img width="391" alt="image" src="https://github.com/odoo/enterprise/assets/35101914/087b23c6-0771-4f71-a7d2-276f3494f7ba"> After: <img width="428" alt="image" src="https://github.com/odoo/enterprise/assets/35101914/e98ae127-2836-4bc6-8a9c-6bbb08c890a1">
This update fixes an issue where the German demo company's Cash and Bank accounts were missing required financial tags, causing them to be excluded from Balance Sheet reports. The fix moves the account tagging code to load at the correct time during company setup, ensuring accurate financial reporting for demo data.
Original PR description
Previously, the code that sets default tags on bank accounts was in l10n_de_reports, so was not yet loaded when the demo company is created at module init of l10n_de. As a result, the demo company was created without the necessary tags on the 1001 Cash and 1201 Bank accounts, which meant that the Balance Sheet would not be impacted by these accounts on the demo company. This commit fixes this. Community PR: https://github.com/odoo/odoo/pull/145013 taskid:none Forward-Port-Of: odoo/enterprise#52274 Forward-Port-Of: odoo/enterprise#52143
This fix resolves two critical issues when processing Mexican invoices with negative line items. The system was crashing when trying to generate tax documents (CFDI) and was incorrectly calculating discount distributions across invoice lines. The fix ensures negative amounts are properly distributed and tax calculations are accurate.
Original PR description
Steps to reproduce: - Install Accounting and l10n_mx_edi - Switch to a Mexican company (e.g. ESCUELA KEMPER URGATE) - Go to "Settings / Technical / Parameters / System Parameters" - Create this…
Steps to reproduce:
- Install Accounting and l10n_mx_edi
- Switch to a Mexican company (e.g. ESCUELA KEMPER URGATE)
- Go to "Settings / Technical / Parameters / System Parameters"
- Create this parameter:
* Key: l10n_mx_edi.manage_invoice_negative_lines
* Value: True
- Create an invoice:
* Customer: [a Mexican customer] (e.g. INMOBILIARIA CVA)
* Invoice Lines:
- Product: P1 - Price: 200 - Taxes: 16%
- Product: P2 - Price: 100 - Taxes: 16% - Product: Discount - Price: -201 (i.e. absolute value greater than 200) - Taxes: 16%
- Confirm the invoice
- Generate "CFDI" via "Send & Print" button => A KeyError ('tax') is raised.
Cause:
When there is a negative line, its amount is distributed as a discount between the other lines and the tax data are updated. During the process, if the amount to distribute is greater than the amount of the first line, a ratio is computed using the inexistant "tax" key.
Another issue:
The distribution ratio is wrongly computed, dividing [the amount to distribute] by [the remaining amount to distribute].
In our example, the amount to distribute for the first line is 200 and the remaining amount to distribute is 1, resulting on a ratio of (200 / 1) = 200, which is not correct.
The ratio should be computed with the total amount to distribute (i.e. 201). In our example, the ratio for the first line should be (200 / 201).
opw-3614319
Forward-Port-Of: odoo/enterprise#52064This update fixes visual alignment issues in the Planning and Sign applications where table cells were inconsistently aligned. The changes standardize the vertical alignment of list items and ensure icons display properly centered. Additionally, a missing stylesheet reference in the Sign module has been corrected to prevent compilation errors.
Original PR description
Prior to this commit some td in the list renderer were vertically align on the middle while other are aligned on top. This comes from commit: https://github.com/odoo/odoo/commit/53f605399755f9355554c2582ea0f693c8f947b4. This commit removes the vertical-align: middle to rely on the inherited alignment from the `<td>` which is inherited until the `<table>` el which set the alignment on `top`. This commit adapts the wrench icon in planning to be centered vertically with the new `$o-line-size` variable introduced in community. The new variable created a compilation error with the sign app because the `function.scss` file was not included in the assets of the module. task-3557566 Community PR: https://github.com/odoo/odoo/pull/138915 Forward-Port-Of: odoo/enterprise#49823
This fix resolves an issue where non-executive employees in Indian companies could not generate salary package offers because the required salary structure template was missing. The fix adds the necessary configuration data so that non-executive employees can now properly generate simulation links and salary offers, just like executive employees.
Original PR description
**Steps to reproduce:** --- - install hr_contract_salary, l10n_hr_in_payroll - switch to `IN Company` - Create Employee and Contract for the same Employee (set `Salary Structure Type` as `Non-Executive` - Click on `Generate Simulation Link` or `Generate Offer` (whichever is there) - Generate it then Get the Generated URL by clicking on `Configure you Package` **Issue:** --- For the Salary Structure Type as Non-Executive, there isn't any salary_packge template like Employee. **Cause:** --- The data for the Salary Structure Type "Non-Executive" was missing. **Fix:** --- Added the necessary data for the Salary Structure Type "Non-Executive." task-3493469 Forward-Port-Of: odoo/enterprise#52129 Forward-Port-Of: odoo/enterprise#50365