Monday, December 11, 2023
12 changes · 17.0
Enhancements to existing features
Excel report exports now include a new summary sheet that displays all active filters and options at the time of export. This improvement helps users better understand what data is included in their exported reports and makes it easier to track which filters were applied.
Original PR description
This commit adds a new sheet for xlsx report exports with a summary of all filters and options activated at the moment of the export. task-3508641
Resolved issues and error corrections
This fix resolves an error that occurred when grouping timesheets by "Billing Type" after installing the project timesheet forecast module. The issue was caused by how the system handled selection fields differently from other field types during grouping operations. The fix ensures proper handling of empty values in selection fields to prevent crashes.
Original PR description
Steps: - Install project_timesheet_forecast_sale. - Open timesheets module. - GroupBy `Billing Type`. Issue: - If project_timesheet_forecast_sale module is not installed and we groupBy `Billing Type` then it works but when this module is installed and then we try to groupBy `Billing Type`, a traceback appears. Cause: - `Billing Type` (timesheet_invoice_type) is a selection field and rest all groupBy are mostly many2one fields.So, when in selection field groupby value is not passed then `None` value is passed. Fix: - We are checking for valid condition,if there is no value then we are just passing None. Issue in this commit - [Link](https://github.com/odoo/enterprise/commit/da90f3b5c00ebbd61e9331d8c909191eb20eb8d7) task-3522253
This fix restores the 'Create Alternative' button that was missing from the upsell subscription feature. Users can now generate alternative subscription options when upselling, improving the flexibility of subscription management and enabling better customer options during the upsell process.
Original PR description
**Version:** - 17.0 **Steps to reproduce:** - create a new subscription - confirm the subscription - upsell the subscription, Create Alternative button is not available **Issue:** The upsell subscription does not have the 'Create Alternative' button. **Cause:** The upsell subscription does not have the 'Create Alternative' button because of the false invisible condition. **Solution:** We fixed the domain and made the 'Create Alternative' button available on the upsell subscription. task-3573486 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures that users without MRP access rights no longer see the Shop Floor menu icon in their interface. Previously, the Shop Floor icon remained visible even when users lacked the necessary permissions, which could cause confusion. The fix adds proper permission checks to hide this menu item from unauthorized users.
Original PR description
Steps to reproduce: - Install MRP - Remove MRP rights for a user - Login as user Issues: Shop floor icon is still shown even though we don't have the rights. Solution: Blacklisting root menu items was not possible, therefore a method was added to allow it. opw-3592620
This fix resolves an issue where users working with branch companies couldn't access parent company accounts during bank reconciliation operations. The system now properly allows branch company users to view and use accounts from the root company when performing manual or automatic reconciliation, improving workflow efficiency for multi-company setups.
Original PR description
Currently, when the current company is a branch of some of company and the user is in bank reconciliation manual operation or auto reconciliation wizard, The account_id field will not be able to access the account from the root company's accounts because of how the domain was previously set on them. This commit aims to fix that behavior and allow their account_id field to access the root company's account too. related community-PR: https://github.com/odoo/odoo/pull/140773 [task-id: 3549961](https://www.odoo.com/web#id=3549961&cids=1&menu_id=4720&action=333&active_id=967&model=project.task&view_type=form) Forward-Port-Of: odoo/enterprise#49456
Fixed an issue where the payment button was incorrectly disabled when customers had only one payment method available during subscription preview. The fix removes unnecessary form validation code that was preventing payment processing in this scenario, allowing customers to complete their subscription payments smoothly.
Original PR description
Issue: ====== When you go into subscription preview with only 1 payment method available, the pay button will be disabled and you can't enable it. Steps to reproduce the isssue: ============================== - Make sure only 1 payment method available (demo) - Create a subscription and make in into `to_invoice` status - Go to preview Origin of the issue: ==================== There is an extra payment_form which was used in set payment method or , manage payment methods. In 17.0, we redirect the user when clicking on the button so we don't need that form anymore. opw-3626037
This fix prevents users from creating new tasks in the timesheet timer when no project has been selected. Previously, tasks could be created and would incorrectly appear under a 'Private' project. The system now requires a valid project to be selected before allowing task creation, ensuring better data integrity and preventing orphaned tasks.
Original PR description
Steps: - Open timesheet - Click the start button - In the task field, enter the non-existing task name - Select 'Create and Edit' Issue: - If we haven't selected any project and directly try to create a new task, the project shown is 'Private'. Cause: - The newly created task doesn't belong to any project. The project id is not found. Fix: - Apply the 'task_with_hours' widget, so that if the project id is not found then it doesn't allow the user to create a new task. task-3378532 Forward-Port-Of: odoo/enterprise#52495 Forward-Port-Of: odoo/enterprise#42971
Fixed a bug in the Chilean electronic invoicing system where the document lookup process was failing when the most recent journal entry was a generic entry rather than a properly formatted invoice. This ensures that financial documents can be correctly identified and processed regardless of the type of the latest entry in the system.
Original PR description
Currently, when trying to find an `account.move` from a document number, we get the padding used on the latest `account.move` and use it, along with the document type (and the document number) to reconstruct a move's name. However, the latest `account.move` could end up being a generic journal entry, making the whole process fail. opw-3490343 Forward-Port-Of: odoo/enterprise#52483 Forward-Port-Of: odoo/enterprise#51680
A bug in the automatic invoice status update process for Mexican tax authorities (SAT) has been fixed. The scheduled action was failing with an error when customers tried to run it. This fix ensures the automatic status updates work correctly without interruption.
Original PR description
An error occurs when the customer runs the scheduled action `Automatic update of state on the SAT (for invoices)`. This is because `self.env.ref` is used instead of `self.env` for calling reference…
An error occurs when the customer runs the scheduled action `Automatic update of state on the SAT (for invoices)`. This is because `self.env.ref` is used instead of `self.env` for calling reference see below.
https://github.com/odoo/enterprise/blob/5ff3da3e5f267b69f7dd32261c5d2426ca327548/l10n_mx_edi/models/l10n_mx_edi_document.py#L2168
sentry traceback-
```
AttributeError: 'str' object has no attribute 'transaction'
File "odoo/tools/safe_eval.py", line 365, in safe_eval
return unsafe_eval(c, globals_dict, locals_dict)
File "ir.actions.server(333,)", line 1, in <module>
File "home/odoo/src/enterprise/17.0/l10n_mx_edi/models/l10n_mx_edi_document.py", line 2163, in _fetch_and_update_sat_status
self.env('l10n_mx_edi.ir_cron_update_pac_status_invoice')._trigger()
File "odoo/api.py", line 562, in __call__
return Environment(cr, uid, context, su)
File "odoo/api.py", line 494, in __new__
transaction = cr.transaction
ValueError: <class 'AttributeError'>: "'str' object has no attribute 'transaction'" while evaluating
"env['l10n_mx_edi.document']._fetch_and_update_sat_status()"
File "odoo/addons/base/models/ir_cron.py", line 377, in _callback
self.env['ir.actions.server'].browse(server_action_id).run()
File "home/odoo/src/custom/trial/saas_trial/models/sentry.py", line 33, in run
res = super().run()
File "odoo/addons/base/models/ir_actions.py", line 932, in run
res = runner(run_self, eval_context=eval_context)
File "odoo/addons/base/models/ir_actions.py", line 764, in _run_action_code_multi
safe_eval(self.code.strip(), eval_context, mode="exec", nocopy=True, filename=str(self)) # nocopy allows to return 'action'
File "odoo/tools/safe_eval.py", line 379, in safe_eval
raise ValueError('%s: "%s" while evaluating\n%r' % (ustr(type(e)), ustr(e), expr))
```
This commit fixes the above issue by calling reference with `self.env.ref` instead of `self.env`.
sentry-4707826242
Forward-Port-Of: odoo/enterprise#52375This update fixes three issues with deferred accounting entries: it resolves rounding errors that prevented users from creating deferral entries, adds a new "Not Started" column to the Deferred Report to help identify amounts not yet active in the reporting period, and ensures deferred start dates are properly recalculated when editing posted transactions. These changes improve the reliability and usability of the deferred accounting workflow.
Original PR description
### [FIX] account_reports: unbalanced deferral due to rounding When creating a deferral entry in the "Manual & Grouped" mode, we might have a tiny rounding error on the final move, resulting in a…
### [FIX] account_reports: unbalanced deferral due to rounding
When creating a deferral entry in the "Manual & Grouped" mode, we might have a tiny rounding error on the final move, resulting in a user error because of an unbalanced move. That way the user is blocked from generating the deferral entry.
We now check before creating the deferral move whether the move is balanced. If there is a tiny difference, we adjust the balance account accordingly.
### [IMP] account_{accountant,reports}: add 'Not Started' column
For specific use-cases it is useful to know which amounts to be deferred have not started yet in or before the report's period.
For that reason we added an extra column 'Not Started' to the Deferred Report so it can be used to make manual accounting adjustments.
### [FIX] account_accountant: compute empty deferred start date on post
Currently when you edit a posted move and remove the deferred start date on a line, it won't be recomputed when posting again.
However we can not have a deferred end date without a deferred start date. That's why we also compute the deferred start date when the state of the move changes.
task-3624148
Forward-Port-Of: odoo/enterprise#52474
Forward-Port-Of: odoo/enterprise#52252This fix resolves an issue where bookmarked menu links were not working correctly from the home page. When users returned to the home page and clicked a bookmark to a different application, the system would incorrectly display the previously visited application instead. Now bookmarked links work as expected, allowing users to navigate directly to the correct application from the home page.
Original PR description
Before this commit, from the home menu, if the menu_id in the url is modified, it is ignored and replaced by the menu_id of the last application visited.
How to reproduce:
- Go to the home menu
- Go to application A
- Return to the home menu
- Modify the url by adding the menu_id of application B
Before this commit:
The menu_id of app B is ignored and replaced by that of app A. App A is displayed
After this commit:
The menu_id of app B is still present. App B is displayed
Steps to reproduce the bug:
- Go to Point of Sale
- Add a bookmark
- Go back to the home page
- Go to Contacts
- Go back to the home page
- Open the bookmark -> The control panel is still the contact one
opw-3595281
Bug introduce by: https://github.com/odoo/odoo/pull/124068
Forward-Port-Of: odoo/enterprise#52382This update improves error messages in the online bank synchronization feature to prevent users from accidentally creating multiple support tickets for the same issue. When an error occurs during bank account synchronization, users will now see clearer messaging that helps them understand the problem without needing to contact support multiple times.
Original PR description
…ltiple ticket creation Forward-Port-Of: odoo/enterprise#52320 Forward-Port-Of: odoo/enterprise#52008