Tuesday, December 12, 2023
22 changes · 17.0
Resolved issues and error corrections
This fixes an internal test that could fail when Colombian localization was enabled because the sample import used a record type with extra required information. The test now uses a safer model, helping keep automated validation stable without changing user-facing behavior.
Original PR description
The test tries to import data from an sql file. The problem is that it is trying to import partners, but when the test is ran with the l10n_co localization, one of the required field is not filled. We just change the model to import to avoid the issue with the missing required field. Linked to runbot error 32740, 32742, 32745, 32738 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes an issue in the Website page properties screen where clicking a dependency link could crash instead of showing more details. This restores the expected tooltip behavior, helping editors safely review page URL changes and related dependencies.
Original PR description
See commit [1] for in-depth explanation and framework-js change but basically, `renderToElement` do not allow multiple root nodes since [2]. The fix is just about using the correct method to render multiple root nodes. Without the fix, it just crashed when you click on the page dependencies links. Step to reproduce: - Go to / - Open Page Properties - Edit / to /test - A list of possible dependencies will be shown, it's a link that can be clicked to open a tooltip to have more details - Clicking on it crash without this commit [1]: https://github.com/odoo/odoo/commit/2cff7e4094ebb4b56ab17a1462ff358b4b3e7ffd [2]: https://github.com/odoo/odoo/commit/6303a3eacdca012649a2ffda627b65c17a7217f1
This fix restores the original Spanish names for Ecuador partner records used in official electronic documents. Keeping these names aligned with VAT/RUC records helps avoid validation mismatches when submitting required XML files.
Original PR description
As we send the name of those partners in the XML for the EDI and in the XML and the correspondance of that name with the VAT number (RUC) is checked, we need to keep the original name. See https://github.com/odoo/odoo/commit/10f9460d2b744a2a135969cd6703f89a3439b923#diff-c58ef9acd83f5647980e035ced040bd699ad3fdaf9a150ca48c4db7a95e86e5aR5 Also translating partners does not make any sense as the field is not translatable. See issue https://github.com/odoo/odoo/issues/145698 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents an error dialog from appearing when an Odoo website using the Events Tracks feature is opened over plain HTTP. It improves the visitor experience in test or non-secure environments where browser service workers are unavailable.
Original PR description
Description of the issue/feature this PR addresses: Website with "website_event_track" addon when test with plain HTTP cause UncaughtPromiseError (#140518) Steps to reproduce: Install Odoo CE with…
Description of the issue/feature this PR addresses:
Website with "website_event_track" addon when test with plain HTTP cause UncaughtPromiseError (#140518)
Steps to reproduce:
Install Odoo CE with "website_event_track" addon installed.
Browse the website with plain HTTP protocol
There will be "Odoo Client Error" dialog with "UncaughtPromiseError - Uncaught Promise > translationerror"
Current behavior before PR:
There is UncaughtPromiseError
Desired behavior after PR is merged:
There is no UncaughtPromiseError
The error is caused by Promise with unhandled rejection in
[odoo/addons/website_event_track/static/src/js/website_event_pwa_widget.js](https://github.com/odoo/odoo/blob/17.0/addons/website_event_track/static/src/js/website_event_pwa_widget.js#L8)
When test with plain HTTP, the "serviceWorker" won't be available
https://developer.mozilla.org/en-US/docs/Web/API/Service_Worker_API
> Service workers only run over HTTPS, for security reasons. Most significantly, HTTP connections are susceptible to malicious code injection by [man in the middle](https://developer.mozilla.org/en-US/docs/Glossary/MitM) attacks
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prProblem --------- Currently, only the ES language has UNSPSC code translation. Objective --------- Make the spanish translation available for columbian, mexican, etc. spanish variant. Solution --------- Add an .po named es_419 that will be used by all the spanish variant. opw-3627465
Original PR description
Problem --------- Currently, only the ES language has UNSPSC code translation. Objective --------- Make the spanish translation available for columbian, mexican, etc. spanish variant. Solution --------- Add an .po named es_419 that will be used by all the spanish variant. opw-3627465
This update corrects the button display in the consolidation grid view when editing consolidations. The 'Add a column' button now appears when needed, and the 'Consolidation balance' button has been removed from the editing interface where it was not required. These changes improve the user experience by ensuring only relevant actions are available during consolidation editing.
Original PR description
The 'Add a column' button was missing when editing a consolidation. The 'Consolidation balance' button was not needed when editing a consolidation. opw-3587724 Forward-Port-Of: odoo/enterprise#51398
This update fixes a display issue in the Employee module where text in the planning statistics button was being cut off at the bottom. The fix applies styling adjustments to ensure all text displays properly without clipping, improving the user experience when viewing employee planning information.
Original PR description
Description of the issue/feature this PR addresses: In the Employee module's view, the text in the planning stat button is being clipped from the bottom. Fix: This PR introduces styling adjustments to prevent the text from being clipped. task:3468392 Forward-Port-Of: odoo/enterprise#46767
This update corrects the display order of fields in the project task list view. Previously, the start date was appearing before the task name due to a duplicate field reference in the view configuration. The fix removes the duplication and ensures fields display in the correct sequence, improving the user experience when viewing project tasks.
Original PR description
The issue of the start date appearing before the task name in the project task list view is caused by a duplication of the company_id in the list view definition so changed the xpath reference to company_id to user_ids task-3468392 Forward-Port-Of: odoo/enterprise#47401
Miscellaneous changes
Steps: - Install `contacts` and `l10n_se` - Open swedish contact in `contacts` Address are in this format ``` {street} {street2} {city} {state_code} {zip} {country_name} ``` instead of ``` {street} {street2} {zip} {city} {country_name} ``` opw-3393569 Forward-Port-Of: odoo/odoo#142051 Forward-Port-Of: odoo/odoo#131070
Original PR description
Steps:
- Install `contacts` and `l10n_se`
- Open swedish contact in `contacts`
Address are in this format
```
{street}
{street2}
{city} {state_code} {zip}
{country_name}
```
instead of
```
{street}
{street2}
{zip} {city}
{country_name}
```
opw-3393569
Forward-Port-Of: odoo/odoo#142051
Forward-Port-Of: odoo/odoo#131070When using a loyalty program reward with a discount on a specific product category in PoS, it was not being applied correctly. The reward contained a discount_product_domain with the category ids. However in PoS the many2one fields are replaced with the corresponding values https://github.com/odoo/odoo/commit/e7632a3bcfa60fa416fff5e2e9daaf2571c5f7f1. To fix this, I replace the ids in the discount_product_domain with the category name values before sending to the PoS. opw-3502703 ---
Original PR description
When using a loyalty program reward with a discount on a specific product category in PoS, it was not being applied correctly. The reward contained a discount_product_domain with the category ids. However in PoS the many2one fields are replaced with the corresponding values https://github.com/odoo/odoo/commit/e7632a3bcfa60fa416fff5e2e9daaf2571c5f7f1. To fix this, I replace the ids in the discount_product_domain with the category name values before sending to the PoS. opw-3502703 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#144870 Forward-Port-Of: odoo/odoo#135868
The "Scan your badge" login option was not working properly when trying to log in to the POS shop. The barcode scanner styles were missing which caused the issue. enterprise PR: https://github.com/odoo/enterprise/pull/51651 opw-3608077 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#143955
Original PR description
The "Scan your badge" login option was not working properly when trying to log in to the POS shop. The barcode scanner styles were missing which caused the issue. enterprise PR: https://github.com/odoo/enterprise/pull/51651 opw-3608077 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#143955
Current behavior: Firefox customer display was not correctly loading the CSS and the display was not correct. Steps to reproduce: - Setup an IoT box with a customer display - Open the IoT box customer display in Firefox - Link the customer display to a POS - Open the POS and add some products to the order - The customer display is not correctly displayed opw-3509606 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#
Original PR description
Current behavior: Firefox customer display was not correctly loading the CSS and the display was not correct. Steps to reproduce: - Setup an IoT box with a customer display - Open the IoT box customer display in Firefox - Link the customer display to a POS - Open the POS and add some products to the order - The customer display is not correctly displayed opw-3509606 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#145773 Forward-Port-Of: odoo/odoo#145441
This commit simply replaces the shortcut for the action_done_schedule_next buttons from alt+q to alt+z in the activity view dialog because the alt+q shortcut is already used for the Save/Schedule buttons. This overlap was introduced by mistake in https://github.com/odoo/odoo/commit/6c412be2ea7c0fb64677152db753a1007934f892 opw-3565747 Forward-Port-Of: odoo/odoo#145738
Original PR description
This commit simply replaces the shortcut for the action_done_schedule_next buttons from alt+q to alt+z in the activity view dialog because the alt+q shortcut is already used for the Save/Schedule buttons. This overlap was introduced by mistake in https://github.com/odoo/odoo/commit/6c412be2ea7c0fb64677152db753a1007934f892 opw-3565747 Forward-Port-Of: odoo/odoo#145738
Before this commit, the default picture (when no picture is set to a product) has been changed for `product.template` but not for `product.product` in commit 0625434 This commit also applies the changes in `product.product` to have the same default picture than `product.template` when there is no picture set on the product. task-3484150 Forward-Port-Of: odoo/odoo#134452
Original PR description
Before this commit, the default picture (when no picture is set to a product) has been changed for `product.template` but not for `product.product` in commit 0625434 This commit also applies the changes in `product.product` to have the same default picture than `product.template` when there is no picture set on the product. task-3484150 Forward-Port-Of: odoo/odoo#134452
To reproduce ============ - go on any record with list view (for example a Quotation) - Check many hidden fields in the list view to show them - The dialogue box for checking and unchecking hidden fields moves with the horizontal scrollbar, sometimes even going off screen. Problem ======= the position of the dropdown menu is computed using the position of the toggler butoon, so if this button moves the menu moves with it Solution ======== make the toggler button sticky so it's alwa
Original PR description
To reproduce ============ - go on any record with list view (for example a Quotation) - Check many hidden fields in the list view to show them - The dialogue box for checking and unchecking hidden fields moves with the horizontal scrollbar, sometimes even going off screen. Problem ======= the position of the dropdown menu is computed using the position of the toggler butoon, so if this button moves the menu moves with it Solution ======== make the toggler button sticky so it's always visible and the dropdown menu will keep same position. opw-3589726 Forward-Port-Of: odoo/odoo#144368
Steps to reproduce: - Make an invoice and setup the layout of the document - A preview will be displayed - Make the invoice and download it Issues: The layout of the preview and the invoice doesn't match the updated layout from https://github.com/odoo/odoo/commit/3764914c8616bf59d299e6279cc6fc93321cdacb. Solution: Correct the view of the report templates. opw-3584286 Forward-Port-Of: odoo/odoo#142837
Original PR description
Steps to reproduce: - Make an invoice and setup the layout of the document - A preview will be displayed - Make the invoice and download it Issues: The layout of the preview and the invoice doesn't match the updated layout from https://github.com/odoo/odoo/commit/3764914c8616bf59d299e6279cc6fc93321cdacb. Solution: Correct the view of the report templates. opw-3584286 Forward-Port-Of: odoo/odoo#142837
Current behaviour: --- When removing the ribbon from a product, the other ribbons are removed as well. Steps to reproduce: --- 1. Go to website 2. Go to Shop 3. Click on Edit (top right) 4. Add a ribbon to multiple products 5. Click on Save 6. Select a product with a ribbon 7. Remove the ribbon 8. (other ribbons are gone) Cause of the issue: --- Reverting fix introduced by https://github.com/odoo/odoo/commit/5d13fa522e7d06b03a098ada5fa6be15ddc49618 t-out was modified into t-
Original PR description
Current behaviour: --- When removing the ribbon from a product, the other ribbons are removed as well. Steps to reproduce: --- 1. Go to website 2. Go to Shop 3. Click on Edit (top right) 4. Add a ribbon to multiple products 5. Click on Save 6. Select a product with a ribbon 7. Remove the ribbon 8. (other ribbons are gone) Cause of the issue: --- Reverting fix introduced by https://github.com/odoo/odoo/commit/5d13fa522e7d06b03a098ada5fa6be15ddc49618 t-out was modified into t-field to be considered dirty when modified. but when removing a ribbon, t-field is set as empty, which overwrites ribbons html value. opw-3487397 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#135908
### Steps to reproduce: - Install **Accounting** app - Go to the Accounting app - Go to **Configuration** > **Chart of Accounts** and create a New account with a name containing **%** - Go to **Accounting** > **Journal Items** - Select a Journal item and from **Actions**, choose **Move to Account** - In the popup displayed, choose the new account created earlier in the To field, and choose a Journal - Click **Create Journal Entries**, an error arises ### Investigation: When the `accou
Original PR description
### Steps to reproduce: - Install **Accounting** app - Go to the Accounting app - Go to **Configuration** > **Chart of Accounts** and create a New account with a name containing **%** - Go to…
### Steps to reproduce:
- Install **Accounting** app
- Go to the Accounting app
- Go to **Configuration** > **Chart of Accounts** and create a New account with a name containing **%**
- Go to **Accounting** > **Journal Items**
- Select a Journal item and from **Actions**, choose **Move to Account**
- In the popup displayed, choose the new account created earlier in the To field, and choose a Journal
- Click **Create Journal Entries**, an error arises
### Investigation:
When the `account_target_name` contains a % literal (ex. "test %"), the `transfer_format` becomes `"{amount} ({debit_credit}) from %s were transferred to <strong>test %</strong> by {link}"` https://github.com/odoo/odoo/blob/8368056d5c98283ef225fc2006ef430c627d74c7/addons/account/wizard/account_automatic_entry_wizard.py#L466-L468
U can notice that now the string has two % placeholders that need two be substituted, but only argument is provided which is `Markup("<strong>%s</strong>") % account.display_name` and so we get a the error `TypeError: not enough arguments for format string` https://github.com/odoo/odoo/blob/8368056d5c98283ef225fc2006ef430c627d74c7/addons/account/wizard/account_automatic_entry_wizard.py#L472
opw-3601886
Forward-Port-Of: odoo/odoo#145097
Forward-Port-Of: odoo/odoo#144146**Steps to reproduce the issue:** - First of all, you can create a multi-company environment and generate different analytic plans for each company, assigning parent and child relationships between them. - Once this is done when trying to create a project with only one of the companies and a timesheet, it results in an Access Error. **Cause:** - After getting the first step try to create a project using the previously created analytic plan, while now you do not have access to that comp
Original PR description
**Steps to reproduce the issue:** - First of all, you can create a multi-company environment and generate different analytic plans for each company, assigning parent and child relationships between them. - Once this is done when trying to create a project with only one of the companies and a timesheet, it results in an Access Error. **Cause:** - After getting the first step try to create a project using the previously created analytic plan, while now you do not have access to that company its generating access error **Fix:** - To fix the issue, _check_company_auto = True is set on the class, and assign check_company=True as an attribute to the parent_id field. task-3247213 Forward-Port-Of: odoo/odoo#145741 Forward-Port-Of: odoo/odoo#118142
Description of the issue/feature this PR addresses: Current behavior before PR: This link fail: https://54898231-master-all.runbot133.odoo.com/slides/slide/main-trees-categories-17 Desired behavior after PR is merged: It should not fail. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: This link fail: https://54898231-master-all.runbot133.odoo.com/slides/slide/main-trees-categories-17 Desired behavior after PR is merged: It should not fail. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
### Steps to reproduce: - install the e-commerce module - in General settings, add and switch French -or any- language - Go to website - Under `e-commerce > products` in the menu bar - click on any product - click on go to website smart button - click on edit button to edit the website page - choose any block to insert, You can notice the message **DROP BUILDING BLOCKS HERE TO MAKE THEM AVAILABLE ACROSS ALL PRODUCTS** stays in English ### Investigation - The message is not add to `we
Original PR description
### Steps to reproduce: - install the e-commerce module - in General settings, add and switch French -or any- language - Go to website - Under `e-commerce > products` in the menu bar - click on any product - click on go to website smart button - click on edit button to edit the website page - choose any block to insert, You can notice the message **DROP BUILDING BLOCKS HERE TO MAKE THEM AVAILABLE ACROSS ALL PRODUCTS** stays in English ### Investigation - The message is not add to `website_sale.pot` file, as the message string passed to an attribute not an actual string inside a tag. opw-3573881 Forward-Port-Of: odoo/odoo#145466 Forward-Port-Of: odoo/odoo#142140
This change is necessary because options['columns'] already repeat the columns accordingly depending on the column group so multiplying by the length of the column group is wrong. Just taking the length of the options columns is enough to know if we have to be in landscape or not. task: no task related Forward-Port-Of: odoo/enterprise#52209 Forward-Port-Of: odoo/enterprise#51936
Original PR description
This change is necessary because options['columns'] already repeat the columns accordingly depending on the column group so multiplying by the length of the column group is wrong. Just taking the length of the options columns is enough to know if we have to be in landscape or not. task: no task related Forward-Port-Of: odoo/enterprise#52209 Forward-Port-Of: odoo/enterprise#51936