Wednesday, December 13, 2023
10 changes · 17.0
Resolved issues and error corrections
This fix removes an overly short survey test step that could end before the system was fully ready, causing occasional automated test failures. Survey session setup is now handled directly in test code, improving reliability without changing the user-facing survey experience.
Original PR description
This commit fixes a nondeterministic runbot issue during the survey session management tour suite (that actually contains multiple tours).
It turns out that the first tour is so short that it does not let enough time to the web framework to correctly initialize everything before it gets killed (as the tour steps are completed almost instantly).
It's hard to say exactly where the issue comes from, as the error does not mention anything (we only know that it's a rejected promise): """
Error received after termination:
PromiseRejectionEvent(
isTrusted=true,
reason=Event,
type='unhandledrejection',
target=Window,
currentTarget=Window)"
"""
Removing this first tour also removes the nondeterministic issue.
It seems like an acceptable compromise as this tour was not really testing anything anyway, we now directly start the session from the python code.
(Note: this issue only started occurring in v17).
Task-3637591Fixes the event registration confirmation email preview so the QR code displays as a proper square instead of appearing compressed. This helps attendees and staff scan registration QR codes reliably from event emails.
Original PR description
Current behaviour: --- QR code is squished, it's 77x21 px Expected behaviour: --- QR code should be 100x100 px Steps to reproduce: --- 1. Go Email Templates 2. Find 'Event: Registration Confirmation' 3. Click on preview 4. QR code is squished opw-3625701 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes an issue where portal breadcrumbs could show the same page title twice after installing subcontracting-related modules. This keeps customer-facing navigation clearer across pages like projects, tasks, timesheets, and tickets.
Original PR description
…cts' twice Steps to Reproduce: - install service apps and website - install website related bridge modules - install quality and related mrp_subcontracting bridge module - click on website , click on My account - click on project ,or timesheet,or tasks,or tickets Issue: - after clicking,we will notice that breadcrumb indicates 'title' twice Cause: - this is because,in mrp_subcontracting , the title for productions is given without checking the page_name , so that will affect all the titles. Solution: - if we gave condition to check the page name for production this issue is solved. task-3607053 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The project update view now counts the relevant sale order item correctly for billable projects. This helps users trust the stat button total and open the expected sale order item without seeing misleading counts.
Original PR description
In the project update view, the sale order items stat button does not display the right count of item. This is because sale order lines are not taken into account for the stat button To reproduce: - Install sale_project - Create a billable project with a customer - Open the project update view and add some sol. - The stat button count should display `1` and when opened, it should only display the `project.project.sale_line_id` task-3573591 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change reverses a previous adjustment to project views that could break existing customizations and cause installation errors for related field service functionality. It preserves compatibility for customers already using the stable version, reducing the risk of disruption during installs or upgrades.
Original PR description
Revert [1] Changing `t` into `span` is not allowed in stable, in case some customization already exist and have xpath that target `t`. The change OE side [2] is problematic too: if a DB has the old XML version (`t`) and the user tries to install `industry_fsm`, an error will be raised: `Element '<xpath expr="//span[@t-if=&https://github.com/odoo/odoo/issues/39;record.partner_id.value&https://github.com/odoo/odoo/issues/39;]">'` `cannot be located in parent view` [1] https://github.com/odoo/odoo/commit/b3e3c92b52ce326661c262046cc455c3439fa1a1 [2] https://github.com/odoo/enterprise/commit/094009669beaac46ed6ebb7689ecffea59c375ae OPW-3629163 sentry-4700256130
This fixes a display issue in the restaurant point-of-sale screen where category counts could fail to show correctly. It ensures the interface can reliably render the category list, reducing confusion for restaurant staff during ordering.
Original PR description
In the commit 7675905 a t-for loop was introduced in the `ActionpadWidget` override from `pos_restaurant` where the t-key value was undefined. This commit fixes the issue by giving a proper value to the t-key. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The date and time picker now correctly detects when a selected value has not changed, preventing unnecessary update actions. This reduces avoidable processing and helps keep user interactions smoother and more predictable.
Original PR description
### [FIX] web: do not apply same datetime picker value
Before this commit, the equality check performed by the datetime service
relied on a JSON-strigified version of the value on one end, and on an
array of ISO strings on the other end. This meant that the value was
never equal to itself and that the `onApply` callback would be called
even if the value remained unchanged.
This commit fixes that by ensuring that the compared values have the
same shape.
### [REF] web: add missing types for datetime hook & service
This commit adds missing type definitions for both the datetime picker
hook and service.
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis update fixes a missing translation in the website shop so customers can see the intended localized text. It helps provide a more consistent shopping experience for visitors using translated versions of the site.
Original PR description
--- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update corrects the abnormal spacing between the 'New' and 'Validate' buttons in the Timesheet to Validate Kanban view. The fix removes an unnecessary spacing property that was left over from a previous version, resulting in a cleaner and more consistent button layout.
Original PR description
**Steps:** - Open Timesheet > Timesheet to Validate - Switch to the Kanban View **Issue:** - Abnormal spacing between the buttons 'New' and 'Validate' **Cause:** - The button 'Validate' is given the property ms-2 which was appropriate for the older version, but it won't be needed in the new code as gap-1 is given. **Fix:** - Removing ms-2 class from the Validate button **Task:** 3394985 Forward-Port-Of: odoo/enterprise#43583
The accounting dashboard was displaying two reconcile buttons for cash journals that needed reconciliation. This fix removes the duplicate button so only one appears, resolving a display issue that resulted from an earlier update that should have been limited to older versions.
Original PR description
Description of the issue/behavior this commit fixes: On the accounting dashboard, when at least one items is to be reconciled on a cash journal, the box of that journal shows two reconcile buttons. This behavior comes from opw-3384351 which was targetting 16.2 and was fw to master while it should have stopped at 16.3. From 16.4, the reconcile button is managed for cash journals. --- Desired behavior after this commit is merged: This commit reverses the problematic fix as from 16.4. With this commit, only one button shows up at any time. --- task-3624210 Forward-Port-Of: odoo/enterprise#52241