Monday, December 18, 2023
2 changes · 17.0
Resolved issues and error corrections
This fix addresses an issue where subscription payments fail silently without notifying customers. When a payment token is invalid (expired, insufficient limits, or bad data), the system now properly handles the failure and sends notifications to customers instead of leaving transactions in draft state without any communication.
Original PR description
Steps: - Install a payment provider and subscription. - Create a subscription. - Set token on it which has max amount less then amount or expiry in the past or something that in invalid data to create order from provider. Issue: - As we are committing transaction in subscription and it does not processed it stays in draft state also it subscription does not send any failure notification to the customer Cause: - When `_send_payment_request` try to create order or try to create make request for recurring transaction it raise error in logger as values to make requests are invalid but it keeps transition in draft state and do not notify customer about payment failure Fix: WIP This does not seems to write fix for tokenize transaction
This update corrects balance sheet calculations for Romanian companies, fixing issues in both standard and IFRS balance sheets. The changes ensure accurate financial reporting by properly referencing accounts and adjusting how earnings are calculated, which is critical for companies to have correct financial statements.
Original PR description
In Romania, there are two balance sheets: one for general companies and one for companies applying IFRS. This commit aims to fix both. #### 1. Balancing the general balance sheet According to the…
In Romania, there are two balance sheets: one for general companies and one for companies applying IFRS. This commit aims to fix both. #### 1. Balancing the general balance sheet According to the Balance Sheet diagnosis tool in https://github.com/odoo/enterprise/pull/36838, some accounts were not referenced correctly. This is now fixed. We also re-do the Retained Earnings / Current Year Earnings with cross-reports to the P&L. #### 2. Balancing the IFRS balance sheet In addition to the issues encountered with the general balance sheet, the IFRS balance sheet also suffered from the problem that officially it should be used with a CoA dedicated for IFRS, which does not contain some of the accounts of the general CoA. Our solution is to nevertheless add those accounts to the Balance Sheet in appropriate locations. #### 3. Refactor the reports to use 1234D/1234C account code notation When the Romanian reports were first written, we thought that certain lines needed to contain a sum of debits or a sum of credits of AMLs of certain accounts. However, it is now certain that what was intended was the credit or debit balance of those accounts. We therefore remove the domain_formula expressions and replace them with account_codes_formula expressions. #### 4. Adapt the l10n_ro_saft tests to the CoA changes in the community PR Community PR: https://github.com/odoo/odoo/pull/145947 taskid: 3634044 Forward-Port-Of: odoo/enterprise#52823 Forward-Port-Of: odoo/enterprise#52603