Wednesday, December 20, 2023
10 changes · 17.0
Resolved issues and error corrections
The cart now shows the product reference price based on the unit price rather than the full line total. This prevents misleading price information when customers buy multiple quantities of the same product.
Original PR description
Before this commit, the product reference price was computed based on the total amount and not on the unit price. Now, the product reference price is computed based on the quotient of the total amount by the quantity.
This update fixes an internal automated test related to mail channel invitations. It helps prevent occasional false failures in the testing system, supporting more reliable development and releases without changing user-facing behavior.
Original PR description
This PR fixes a test that ensures the bus subscriptions are updated when a member is invited to a channel. This test waits some time before checking if the subscription is done. Sometimes, a tick is not enough and the test fails. This PR adds a deferred that resolves when the subscription is done that can be awaited to ensure the timing is always right. fixes runbot-46941
New live chats no longer trigger an unnecessary message-loading request immediately after creation. This reduces avoidable server calls and helps the live chat experience start more efficiently without changing visible behavior for users.
Original PR description
When a live chat is created on the server, the `/mail/thread/messages` route is called. This is not required since we know for a fact the thread was just created. This PR prevent this useless request. task-3646201
This update corrects wording in stock and manufacturing screens so users see clearer labels for where items are picked from and stored to. It also adjusts the byproduct list view to show the destination location, helping warehouse and manufacturing teams avoid confusion during operations.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents an error when users remove the starting or ending value while editing account groups in Accounting. It makes the form handle empty range fields correctly, so users can continue creating or updating account groups without interruption.
Original PR description
This traceback arises when the user removes the `from` or `to` values. To reproduce this traceback: 1) Install `account_accountant` and make sure the debugger mode is on 2) Open…
This traceback arises when the user removes the `from` or `to` values.
To reproduce this traceback:
1) Install `account_accountant` and make sure the debugger mode is on
2) Open `Accounting/Configuration/Account Groups`
3) Create a new record
4) Give the `from` value and then remove the `to` value
Error:-
```
TypeError: '>' not supported between instances of 'str' and 'bool'
File "odoo/http.py", line 2157, in __call__
response = request._serve_db()
File "odoo/http.py", line 1732, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "odoo/service/model.py", line 133, in retrying
result = func()
File "odoo/http.py", line 1759, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 1960, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 207, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 722, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "addons/web/controllers/dataset.py", line 24, in call_kw
return self._call_kw(model, method, args, kwargs)
File "addons/web/controllers/dataset.py", line 20, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "odoo/api.py", line 466, in call_kw
result = _call_kw_multi(method, model, args, kwargs)
File "odoo/api.py", line 453, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "addons/web/models/models.py", line 1069, in onchange
todo = [
File "addons/web/models/models.py", line 1072, in <listcomp>
if field_name not in done and snapshot0.has_changed(field_name)
File "addons/web/models/models.py", line 1185, in has_changed
return self[field_name] != self.record[field_name]
File "odoo/models.py", line 6584, in __getitem__
return self._fields[key].__get__(self, type(self))
File "odoo/fields.py", line 1151, in __get__
self.recompute(record)
File "odoo/fields.py", line 1366, in recompute
apply_except_missing(self.compute_value, recs)
File "odoo/fields.py", line 1339, in apply_except_missing
func(records)
File "odoo/fields.py", line 1388, in compute_value
records._compute_field_value(self)
File "odoo/models.py", line 4858, in _compute_field_value
fields.determine(field.compute, self)
File "odoo/fields.py", line 101, in determine
return needle(*args)
File "addons/account/models/account_account.py", line 841, in _compute_code_prefix_start
if not group.code_prefix_start or group.code_prefix_start > group.code_prefix_end:
```
When removing the `to` value `code_prefix_end` will be False.
It leads to the above traceback from here.
https://github.com/odoo/odoo/blob/230b680bf92583c9f5e4a3739be1d8602df44331/addons/account/models/account_account.py#L838-L842
sentry-4715927815Users can now edit existing labels in the Documents app without seeing an error. The fix opens the correct editing screen, helping teams maintain their document organization labels smoothly.
Original PR description
Steps to reproduce: - Install the documents app - Open it - Try to edit an existing label Issues: An error is displayed, and you cannot edit the label. Solution: Open the correct view for the model. opw-3637418
This fix improves error messages in the Knowledge module by displaying the article name when users encounter issues while moving articles. Previously, error messages were incomplete and didn't show which article caused the problem, making it harder for users to identify and resolve issues.
Original PR description
Some error message parameters were missing for the `move_to` operation, preventing the user from seeing the article name related to the erroneous operation. task-3640010 Forward-Port-Of: odoo/enterprise#52979 Forward-Port-Of: odoo/enterprise#52761
This update corrects how salary offers are displayed in the system. Previously, the offer display was showing the validity date, which was confusing. Now it correctly shows the creation date of the offer, making it clearer when the offer was actually created and sent to employees.
Original PR description
Currently, when sending an offer the display name of the offer uses the validity date of the offer instead of the create date. This commit fixes this as displaying the validity date does not make sense. task-3619108 Forward-Port-Of: odoo/enterprise#51959
This update resolves an issue where the self-assignment button was appearing twice in the Planning schedule form. The fix removes unnecessary user group restrictions on the button and ensures it properly respects visibility settings, providing a cleaner user interface.
Original PR description
Before this PR, header button for self assigning display twice inside the planning.slot form view. In this PR, fixes the issue by removing user group access on the button. as well as button get invisible on 'invisible' attribute condition and ignore 'attrs' conditions. task-3475975 Forward-Port-Of: odoo/enterprise#46462
This update removes unwanted extra spacing that was appearing in warning messages displayed during barcode scanning operations. The issue was caused by formatting characters in the message text and has been corrected to improve the visual presentation of these important user notifications.
Original PR description
Extra spacing was appearing between two sentences in warning message. Steps to reproduce: ------------------- * Install 'barcode' * On barcode, close the blue message under 'Barcode Scanning' Why the fix: ------------ Since 16.0 the message is shown in 'white-space: pre-wrap style'. Character '\ ' was causing extra spacing. NOTE: ----- The fix doesn't brake translations. Translations weren't working prior to the fix anyway. opw-3608979 Forward-Port-Of: odoo/enterprise#52927 Forward-Port-Of: odoo/enterprise#52867