Saturday, December 23, 2023
6 changes · 17.0
Resolved issues and error corrections
When a user clears the quantity field in the product catalog, the product is now treated as having a quantity of zero instead of leaving an empty or invalid value. This keeps the product card display consistent and helps avoid related errors in field service sales workflows.
Original PR description
When the user inputs nothing in the setQuantity input in the product catalog input, NaN is fixed in the productCatalogData.quantity value, which is fine for the backend since the NaN will be converted to Null then 0 when fixed in the SOL qty_product but the product card will display an empty input which is not good. with this change the productCatalogData.quantity will be fixed to 0, making the input space (and minus/plus buttons) disapear, which is more logical since the product quantity has been set to 0 In addition to this it'll prevent a traceback in industry_fsm_sale module where we used float_round() to fix the product quantity, which doesn't handle Null value -> https://github.com/odoo/enterprise/pull/50839 Task-3599491 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
This pull request updates the project README documentation. It is a minor documentation-only change, so it should not affect day-to-day product behavior or business workflows.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The default is 25000 rounds, which is too low nowadays. An off-the-shelf laptop takes ~400ms for a single hash at 600k rounds. Forward-Port-Of: odoo/odoo#146896 Forward-Port-Of: odoo/odoo#146865
Original PR description
The default is 25000 rounds, which is too low nowadays. An off-the-shelf laptop takes ~400ms for a single hash at 600k rounds. Forward-Port-Of: odoo/odoo#146896 Forward-Port-Of: odoo/odoo#146865
Comes from https://github.com/odoo/odoo/pull/116779 Forward-Port-Of: odoo/odoo#147318
Original PR description
Comes from https://github.com/odoo/odoo/pull/116779 Forward-Port-Of: odoo/odoo#147318
### [[FIX] mail: mime type alias] Some printers incorrectly specify the content-type of PDFs as "pdf" instead of the correct "application/pdf." To handle this situation, an alias has been introduced, treating content-type "pdf" as "application/pdf." ### [Reproducing original bug] 1. run odoo with documents module 2. prepare email file 2.1 create email with a pdf attached 2.2 export email to .eml 2.3 modify content-type of the pdf from "application/pdf" to "pdf" 3.
Original PR description
### [[FIX] mail: mime type alias] Some printers incorrectly specify the content-type of PDFs as "pdf" instead of the correct "application/pdf." To handle this situation, an alias has been introduced,…
### [[FIX] mail: mime type alias]
Some printers incorrectly specify the content-type of PDFs as "pdf" instead of
the correct "application/pdf." To handle this situation,
an alias has been introduced, treating content-type "pdf" as "application/pdf."
### [Reproducing original bug]
1. run odoo with documents module
2. prepare email file
2.1 create email with a pdf attached
2.2 export email to .eml
2.3 modify content-type of the pdf from "application/pdf" to "pdf"
3. send prepared email to odoo to inbox-financial alias (the default one
creating documents)
4. Go to documents, observe that the created PDF is blank!
### [Motivation for fix]
Since:
1. Odoo uses the Python built-in module for parsing emails*
(the actual issue lies outside Odoo code).
2. "pdf" is not an accepted MIME type according to current norms
(https://datatracker.ietf.org/doc/html/rfc6838#section-4.2).
It's not an actual Odoo bug.
However, redirecting this issue to the appropriate printer manufacturer and
waiting for a fix may be time-consuming, hence the proposed fix.
*function parsing email with the Python built-in module
https://github.com/odoo/odoo/blob/407ea60796a2b18eb02f5569e1cfab9f1163a572/addons/mail/models/mail_thread.py#L1282
opw-3462260
Forward-Port-Of: odoo/odoo#146139Versions: --------- - saas-16.2+ Steps to reproduce: ------------------- 1. Have a project with tasks & sub-tasks; 2. invite portal user to project; 3. log in as portal user; 4. go to a sub-task; 5. click the parent task button. Issue: ------ Javascript is trying to get the type attribute of an `undefined` value. Cause: ------ Commit 590beec44768889a7df0ddb166763772bb8722f6 added `task_properties` to `view_task_search_form`, this search view is used by `action_project_sharin
Original PR description
Versions: --------- - saas-16.2+ Steps to reproduce: ------------------- 1. Have a project with tasks & sub-tasks; 2. invite portal user to project; 3. log in as portal user; 4. go to a sub-task; 5. click the parent task button. Issue: ------ Javascript is trying to get the type attribute of an `undefined` value. Cause: ------ Commit 590beec44768889a7df0ddb166763772bb8722f6 added `task_properties` to `view_task_search_form`, this search view is used by `action_project_sharing_view_parent_task`, bringing it into view for portal users who do not have read access to this field. Solution: --------- Add a `search_view_ref` to the context to force using `project_sharing_project_task_view_search` instead. opw-3498012 Forward-Port-Of: odoo/odoo#147107