Saturday, December 23, 2023
2 changes · 17.0
Resolved issues and error corrections
When a user clears the quantity field in the product catalog, the product is now treated as having a quantity of zero instead of leaving an empty or invalid value. This keeps the product card display consistent and helps avoid related errors in field service sales workflows.
Original PR description
When the user inputs nothing in the setQuantity input in the product catalog input, NaN is fixed in the productCatalogData.quantity value, which is fine for the backend since the NaN will be converted to Null then 0 when fixed in the SOL qty_product but the product card will display an empty input which is not good. with this change the productCatalogData.quantity will be fixed to 0, making the input space (and minus/plus buttons) disapear, which is more logical since the product quantity has been set to 0 In addition to this it'll prevent a traceback in industry_fsm_sale module where we used float_round() to fix the product quantity, which doesn't handle Null value -> https://github.com/odoo/enterprise/pull/50839 Task-3599491 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed an issue where batch payment PDF reports were limited to displaying only 20 payments per page, causing excessive white space and awkward page breaks. The fix removes this artificial limit, allowing more payments to fit naturally on each page and creating cleaner, more efficient PDF documents.
Original PR description
Steps to reproduce: - Install Accounting - Activate "Batch Payments" in Accounting settings - Go to "Accounting / Customers / Payments" - Create more than 20 payments - Select all the payments and create a batch payment - Confirm the batch payment and print it => Each page of the generated PDF only contains 20 payments, letting a lot of white space at the bottom of the page between each page. If the customer names are very long and are displayed on several lines, it can happen that the 1st page contains the 19 first payments (displayed on the whole page) and the 2nd page only contains the 2Oth payment. Then the next 20 payments are displayed on the 3rd page, leaving the 2nd page almost empty. opw-3597753 Forward-Port-Of: odoo/enterprise#53316 Forward-Port-Of: odoo/enterprise#51604