Friday, December 29, 2023
9 changes · 17.0
Resolved issues and error corrections
Browsing the Industries section in Apps no longer creates unnecessary warning messages in the system logs. This keeps monitoring cleaner and helps administrators focus on issues that require attention.
Original PR description
An ormcache has been added to a method that takes lists as parameters but lists are not hashable. **steps to reproduce:** - go to apps and click on on 'Industries' **before this commit:** - a warning…
An ormcache has been added to a method that takes lists as parameters but lists are not hashable.
**steps to reproduce:**
- go to apps and click on on 'Industries'
**before this commit:**
- a warning is raised in the logs:
```
WARNING industry odoo.tools.cache: cache lookup error on ('ir.module.module', <function IrModule._get_modules_from_apps at 0x7f99e842fc70>, ['icon', 'icon_flag', 'to_buy', 'name', 'state', 'summary', 'website', 'application', 'module_type', 'shortdesc'], 'industries', False, ['&', '!', ['name', '=like', 'theme_%'], '&', ['application', '=', True], ['module_type', '=', 'industries']], 80, 0) Traceback (most recent call last):
File "/home/nda/dev/odoo/17.0/odoo/odoo/tools/cache.py", line 99, in lookup
r = d[key]
File "<decorator-gen-5>", line 2, in __getitem__
File "/home/nda/dev/odoo/17.0/odoo/odoo/tools/func.py", line 87, in locked
return func(inst, *args, **kwargs)
File "/home/nda/dev/odoo/17.0/odoo/odoo/tools/lru.py", line 34, in __getitem__
a = self.d[obj]
TypeError: unhashable type: 'list'
```
**after this commit:**
- ormcache is properly used
opw-3660052
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prRecruitment job cards now show long job titles by wrapping the text instead of letting it spill outside the card. This improves readability for recruiters and keeps the job overview clean, especially when titles are unusually long.
Original PR description
The text overflow was causing the job title to overflow the kanban card and could create readability problems. This commit removes the text overflow and thus permit the job title to be displayed in full. task-3598895 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Deleting a stage from the Helpdesk ticket board now works without causing an error. This prevents interruptions for support teams managing their ticket workflow.
Original PR description
Steps to Reproduce: - Navigate to the helpdesk.ticket kanban view. - Attempt to delete a stage. Issue: - An AttributeError is encountered during the execution of the action_unlink_wizard method Cause: - The traceback error is caused by an attempt to invoke the action_unlink_wizard method on the helpdesk.ticket model. However, it appears that the action_unlink_wizard method is not defined or available for the helpdesk.ticket model.it is in helpdesk.stage model. Solution: - resModel is specified to helpdesk.ticket model and we have delete from helpdesk.stage which is a relation with helpdesk.ticket model.that's why group.groupByField.relation and group.value is the correct parameter. task-3631310
Miscellaneous changes
For countries where the financial year is not from January to December so the sequence may contain two years like 2022-2023 where 2022 is the financial year start and 2023 is the financial year end and this sequence is reset when the financial year ends. so in this commit, we add support for this type of sequence INV/2022-2023/00001 INV/22-23/00001 INV/2022-23/00001 INV/22-2023/00001 Task : 3645807 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/subm
Original PR description
For countries where the financial year is not from January to December so the sequence may contain two years like 2022-2023 where 2022 is the financial year start and 2023 is the financial year end and this sequence is reset when the financial year ends. so in this commit, we add support for this type of sequence INV/2022-2023/00001 INV/22-23/00001 INV/2022-23/00001 INV/22-2023/00001 Task : 3645807 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#147771 Forward-Port-Of: odoo/odoo#104433
Since commit [1], we've applied a style to the badges (Bootstrap badge) which display extra prices next to a product's variants. However, this style unintentionally affected certain badges that should not have been affected since this other commit [2]. Steps to reproduce the bug: - Open the Website app. - Go to "Configuration" in the main navbar. - Select "Payment Providers" in the dropdown. - Pick the "Demo" payment provider. - Change the state to "Test Mode." - Set "Bank" as th
Original PR description
Since commit [1], we've applied a style to the badges (Bootstrap badge) which display extra prices next to a product's variants. However, this style unintentionally affected certain badges that…
Since commit [1], we've applied a style to the badges (Bootstrap badge) which display extra prices next to a product's variants. However, this style unintentionally affected certain badges that should not have been affected since this other commit [2]. Steps to reproduce the bug: - Open the Website app. - Go to "Configuration" in the main navbar. - Select "Payment Providers" in the dropdown. - Pick the "Demo" payment provider. - Change the state to "Test Mode." - Set "Bank" as the "Payment Journal". - Go to the "/shop" page. - Click on a product. - Click on "Add to Cart" on the product page. - Go to the cart and click on "Process Checkout". - Bug: On the "/shop/payment" page, notice a slight text misalignment in the badges next to the Payment Providers selector. In this commit, we've adjusted the CSS rule to ensure that only product configurator "extra price" badges receive this styling. [1]: https://github.com/odoo/odoo/commit/3e03bd9a399d607d0f36c7e7652ee743a7cfe61a [2]: https://github.com/odoo/odoo/commit/611e2f20f975c590eb75d64379be84dd4cc472ef task-3626728 ___________ **BEFORE** =>  **AFTER** =>  Forward-Port-Of: odoo/odoo#145170
Before this PR, the "mark as read" notification group test was sometimes faiing. This is due to the use of the `afterNextRender` helper which is known to be unreliable. This PR replaces this helper by the `contains` one that is more reliable: it uses a MutationObserver to detect changes of the DOM which guarantees we are in the expected state before making assertions. fixes runbot-53126 Forward-Port-Of: odoo/odoo#147713 Forward-Port-Of: odoo/odoo#147587
Original PR description
Before this PR, the "mark as read" notification group test was sometimes faiing. This is due to the use of the `afterNextRender` helper which is known to be unreliable. This PR replaces this helper by the `contains` one that is more reliable: it uses a MutationObserver to detect changes of the DOM which guarantees we are in the expected state before making assertions. fixes runbot-53126 Forward-Port-Of: odoo/odoo#147713 Forward-Port-Of: odoo/odoo#147587
Before this PR the "Can handle im_status of unknown partner" test was sometimes failing. This test is not related to im_status: it tests that receiving a `mail.record/insert` notification properly inserts the data in the store. This flow is already thoroughly tested as many discuss functionalities rely on this mechanism. This PR removes this test. fixes runbot-52628 Forward-Port-Of: odoo/odoo#147679 Forward-Port-Of: odoo/odoo#147574
Original PR description
Before this PR the "Can handle im_status of unknown partner" test was sometimes failing. This test is not related to im_status: it tests that receiving a `mail.record/insert` notification properly inserts the data in the store. This flow is already thoroughly tested as many discuss functionalities rely on this mechanism. This PR removes this test. fixes runbot-52628 Forward-Port-Of: odoo/odoo#147679 Forward-Port-Of: odoo/odoo#147574
`_l10n_ec_get_identification_type` will get called quite often in a loop in the ATS report, so it's important that it gets orm-cached. This reimplementation removes calls to `ref()` and replaces them with calls to `_xmlid_to_res_model_res_id()` which is entirely orm-cached. Forward-Port-Of: odoo/odoo#146661
Original PR description
`_l10n_ec_get_identification_type` will get called quite often in a loop in the ATS report, so it's important that it gets orm-cached. This reimplementation removes calls to `ref()` and replaces them with calls to `_xmlid_to_res_model_res_id()` which is entirely orm-cached. Forward-Port-Of: odoo/odoo#146661
Before this commit, the step to check if the state of the task is correctly marked as done failed because the class used to select the button in the state is wrong. This commit fixes the issue by updating the class to correctly the button as expected. runbot-52746 runbot-52753 runbot-52748 Forward-Port-Of: odoo/enterprise#53503
Original PR description
Before this commit, the step to check if the state of the task is correctly marked as done failed because the class used to select the button in the state is wrong. This commit fixes the issue by updating the class to correctly the button as expected. runbot-52746 runbot-52753 runbot-52748 Forward-Port-Of: odoo/enterprise#53503