Odoo Changelog — 2024-01-04

Thursday, January 4, 2024

39 changes · master

Improvements(5)

Enhancements to existing features

[IMP] odoo: unused css finder

PR #122045

Coremasterodoo

Adds an internal script that helps teams find unused or potentially problematic CSS in asset bundles. This can support future cleanup work, reduce bundle size, and improve maintainability without directly changing customer-facing behavior.

Original PR description

The goal is to be able to tell the useless / problematic parts in an assets bundle and try to reduce their size with a script  that checks all CSS classes that can be produced in our CSS bundles.

This is a functioning version, that is able to split the results in 3 categories :
- 0 use detected
- may be used somewhere
- probably used (dynamically)

By default it outputs its results in 3 text files.

task-3248659 - Step 1

#css#assets#cleanup#performance

[IMP] web: debug function to view assets size

PR #122049

Coremasterweb

A new debug option helps Odoo teams see which web assets are loaded and identify files that make pages heavier. This supports performance optimization by making it easier to find unnecessary or oversized CSS and JavaScript in asset bundles.

Original PR description

The goal is to be able to tell the useless / problematic parts in an assets bundle and try to reduce their size with a script that checks the size of the CSS/JS produced by each file inside a specific assets bundle.

This commit add a new debug button that display every asset loaded.

task-3248659 - Step 2

#debug#assets#performance

[IMP] web: update popper.js

PR #148037

Coremasterweb

This updates a background library used to position pop-ups, menus, and tooltips in the web interface. It helps keep this component current and may support better reliability, with little expected direct impact for everyday users.

Original PR description

Note: popper js has become floating UI and could require some
refactoring to switch to this new version.

#web interface#maintenance#pop-ups

[IMP] *: adapt tests and tours for new notification design

PR #53590

Enterprisemasterdocuments_spreadsheetplanningstock_barcodestock_barcode_mrpstock_barcode_picking_batchtimesheet_gridweb_studio

Automated tests and guided tours were updated to match the redesigned notification appearance. This keeps quality checks reliable after the visual change, helping prevent false test failures without changing business workflows.

Original PR description

With the introduction of the new notification design brought in https://github.com/odoo/odoo/pull/140071 we need to update all the tests and tours accordingly since we dropped the `border-color` on the `o_notification` element and are now using a `bg-[color]` on one of it's child, `o_notification_bar`

task-3469789
community PR: https://github.com/odoo/odoo/pull/140071

#tests#tours#notifications

[IMP] l10n_in_reports: change in default coa in deferred setting

PR #45684

Enterprisemasterl10n_in_reports

The India reports module now uses dedicated deferred expense and deferred income accounts as the default settings. This helps businesses classify deferred costs and income more accurately instead of using unrelated suspense or capital accounts.

Original PR description

Before this commit the default Deferred Expense was set to `100202 Bank Suspense ` Account and default Deferred Revenue was set to `111100 Capital Account`

After this commit the default Deferred Expense is set to `100840 Deferred Expenses` and the default Deferred Revenue is set to `100850 Deferred Income`

Related Community PR- https://github.com/odoo/odoo/pull/131675

task-3418482

#india#accounting#deferred-accounts

Bug Fixes(3)

Resolved issues and error corrections

[FIX] calendar: extract token from query-string

PR #147918

Coremastercalendar

This fix changes how calendar access tokens are read from shared calendar links, using only the web address query information instead of broader request data. This helps keep calendar access working correctly while avoiding unnecessary processing that could interfere with newer request-handling safeguards.

Original PR description

For `@route(auth='calendar')` methods, a `token` argument can be injected in the query-string of the request to access to the controller even when not connected. That argument is solely found in the query-string and nowhere else (it is never found in a POST form), with the new http stack of httpocalypse it is better not to call `get_http_params` before `pre_dispatch` is called as other middlewares can enforce limits like a max body size. Accessing the underlying requests query-string (`args`) is safe because the request line is already subject to a length limit by web server (8k by default on nginx and apache, see their configuration regarding 414 Request URI too long).

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Refactoring(2)

Code cleanup and technical improvements

[REF] bus, *: remove notification event from the bus service

PR #147747

Coremasterbusmailpoint_of_salepos_adyenpos_online_paymentpos_online_payment_self_orderpos_restaurantpos_self_orderpos_viva_walletsurveyweb_editor

This change updates how Odoo apps receive internal real-time notifications, moving them to a more direct subscription method. It reduces unnecessary processing and lowers the risk of missed or incorrectly handled notifications across messaging, point of sale, surveys, and web editing.

Other(29)

Miscellaneous changes

[FW][FIX] hr, hr_contract: fix employee attendance data fetch

PR #148086

Coremasterhrhr_contract

Before this commit, _get_calendar_attendances was calling the calendar method get_work_duration_data without specifying the company in the domain, ending up in wrong data if global leaves that don't concern the employee are concerning the calendar. This commit adds a domain for that method call so that only relevent global leaves are taken into account. Forward-Port-Of: odoo/odoo#148043

Original PR description

Before this commit, _get_calendar_attendances was calling the calendar method get_work_duration_data without specifying the company in the domain, ending up in wrong data if global leaves that don't concern the employee are concerning the calendar.

This commit adds a domain for that method call so that only relevent global leaves are taken into account.

Forward-Port-Of: odoo/odoo#148043

The goal is to be able to tell the useless / problematic parts in an assets bundle and try to reduce their size with a script that checks all CSS classes that can be produced in our CSS bundles. This is a functioning version, that is able to split the results in 3 categories : - 0 use detected - may be used somewhere - probably used (dynamically) By default it outputs its results in 3 text files. task-3248659 - Step 1

The goal is to be able to tell the useless / problematic parts in an assets bundle and try to reduce their size with a script that checks the size of the CSS/JS produced by each file inside a specific assets bundle. This commit add a new debug button that display every asset loaded. task-3248659 - Step 2

With the introduction of the new notification design brought in https://github.com/odoo/odoo/pull/140071 we need to update all the tests and tours accordingly since we dropped the `border-color` on the `o_notification` element and are now using a `bg-[color]` on one of it's child, `o_notification_bar` task-3469789 community PR: https://github.com/odoo/odoo/pull/140071

Before this commit the default Deferred Expense was set to `100202 Bank Suspense ` Account and default Deferred Revenue was set to `111100 Capital Account` After this commit the default Deferred Expense is set to `100840 Deferred Expenses` and the default Deferred Revenue is set to `100850 Deferred Income` Related Community PR- https://github.com/odoo/odoo/pull/131675 task-3418482

For `@route(auth='calendar')` methods, a `token` argument can be injected in the query-string of the request to access to the controller even when not connected. That argument is solely found in the query-string and nowhere else (it is never found in a POST form), with the new http stack of httpocalypse it is better not to call `get_http_params` before `pre_dispatch` is called as other middlewares can enforce limits like a max body size. Accessing the underlying requests query-string (`args`) is safe because the request line is already subject to a length limit by web server (8k by default on nginx and apache, see their configuration regarding 414 Request URI too long). Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

This issue occurs when a customer creates multiple companies. Then, after installing the attendance module, after selecting the kiosk mode, an error is generated. This is because, before installing the attendance module, if the customer created a company, a single kiosk key is generated. This key is different for each company, but it is the same. step to reproduce- - First created two company. - Install the `Attendances` & Open it. - Click on the Kiosk Mode from Menu. - Error will be generated. sentry traceback- ``` ValueError: Expected singleton: res.company(2, 1, 4, 3) File "odoo/http.py", line 2157, in __call__ response = request._serve_db() File "odoo/http.py", line 1732, in _serve_db return service_model.retrying(self._serve_ir_http, self.env) File "odoo/service/model.py", line 133, in retrying result = func() File "odoo/http.py", line 1759, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 1873, in dispatch return self.request.registry['ir.http']._dispatch(endpoint) File "addons/website/models/ir_http.py", line 235, in _dispatch response = super()._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 207, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 722, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/hr_attendance/controllers/main.py", line 82, in open_kiosk_mode } for e in request.env['hr.employee'].sudo().search_read(domain=[('company_id', '=', company.id)], File "odoo/fields.py", line 5118, in __get__ raise ValueError("Expected singleton: %s" % record) ``` after this commit,Each attendance kiosk key generated during the company's creation is unique. sentry-4617967282 Forward-Port-Of: odoo/odoo#145382

To reproduce: 1. Sync the IoT with a 17 database 2. Once it is set up, force shut down the server by Ctrl+C 2 times 3. Wait a few seconds: => crash of `WebsocketClient` thread with the following traceback: ``` Traceback (most recent call last): File "/usr/lib/python3.11/threading.py", line 1038, in _bootstrap_i> self.run() File "/home/pi/odoo/addons/hw_drivers/websocket_client.py", line 83> self.ws.run_forever() File "/usr/local/lib/python3.11/dist-packages/websocket/_app.py", l> raise WebSocketException("socket is already opened") websocket._exceptions WebSocketException socket is already opened ``` The IoT synchronised servers can stop in 2 ways that we need to handle: - Gracefully (Ctrl+C): In this case a disconnection signal is sent to the IoT-box The websocket is properly closed, but it needs to be established a new connection when the server will be back. Solution: `while True` loop as `run_forever` will return on close. `time.sleep` for the reconnection delay - Forced/killed (Ctrl+C 2 times): In this case there is no disconnection signal received Solution: use `reconnect` that will automatically take care re-attempting a connection This will also happen with the graceful quit as `reconnect` will trigger if the server is offline while attempting the new connection In both case, we perform a reconnection attempt with a delay of 10 seconds to avoid spamming the database After this commit: The websocket will reconnect itself automatically after 10 seconds if the connection is disrupted opw-3612528 Forward-Port-Of: odoo/odoo#147858

Description of the issue/feature this PR addresses: The webhook URLs used by MercadoPago are not sanitized and cause the payment to fail when the URL contains spaces or other non-ASCII characters. Steps to reproduce the bug: 1. Instal the Argentine localization and configure "payment_mercado_pago" as the payment method (test or production). 2. Create an invoice and generate a payment link (the reference will be something like "FA-C 0001-000133444"). 3. Initiate the payment process and it will generate an error in the last stage of payment (on the MercadoPago website). - Mercadopago tests credentials TEST-4811719641145832-020115-c5caffc149634e3e9d72fde2b74544d8__LD_LA__-172837665 - Used payment methods: https://www.mercadopago.com.ar/developers/es/docs/checkout-api/additional-content/your-integrations/test/cards - Credencial de test usada TEST-4811719641145832-020115-c5caffc149634e3e9d72fde2b74544d8__LD_LA__-172837665 - Metodo de pago usados: https://www.mercadopago.com.ar/developers/es/docs/checkout-api/additional-content/your-integrations/test/cards Current behavior before PR: Payment in MercadoPago cannot be confirmed when the reference contains spaces. Desired behavior after PR is merged: Payment in MercadoPago is confirmed even when the reference contains spaces. Adhoc Ticket: 68591 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#147848

The email_to field of the contactus form have to be dynamic except if the user manually set it via the form options. Unfortunately, the website signature task broke this feature. This commit fixes it and adds a test to prevent this regression in the future. Steps to reproduce the bug: - Go to the contactus page - Edit the page - Add a field on the form - Save the page - Change the company email address via the settings => The contactus form still send the email to the old email address. --- Since [this other commit], the recipient email option of the form on the `/contactus` page is not filled correctly with the company email. By chance, the form signature task fixed the bug but introduced another one. The previous commit fixed the bug introduced by the form signature task but reintroduced the inital bug. This commit fixes the initial bug and adds a test. By default, the form on the `/contactus` page sends emails to the email address of the company. Unfortunately, before this commit, when a user entered edit mode, the Recipient E-mail option always displayed "info@yourcompany.example.com" even when the company's e-mail address was different. This commit corrects this by displaying the dynamic value of `company.email` in the Recipient E-mail option coming from the data-for. Steps to reproduce the issue fixed by this commit: - Go to Settings > General Settings - Update the company's email address - Go to /contactus and edit - Click on the form => The recipient email value is still "info@yourcompany.example.com" instead of the company's email address. This commit fixes the issue, adds a test to ensure the recipient email option is correct and adds a utility to parse the data-for data. Bonus: this commit also fixes the following issue catched by sentry: - Go to /contactus - Click on Edit - In the Form option, remove the content of the 'Recipient Email' field. - Save - Fill and submit the form => An error is generated in the log. [this other commit]: https://github.com/odoo/odoo/commit/043e1fdf923d2037dd8da128ab99388f0c92e544 --- task-3382195 sentry-4633940473 Forward-Port-Of: odoo/odoo#147933 Forward-Port-Of: odoo/odoo#126508

The "grid images" are grid items that only contain an image (i.e. the image is alone in its column). This distinction with other images in grid mode allows to set the `object-fit` CSS property to `cover` so they take the whole space of the grid item (see commits [1] and [2]). In commit [3], the "Position" option has been added, allowing to switch between the `cover` and `contain` values for this property, to have the possibility to still choose to display the entire image, so it can keep its ratio. However, only the images that are direct children of the column have been considered when checking if it was a grid image and in the related CSS rules. This means that an image with a link cannot be one, since the image is the child of an anchor element `<a>` in that case. It can therefore not be set as "cover" or have the "Position" option. This commit adds the support for images with a link set on them, so they can be considered as grid images too. Steps to reproduce: - Drop the "Masonry" snippet. - Click on the image and set a link on it. => The image is now "contain" and the "Position" option disappeared from the right panel so we cannot change it. [1]: https://github.com/odoo/odoo/commit/e9c7e020daf88022d6e02de0a5620074e8417b5a [2]: https://github.com/odoo/odoo/commit/d8c374e3e6b31bf88aa42952aadf3379936f7600 [3]: https://github.com/odoo/odoo/commit/faf19ef7f87fc043fb9a814516e01b8eeafd9b61 opw-3580128 Forward-Port-Of: odoo/odoo#148022 Forward-Port-Of: odoo/odoo#147884

## Description Saving a new `res.config.settings` (for ex: checking "Use QR code on ticket") can be extremely slow on database with a large number of `pos.order`. ## Analysis Saving a new `res.config.settings` creates a new instance of the config. This will invoke a check on the python constraints calling eventually `_check_currencies` of `pos.config`, which will invoke the compute of `currency_id` setting the field as dirty. The `_compute_currency_rate` of `pos.order` depends on the `currency_id` of the current `pos.config` (via a related). This means the compute will be called with *all* `pos.order` ever made. As the compute itself makes a few calls to `_get_conversion_rate`, which makes a query, it can become slow when the method is called frequently. ## Solution Memoize the call to `_get_conversion_rate`, as similarly done in `account.move.line` from d8d47f9ff8554f4b39487fd2f13c153c7d6f958d to reduce the number queries necessary. ## Benchmark The `create` request to `res.config.settings` on a database with over 240k `pos.order` took | | Before | After | |-------------|-----------|----------| | Timing | 36.9 secs | 4.3 secs | | Query count | 47k | 627 | ## Reference opw-3632273 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#147957 Forward-Port-Of: odoo/odoo#145810

Improvements(5)

[IMP] odoo: unused css finder

[IMP] web: debug function to view assets size

[IMP] web: update popper.js

[IMP] *: adapt tests and tours for new notification design

[IMP] l10n_in_reports: change in default coa in deferred setting

Bug Fixes(3)

[FIX] calendar: extract token from query-string

Refactoring(2)

[REF] bus, *: remove notification event from the bus service

Other(29)

[FW][FIX] hr, hr_contract: fix employee attendance data fetch

Improvements(5)

[IMP] odoo: unused css finder

[IMP] web: debug function to view assets size

[IMP] web: update popper.js

[IMP] *: adapt tests and tours for new notification design

[IMP] l10n_in_reports: change in default coa in deferred setting

Bug Fixes(3)

[FIX] calendar: extract token from query-string

Refactoring(2)

[REF] bus, *: remove notification event from the bus service

Other(29)

[FW][FIX] hr, hr_contract: fix employee attendance data fetch

[FIX] project_hr_skills: use correct model in related fields

[WIP][FIX] test_l10n_be_hr_payroll_account: fix demo data

[REF] *: remove notification event from the bus service

[FW][FIX] website_crm_partner_assign: align priority on portal view

[FW][FIX] hr_attendance: generated unique kiosk key for every company

[FW][FIX] mail: further perf improvements of js records

[FW][FIX] website: prevent crash in FormEditorRegistry if key not found

[FW][FIX] hw_drivers: reconnect WS on server disconnection

[FW][FIX] l10n_gcc_pos: add missing VAT per line and resolve styling issues

[FW][FIX] pos_online_payment: full flow test

[FW][FIX] auth_totp: unbound request with xmlrpc

[FW][FIX] hr: cannot select Working Hour if it doesn't have a company to set up default Working Hour for a company

[FW][FIX] web: rectify alignment of worksheet template

[FW][FIX] payment_demo: prevent header overlap with "pay with demo" dialog

[FW][FIX] website_cf_turnstile: better error message for turnstile errors

[FW][FIX] payment_mercado_pago: sanitarize tx reference in webhook url

[FW][FIX] website_forum: fix the invalid URL link

[FW][FIX] base: correct typos in res.country.state.csv

[I18N] base: correct swedish translation

[FW][FIX] mass_mailing: fix template content visibility in email

[FW][FIX] website_event: correct ticket quantity style in mobile

[FW][FIX] core: HTTP 413 when restoring large backups

[FW][IMP] website: show form dynamic recipient email in edit mode

[FW][FIX] web_editor, website: consider images with a link as grid images

[FW][PERF] pos_sale: memoize `_compute_currency_rate` of `pos.order`

[FW][FIX] point_of_sale: fix pos_restaurant in free trial

[FW][FIX] mail: no quick action on attachment on small device

[FW][FIX] documents_spreadsheet: target col header value in autofill

[FW][FIX] knowledge: update behavior props when copying an article

[FW][I18N] l10n_co_reports: fix typo

[FW][FIX] l10n_mx_edi_pos: TipoRelacion in POS global invoice