Thursday, January 4, 2024
5 changes · master
Resolved issues and error corrections
This change corrects how Chilean point-of-sale orders choose document types and journals, preventing export invoices or incompatible sales journals from being selected by default. It helps sales be validated smoothly by automatically creating and posting the appropriate default document during POS transactions.
Original PR description
Description of the issue/feature this PR addresses: This is a work-in-progress commit, to be tested and complemented. It fixes the weird behavior of #97417 Current behavior before PR: the document type 110 (export invoice) was selected by default when the partner was empty (the xml_id was incorrect) once corrected this, more unexpected behaviors arrived: - the journal for the pos order should not be a sales journal since when validated without document type raises an error from LatAm document type constraints. Desired behavior after PR is merged: when selecting products in the pos and doing the sale, automatically create the default document and post it -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Employee attendance data now considers only company-relevant global time off when calculating work durations. This prevents employees from being affected by leave records that belong to another company, improving accuracy in HR attendance and contract-related data.
Original PR description
Before this commit, `_get_calendar_attendances` was calling the calendar method `get_work_duration_data` without specifying the company in the domain, ending up in wrong data if global leaves that don't concern the employee are concerning the calendar. This commit adds a domain for that method call so that only relevent global leaves are taken into account.
This fix changes how calendar access tokens are read from shared calendar links, using only the web address query information instead of broader request data. This helps keep calendar access working correctly while avoiding unnecessary processing that could interfere with newer request-handling safeguards.
Original PR description
For `@route(auth='calendar')` methods, a `token` argument can be injected in the query-string of the request to access to the controller even when not connected. That argument is solely found in the query-string and nowhere else (it is never found in a POST form), with the new http stack of httpocalypse it is better not to call `get_http_params` before `pre_dispatch` is called as other middlewares can enforce limits like a max body size. Accessing the underlying requests query-string (`args`) is safe because the request line is already subject to a length limit by web server (8k by default on nginx and apache, see their configuration regarding 414 Request URI too long). Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where project task skill-related information referenced the wrong underlying data model. The change helps ensure task and reporting data show the correct skill information, reducing confusion for users reviewing project assignments.
Original PR description
This PR fixes two related fields using the wrong model.
This corrects demo data references in the Belgian payroll accounting test module so they point to the right internal records. It helps keep test/demo environments coherent and reduces the risk of setup errors during validation.
Original PR description
Before this commit, some references in the demo data were made to referencing the `hr_holidays` module while the id used is also created inside the module. This has been changed to make the demo data coherent.