Tuesday, January 9, 2024
7 changes
Resolved issues and error corrections
Fixed an issue where branch companies couldn't see their parent company's accounts when setting up deferred entry options in the accounting module. Now branch companies can properly access and use parent company accounts for accounting configurations, improving the flexibility of multi-company accounting setups.
Original PR description
[FIX] account_accountant: include parent companies accounts Issue: When listing accounts options for deferred entries of a branch it doesn't show the the accounts of the parent company Steps to reproduce: 1. Install Accounting App 2. Go to settings 3. Go to Users&Companies 4. Go to Companies 5. Choose a company 6. Branches 7. Create a new branch 8. Go to accounting app 9. Go to settings 10. Change current company to be the new branch 11. Go to default accounts 12. list deferred entries options Solution: The domain on these fields was defining a criteria that the account's company should be the same as the current company while the current company can be a branch of another company, so we changed the criteria opw-3633186
This fix resolves an issue where utility products were not being properly loaded when opening a point of sale session in the Belgian blackbox module. A recent code change had inadvertently ignored the product loading rules, preventing these essential products from appearing. The fix ensures these utility products are now correctly available when staff start their POS sessions.
Original PR description
Since b90cae065001aa44fb05532950b78732217649a7, the domain from _loder_params_product_product is ignored. But the utility products that are supposed to be loaded are declared in that method. In this commit, we now override the _get_available_product_domain to make sure the utility products are loaded when opening a pos session.
This fix corrects a bug where appointment locations were incorrectly displayed as "Online" meetings on the customer-facing booking page. After this change, the "Online" status will only appear when no physical location has been assigned to an appointment type, ensuring customers see accurate meeting location information.
Original PR description
Steps to Reproduce ================== 1) Create a new appointment type. 2) Assign a location to it. 3) Access the front-end. - It is displayed as being online. Technical Details ================= Following this commit https://github.com/odoo/enterprise/commit/5ed8ea8e5fa65af700484aeab7745f127166d00a, the xpath in the file `appointment_templates_appointments.xml` within the `appointment_account_payment` module is causing it to fall within the if-else statement. To resolve this, change the class position from "else div" to "if div". After this PR ================= The "Online" status will only be shown if the location is not set. Task-3668128
This update fixes a problem that prevented users from accessing Customer Statements reports in Odoo Studio. The issue occurred when trying to view the report without applying filters. The fix simplifies how the system retrieves customer data, making the report more reliable and accessible to all users.
Original PR description
l10n_account_* = l10n_account_customer_statements Steps: - Install `web_studio` - Install `l10n_account_customer_statements` - Open Studio from anywhere - Go to Reports and remove default filter - Select `Customer Statements` report - Traceback `CustomerStatementReport:_get_report_values` function was using `data['context']['active_ids']` to get `res.partner` records. We can just use `_get_report_values`'s params `docids`
This fix prevents empty project groups from appearing in timesheet list and filter views when there are many active projects. Previously, the system was incorrectly showing projects with zero timesheets due to how groups were being expanded across different view types. The fix ensures group expansion only applies to the grid view where it's needed, eliminating confusing empty entries for users.
Original PR description
### Steps to reproduce: Have more than 80 project active on your db, go to my timesheets/all timesheets (or activate the my project filter) views> list view > group by project > some of the group…
### Steps to reproduce: Have more than 80 project active on your db, go to my timesheets/all timesheets (or activate the my project filter) views> list view > group by project > some of the group project will show 0 timesheets linked even tho they do have timesheets ### Issue: the empty groups that have timesheets should not be displayed at all ### Cause: The _group_expand_project_ids supposed to be only for the grid view also triggers for the other views, the read_group of the listview has a base limit of 80 but with the group expand 100 groups are fetched by page so more "empty" project groups are fetched to fill the result ### Solution: Local solution to test thoroughly, renamed the 'group_expand' keys in the My timesheet/ All timesheets/ my project filter/ timesheet_view_grid_by_project_no_section by 'grid_group_expand' In the read_grid method we check if that 'grid_group_expand' is present in the context, if so it'll also add the 'group_expand' key in the context then do the read_grid custom expansion The _group_expand_project_ids and _group_expand_employee_ids now need to have this 'group_expand' in their context so basically they can now only be triggered if the read_grid method has been triggered before. This ensures us that this group expand can't happen alone in the list/kanban/... views **this solution should be reviewed since i wasn't able to trigger the _group_expand_project_ids when the grid_view is enabled, so it may be possible to completely deprecated the _group_expand_project_ids method (as well as the _group_expand_employee_ids)** Ticket-3450175 Forward-Port-Of: odoo/enterprise#53521 Forward-Port-Of: odoo/enterprise#51615
This fix corrects an issue in the Belgian payroll module where holiday pay was being incorrectly recovered during salary simulations. The change ensures that when employees use the salary simulation tool, holiday pay calculations are handled properly without unintended deductions. This improves the accuracy of payroll forecasts for Belgian companies.
Original PR description
Forward-Port-Of: odoo/enterprise#53627
The system was displaying incorrect caller information during incoming calls due to phone number formatting mismatches between the database and the phone system. This fix removes the unreliable caller identification feature to prevent confusion, while also improving system performance. The feature will be reimplemented once a more reliable solution is found.
Original PR description
The search for a partner corresponding to the number of an incoming call doesn't work correctly and shows the wrong partner most of the time. This is really confusing; better to show nothing than something wrong and misleading.
Futhermore, since 3efd8e84865d8abdda89553c7fec761725a9cd58 where `sanitized_{mobile,phone}` were mistakenly removed, the phone numbers in the database and those sent by the PBX aren't formatted the same way, making it even less likely to get a relevant match.
As this also has a bad impact on performance, this commit removes the feature until we find an acceptable tradeoff.
Forward-Port-Of: odoo/enterprise#49169