Odoo Changelog — 2024-01-13

Saturday, January 13, 2024

66 changes · master

Improvements(2)

Enhancements to existing features

[IMP] No need to create module when exporting translation files

Coremasterbase

Exporting translation files no longer prompts users to create a module as part of the process. This removes an unnecessary step, making translation exports clearer and faster for users who only need the files.

Original PR description

Description of the issue/feature this PR addresses:
Disable module creation when exporting translation files

Current behavior before PR:
<img width="821" alt="image" src="https://user-images.githubusercontent.com/5561864/103731790-eff63e00-5020-11eb-962d-ff939357533b.png">

Desired behavior after PR is merged:
<img width="804" alt="image" src="https://user-images.githubusercontent.com/5561864/103731840-161bde00-5021-11eb-84f6-d4986dc2e2be.png">




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#translations#export#usability

[IMP] web: disable show weekends on daily scale on ViewScaleSelector

PR #146863

Coremasterweb

The view scale selector now disables the "show weekends" option when users choose a daily view, where that setting has no effect. This prevents confusion by making unavailable options clearer in calendar and grid views.

Original PR description

Currently, the ViewScaleSelector has the show weekends button enabled even when using a daily scale. Since both in calendar and in grid views, the daily scale makes the show weekend feature be ignored, it makes sense to disable it when the feature is not taken into account.

task-3628487

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#calendar#grid#usability

Bug Fixes(3)

Resolved issues and error corrections

[FIX] project : traceback on stage hover

PR #149002

Coremasterproject

Hovering over a stage in the project task kanban view no longer triggers an error. The change removes a broken hover tooltip that did not show useful information, improving reliability for project users.

Original PR description

Issue: When the user hovers the stage in a project task kanban view, a traceback appears.

Reason: In the task kanban view, there is a groupby tooltip description. That is supposed to display a tooltip on stage hover with the description of the stage. However, the field description is not present on the project.task.type, which then triggers a traceback.

Solution: Remove to tooltip on hover (which was already not displaying anything)





---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#project#tasks#kanban#tooltip

Removals(1)

Features or functions removed from Odoo

[REM] website_forum: remove back button code

PR #149207

Coremasterwebsite_forum

The website forum module has had outdated back button code removed because it is no longer used. This is a low-impact cleanup that reduces unnecessary code without changing the forum experience for users.

Original PR description

This PR removes the forum back button code which is irrelevant as it is not used anywhere after the merge of https://github.com/odoo/odoo/commit/4bb00c2e838342260274fc73a1c5e11284f29dbf

Task-3613078

#forum#cleanup#website

Refactoring(1)

Code cleanup and technical improvements

[REF] pos_online_payment: structure files

PR #149048

Coremasterpos_online_payment

The Point of Sale online payment module's internal files were reorganized to match the project's standard structure. This does not introduce new customer-facing behavior, but it makes the module easier to maintain and evolve reliably.

Original PR description

In this commit we rearange the static files of the `pos_online_payment` module such that they respect the pattern established in e216528






---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#point-of-sale#online-payments#maintenance

Other(59)

Miscellaneous changes

[FW][FIX] point_of_sale: skip recomputes on settings change

PR #148968

Coremasterpoint_of_sale

Original PR description

In v16 the configuration of a pos.config got moved from Point of Sale to Settings, with new settings fields related to pos_config fields. The create method got overriden in point_of_sale to write…

In v16 the configuration of a pos.config got moved from Point of Sale to Settings, with new settings fields related to pos_config fields. The create method got overriden in point_of_sale to write values on the current pos_config
after the creation of the new settings.

The side-effect of doing so is that each creation of a res.config.setting, i.e. after changing any given setting (pos-related or not), triggers a write on ~50 fields of the current pos.config. Among those fields there are `modifying_relations` fields that trigger recomputes on pos.order. Because pos.order can grow quite big in some databases (> 200.000 pos.orders), it makes it almost impossible to change any setting in these database. They reach a TimeoutError on SaaS/SH.

To fix this, this commit filter `pos_fields_vals` to only write new values on pos.config. If no value got changed since the last settings creation, no write is triggered, and no recompute happens.

Because we are in the context of res.config.settings create, and all the pos.config settings fields are related fields, everything should be in cache and no (or very few) query should be executed when doing this filtering.

This is done for res_config_settings in general in https://github.com/odoo/odoo/blob/3b24a13ee217b2d3846ad0953ccf8885d7b1f15a/odoo/addons/base/models/res_config.py
```python
old_value = field0.convert_to_record(
    field0.convert_to_cache(vals[fname0], self), self)
for fname in fnames:
    old_value = next(iter(old_value), old_value)[fname]

# determine the new value
new_value = field.convert_to_record(
    field.convert_to_cache(vals[field.name], self), self)

# drop if the value is the same
if old_value == new_value:
    vals.pop(field.name)
```

opw-3547106
opw-3508239

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#148756
Forward-Port-Of: odoo/odoo#139634

Description of the issue/feature this PR addresses: Disable module creation when exporting translation files Current behavior before PR: <img width="821" alt="image" src="https://user-images.githubusercontent.com/5561864/103731790-eff63e00-5020-11eb-962d-ff939357533b.png"> Desired behavior after PR is merged: <img width="804" alt="image" src="https://user-images.githubusercontent.com/5561864/103731840-161bde00-5021-11eb-84f6-d4986dc2e2be.png"> -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Currently, the ViewScaleSelector has the show weekends button enabled even when using a daily scale. Since both in calendar and in grid views, the daily scale makes the show weekend feature be ignored, it makes sense to disable it when the feature is not taken into account. task-3628487 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Issue: When the user hovers the stage in a project task kanban view, a traceback appears. Reason: In the task kanban view, there is a groupby tooltip description. That is supposed to display a tooltip on stage hover with the description of the stage. However, the field description is not present on the project.task.type, which then triggers a traceback. Solution: Remove to tooltip on hover (which was already not displaying anything) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

In this commit we rearange the static files of the `pos_online_payment` module such that they respect the pattern established in e216528 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

In v16 the configuration of a pos.config got moved from Point of Sale to Settings, with new settings fields related to pos_config fields. The create method got overriden in point_of_sale to write values on the current pos_config after the creation of the new settings. The side-effect of doing so is that each creation of a res.config.setting, i.e. after changing any given setting (pos-related or not), triggers a write on ~50 fields of the current pos.config. Among those fields there are `modifying_relations` fields that trigger recomputes on pos.order. Because pos.order can grow quite big in some databases (> 200.000 pos.orders), it makes it almost impossible to change any setting in these database. They reach a TimeoutError on SaaS/SH. To fix this, this commit filter `pos_fields_vals` to only write new values on pos.config. If no value got changed since the last settings creation, no write is triggered, and no recompute happens. Because we are in the context of res.config.settings create, and all the pos.config settings fields are related fields, everything should be in cache and no (or very few) query should be executed when doing this filtering. This is done for res_config_settings in general in https://github.com/odoo/odoo/blob/3b24a13ee217b2d3846ad0953ccf8885d7b1f15a/odoo/addons/base/models/res_config.py ```python old_value = field0.convert_to_record( field0.convert_to_cache(vals[fname0], self), self) for fname in fnames: old_value = next(iter(old_value), old_value)[fname] # determine the new value new_value = field.convert_to_record( field.convert_to_cache(vals[field.name], self), self) # drop if the value is the same if old_value == new_value: vals.pop(field.name) ``` opw-3547106 opw-3508239 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#148756 Forward-Port-Of: odoo/odoo#139634

Uploadable modules latest_version is not fully defined (ex: 1.0 instead of 15.0.1.0), which lead to issues in the MigrationManager. **Steps to reproduce (in 17.0):** - make sure you have the industry repository in the addons-path and the upgrade one in the upgrade-path - create an empty database - On 'Hair Salon', click 'Activate' - On the 'Install an App' popup window, click 'Install' - Wait for the Hair Salon Industry to install > Once finished, go to the Website - Click 'Edit' to open the website editor - Click 'Theme' - Next to the 'Theme' field under the 'Website' section, click 'Switch Theme' - Click 'Ok' on the Confirmation popup window - Click 'Use this theme' for the BEAUTY them - The 'Building your website...' animation begins ``` An error is thrown File "/home/odoo/src/odoo/17.0/odoo/addons/base/maintenance/migrations/theme_common/9.saas~13.1.1/pre-views.py", line 4, in <module> from openerp.addons.base.maintenance.migrations import util ModuleNotFoundError: No module named 'openerp' ``` opw-3589376 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#148955 Forward-Port-Of: odoo/odoo#144393

Steps to reproduce ================== 1. Install event 2. Go to Events 3. Configuration > Event Templates 4. Click on any event 5. Click on Communication 6. Add a line, change type to SMS 7. Type anything in Template 8. Click on Create "..." 9. The operation cannot be completed Cause of the issue ================== For many2one and many2many editable fields, the server sets the can_create and can_write attributes on the field nodes. [1] [2] In some cases [3], those attributes are missing even though the fields are actually editable. They are also absent for reference fields. The `canQuickCreate` props was set to the following value: `canCreate && !noQuickCreate`. When canCreate was absent, this was evaluated to undefined, thus ignoring the noQuickCreate option. Solution ======== When the permission attributes are missing, we have to assume that the user has the appropriate permissions. We also have to cast the extracted props to booleans as if you have an props with a value of undefined, it will fall back to the default value. In the test `no_quick_create option on a many2one when can_create is absent`, we set the field as readonly and then cancel the readonly on the view. This reproduces one of the bug of [3] which causes the permission attributes to be missing. ----- [1]: https://github.com/odoo/odoo/blob/fa6da3d63a3a4cce4e8ca788a49772925d318764/odoo/addons/base/models/ir_ui_view.py#L1296-L1297 [2]: https://github.com/odoo/odoo/blob/fa6da3d63a3a4cce4e8ca788a49772925d318764/odoo/addons/base/models/ir_ui_view.py#L1080-L1086 [3]: https://github.com/odoo/odoo/pull/138032 opw-3609799 Forward-Port-Of: odoo/odoo#148163 Forward-Port-Of: odoo/odoo#145433

Before this commit when the user creates a task with a subtask and save the form view and then go to the form view of the subtask and set as project the same than the one set on the parent task, he cannot save the form view. The reason is because the framework JS considers there is nothing to save since in fact , the project set is the same than the parent by default, it is just not displayed in the interface thanks to the value of `display_in_project` field. The reason is to be able to let the user choose if he wants to see the subtask in the main views (list/kanban) of tasks linked to the project or just below the parent task. This commit fixes the issue by forcing to update the `display_in_project` field even if it is not in the active fields since it is invisible in the interface and only the widget set on the project field will read and update it. Steps to reproduce: ================== - Install Project app - Go to the project app - Create project A - Create a task inside that Project A - Go to the form view of that task - Create a subtask - Save the form view - Go to the form view of the subtask - Set the project A as project for that subtask - Save the form view Current Behavior: ================ The form view cannot be saved because the framework JS considered there is in fact, nothing to save since `display_in_project` is not in the active fields and there is no force_save="1" set on the field in the view definition. Expected behavior: ================= The form view should be saved. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149035

Steps: 1. Install the Accounting module. 2. Enable cash rounding for Customer Invoices in the settings. 3. Activate Developer mode. 4. Navigate to Accounting > Configuration > Management > Cash Rounding. 5. Create a Cash Rounding rule with the following settings: a. Rounding Precision = 1 b. Rounding Method = UP c. Rounding Strategy = Add a rounding line. 6. Create a bill and apply the rounding rule. Add invoice lines with products priced at $99.5 and a tax rate of 15%. 7. Confirm the invoice. 8. Access the cash rounding settings and change the Rounding Method to Down. 9. Open the bill, navigate to the "Other Info" page, and select the "To Check" option. This will result in a UserError: "You cannot modify the taxes related to a posted journal item, you should reset the journal entry to draft to do so." Reason: If there is any change in the rounding method after the journal entry is confirmed, the compute method of tax_totals is triggered when some field of that record is modified. This may lead to the creation of another journal item or changes to existing ones based on the new rounding configuration. However, performing this on a confirmed entry is restricted so it will raise UserError. Solution: Don't compute rounding according to the amount_total after its conformation. Instead, count it using journal items for type-rounding Task - 3468308 Forward-Port-Of: odoo/odoo#139422

The user associated to an employee doesn't need to be in the same company of the employee. When this happens, we could get a multi company issue when trying to _only_ display the employee form. One way this issue is triggered is when the partner of the associated user is marked as partner_share=True. We may get an access error due to the rule `base.res_partner_rule`. Steps to reproduce: 1. Install HR module 2. Create an extra company with a user (U) on it. Ensure the partner of U is also set as belonging to this second company. 3. Create an employee in the first company with associated user U. 4. Archive U (this makes the partner of U get partner_share=True) 5. Try to access the employee form from the first company. We get an error: ``` Due to security restrictions, you are not allowed to access 'User' (res.users) records. Records: U (id=11, company=COMP2) User: Mitchell Admin (id=2) This restriction is due to the following rules: - user rule Note: this might be a multi-company issue. Contact your administrator to request access if necessary. Implicitly accessed through 'User' (res.users). ``` Since we allow hr.employee records to keep the associated archived user, to avoid this issue (potentially triggered differently) we opt to compute the avatar placeholder as sudo. The issue has been observed in multiple upgrade requests. Forward-Port-Of: odoo/odoo#148726 Forward-Port-Of: odoo/odoo#148325

...for orders made through Sales with loyalty programs that uses websites Problem: For loyalty & gift card programs that has sales and website enabled along with a specified website, the loyalty points will not accrue and gift card codes will generates for products if the SO was created with the Sales app. Solution: The SO ordered through the website should filter based on the website_id. SOs created through Sales will not have a website_id, thus, no need to add an extra filter for website_id. Gift card codes will generate and loyalty points will accrue for orders made through Sales even if the program has a website specified. Steps to Reproduce on Runbot 16: Create a new product of the type consumable Go to Sales > Products > Gift cards & eWallet and click on NEW For the Gift Card Products field add the previously created product For the website field specify a specific website (e.g. My Website) Create a new sale order for the originally created product Confirm the sale order Click on the Customer Preview smart button You won’t see a gift card code anywhere when it should have been generated & Loyalty points are not accrued opw-3550278 opw-3587226 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149112 Forward-Port-Of: odoo/odoo#146753

Improvements(2)

[IMP] No need to create module when exporting translation files

[IMP] web: disable show weekends on daily scale on ViewScaleSelector

Bug Fixes(3)

[FIX] project : traceback on stage hover

Removals(1)

[REM] website_forum: remove back button code

Refactoring(1)

[REF] pos_online_payment: structure files

Other(59)

[FW][FIX] point_of_sale: skip recomputes on settings change

Improvements(2)

[IMP] No need to create module when exporting translation files

[IMP] web: disable show weekends on daily scale on ViewScaleSelector

Bug Fixes(3)

[FIX] project : traceback on stage hover

Removals(1)

[REM] website_forum: remove back button code

Refactoring(1)

[REF] pos_online_payment: structure files

Other(59)

[FW][FIX] point_of_sale: skip recomputes on settings change

[FIX] account_reports: fix generate all files test

[REF] mail: clean web push code

[FW][FIX] pos_self_order: fix self order on iOS

[FW][FIX] payment: show the payment methods buttons only when necessary

[FW][FIX] l10n_in_edi: fix invoice preview taxes table

[FW][FIX] web: kanbancard reestablish 16.0 outline effect

[FW][FIX] account: add error when trying to update CoA with outdated module

[FW][FIX] base_import_module: use full version for uploadable module

[FW][FIX] point_of_sale: fix access error for company branch

[FW][FIX] web: useRecordObserver error bubbles

[FW][FIX] purchase_stock: allow validation of a receipt with invoiced qty

[FW][FIX] l10n_sa_edi: fix access to attachment of EDI document

[FW][FIX] account: fix single bill creation with PDF and XML from alias

[FW][FIX] web: no_quick_create option ignored

[FW][FIX] base: correct spanish address format

[FW][FIX] website_hr_recruitment: remove crsf

[FW][FIX] base_import_module: raise error if dependencies not in addons path

[FW][FIX] l10n_rs: remove duplicate report template inheritance in files l10n_rs/views/account_move.xml and l10n_rs/views/report_invoice.xml

[FW][FIX] point_of_sale: use system date format for date search

[FW][FIX] point_of_sale: display product attributes' images

[FW][FIX] base, hr: avoid invalid access error in onchange() when editing user

[FW][FIX] project: unable to save the project for subtask

[FW][FIX] web: improve ListRenderer rendering speed

[FW][IMP] account: don't calculate cash rounding if state is posted

[FW][FIX] website_sale: check pickUp list

[FW][FIX] hr: fix error on avatar computation in multi-comp

[FW][FIX] point_of_sale: Update ngrok for remote connection in IoT

[FW][FIX] mail: 'Logged _in_ as' on welcome page

[FW][FIX] sale: recompute down payment line description

[FW][FIX] stock: correct field reference in stock report template

[FW][FIX] mrp: By-product update in MO

[FW][FIX] website_slides: enable t-cache only without search tags

[FW][FIX] web: fix error when no app in clickbot

[FW][FIX] purchase_stock: use bill date exch rate for pdiff amls

[FW][FIX] im_livechat: fix env._t leftover

[FW][FIX] base: prevent language deactivation

[FW][FIX] mail: redirect with cid when not logged in

[FW][FIX] account_peppol: limit demo mode to peppol

[FW][FIX] base: Module category can reference itself as parent

[FW][IMP] product,sale: fix spacing and alignment issues

[FW][FIX] website_sale_loyalty: accrue points & create gift codes

[FW][IMP] l10n_in_edi_ewaybill: on verify it's only display error code

[FW][FIX] account: traceback after delete on invoice line

[FW][FIX] l10n_it_edi: avoid conflict with peppol when switching to demo

[FW][FIX] web: prevent autofocus on touch devices

[FW][FIX] web_studio: fix crash when editing rainbow effect on button

[FW][FIX] web_enterprise: fix autofocus on the home menu

[FW][FIX] web_studio: prevent editing the employee profile view

[FW][FIX] l10n_pe_reports: Fixed sales report for cancelled documents

[FW][IMP] sale_subscription: before this commit, the email context need the

[FW][FIX] delivery_ups_rest: include email address

[FW][FIX] hr_payroll: test deactivates a language still used by inactive users

[FW][FIX] pos_blackbox_be: fix env._t leftovers

[FW][FIX] appointment: ensure resource leaves on last day

[FW][FIX] partner_commission: make tests localization independant

[FW][IMP] knowledge: add /clipboard demonstration video in demo article

[FW][FIX] timesheet_grid: always display overtime in small device

[FW][FIX] studio: prevent field fetching in subviews when studio_no_fetch