Monday, January 15, 2024
5 changes · 17.0
Resolved issues and error corrections
This fix resolves a system warning that was appearing when the bank reconciliation widget tried to calculate analytic distribution information. The issue occurred because the system was attempting to pre-calculate a field that depends on partner information, which wasn't yet available. This fix ensures the calculation happens at the right time, eliminating the warning and improving system stability.
Original PR description
before this, this warning appears in terminal UserWarning: Field bank.rec.widget.line.analytic_distribution cannot be precomputed as it depends on non-precomputed field bank.rec.widget.line.partner_id
The Delete button in the Documents app is now only visible when editing existing workspaces, not when creating new ones. This improves the user experience by removing a confusing button that serves no purpose during document creation.
Original PR description
**Before this PR:**
The "Delete" button was visible in all instances of the document form view, including documents, projects, etc even while creating a new record. This was not logical since the "Delete" button is only useful when editing a workspace, not while creating a new record.
**Technical:**
We have added an `attrs` having invisible with the condition `('id', '=', 'False')` to the delete button, so It won't be visible if the record is not created.
**After this PR:**
The Delete button will only be visible in the Documents app when editing a workspace.
**Task**-3607426
Forward-Port-Of: odoo/enterprise#51636This update corrects the test validation for SMS mailing reports to check the right performance metrics. The test was incorrectly comparing unrelated metrics (like reply rates against bounce rates), when it should be validating click rates and bounce rates instead. This ensures the test accurately reflects how SMS campaign performance is actually measured.
Original PR description
`replied_ratio` shouldn't be tested against bounced_ratio, neither should be `opened_ratio` against `clicks_ratio`. `_prepare_statistics_email_values` function returns list, whose last two values are: `clicks_ratio` and `bounced_ratio` instead of `opened_ratio` and `replied_ratio`. Also checking `replied_ratio` and `opened_ratio` doesn't make sense, when testing sms. task-3485424 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149141 Forward-Port-Of: odoo/odoo#148993
This update reorganizes the order of company identification fields in the Czech localization module. The Company ID (IČO) field now appears before the VAT ID (DIČ) field, which better reflects Czech business practices where every company has an IČO but not all have a VAT ID. This improves the user experience by presenting the most essential identifier first.
Original PR description
in Czech Republic, the field company_registry (IČO) is typically located before the VAT/DIČ. Each subject always has company ID/ IČO, while not each subject has VAT ID. For this reason, I would like to propose a change of the location of this field. It should not cause any harm, as both fields are already there, we will just swap their order :) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
To reproduce (16.2 and > ?): 1. Install l10n_de_pos_res_cert 2. Configure fiskaly 3. Configure a PoS restaurant with floor & tables 4. Configure taxes on product that you want to use 5. Open the PoS session 6. Pick a table 7. Add a product to the order 8. Go back to the floor 9. Open back the order 10. Validate it and pay it => JS errors: ``` TypeError: this._super is not a function at Proxy._flush_orders (.../point_of_sale.assets.min.js:5754:13) at async .../poin
Original PR description
To reproduce (16.2 and > ?):
1. Install l10n_de_pos_res_cert
2. Configure fiskaly
3. Configure a PoS restaurant with floor & tables
4. Configure taxes on product that you want to use
5. Open the PoS session
6. Pick a table
7. Add a product to the order
8. Go back to the floor
9. Open back the order
10. Validate it and pay it => JS errors:
```
TypeError: this._super is not a function
at Proxy._flush_orders (.../point_of_sale.assets.min.js:5754:13)
at async .../point_of_sale.assets.min.js:1694:84
```
For some strange (JS) reason `this._super` is set as `undefined` after the `await this.env.services.orm.call` of the function.
opw-3636635
Forward-Port-Of: odoo/enterprise#53471
Forward-Port-Of: odoo/enterprise#53445