Commit [1] added the support for images with a link set on them in grid mode. As a follow up, this commit does the following: - Removes the `!important` from the grid image anchor CSS rules, as they were not really needed. - Checks if the image has a closest `o_grid_item_image` column instead of checking the parent in the `GridImage` options. Indeed, this class already guarantees that the image is well a grid image; we can therefore simplify the code. It also removes a comment that was f

Commit [1] added the support for images with a link set on them in grid mode.

As a follow up, this commit does the following:
- Removes the `!important` from the grid image anchor CSS rules, as they were not really needed.
- Checks if the image has a closest `o_grid_item_image` column instead of checking the parent in the `GridImage` options. Indeed, this class already guarantees that the image is well a grid image; we can therefore simplify the code.

It also removes a comment that was forgotten in commit [2].

[1]: https://github.com/odoo/odoo/commit/085d70cea571ea80c141ac6005e8bd8333bd269f
[2]: https://github.com/odoo/odoo/commit/d8c374e3e6b31bf88aa42952aadf3379936f7600

related to opw-3580128

Forward-Port-Of: odoo/odoo#149681
Forward-Port-Of: odoo/odoo#148152

[FIX] l10n_ar: add missing translations Issue: spanish_ar translation is missing for some menu items and template names in the accounting app Steps to reproduce: 1- install l10n_ar 2- switch language to Spanish(AR) 3- Open accounting app 4- check menu items Solution: Issue was that the translation file was called es.po and for spanish (AR) language it should fallback to es_419 As per the translation code found here in in 'translate.py' in odoo tools https://github.com/odoo/odoo

[FIX] l10n_ar: add missing translations

Issue: spanish_ar translation is missing for some menu items and template names in the accounting app

Steps to reproduce:
1- install l10n_ar
2- switch language to Spanish(AR)
3- Open accounting app
4- check menu items

Solution:
Issue was that the translation file was called es.po and for spanish (AR) language it should fallback to es_419
As per the translation code found here in in 'translate.py' in odoo tools

https://github.com/odoo/odoo/blob/20a3998c3073af8a5d95f8303283107363caed85/odoo/tools/translate.py#L1565-L1574

opw-3601556

Forward-Port-Of: odoo/odoo#146742

Steps: ------------------------------------- - Install project. - Go to the project. - Create or edit the project name to be excessively long. - Then go to Kanban view. - The project name would overflow. Issue: -------------------------------------- - Before this PR, in the project's kanban view, if the project's name was excessively long, it would overflow. Cause: -------------------------------------- - When the name is excessively long it would overflow out of the div elemen

Steps:
-------------------------------------
- Install project.
- Go to the project.
- Create or edit the project name to be excessively long.
- Then go to Kanban view.
- The project name would overflow.

Issue:
--------------------------------------
- Before this PR, in the project's kanban view, if the project's name was
 excessively long, it would overflow.

Cause:
--------------------------------------
- When the name is excessively long it would overflow out of the div element.

Fix:
-------------------------------------
- After this PR the name is now shortened by applying the 'me-5' Bootstrap
 class.

task-3676094

Forward-Port-Of: odoo/odoo#149007

Issue: The eCommerce categories scrollbar is too small/ not easy to grab with your mouse. Fix: The scrollbar height is increased on hover to increase the grabbing area task-3371760 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#126502

Issue:

The eCommerce categories scrollbar is too small/ not easy to grab with your mouse.

Fix:

The scrollbar height is increased on hover to increase the grabbing area

task-3371760

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#126502

Enterprise: https://github.com/odoo/enterprise/pull/54512

Enterprise: https://github.com/odoo/enterprise/pull/54512

Steps to reproduce: 1- install stock_account and account_accountant 2- activate in Settings > Accounting > Automatic Accounting 3- open a Product Category > set Inventory Valuation = Automated [`real_time`] (optional step: can change the account stock properties values, but doesn't matter) 4- install mrp_account Expected result: - Accounts already set under the Account Stock Properties (i.e.: property_stock_valuation_account_id, property_stock_account_input_categ_id, etc) remain

Steps to reproduce:
1- install stock_account and account_accountant
2- activate in Settings > Accounting > Automatic Accounting
3- open a Product Category > set Inventory Valuation = Automated
   [`real_time`] (optional step: can change the account stock properties
   values, but doesn't matter)
4- install mrp_account

Expected result:
- Accounts already set under the Account Stock Properties (i.e.: property_stock_valuation_account_id, property_stock_account_input_categ_id, etc) remain unchanged.

Actual result:
- Account stock properties for any Product Categories already set to Automated before installing mrp_account are wiped to nothing

Issue:
`_post_load_data` was resetting all property values (i.e. the accounts) to False since PR odoo/odoo#119564 to ensure correct accounts were used for `manual_periodic` valuation when stock_account and mrp_account are first installed. This was previously not an issue because no valuations could be set to `real_time` before stock_account was installed and mrp_account did not run `post_load_data` (i.e. an mrp account was added) until saas-16.3. So now we avoid wiping existing assigned accounts when mrp_account calls `_post_load_data` at its install time

Task: 3471065

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#132649

The user can define automated actions for sending data to a remote server using a webhook. To prevent this feature from sending unwanted data from a test database, this commit neutralizes the field `webhook_url` to an invalid URL. When the action is run, a warning is logged. Forward-Port-Of: odoo/odoo#149592

The user can define automated actions for sending data to a remote server using a webhook.
To prevent this feature from sending unwanted data from a test database, this commit neutralizes the field `webhook_url` to an invalid URL. When the action is run, a warning is logged.

Forward-Port-Of: odoo/odoo#149592

This commit adds a new event listener on the odooEditor which listens for external history steps (if collab mode is enabled), and changes the state of the record's dirtyness when a user receives external steps. This way a user will see that the record has been modified when he is editing a collaborative html field. task-3609594 ENT PR: odoo/enterprise#51579 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#145928

This commit adds a new event listener on the odooEditor which listens for external history steps (if collab mode is enabled), and changes the state of the record's dirtyness when a user receives external steps.

This way a user will see that the record has been modified when he is editing a collaborative html field.

task-3609594
ENT PR: odoo/enterprise#51579

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#145928

Current behavior: When you add multiple note in a sale order, only the last one was taken into account in the POS. Now we show all notes on the ProductScreen and on the ReceiptScreen. Steps to reproduce: - Install pos_sale - Create a sale order with a product and 2 notes - Open the POS and load the sale order - Only one note appears under the product - Validate the order - Only one note appears on the receipt under the product opw-3551331 --- I confirm I have signed the CLA and re

Current behavior:
When you add multiple note in a sale order, only the last one was taken into account in the POS. Now we show all notes on the ProductScreen and on the ReceiptScreen.

Steps to reproduce:
- Install pos_sale
- Create a sale order with a product and 2 notes
- Open the POS and load the sale order
- Only one note appears under the product
- Validate the order
- Only one note appears on the receipt under the product

opw-3551331
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#146891
Forward-Port-Of: odoo/odoo#144225

Issue When a location is set on an event, the google meet link is also generated, leading to confusion about the meeting format. Steps to reproduce - Create an event with a location - Sync the Calendar with Google. - Observe that a Google Meet link is sent with the email. Solution check if the loacation is set before generating a google meet link. opw-3589379 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forwa

Issue
    When a location is set on an event, the google meet link is also
    generated, leading to confusion about the meeting format.

Steps to reproduce
    - Create an event with a location
    - Sync the Calendar with Google.
    - Observe that a Google Meet link is sent with the email.

Solution
    check if the loacation is set before generating a google meet link.

opw-3589379

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#149654
Forward-Port-Of: odoo/odoo#146561

… project upgrade report Issue Description: ====================== There is an issue in the project upgrade report where an expense with a related analytic account appears twice. This occurs once as "Expenses" and again as "Vendor Bills". This problem does not manifest on runbot with all apps installed, indicating a specific configuration issue. The installation of the 'project_purchase' module resolves the issue, as the method "_get_already_included_profitability_invoice_line_ids" withi

… project upgrade report

Issue Description:
======================
There is an issue in the project upgrade report where an expense with a related analytic account appears twice. This occurs once as "Expenses" and again as "Vendor Bills". This problem does not manifest on runbot with all apps installed, indicating a specific configuration issue.

The installation of the 'project_purchase' module resolves the issue, as the method "_get_already_included_profitability_invoice_line_ids" within both the "project_purchase" and "project_hr_expense" modules performs a check for an 'expense_sheet_id' in account moves. This check helps to exclude these entries from the profitability items, thereby preventing duplication. However, while this solution is effective, it leads to an undesirable addition of the Purchase app to the client's database, which is not acceptable for the client. Relevant code sections: https://github.com/odoo/odoo/blob/1fbcfdf69b503e77e1a931d23dd47df0daf8b2fe/addons/project_hr_expense/models/project_project.py#L70-L78
https://github.com/odoo/odoo/blob/1fbcfdf69b503e77e1a931d23dd47df0daf8b2fe/addons/project_purchase/models/project_project.py#L138

Steps to Reproduce:
======================
1. Install Expense, Accounting, Project, Sales, Employees, Contacts apps on base runbot.
2. Create a service product with 'Prepaid/Fixed Price' and ensure 'Create an Order: Project & Task' is selected.
3. Create and confirm a sales order for the service product created in step 2.
4. In the Expenses app, create an employee-paid expense linked to the sales order's analytic account (e.g., Analytic Distribution: Departments > S00074).
5. Follow the process in the Expenses app by clicking on 'Create Report' > 'Submit to Manager' > 'Approve' > 'Post Journal Entries'.
6. Access Project Updates in the Projects app.
7. Observe that in the project profitability cost section, the same expense is listed twice under different labels: once as "Expenses" and once as "Vendor Bills".

Proposed Solution:
======================
The proposed solution involves modifying the domain of the `_add_purchase_items` function within the `project_account` module, specifically at [this code section](https://github.com/odoo/odoo/blob/763f88e2d45cb7ba107db135eecd0365ba2b8c8b/addons/project_account/models/project_project.py#L14). The enhancement would entail adding a condition to the function's domain to exclude any IDs that are already present in the profitability report. This approach will efficiently prevent the double counting of expenses, ensuring that each expense is represented only once in the project profitability report, thereby maintaining accuracy and consistency in financial tracking. This solution focuses on enhancing the existing functionality with a targeted and efficient modification, ensuring minimal impact on other system components while effectively addressing the issue.

opw-3522293

Forward-Port-Of: odoo/odoo#149623
Forward-Port-Of: odoo/odoo#148986

This reverts commit 185adf6fb487fa260bb6dfe985638bc545de7fa2. The change was made to "fix" line breaks with rating feedback in helpdesk. However, it's not ok to apply `inline` display layout for all non-user made message body, as usual block display is expected for html tags like `<div>` or `<p>`. The correct fix should be to remove these unwanted `<br>` in the feedback rating messages. We don't know how they appeared, but this is a specific minor issue in helpdesk rating, so reverting the

This reverts commit 185adf6fb487fa260bb6dfe985638bc545de7fa2.

The change was made to "fix" line breaks with rating feedback in helpdesk. However, it's not ok to apply `inline` display layout for all non-user made message body, as usual block display is expected for html tags like `<div>` or `<p>`.

The correct fix should be to remove these unwanted `<br>` in the feedback rating messages. We don't know how they appeared, but this is a specific minor issue in helpdesk rating, so reverting the fix is a higher priority.

Forward-Port-Of: odoo/odoo#149570
Forward-Port-Of: odoo/odoo#149516

[FIX] website: fix video in Image Gallery and Images Wall Steps to reproduce: bug 1: - Enter edit mode. - Drag and drop an "Image Gallery" snippet onto the page. - Double-click on an image within the snippet. - In the media dialog, click the "Video" tab. - Copy-paste a YouTube video URL into the URL input. - Save the media dialog by clicking on the "Add" button. - Bug: The video is very small. bug 2: - Drag and drop an "Images Wall" snippet

[FIX] website: fix video in Image Gallery and Images Wall
Steps to reproduce:

    bug 1:
    - Enter edit mode.
    - Drag and drop an "Image Gallery" snippet onto the page.
    - Double-click on an image within the snippet.
    - In the media dialog, click the "Video" tab.
    - Copy-paste a YouTube video URL into the URL input.
    - Save the media dialog by clicking on the "Add" button.
    - Bug: The video is very small.

    bug 2:
    - Drag and drop an "Images Wall" snippet onto the page.
    - Double-click on an image within the snippet.
    - In the media dialog, click the "Video" tab.
    - Copy-paste a YouTube video URL into the URL input.
    - Save the media dialog by clicking on the "Add" button.
    - Bug: the spacing around the video is not correct and the "spacing"
    option does not work for the video.

Note that the "image gallery" snippet (also the "image wall" snippet)
was not initially designed to handle anything other than images. When
you click on the "Add" button of the snippet, you can only add images.

However, by following the steps described above, it's possible to work
around this limitation and add a video to the snippet. Since this was
not part of the original plan, several options do not function correctly
with a video.

Instead of preventing the addition of videos, we have chosen to allow it
and focus on fixing the main issues (the small size of the video and the
"spacing" option which does not work with videos). So, if someone
specifically wants to add a video, it's currently possible, though some
features may not work as intended.

task-3597156

Forward-Port-Of: odoo/odoo#148637

Hidden message_needaction fields was taking 2.1 over 2.2 seconds on odoo.com (+- 5000 contracts in running state) Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#148581 Forward-Port-Of: odoo/odoo#148458

Hidden message_needaction fields was taking 2.1 over 2.2 seconds on odoo.com (+- 5000 contracts in running state)

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#148581
Forward-Port-Of: odoo/odoo#148458

Currently, if you have Spanish POS installed and create a Cash In/Out, you are met with an error. ### Steps to reproduce * install `l10n_es_pos` * start a POS session * click on the hamburger button in the top-right corner > Cash In/Out * add any amount and confirm You should be met with an error. Fix --- At first glance, the original condition: ```js partner?.id !== props.data.simplified_partner_id ``` and the revised condition: ```js partner && partner.id !== props.d

Currently, if you have Spanish POS installed and create a Cash In/Out, you are met with an error.

### Steps to reproduce

* install `l10n_es_pos`
* start a POS session
* click on the hamburger button in the top-right corner > Cash In/Out
* add any amount and confirm

You should be met with an error.


Fix
---
At first glance, the original condition:
```js
partner?.id !== props.data.simplified_partner_id
```

and the revised condition:
```js
partner && partner.id !== props.data.simplified_partner_id
```

might seem equivalent. However, they behave differently when `partner`
is `null` or `undefined`, i.e. with cash operations.

In the original condition, the optional chaining operator evaluates
to `undefined`, leading to the following `undefined !==
props.data.simplified_partner_id`, which is defined here : https://github.com/odoo/odoo/blob/2d5d1784033911ae6651bb2d680292571ed2fd09/addons/l10n_es/data/res_partner_data.xml#L3-L5

The revised condition will shorcircuit when `partner` is falsy, ensuring
that the code only executes when `partner` is a truthy object.


opw-3667287
opw-3676250

Forward-Port-Of: odoo/odoo#148688

Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149492

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#149492

Have a product with percent tax and fixed tax Have a promo program applying 50% on the order Create a sale order - Add the product - Add the promo Issue: The fixed tax is discounted We should ignore fixed taxes when applying promotions. opw-3580170 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-O

Have a product with percent tax and fixed tax
Have a promo program applying 50% on the order
Create a sale order
- Add the product
- Add the promo

Issue: The fixed tax is discounted
We should ignore fixed taxes when applying promotions.

opw-3580170

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#146947
Forward-Port-Of: odoo/odoo#145567

Before PR: --- If state is not set in the company,it gives error on order confirmation. After PR: --- If state is not set in the company, now it gives error when opening POS session. task id: 3360161 Forward-Port-Of: odoo/odoo#149381 Forward-Port-Of: odoo/odoo#124605

Before PR:
---
If state is not set in the company,it gives error on order confirmation.

After PR:
---
If state is not set in the company, now it gives error when opening POS session.

task id: 3360161

Forward-Port-Of: odoo/odoo#149381
Forward-Port-Of: odoo/odoo#124605

Problem --------- In the commit 24345812cb015e86f362f8c35176646239bfb803 (odoo), we modified the extraction of attachment in such a way that mails coming in a journal from aliases with several attachments create several invoices. Due to the urgency of the task, the computation of whether an attachment needs auto-extraction or not, has been skipped which failing some tests that had been silenced. Linked https://github.com/odoo/enterprise/pull/49816 fixes it. However, as a comment on the said PR

Problem
---------
In the commit 24345812cb015e86f362f8c35176646239bfb803 (odoo), we modified the extraction of attachment in such a way that mails coming in a journal from aliases with several attachments create several invoices. Due to the urgency of the task, the computation of whether an attachment needs auto-extraction or not, has been skipped which failing some tests that had been silenced. Linked https://github.com/odoo/enterprise/pull/49816 fixes it. However, as a comment on the said PR suggested, we should add a context key that disable the auto-extraction.

Objective
---------
Add a context key that disable the auto-extraction and update commit [2bfe69be5c64743d0bf35793a427878170d0b3c6](https://github.com/odoo/enterprise/commit/2bfe69be5c64743d0bf35793a427878170d0b3c6) (enterprise) to use the said context key.

Solution
---------
1. Remove the override of the `_needs_auto_extract`
2. Manually set the main attachment of the created moves so that `register_as_main_attachment` is not called when accessing the move. This removes the auto-extraction without the need to use the key (we still keep the context key as suggested by the OCR team).

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#149525

Avoid annoying the user when he put an account manually then changes the label because the account changes again. In order to do that, we only apply the predicted account if it is better than the second option for prediction. To reproduce: * create an invoice * add a line * change the account * change the label of the line Previously, it would always change and override the account even if it had a low certainty about the prediction. Now, it will only override the current account if

Avoid annoying the user when he put an account manually then changes the label because the account changes again.
In order to do that, we only apply the predicted account if it is better than the second option for prediction.

To reproduce:
* create an invoice
* add a line
* change the account
* change the label of the line

Previously, it would always change and override the account even if it had a low certainty about the prediction.
Now, it will only override the current account if there is a prediction that is clearly better.
The threashold is a ranking at least 10% better than the secondbest choice.

[task-3525714](https://www.odoo.com/web#id=3525714&model=project.task)

Forward-Port-Of: odoo/enterprise#54026
Forward-Port-Of: odoo/enterprise#53776

Steps to reproduce ------------------ 1. Install Helpdesk with demo data, go to the portal > Tickets. 2. Group by "Stage", and look at the order of the Stage groups. 3. Sort by "Stage", and the order of the Stage groups is now different. --- The groups should always be in the same order, regardless of the order of the tickets. This PR makes the order of the groups consistent regardless of the order of the tickets. Task-3675085 Forward-Port-Of: odoo/enterprise#53908

Steps to reproduce
------------------

1. Install Helpdesk with demo data, go to the portal > Tickets.
2. Group by "Stage", and look at the order of the Stage groups.
3. Sort by "Stage", and the order of the Stage groups is now different.

---

The groups should always be in the same order, regardless of the order of the tickets. This PR makes the order of the groups consistent regardless of the order of the tickets.

Task-3675085

Forward-Port-Of: odoo/enterprise#53908

Steps: Open the Field Service module. Go to configuration. Open worksheet templates. Select any worksheet template and click on "Design Template". Drag and drop tabs or columns inside the comments field. The size of tabs/columns appears very small. Issue: When dragging and dropping tabs or columns inside the comments field, the size of the tabs/columns appears very small. Cause: This issue occurs because tabs and columns are allowed inside the comments field. Inside the comment

Steps:

Open the Field Service module.
Go to configuration.
Open worksheet templates.
Select any worksheet template and click on "Design Template". Drag and drop tabs or columns inside the comments field. The size of tabs/columns appears very small.

Issue:

When dragging and dropping tabs or columns inside the comments field, the size of the tabs/columns appears very small.

Cause:

This issue occurs because tabs and columns are allowed inside the comments field. Inside the comments field, there is a grid, which reduces the size of tabs and columns.

Fix:

It is unnecessary to allow tabs and columns inside the comments field. We should restrict them from being placed inside the comments field. Tabs and columns should be allowed inside sheet and after group.

task-3631285

Forward-Port-Of: odoo/enterprise#54361
Forward-Port-Of: odoo/enterprise#49034

Added JS tests for the following: - fsm_date_widget - fsm_task_calendar_view - fsm_task_gantt_view (patched TaskGanttController) Also refatored fsm_date_widget planned_date_end deprecated references (to date_deadline) Task-3661094 Forward-Port-Of: odoo/enterprise#53696

Added JS tests for the following:
- fsm_date_widget
- fsm_task_calendar_view
- fsm_task_gantt_view (patched TaskGanttController)

Also refatored fsm_date_widget planned_date_end deprecated references (to date_deadline)

Task-3661094

Forward-Port-Of: odoo/enterprise#53696

Steps to Reproduce: - install timesheets - go to cofiguration - under time encoding - enable Days/Half-Days option - click on all timesheets, go to kanban view - select a record, click on validate Issue: - in validated timesheet the days spent field is editable, days spent should not be editable in validated timesheet. Cause: - while giving attributes to the unit_amount field, the conditions checking for readonly will cause the error. Solution: - if we gave the conditions prop

Steps to Reproduce:
- install timesheets
- go to cofiguration
- under time encoding
- enable Days/Half-Days option
- click on all timesheets, go to kanban view
- select a record, click on validate

Issue:
-  in validated timesheet the days spent field is editable, days spent should not be editable in validated timesheet.

Cause:
- while giving attributes to the unit_amount field, the conditions checking for readonly will cause the error.

Solution:
- if we gave the conditions properly,then the issue will be solved.

 task-3627670

Forward-Port-Of: odoo/enterprise#54243
Forward-Port-Of: odoo/enterprise#52373

### 1. Remove unwanted border Prior to this PR, there was a border on the date picker in the sidebar of the shop page, which created a layout issue. To fix that, this commit removes this border. ### 2. Adapt invalid inputs Prior to this commit, renting inputs were supposed to have a red border when invalid. The related function targeted the wrong name and no longer worked. This commit adapts this function and the style applied to maintain consistency. Requires: - https://github.com

### 1. Remove unwanted border
Prior to this PR, there was a border on the date picker in the sidebar of the shop page, which created a layout issue.
To fix that, this commit removes this border.

### 2. Adapt invalid inputs
Prior to this commit, renting inputs were supposed to have a red border when invalid. The related function targeted the wrong name and no longer worked.

This commit adapts this function and the style applied to maintain consistency.

Requires: 
- https://github.com/odoo/enterprise/pull/54378

task-3586525

Forward-Port-Of: odoo/enterprise#50364

Community: https://github.com/odoo/odoo/pull/149732

Community: https://github.com/odoo/odoo/pull/149732

Forward-Port-Of: odoo/enterprise#54429 Forward-Port-Of: odoo/enterprise#53791

Forward-Port-Of: odoo/enterprise#54429
Forward-Port-Of: odoo/enterprise#53791

Currently, you cannot delete a certificate. ### Steps to reproduce - install `l10n_mx_edi` * switch to a Mexican company * go to the settings * under 'MX Electronic invoicing', delete a line from the 'Certificates' field * attempt to save You should be met with a validation error. ### Cause In the `Certificate` model, the `company_id` field is defined as a `Many2one` relation to the `ResCompany` model and is marked as `required=True`. The inverse relation in the `ResCompany` m

Currently, you cannot delete a certificate.

### Steps to reproduce

- install `l10n_mx_edi`
* switch to a Mexican company
* go to the settings
* under 'MX Electronic invoicing', delete a line from the 'Certificates' field
* attempt to save

You should be met with a validation error.

### Cause

In the `Certificate` model, the `company_id` field is defined as a `Many2one` relation to the `ResCompany` model and is marked as `required=True`. The inverse relation in the `ResCompany` model contains a `certificate_ids` field.

When saving after removing a certificate in the settings, Odoo attempts to unlink the certificate from `company_id.certificate_ids`. Due to the defined relationships, this will result in the system trying to set the `certificate.company_id` field to `False`. However, since `company_id` is a required field, this operation leads to an error.

opw-3664517

Forward-Port-Of: odoo/enterprise#54134

This commit aims at adding the status indicator buttons that are present in most other Odoo Form views to Knowledge. These indicators enables the user to know when changes has been taken into account and can be saved inside the DB, either using the buttons or using other methods. This also enables the user to discard any changes he'd done to the article quickly. task-3609594 COM PR: odoo/odoo#145928 Forward-Port-Of: odoo/enterprise#51579

This commit aims at adding the status indicator buttons that are present in
most other Odoo Form views to Knowledge.
These indicators enables the user to know when changes has been taken into
account and can be saved inside the DB, either using the buttons or using other
methods.

This also enables the user to discard any changes he'd done to the article
quickly.

task-3609594
COM PR: odoo/odoo#145928

Forward-Port-Of: odoo/enterprise#51579

Forward-Port-Of: odoo/enterprise#54194

Forward-Port-Of: odoo/enterprise#54194

Currently, if you have 2 browser tabs or 2 different PoS using the same Worldline terminal, there was a way to do some damage if requests were started at the same time 1) Since we call C++ code through a thread without a mutex, it was possible to get a race condition and provoke a segmentation fault 2) Even if there was no race condition, we were not specifying to who the driver is replying all the time. So a cancel request on the 1st PoS could cancel an active transaction on the 2nd PoS. T

Currently, if you have 2 browser tabs or 2 different PoS using the same Worldline terminal, there was a way to do some damage if requests were started at the same time
1) Since we call C++ code through a thread without a mutex, it was possible to get a race condition and provoke a segmentation fault
2) Even if there was no race condition, we were not specifying to who the driver is replying all the time. So a cancel request on the 1st PoS could cancel an active transaction on the 2nd PoS.

This PR fixes both issues by specifying the owner of the request and the cid in every single response sent from the driver to the frontend.
I am also adding the cid to the data sent in a cancellation request as otherwise we don't know which transaction line we're cancelling.
It replaces the threads by a queue to avoid race conditions in the future and respect the condition that all the Driver class logic must be executed in the "run" method for safe execution.
It also fixes the Last Transaction Status popup which could accidentally "catch" the response from a transaction since it doesn't care about the cid.
This PR also makes the popup consistent with the response (using error popup for a response resulting in an error).

task-3676153

Forward-Port-Of: odoo/enterprise#54157
Forward-Port-Of: odoo/enterprise#53951

Improved warning message for shiprocket recommended couriers in sales order. task-3658367 Forward-Port-Of: odoo/enterprise#53526

Improved warning message for shiprocket recommended couriers in sales order.

task-3658367

Forward-Port-Of: odoo/enterprise#53526

In a previous commit [1], we modified the code to update the currency rates, introducing a bug where we could only get the currency rates from the first provider. This commit fixes that. [1] 24012f9db268a7722275a508374498bb18bbebdc Forward-Port-Of: odoo/enterprise#54055 Forward-Port-Of: odoo/enterprise#54025

In a previous commit [1], we modified the code to update the currency rates, introducing a bug where we could only get the currency rates from the first provider.

This commit fixes that.

[1] 24012f9db268a7722275a508374498bb18bbebdc

Forward-Port-Of: odoo/enterprise#54055
Forward-Port-Of: odoo/enterprise#54025

From the 1st of January 2024, commodity code [0803 90 10] is replaced by these 2 new codes: - [0803 90 11] Plátano de Canarias - [0803 90 19] Others Source: https://www.nbb.be/en/statistics/foreign-trade/nomenclature-and-codes  opw-3676899 Forward-Port-Of: odoo/enterprise#54359 Forward-Port-Of: odoo/enterprise#54102

From the 1st of January 2024, commodity code [0803 90 10] is replaced by these 2 new codes:
- [0803 90 11] Plátano de Canarias
- [0803 90 19] Others

Source: https://www.nbb.be/en/statistics/foreign-trade/nomenclature-and-codes

![intrastat_new_codes](https://github.com/odoo/enterprise/assets/3715017/2e687d90-de55-463a-8b1f-bc5ac9938f36)

opw-3676899

Forward-Port-Of: odoo/enterprise#54359
Forward-Port-Of: odoo/enterprise#54102

On database with large amount of move lines, the report is really slow to generate, this commit improve a bit the situation by: 1/ replacing the `amount_residuals_by_aml_id` CTE by a `LATERAL JOIN` 2/ Fixing inefficient subquery that exclude move line of an exchange move (`NOT IN` -> `NOT EXISTS`) 3/ rounding the `amount_residual` (aka "Balance in Foreign Currency") so that line where reconciled amount sum is not strictly zero (epsilon) are all correctly excluded On our test database

On database with large amount of move lines, the report is really slow to generate, this commit improve a bit the situation by:

1/ replacing the `amount_residuals_by_aml_id` CTE by a `LATERAL JOIN`

2/ Fixing inefficient subquery that exclude move line of an exchange move (`NOT IN` -> `NOT EXISTS`)

3/ rounding the `amount_residual` (aka "Balance in Foreign Currency") so that line where reconciled amount sum is not strictly zero (epsilon) are all correctly excluded

On our test database, the report now render in ~2 minutes, down from ~13-15 minutes before

OPW-3646825

Forward-Port-Of: odoo/enterprise#54014

Problem --------- In the commit [24345812cb015e86f362f8c35176646239bfb803](https://github.com/odoo/odoo/commit/24345812cb015e86f362f8c35176646239bfb803) (odoo), we modified the extraction of attachment in such a way that mails coming in a journal from aliases with several attachments create several invoices. Due to the urgency of the task, the computation of whether an attachment needs auto-extraction or not, has been skipped. This commit fixes this. The problem of the failing test came fr

Problem
---------
In the commit [24345812cb015e86f362f8c35176646239bfb803](https://github.com/odoo/odoo/commit/24345812cb015e86f362f8c35176646239bfb803) (odoo), we modified the extraction of attachment in such a way that mails coming in a journal from aliases with several attachments create several invoices.
Due to the urgency of the task, the computation of whether an attachment needs auto-extraction or not, has been skipped. This commit fixes this.

The problem of the failing test came from the conditional order that verified if the auto-extraction was needed or not. Here is the difference

What the test expected              
1. From alias                       
    a. Attachment is PDF            
2. New move or purchase document

What we had
1. New move
2. From alias
    a. Attachment is PDF
3. Purchase document

So, new documents were always extracted even though the option for extracting PDF only was active. Since all document created through a mail from a mail alias are new document, all attachments (no matter if binary or PDF) were extracted.

Solution
---------
Update the `_needs_auto_extract` and decoder to behave as the test expects; by shifting the conditions around. Also context key checks in both the `_needs_auto_extract` method and decoder to completely disable the calls to the OCR when needed.

Forward-Port-Of: odoo/enterprise#49816

Descritpion of the issue/feature this commit addresses: At the moment, trying to use the analytic groupy on the Journal Report results in a traceback. It is not possible to use it at all. --- Steps to reproduce: 1-Activate the Analytic Accounting in the settings 2-Activate the Analytic Groupby in the Journal Report's options 3-Go to the Journal Report and apply any Analytic Groupby filter 4-A traceback shows up --- Desired behavior after this commit is merged: This com

Descritpion of the issue/feature this commit addresses:

At the moment, trying to use the analytic groupy on the Journal Report results in a traceback. It is not possible to use it at all.

---

Steps to reproduce:

1-Activate the Analytic Accounting in the settings 
2-Activate the Analytic Groupby in the Journal Report's options 
3-Go to the Journal Report and apply any Analytic Groupby filter 
4-A traceback shows up

---

Desired behavior after this commit is merged:

This commit handles the issue by adding a check at the very start of the custom handler of the Journal Report. This new check verifies that no analytic groupby filter is being applied on the report. If it is the case, an error is raised to tell the user the feature is not supported by that report.

While at it, the Horizontal Grouping and Period Comparison options have also been disabled because their rendering was making the report unreadable and they added no value to it.

With this commit, the Journal Report can't use Analytic Groupby, Horizontal Grouping or Period Comparison.

---

task-3600349

Forward-Port-Of: odoo/enterprise#53807