Saturday, January 20, 2024
18 changes · saas-17.1
Miscellaneous changes
To reproduce ============ - With hr_attendance installed on ios application - click on small button (green/red) to checkin/checkout - nothing happens Problem ======= the method `signInOut` is failling because `navigator.geolocation` is not defined on iOS Solution ======== check if `navigator.geolocation` is defined before using it opw-3649654 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149518
Original PR description
To reproduce ============ - With hr_attendance installed on ios application - click on small button (green/red) to checkin/checkout - nothing happens Problem ======= the method `signInOut` is failling because `navigator.geolocation` is not defined on iOS Solution ======== check if `navigator.geolocation` is defined before using it opw-3649654 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149518
For some reason the demo data for some of the ranking motivational messages is different from their default motivational message (in data). Because of the way the `translate=html_translate` works, when the demo data was installed, the original motivational message was overwritten and therefore not exported in the .pot file so it could never be translated. Since we want both the demo and original messages translated, it's best that we add the original messages into the demo data so that it's not
Original PR description
For some reason the demo data for some of the ranking motivational messages is different from their default motivational message (in data). Because of the way the `translate=html_translate` works, when the demo data was installed, the original motivational message was overwritten and therefore not exported in the .pot file so it could never be translated. Since we want both the demo and original messages translated, it's best that we add the original messages into the demo data so that it's not visible to users, but is still exported to the .pot file. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#150206 Forward-Port-Of: odoo/odoo#149231
Before this commit auto complete suggestion were showing on partner field even though there is no_create attribute on partner field and because of that user can create partner record from that field even though user is not allow to create record from it and also it gives trackback in partner portal field because of access_token. This commit prevent auto complete suggestion when partner field has no_create attribute set on them to avoid unnecessary partner creation from that field. task-369
Original PR description
Before this commit auto complete suggestion were showing on partner field even though there is no_create attribute on partner field and because of that user can create partner record from that field even though user is not allow to create record from it and also it gives trackback in partner portal field because of access_token. This commit prevent auto complete suggestion when partner field has no_create attribute set on them to avoid unnecessary partner creation from that field. task-3690532 Forward-Port-Of: odoo/odoo#150106
When inheriting from a test class having tests methods, the tests are played twice. In this particular case, the inheritance was not necessary at all. Forward-Port-Of: odoo/odoo#150165
Original PR description
When inheriting from a test class having tests methods, the tests are played twice. In this particular case, the inheritance was not necessary at all. Forward-Port-Of: odoo/odoo#150165
By inheriting from a test class that contains test methods, these tests are executed twice. Forward-Port-Of: odoo/odoo#150107
Original PR description
By inheriting from a test class that contains test methods, these tests are executed twice. Forward-Port-Of: odoo/odoo#150107
The computation of such taxes were wrong, thus we update the tax template to correct the computation and the tax tags. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149146
Original PR description
The computation of such taxes were wrong, thus we update the tax template to correct the computation and the tax tags. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149146
Current behavior: It was possible to use an expired eWallet to pay for an order. It was also possible to put money on an expired eWallet. Steps to reproduce: - Create an eWallet with an expiration date in the past - Open PoS and add products to the order - Click on the eWallet button - You can still use the eWallet to pay for the order opw-3568270 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149622 Forward-Port-
Original PR description
Current behavior: It was possible to use an expired eWallet to pay for an order. It was also possible to put money on an expired eWallet. Steps to reproduce: - Create an eWallet with an expiration date in the past - Open PoS and add products to the order - Click on the eWallet button - You can still use the eWallet to pay for the order opw-3568270 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149622 Forward-Port-Of: odoo/odoo#145801
The webclient returns a message "server error" if you add an attachment or send a message on an archived record chatter. **steps to reproduce:** - archive a record (ex: a partner) - send a message on the chatter or add an attachment **before this commit:** - a popup error is raised "server error" **after this commit:** - the chatter is working properly on archived records opw-3689169 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr For
Original PR description
The webclient returns a message "server error" if you add an attachment or send a message on an archived record chatter. **steps to reproduce:** - archive a record (ex: a partner) - send a message on the chatter or add an attachment **before this commit:** - a popup error is raised "server error" **after this commit:** - the chatter is working properly on archived records opw-3689169 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149862
Tests the method formatLang() to be able to do safe(r) refactoring in future versions. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149775
Original PR description
Tests the method formatLang() to be able to do safe(r) refactoring in future versions. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149775
…e 8 decimals Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149538
Original PR description
…e 8 decimals Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149538
Have a nested (2 levels) form view with a footer. On the main view, add a record in the one2many in form view (dialog). Before this commit, the footer of the nested one2many form (within the dialog) was put inside the footer of the dialog, which is wrong, as the footer originates from a subview, hence has nothing to do with its parent. After this commit, each subview's part that should be rendered elsewhere than in the main formRenderer doesn't pollute the main view. opw-3681966 Des
Original PR description
Have a nested (2 levels) form view with a footer. On the main view, add a record in the one2many in form view (dialog). Before this commit, the footer of the nested one2many form (within the dialog) was put inside the footer of the dialog, which is wrong, as the footer originates from a subview, hence has nothing to do with its parent. After this commit, each subview's part that should be rendered elsewhere than in the main formRenderer doesn't pollute the main view. opw-3681966 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#150010 Forward-Port-Of: odoo/odoo#149896
When having an analytic plan with subplans, with analytic accounts on each, the all accounts count is not well computed on the subplans. opw-3677889 Forward-Port-Of: odoo/odoo#149898
Original PR description
When having an analytic plan with subplans, with analytic accounts on each, the all accounts count is not well computed on the subplans. opw-3677889 Forward-Port-Of: odoo/odoo#149898
[ADD] l10n_ec_reports_ats: Ecuadorian ATS Report (SRI) The Simplified Transactional Annex (Anexo Transaccional Simplificado - ATS) Developed in collaboration with the Trescloud team [General description] - Report generated in xml to be uploaded to the DIMM software of the SRI (Servicio de Rentas Internas) in Ecuador. - Added button action to generate the ATS report in XML, in Accounting > Reports > Tax Report. - The ATS is generated per month. - Non-blocking error notifications in t
Original PR description
[ADD] l10n_ec_reports_ats: Ecuadorian ATS Report (SRI) The Simplified Transactional Annex (Anexo Transaccional Simplificado - ATS) Developed in collaboration with the Trescloud team [General…
[ADD] l10n_ec_reports_ats: Ecuadorian ATS Report (SRI) The Simplified Transactional Annex (Anexo Transaccional Simplificado - ATS) Developed in collaboration with the Trescloud team [General description] - Report generated in xml to be uploaded to the DIMM software of the SRI (Servicio de Rentas Internas) in Ecuador. - Added button action to generate the ATS report in XML, in Accounting > Reports > Tax Report. - The ATS is generated per month. - Non-blocking error notifications in the ATS XML generation process [Purchase Document Reports] - Local and foreign purchase documents grouped by partner and tax support. - All pre-printed and electronic purchasing documents are included. - Total amounts of profit and VAT in withholding taxes for the purchase documents to be declared in the selected period. - Report pre-printed and electronic withholdings for each purchase document, if it was generated for that purchase document and the withhold date is in the search period. [Report sales documents] - Pre-printed and electronic sales documents grouped by partner. [Report void documents] - Pre-printed and electronic documents canceled in the selected period. - Canceled sales, purchase and withholding documents are included. Task: 3303501 _____________ [FIX] l10n_ec_reports: Fix manifest icons options - Add 'countries' option in the module manifest - Delete static files. This way of displaying icons is deprecated. _____________ [IMP] l10n_ec_edi: Cases to show and edit EC authorization number - Hide EC authorization number for not EC documents, documents without a document type and if the document is not a withhold - Allow editing of the authorization number for EC pre-printed and manual documents - Do not allow the editing of electronic documents Forward-Port-Of: odoo/enterprise#54762
Forward-Port-Of: odoo/enterprise#53789
Original PR description
Forward-Port-Of: odoo/enterprise#53789
Steps to reproduce: - Install the planning app and Studio. - Go to the planning app and trigger studio to edit. - Change the `Day Precision` to `Quarter Hour`. - Close and now click on `Week` and change the view to `Day`. The issue is that since the gantt is generated based on the screen size of the user in order to fit the whole gant in that width, when we divide the cell in 4 or even 2, the totals are going to overlap in smaller screens since there's no space for that division to disp
Original PR description
Steps to reproduce: - Install the planning app and Studio. - Go to the planning app and trigger studio to edit. - Change the `Day Precision` to `Quarter Hour`. - Close and now click on `Week` and…
Steps to reproduce: - Install the planning app and Studio. - Go to the planning app and trigger studio to edit. - Change the `Day Precision` to `Quarter Hour`. - Close and now click on `Week` and change the view to `Day`. The issue is that since the gantt is generated based on the screen size of the user in order to fit the whole gant in that width, when we divide the cell in 4 or even 2, the totals are going to overlap in smaller screens since there's no space for that division to display the totals horizontally. But in the other hand If we display the totals vertically and make them have a responsive fontsize, it will be visible for pretty much every screen size. Before:  After:  Note: It will also change for when we don't need to divide the cells, but I'm not sure of an easier solution to this. opw-3538039 Forward-Port-Of: odoo/enterprise#50763
Before this commit, the report Finished Product PDF (mrp.label_production_view_pdf) was editable. Though this report really doesn't play well in the report editor as the xml contains a lot of code and the model on this report is wrong, meaning that "docs" does not refer to the actual data that report contain eventually. After this commit, this report cannot be edited via studio as it is too specific. opw-3650049 Forward-Port-Of: odoo/enterprise#54487
Original PR description
Before this commit, the report Finished Product PDF (mrp.label_production_view_pdf) was editable. Though this report really doesn't play well in the report editor as the xml contains a lot of code and the model on this report is wrong, meaning that "docs" does not refer to the actual data that report contain eventually. After this commit, this report cannot be edited via studio as it is too specific. opw-3650049 Forward-Port-Of: odoo/enterprise#54487
Activate 'Budget Management' In Accounting>Configuration>Management>Budgetary Positions Create a new Budgetary Position Add some accounts Save Remove an account Save ValidationError: The budget must have at least one account This occurs because there was a change in the write commands sent Up to saas-16.4 we used to receive `{'account_ids': [[Command.set, False, ids]]}` We now have something like `{'account_ids': [[Command.unlink, id]]}` and the old way of checking the updated `a
Original PR description
Activate 'Budget Management'
In Accounting>Configuration>Management>Budgetary Positions
Create a new Budgetary Position
Add some accounts
Save
Remove an account
Save
ValidationError: The budget must have at least one account
This occurs because there was a change in the write commands sent Up to saas-16.4 we used to receive
`{'account_ids': [[Command.set, False, ids]]}`
We now have something like
`{'account_ids': [[Command.unlink, id]]}`
and the old way of checking the updated `account_ids` no longer works
opw-3633650
Forward-Port-Of: odoo/enterprise#54323### Steps to reproduce * attempt to import an asset (CSV or XLSX file) with a value for a `journal_id` related field. That value will not be automatically matched with an Odoo Field. If you try to set it by manually, that field won't appear in the list of available fields. ### Cause In 16, even though a field was read-only, we would still allow it to be imported [depending on the 'states' field](https://github.com/odoo/odoo/blob/78bb35ae0f33777af003db310a59d807182008d5/addons/base_i
Original PR description
### Steps to reproduce * attempt to import an asset (CSV or XLSX file) with a value for a `journal_id` related field. That value will not be automatically matched with an Odoo Field. If you try to set it by manually, that field won't appear in the list of available fields. ### Cause In 16, even though a field was read-only, we would still allow it to be imported [depending on the 'states' field](https://github.com/odoo/odoo/blob/78bb35ae0f33777af003db310a59d807182008d5/addons/base_import/models/base_import.py#L288-L294) attribute. But since that attribute has been removed, a read-only field cannot be set trough import. ### Fix This commit makes the assets' `journal_id` field not read-only. The usual behavior (read-only if not in draft) remains unchanged because the views were already adapted accordingly. opw-3635484 Forward-Port-Of: odoo/enterprise#52872