Tuesday, January 30, 2024
8 changes · 17.0
Resolved issues and error corrections
The Employee app now shows a more appropriate title when adding resume experience entries, instead of incorrectly displaying "Select Skills." This reduces confusion for HR users managing employee resume information.
Original PR description
**Current behavior:** Using the resume_one2many widget renders a view whose title is the same as the skills_one2many widget. --- **Expected behavior:** The resume_one2many widget will render a view with a more relevant title. --- **Steps to reproduce:** 1. In the Employee application, select or create and employee 2. In the 'Resume' notebook tab, add a new entry in their 'Experience' section 3. The view rendered here is titled "Select Skills" --- **Cause of the issue:** The resumeX2ManyField class extends skillsX2ManyField, inheriting its title. --- **Fix:** Setup resumeX2ManyField independent of skillsX2ManyField and give it a unique title. --- opw-3687865
This fixes an issue in Field Service Sales where manually invoiced service quantities could not be decreased from the product catalog. Users can now correct service quantities more easily, helping keep orders and invoices accurate.
Original PR description
Task-3689939
Fixed a payslip display issue where a sample amount could appear even when real payroll values were present. This prevents confusing or misleading information from showing on employee payslip reports.
Original PR description
100$ should be a placeholder, but is outside of the span, so it is always displayed instead of only when there is no values.
This update removes an unnecessary variable that was being sent when the POS system communicates with IoT devices for password management. By eliminating this unused parameter, the system will no longer generate warning messages in the IoT logs, resulting in cleaner system operations and easier troubleshooting.
Original PR description
In iot, when we send a request to the route '/hw_posbox_homepage/password' we pass a variable which is unused. And which therefore causes a warning in the iot logs. This commit removes the query parameter. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#151505
This fix prevents the creation of massive unnecessary log files when running tests that fail. The issue occurred because a background process was trying to write screencast files without first checking if the required directory existed, causing a race condition. The fix simply ensures the directory is checked before writing, eliminating the problematic logs.
Original PR description
Without this patch, running this command on an environment where the tour will fail, will create massive and useless logs:
odoo --stop-after-init -i auth_totp --test-enable --test-tags /auth_totp
[Excerpts of those massive useless logs](https://github.com/odoo/odoo/files/14065596/odoo.log.txt)
This is because this method is a callback that can come in a different thread, creating a race condition.
There's no problem on checking wether the directory exists before creating the file, and then safeguarding from the problem.
@moduon MT-1075
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#151364Miscellaneous changes
Task: 32588 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#150759 Forward-Port-Of: odoo/odoo#146491
Original PR description
Task: 32588 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#150759 Forward-Port-Of: odoo/odoo#146491
With opw 3680495, input fields can trigger more often what happens when the change event is triggered, because of a soften condition. fsm_product_quantity widget has a feature to trigger the onchange event on enter keydown. The code would trigger manually a change and blur event. This is problematic as the enter key would already trigger a change. With the fix in opw 3680495, the server would be called twice and would wrongly duplicate the set values. Also, a test would first make use
Original PR description
With opw 3680495, input fields can trigger more often what happens when the change event is triggered, because of a soften condition. fsm_product_quantity widget has a feature to trigger the onchange…
With opw 3680495, input fields can trigger more often what happens when the change event is triggered, because of a soften condition. fsm_product_quantity widget has a feature to trigger the onchange event on enter keydown. The code would trigger manually a change and blur event. This is problematic as the enter key would already trigger a change. With the fix in opw 3680495, the server would be called twice and would wrongly duplicate the set values. Also, a test would first make use of editInput to change the value then trigger the keydown event to access the mockRPC logic. This test was not working properly. The editInput was triggering a change event and the mock rpc logic was ran. Then the widget would set back the value 0. Then, the keydown event was triggered but the onchange logic was never ran cause of the problem solved in opw 3680495 (a value set, then changed, then set back to the first value). So the keydown trigger was basically untested. Forward-Port-Of: odoo/enterprise#55291 Forward-Port-Of: odoo/enterprise#54983
Steps to Reproduce =================== 1. Create an event (e.g. starting at 9:00 AM) 2. People arrive early and attempt to scan a badge at 7:30 AM --> An error occurs: "Not part of an ongoing event" Technical Reason ================= Before this PR we were considering both date and time due to this is_ongoing was set as false. So to support early entrance we removed the old condition and added a new condition. After this PR ================= It will let you scan badge
Original PR description
Steps to Reproduce =================== 1. Create an event (e.g. starting at 9:00 AM) 2. People arrive early and attempt to scan a badge at 7:30 AM --> An error occurs: "Not part of an ongoing event" Technical Reason ================= Before this PR we were considering both date and time due to this is_ongoing was set as false. So to support early entrance we removed the old condition and added a new condition. After this PR ================= It will let you scan badges and verify attendees as long as the event is not finished. Task-3596660 Forward-Port-Of: odoo/enterprise#54182