Wednesday, January 31, 2024
13 changes · master
Enhancements to existing features
Automated tests now run with stricter validation enabled, helping catch component setup issues earlier before they reach users. This improves quality assurance across the web interface and related website learning features without changing day-to-day user behavior.
Original PR description
This commit ensures tests are run in debug mode so that props validation is required for tests to pass. This was supposed to be part of https://github.com/odoo/odoo/pull/143209 but was mistakenly removed by a conflict.
The web module's internal HTTP service tests were moved to a newer testing framework. This helps maintain the quality and reliability of web networking behavior without changing what end users see.
Original PR description
task-id: 3705027
Resolved issues and error corrections
Indian GST return reporting now uses the existing EDI production environment setting instead of a separate GST-specific setting. This reduces configuration duplication and helps ensure GST reports follow the same production/test mode as other Indian e-invoicing features.
Original PR description
Before this PR:- l10n_in_gstr_gst_production_env not needed because we already have l10n_in_edi_production_env After this PR:- Change the value coming from l10n_in_gstr_gst_production_env to l10n_in_edi_production_env. Task - 3271172
Code cleanup and technical improvements
The spreadsheet chart side panels have been rebuilt using shared interface building blocks. This keeps the user experience consistent while making future updates easier and less risky.
Miscellaneous changes
Issue: This PR (https://github.com/odoo/odoo/pull/145412) wrongly removes "vat_required" option from "Domestique - France" fiscal postion. Solution: Set "vat_required" option back. opw-3617761 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#151629 Forward-Port-Of: odoo/odoo#151518
Original PR description
Issue: This PR (https://github.com/odoo/odoo/pull/145412) wrongly removes "vat_required" option from "Domestique - France" fiscal postion. Solution: Set "vat_required" option back. opw-3617761 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#151629 Forward-Port-Of: odoo/odoo#151518
This update resolves internal validation issues affecting planning and payroll interface components. It helps keep automated checks reliable and reduces the risk of small display or test failures after recent validation changes.
Original PR description
This commit fixes props validation errors linked to the introduction of props validation in tests of https://github.com/odoo/odoo/pull/151027
The accounting test suite was updated to match a related change in how messaging data is requested. This helps keep automated checks reliable without changing day-to-day user workflows.
Original PR description
community: https://github.com/odoo/odoo/pull/151722
Commit [1] solved an unseen issue with the configurator introduced with commit [2]. It was preventing the website configurator to go through in some cases, which was detected on odoo.com/trial the day the 17.1 became available there. The fix was quickly deployed, but it was actually not enough.. Indeed, Odoo.com trial databases are not created from scratch but indeed are using custom odoo DB images. Those images are not sync'd with the code where they run obviously (we don't create new ima
Original PR description
Commit [1] solved an unseen issue with the configurator introduced with commit [2]. It was preventing the website configurator to go through in some cases, which was detected on odoo.com/trial the…
Commit [1] solved an unseen issue with the configurator introduced with commit [2]. It was preventing the website configurator to go through in some cases, which was detected on odoo.com/trial the day the 17.1 became available there. The fix was quickly deployed, but it was actually not enough.. Indeed, Odoo.com trial databases are not created from scratch but indeed are using custom odoo DB images. Those images are not sync'd with the code where they run obviously (we don't create new images everytime we update our /trial production). Because of that, the fix made at [1] was not enough, as it relied on website module installation. It was quickly done to "revive" the configurator on the production. The biggest problem is actually the fact that there is no workaround this blocked configurator screen: no skip button, no redirect button, nothing. That part will be handled in an upcoming task, see [3], which will mitigate the issue as if the configurator were to be blocked again later, there would be a way for the user to "continue". The fix here is about reverting commit [2] to not take any risk. It means that it will load configurator templates from all themes, even uninstalled ones, but it will reduce the risk of a configurator failure drastically. Steps to reproduce: - Checkout git before commit [1] - Start with `odoo-bin -i website` and design-themes in the addons path. - Create a new website. - Generate a website with "About Us", "Services", "Pricing" and "Privacy Policy". - ERROR: It will crash - Now checkout after commit [1] - Try again the configurator: it will crash. (But note that it will be enough to fix DB created after commit [1]) - Now checkout this commit - Try again the configurator: it works [1]: https://github.com/odoo/odoo/commit/9ae5e2bb25ea164264aeab7e45f53472a7d6aa5a [2]: https://github.com/odoo/odoo/commit/cfed4e391d11058b1b46417f0b630cdbc4070d7c [3]: https://www.odoo.com/web#menu_id=4720&cids=1&action=333&active_id=974&model=project.task&view_type=form&id=3709708 Forward-Port-Of: odoo/odoo#151806
With this commit, the button "duplicate" when you selected some attendances is not shown anymore. task : 3646395 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#147276
Original PR description
With this commit, the button "duplicate" when you selected some attendances is not shown anymore. task : 3646395 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#147276
Fix 1: Before this commit, the smart button on the employee would display `x/y` Time Off, indicating remaining leaves over max leaves. However, while `y` was correctly taking into account current allocations only, `x` didn't, resulting in incoherent values. Reproduce the issue: - For an employee, create an expired allocation and validate it of x days; - Create an additional allocation which is still valid today of y days and validate it as well; - Go on the employee form view; - Time O
Original PR description
Fix 1: Before this commit, the smart button on the employee would display `x/y` Time Off, indicating remaining leaves over max leaves. However, while `y` was correctly taking into account current…
Fix 1: Before this commit, the smart button on the employee would display `x/y` Time Off, indicating remaining leaves over max leaves. However, while `y` was correctly taking into account current allocations only, `x` didn't, resulting in incoherent values. Reproduce the issue: - For an employee, create an expired allocation and validate it of x days; - Create an additional allocation which is still valid today of y days and validate it as well; - Go on the employee form view; - Time Off smart button display (x+y)/y instead of y/y Fix 2: Before this commit, there was no way to track error inducing leaves that were created through a bug or that were already created in the database prior to the changes brought in version 17.0. This commit adds a new property in the leave data indicating the id and the start date of the leave that is causing the discrepancies in the database and displays a warning on the dashboard if there are some error inducing leaves. Forward-Port-Of: odoo/odoo#151693 Forward-Port-Of: odoo/odoo#151288
- Improved the UX of the product configurator. - Display of attribute name in orderline name. Previously, the user had to click on the checkbox or radio to select the option, clicking on the label didn't work. The attribute name was not displayed in the orderline name, only the values. Now the input has been replaced by a button, making it easier to use on touch-screen devices. The attribute name is displayed in the orderline name in the format `Size: M, Fabric: Leather`. task-363819
Original PR description
- Improved the UX of the product configurator. - Display of attribute name in orderline name. Previously, the user had to click on the checkbox or radio to select the option, clicking on the label didn't work. The attribute name was not displayed in the orderline name, only the values. Now the input has been replaced by a button, making it easier to use on touch-screen devices. The attribute name is displayed in the orderline name in the format `Size: M, Fabric: Leather`. task-3638192 task-3633555 Forward-Port-Of: odoo/odoo#150962 Forward-Port-Of: odoo/odoo#147744
**Before this commit:** When a user adds a tip and removes it by hitting multiple backspaces, a traceback occurs. The value passed as the tip was supposed to be an empty string if no tip is applied, but it received a null value, causing a traceback. **After this commit:** The tip value is checked to be a truthy value. If it is not a truthy value, then an empty string is passed, resolving the traceback. task-3692849 Forward-Port-Of: odoo/odoo#151419 Forward-Port-Of: odoo/odoo#1505
Original PR description
**Before this commit:** When a user adds a tip and removes it by hitting multiple backspaces, a traceback occurs. The value passed as the tip was supposed to be an empty string if no tip is applied, but it received a null value, causing a traceback. **After this commit:** The tip value is checked to be a truthy value. If it is not a truthy value, then an empty string is passed, resolving the traceback. task-3692849 Forward-Port-Of: odoo/odoo#151419 Forward-Port-Of: odoo/odoo#150586
The helper `toggleCogMenuSpreadsheet`is quite slow atm. As much as this should be investigated, there is a quick win by cutting in the functional flow to insert a list in a spreadsheet and rely on the implementation by triggering the bus event related to tje insert of the list in a spreadsheet. This revision speeds up the related concerned tests by ~6.2 seconds on a local installation. Testing the modules `documents_spreadsheet > list view` and `documents_spreadsheet > insert_list_spreadsh
Original PR description
The helper `toggleCogMenuSpreadsheet`is quite slow atm. As much as this should be investigated, there is a quick win by cutting in the functional flow to insert a list in a spreadsheet and rely on the implementation by triggering the bus event related to tje insert of the list in a spreadsheet. This revision speeds up the related concerned tests by ~6.2 seconds on a local installation. Testing the modules `documents_spreadsheet > list view` and `documents_spreadsheet > insert_list_spreadsheet_menu`: Average on 10 runs Before: 11600 ms After: 5400 ms Forward-Port-Of: odoo/enterprise#55337 Forward-Port-Of: odoo/enterprise#55202