Saturday, February 3, 2024
4 changes · master
Code cleanup and technical improvements
This update improves the reliability and efficiency of automated tests for online sales, delivery, product, and sales workflows. It also corrects a company-specific delivery provider issue so unavailable carriers from other companies no longer affect checkout display decisions.
Original PR description
--- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update moves character field checks in the web module to a newer testing system and fixes an issue in the test mock behavior. It helps developers catch problems more reliably without changing day-to-day user workflows.
Original PR description
[[REF] web: hoot: char_field conversion](https://github.com/odoo/odoo/pull/152305/commits/f503ad9ab0a9b92826134ee6e1d80022703e90b8) ----------- This commit converts the legacy char_field tests to the new test framework. task-3705027 [[FIX] web: hoot: return boolean in set handler](https://github.com/odoo/odoo/pull/152305/commits/6131730088a1a41aff38fa4b76d3e67598e10024) ----- According to [1] set should: - Return true to indicate that assignment succeeded. - if the set() method returns false, and the assignment happened in strict-mode code, a TypeError will be thrown. Before this commit, the set handler did not return anything, which resulted in the TypeError being thrown. Now, the set handler does return a boolean. [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/set
This update simplifies internal naming in Odoo's mail and live chat code, making it easier for developers to maintain. It should not change day-to-day user behavior, but it reduces future complexity and risk around chat and messaging features.
Original PR description
[REF] mail, *: rename originThread to thread [REF] mail, im_livechat: use channel_type rather than type [REF] mail, *: rename followedThread to thread https://github.com/odoo/enterprise/pull/55645
This update simplifies internal naming in messaging-related features and aligns WhatsApp channel data with the standard channel field. It should not change user workflows, but it helps reduce maintenance complexity and supports more reliable future improvements.
Original PR description
[REF] mail, *: rename originThread to thread [REF] whatsapp: use channel_type rather than type https://github.com/odoo/odoo/pull/152320