Tuesday, February 13, 2024
13 changes · 17.0
Enhancements to existing features
This update fixes a test in the subscription module that was failing when run at midnight due to timing-related issues. The improvement ensures the test runs reliably at any time of day, making the system more stable and reducing false test failures.
Original PR description
runbot task: 55516 Forward-Port-Of: odoo/enterprise#55732
This update allows businesses to customize which product is used when applying discounts to sales orders. Previously, the discount product was fixed, but now developers can override it to match specific business needs. This provides greater flexibility for companies with unique discount product requirements.
Original PR description
Add method '_get_discount_product' to allow to override the product used by the sale_order_discount wizard.
This update improves the code comments in the web editor's image processing method to better explain how image customization works. The change clarifies technical limitations around customizing images added via URLs, helping developers understand the system's behavior and constraints.
Original PR description
The goal of this commit is to impove the comment in the `loadImageInfo` method. Forward-Port-Of: odoo/odoo#153554 Forward-Port-Of: odoo/odoo#153438
Resolved issues and error corrections
Fixes a Todo kanban display issue where personal stages could reappear after being deleted in sequence. This prevents users from seeing outdated “ghost” stages that were already removed, reducing confusion and avoiding errors until the view is refreshed.
Original PR description
This commit's purpose is to fix the re apparition of personnal stage on the todo app when personnal stages are deleted one after the other. Step to reproduce: -login as Marc demo -open todo -delete…
This commit's purpose is to fix the re apparition of personnal stage on the todo app when personnal stages are deleted one after the other. Step to reproduce: -login as Marc demo -open todo -delete any personnal stage without any todo in it -delete any personnal stage with at least one todo in it The personnal stage deleted first is now present again in the kanban view. Note that it is only a frontend bug. The record has been correctly removed from the db, and any action with it will trigger a cache miss exception and reloading the view completly will removed those ghost stages definitly. Source of the problem: The problem is that the deletion is only reloading the view completly when a record with child data is removed. More precisly, the _deleteGroup function of the dynamic list triggers an rpc call to update the config of the component only when a record with child data is deleted, and that data need to be switched to another record, while when it is an empty record, the record is simply removed from the group field of the list. The issue is that there is thus a mismatch between the group in the list.config.groups and the list.group. And when the config is updated, only the list.config.groups is used to update the config, meaning it potentially still contains element that were already deleted. Solution: Doing a check up on the list.group to ensure that any deleted element is also removed from the config when an update is triggered. Note: I dont why Mitchel admin did not trigger the bug. Code wise, it should happends no matter the access right of the connectedd user. Version affected: master task - 3553101 https://www.odoo.com/web#id=3553101&menu_id=4720&cids=1&action=333&active_id=4105&model=project.task&view_type=form Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Code cleanup and technical improvements
The intrastat report's query building function has been reorganized and simplified to improve code clarity and reliability. This cleanup helps prevent technical issues with the system's security checks and makes the code easier to maintain going forward.
Original PR description
`_build_query` is a rat's nest of randomly sprinkled `SQL`, which seems to end in the sql injection checker getting confused and non-deterministic. Do some cleaning to try and make it more understandable for the linter. Forward-Port-Of: odoo/enterprise#56367
Miscellaneous changes
terms were changed in pull [147944](https://github.com/odoo/odoo/pull/147944) but not updated in 15.0 and 15.2 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#153590
Original PR description
terms were changed in pull [147944](https://github.com/odoo/odoo/pull/147944) but not updated in 15.0 and 15.2 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#153590
The Peru localization now allows export invoices to use the required invoice document type instead of being limited to receipt-style documents. This prevents incorrect document restrictions for export sales and helps businesses issue compliant invoices.
Original PR description
In commit https://github.com/vauxoo-dev/odoo/commit/355250d062fb8dde558d21ea861b9af578545fe0, the domain was adjusted to automatically select the invoice document type for customers with a RUC and limit others to the "boleta" document type. This generally holds true, except for export invoices requiring the 01 document type. This commit addresses the current restriction, allowing the selection of document type 01 other than "boleta" or "debit note boleta.
This update adds an extra safeguard when invoicing sales orders that include recurring products but do not have a recurring plan set. It helps avoid unexpected crashes in edge cases, improving reliability without changing the normal subscription workflow.
Original PR description
We prevent creating subscription sale orders with recurring products and no recurring plans However it's better to be defensive to avoid crashes. This commit adds an additional condition before accessing order_id.plan_id Task: 3725476
This fix removes restrictions that prevented editing certain accounting fields on product templates when they weren't marked as purchasable. The fields for expense accounts and price differences are now always editable, simplifying the system and avoiding unnecessary complexity across modules.
Original PR description
Product template "property_account_expense_id" and "property_account_creditor_price_difference" fields must stay editable in cases even if not "can be puchased". Since it being readonly is trivial, better leave it writeable instead of implementing cross module readonly logic. Task: 3695677
The AI writing assistant option has been removed from the toolbar when images are selected, since AI-generated text would replace the image rather than enhance it. The AI option now only appears when working with text, making the toolbar more intuitive and preventing confusing user experiences.
Original PR description
Specification: This commit targets the scenario when an image is in the selection and the toolbar displays an AI option, which makes no sense as the generated response will replace the image. Desired behavior after PR is merged: The toolbar has been updated to show the AI option only for text-based scenario task-3733320
This update corrects the spacing of the activity button in the messaging interface. A previous change had added extra spacing to separate the activity button from communication-related buttons, but this spacing was not desired. This fix restores the original spacing to improve the visual layout of the interface.
Original PR description
In https://github.com/odoo/odoo/commit/e0491c1a623ffec19ed563679f853cc6d1c56d03 we changed the spacing of the activity button to dissociate it from buttons that are "message/communication" oriented. This spacing was unwanted so we need to revert it back. task-3730089 | Before | After | | --- | --- | | | | --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update corrects the visual styling of forecast icons in the sales inventory module to match other similar icons throughout the system. The icon color and hover behavior have been adjusted to provide a more consistent and intuitive user experience when interacting with forecast information.
Original PR description
This PR fixes an unconsistent forestack icon within the `sale_stock` module. Prior to this PR, the forecast icon was using a `text-primary` class, making it unconsistent regarding the other forecast icons. We also add a missing `cursor-pointer` class to fix the improve the hover state and the visual feedback of the link. task-3582145 Forward-Port-Of: odoo/odoo#140959
Before this commit: - The tour does not prompt us to close the preview. Reason: - The selector passed inside the trigger is no longer available. (i.e. after saas-15.2). After this commit: - We now get the prompt to close the preview. Forward-Port-Of: odoo/enterprise#56240 Forward-Port-Of: odoo/enterprise#55096
Original PR description
Before this commit: - The tour does not prompt us to close the preview. Reason: - The selector passed inside the trigger is no longer available. (i.e. after saas-15.2). After this commit: - We now get the prompt to close the preview. Forward-Port-Of: odoo/enterprise#56240 Forward-Port-Of: odoo/enterprise#55096