Tuesday, February 13, 2024
5 changes · saas-17.1
Resolved issues and error corrections
Messages whose original author contact was deleted now remain visible without errors. The message shows a default avatar and uses the sender email as the author name, keeping chatter histories readable for users.
Original PR description
Description of the issue/feature this PR addresses: Prerequisite: - User A (admin) - User B (random internal) Steps: - Login as B - Find a chatter and send a log note or a message - Logout - Login with A - Delete user B and the contact related - Open the same chatter than above Current behavior before PR: - Multiple traceback due to "no author" - No avatar Desired behavior after PR is merged: - No traceback - Message avatar is the default one / the placeholder - Message author name is the email_from field opw-3743727 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an error that could occur when showing sample document data if a generated value triggered an unintended thumbnail update. The change makes sample values safer for selection fields, improving reliability when users preview or test the Documents app.
Original PR description
Bug === When we show the sample data of documents, it will choose a random value for the selection field. But document use a special option to make the browser generate the thumbnail of PDFs and then save it on the record. So, without this rule, it will try to update the record if "client_generated" has been chosen. Task-3697924
This update makes an internal quality check run consistently by processing files in a stable order. It helps avoid random failures during development and release validation, reducing noise for teams without changing customer-facing behavior.
Original PR description
pylint sql-injection check may fail because of random checking paths' order this commit fixes the issue by sorting these paths this fix is also a backport commit from https://github.com/odoo/odoo/pull/142814 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Opening the Documents app with sample data could sometimes fail when a randomly chosen thumbnail option tried to update a sample record. This fix prevents that incorrect option from being used, so sample documents load reliably for users evaluating or demonstrating the app.
Original PR description
Bug === When we show the sample data of documents, it will choose a random value for the selection field. But document use a special option to make the browser generate the thumbnail of PDFs and then save it on the record. So, without this rule, it will try to update the record if "client_generated" has been chosen. Task-3697924 See odoo/odoo/pull/152490
Currently, a log error is occurring from [1] and [2] due to adding two msgids instead of one there in the 'es_419.po' file. This is because the recently refactored code https://github.com/odoo/enterprise/commit/c2a5c5950cf702c6ed77d8b94c7dfece3f127dc8 updated translations but added an extra msgid at [1] and [2]. Error ``` KeyError: ('mi', 'mi') File "polib.py", line 1491, in process (action, state) = self.transitions[(symbol, self.current_state)] OSError: Syntax error in po fil
Original PR description
Currently, a log error is occurring from [1] and [2] due to adding two msgids instead of one there in the 'es_419.po' file. This is because the recently refactored code…
Currently, a log error is occurring from [1] and [2] due to adding two msgids instead of one
there in the 'es_419.po' file. This is because the recently refactored code https://github.com/odoo/enterprise/commit/c2a5c5950cf702c6ed77d8b94c7dfece3f127dc8
updated translations but added an extra msgid at [1] and [2].
Error
```
KeyError: ('mi', 'mi')
File "polib.py", line 1491, in process
(action, state) = self.transitions[(symbol, self.current_state)]
OSError: Syntax error in po file (line 281)
File "odoo/tools/translate.py", line 1660, in _get_code_translations
p = CodeTranslations._read_code_translations_file(fileobj, filter_func)
File "odoo/tools/translate.py", line 1647, in _read_code_translations_file
reader = TranslationFileReader(fileobj, fileformat='po')
File "odoo/tools/translate.py", line 636, in TranslationFileReader
return PoFileReader(source)
File "odoo/tools/translate.py", line 691, in __init__
self.pofile = polib.pofile(source.read().decode())
File "polib.py", line 130, in pofile
return _pofile_or_mofile(pofile, 'pofile', **kwargs)
File "polib.py", line 78, in _pofile_or_mofile
instance = parser.parse()
File "polib.py", line 1352, in parse
self.process(keywords[tokens[0]])
File "polib.py", line 1495, in process
raise IOError('Syntax error in po file (line %s)' %
```
[1]-https://github.com/odoo/enterprise/blob/8e8e5b2f01c75f0131d8248997fa4059777e3fa1/l10n_ar_reports/i18n/es_419.po#L280-L281 [2]-https://github.com/odoo/enterprise/blob/8e8e5b2f01c75f0131d8248997fa4059777e3fa1/l10n_ar_reports/i18n/es_419.po#L459-L460
sentry-4963679418