Thursday, February 15, 2024
2 changes · 17.0
Resolved issues and error corrections
This fix resolves a bug where comments and messages were not loading properly in the Knowledge module. Previously, only one comment thread would display messages while others remained empty, potentially causing users to lose comments and preventing the main message area from showing updates. The fix ensures each comment section loads its messages independently without interfering with others.
Original PR description
This commit fixes a bug where the Comments would only load one of the different Components present inside of the view, meaning that only one thread would show their messages. This leads to possible losses of comments and the main chatter being unable to show messages. The issue was that both the comments and the form view shared a singular chatter object in the environment. This object enables the Thread component to know if it needs to either load more data or messages via two booleans: `fetchData` and `fetchMessages` that would be set to false when the Thread finished fetching either messages or data. To fix this, the chatter in the environment below the Comment level was set to false, as the condition to fetch data and messages is `!this.env.chatter || this.env.chatter?.fetchData`. This way when OWL mounts each Comment Component it will fetch the necessary data without impacting each other and the Form view's main chatter. task-3714345
This fix resolves an issue where customers couldn't complete payments for subscriptions using Stripe payment links. The problem occurred because a recent code update removed information that Stripe needs to properly handle recurring subscription payments. This update restores that information specifically for subscription transactions.
Original PR description
In odoo/odoo@7e012dd, `_get_custom_rendering_context_values` was refactored and renamed `_get_extra_payment_form_values`. `sale_order_id` was mainly used for reconciliation in the transaction route and was removed from the extra payment form values as it was not needed anymore. Unfortunately, Stripe still needs `sale_order_id` for subscriptions, to compute whether the tokenization is required. This commit adds `sale_order_id` back in the extra payment form values when the Subscription app is installed. --- Steps to reproduce: 1. Configure Stripe; 2. Create a subscription with at least one recurrent product; 3. Generate a payment link and try to pay.