Tuesday, February 20, 2024
10 changes · saas-17.1
Resolved issues and error corrections
Opening page properties in debug mode no longer triggers an error caused by internal validation of the page form component. This keeps website page administration working smoothly for users and developers using debug mode.
Original PR description
Since [1], the clonePage and deletePage callbacks are props. This commit addresses the validation of component props specifically in development mode. It specializes the FormController component to be utilized by the PagePropertiesDialog component, resolving the issue. Steps to Reproduce: - Enter debug mode. - Navigate to any website page in the backend. - Click on page properties. Result: A traceback appears stating "Invalid props for component 'FormController'." [1]: https://github.com/odoo/odoo/commit/3242abc4bdb51e24dff8069cedb762677da611d9 task-3746498
Resending a signature document now works without triggering an error. This prevents interruptions for users who need to resend documents for signing and keeps the signing workflow reliable.
Original PR description
After the conversion of the user service to a simple module, a traceback started happening when trying to resend a document. This was due to the missing conversion of the user service paradigm to the module one for that specific flow. This commit fixes this by using the user module instead of the user service. task-3710633
This update resolves an issue where Odoo was displaying error messages from external pages when the live chat was embedded. The change removes a problematic error service that was incorrectly catching errors, leading to disruptive popups. This improves the user experience for live chat embeds.
Original PR description
Before this commit, an Odoo dialog would open to show errors that occurred in the pages embedding the live chat. We should not display errors originating from outside the embedded script. Moreover, the error service listens to the error event on the window object. Thus, errors occurring in the shadow DOM won't be caught. As a result, the error service disrupts the site that embeds it and is entirely useless for the live chat. This PR removes the error service from the embedded live chat. OPW-3699040 Forward-Port-Of: odoo/odoo#154102 Forward-Port-Of: odoo/odoo#154012
This update resolves a visual issue where tables within task descriptions would sometimes overflow the designated field, particularly when a new row was added above. The fix ensures that table widths are only set on the initial row, allowing for scrollable tables and preventing layout problems. This improves the user experience when creating and viewing task descriptions.
Original PR description
Reproduction: 1. In project -> task, create a new task 2. In the description, make a table of 1 row 2 columns, type two line long string in the second cell 3. Create a row above, type anything short, save 4. Add the portal user as follower, e.g. search user joel 5. In an incognito tab log in with portal portal, check the task and the table is out of the field Fix: Only set the width of the cells when it’s the first row and there’s other preset style of width for existing cells task-3559104 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#154569 Forward-Port-Of: odoo/odoo#139016
This update resolves a bug where cursor movement near zero-width spaces in the editor caused the cursor to jump to the wrong block. The fix ensures accurate navigation within the editor, preventing users from unintentionally bypassing sections of text. This improves the overall editing experience.
Original PR description
Description of the issue this PR addresses: In cases where the cursor is at the end of the current block and the next block begins with a zero-width space, the mechanism that skips these characters while using arrow keys should not traverse all the way to the end of the zero-width space in the next block. Because this mechanism operates before the browser applies its own behavior for arrow keys, potentially causing the cursor to jump to the start of the third block when second block only contains a zero-width space, completely bypassing the second block. Conversely true for the arrow left keys. This commit ensures that the navigation does not extend beyond the current block when searching for a `newFocusNode` when moving with arrow keys near zero-width space. task-3653307 Forward-Port-Of: odoo/odoo#154676 Forward-Port-Of: odoo/odoo#153217
This update resolves an issue where clicking a document multiple times in the Documents activity view would open multiple 'Schedule Activity' wizards. The fix ensures that the wizard opens only once, streamlining the scheduling process and preventing user frustration with lingering windows.
Original PR description
**Steps to reproduce:** - Go to Documents activity view. - Click on Schedule activity. - Perform multiple clicks on any document. **Issue:** The 'Schedule Activity' wizard opened as many times as the document was clicked. As a result, even after successfully scheduling an activity on that document, the user still faced multiple open wizards remaining and had to manually close each one of them. **Fix:** This PR introduces a method `executeOnceAndClose` which makes use of a flag 'busy' to ensure that the `onSelected` function is called only once and hence exactly one `Schedule Activity` wizard is opened, despite clicking a record more than once. Task: [3721404](https://www.odoo.com/web#id=3721404&menu_id=4722&cids=2&action=333&active_id=10888&model=project.task&view_type=form) Forward-Port-Of: odoo/odoo#154442 Forward-Port-Of: odoo/odoo#153869
This update corrects a bug where a purchase bill automatically assigned the salesperson from the original purchase order, even when a different user (the purchase representative) created the bill. This ensures bills are correctly associated with the intended buyer, preventing unnecessary notifications and streamlining the billing process. This change improves data accuracy and user experience.
Original PR description
Steps to reproduce: - Install Accounting and Purchase - Create a PO with Purchase Representative different from current user (e.g. Marc Demo) 1) - Mark the product as received - Create a bill from PO 2) - Go to Accounting - Create a bill - Select the PO in Auto-Complete field - Save the bill Issue: The Purchase Representative of the PO is set as Salesperson (hidden field) of the bill. He should not. The default user (i.e. the current user) should be the Salesperson. In the second case, by adding the purchase representative as Salesperson of the bill, he is also added as a follower of the bill and he receives a notification about being assigned to the bill. opw-3677713 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#154356 Forward-Port-Of: odoo/odoo#151814
This update resolves an issue where the spreadsheet's share button dropdown menu displayed a scroll bar in certain languages. The fix adjusts the dropdown's height to automatically fit the content, ensuring a clean and consistent user experience across all languages. This improves usability for all users.
Original PR description
## Description: Previously, an issue was observed where the dropdown menu of the spreadsheet's share button displayed a scroll bar when users had selected a different language, such as French (BE). This PR addresses the problem by setting the height of the dropdown menu to auto, thereby resolving the issue of unnecessary scroll bar. Task ID: [3742260](https://www.odoo.com/web#id=3742260&cids=2&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form) Forward-Port-Of: odoo/odoo#154561 Forward-Port-Of: odoo/odoo#153834
This update corrects a bug where inactive tax settings incorrectly continued to influence fiscal position mappings. Now, when a tax is marked as inactive, it no longer affects related fiscal positions, ensuring accurate reporting and compliance. This improves data integrity within the accounting system.
Original PR description
When a tax is set to inactive, the fiscal positions mapping other taxes to it continued to apply, disregarding the fact that it shouldn't be used anymore. Not anymore with this fix. task-3751224 Forward-Port-Of: odoo/odoo#154464 Forward-Port-Of: odoo/odoo#154246
This update resolves an issue where the website editor's mobile order feature was limited to a maximum of 12 columns. The team decided to switch to inline styling to remove this restriction and ensure a more flexible layout for users. This change improves the usability of the website editor.
Original PR description
Commit [1] introduced mobile orders for columns in flex containers snippets. This was later amended with commit [2] to use Bootstrap's `order-X` classes. Finally, to be complete, commit [3] also added some manipulations around mobile orders. Those classes are limited to 12 possible orders, which means the feature stops working for any column over that threshold: a column with `order-13` will appear as if it didn't have any order. In the end, it has been decided that the trade-off of being capped at 12 mobile orders (and so 12 columns) and the behavior it causes isn't worth using the classes: we will use inline style instead. [1]: https://github.com/odoo/odoo/commit/710d000f1872fd99b41d52ec3d6923756bba7cba [2]: https://github.com/odoo/odoo/commit/143bdfa13d331b93b88e207f181840d91796cdce [3]: https://github.com/odoo/odoo/commit/7b27385dba36c2e741d96e76ad5d847d09f2b084 task-3666688 Forward-Port-Of: odoo/odoo#152024