Daily updates from Odoo
Wednesday, February 21, 2024
14 changes
10 changes
Resolved issues and error corrections
This update resolves a bug where users could see multiple quiz versions when quickly clicking the 'Done' button in the eLearning app. The fix ensures only one quiz is displayed, improving the user experience and preventing potential confusion. This change also addresses a similar issue with video content.
Original PR description
How to reproduce: 1. Open eLearning app 2. Go to any course having document with quiz. 3. Solve the quiz 4. Click multiple time quickly on 'Done' (green tick) button. 5. Multiple quiz are displayed…
How to reproduce: 1. Open eLearning app 2. Go to any course having document with quiz. 3. Solve the quiz 4. Click multiple time quickly on 'Done' (green tick) button. 5. Multiple quiz are displayed if your connection is slow or you click fast enough. The fix ensures that only one quiz is displayed. We do the same change for video to prevent such problem with them. Technical note: when clicking on the "green tick" of the quiz, the method _toggleSlideCompleted is called which cause a _renderSlide. That method clears the content div (o_wslides_fs_content) and appends a new Quiz widget to that div. The problem is that the "append" is asynchronous (it call the "willStart" of Quiz widget that fetch the quiz) so if you click multiple time, the content div is cleared multiple times and then after each quiz created is ready (after having fetched the data), they are appended to the content div, resulting in multiple quiz displayed. We solve the problem by avoiding concurrent execution of the _renderSlide method: the body of the method is skipped when the rendering is ongoing (for example while waiting the quiz from the server). As the method is inserting the slide at the same place, its behavior was anyway unpredictable because depending on the response time of each request. By skipping the method body while already running we make it a bit more predictable, avoid the content duplication on the page, and we avoid unnecessary call to the server. Task-3412847 Forward-Port-Of: odoo/odoo#154069 Forward-Port-Of: odoo/odoo#143743
This update addresses a technical issue within Odoo's core functionality related to how it processes read groups. While the underlying change might seem minor, it ensures a more robust and reliable system, preventing potential errors. This fix prioritizes stability and proper error handling.
Original PR description
Use read_group with groupby=['id'] raise a Exception:
```
File "/home/odoo/Documents/dev/odoo/odoo/models.py", line 2386, in _read_group_format_result
m2x_records = self.env[field.comodel_name].browse(ids).union()
File "/home/odoo/Documents/dev/odoo/odoo/api.py", line 521, in __getitem__
return self.registry[model_name](self, (), ())
File "/home/odoo/Documents/dev/odoo/odoo/modules/registry.py", line 190, in __getitem__
return self.models[model_name]
KeyError: None
```
While if it doesn't make much sense to do this (it's mostly equivalent to search_read), it's preferable to handle the case properly.
Forward-Port-Of: odoo/odoo#154748
Forward-Port-Of: odoo/odoo#153505This update fixes a conflict between the 'Cancel' button and its shortcut key (z) within the activity scheduling feature. The hotkey has been changed to 'x' to avoid confusion and ensure users can easily cancel scheduled activities. This improves the user experience and prevents accidental actions.
Original PR description
Since 17.0, the `Cancel` button in the `mail_activity_schedule_view_form` uses the hotkey `z`, which conflicts with the other button. Change the hotkey into `x`. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#154727
This update resolves an issue where Odoo forms crashed when adding new records linked through inherited relationships (using _inherits). The fix ensures that parent record updates only occur when the related one2many field has a valid value, preventing initialization errors and improving stability.
Original PR description
Consider models A and B such that B inherits from A (with `_inherits`), and a form view of A with a one2many field that inverses the many2one "delegate" field from B to A. When adding a new record in the one2many, `onchange()` crashes while trying to update the cache of an empty parent record. The situation is caused by how `onchange()` initializes the new record of model B, and the fact that the form provides a value for the delegate field. The new record is actually initialized with an empty value for the delegate field, which causes the code to crash. The fix simply consists in updating the parent record only if is nonempty. opw-3744514 Forward-Port-Of: odoo/odoo#154735
This update fixes an issue where HR emails sent when applicants are rejected were being automatically deleted. This prevented HR from seeing communication and gaining a complete record of applicant interactions. The change ensures that all emails related to rejected applicants are retained, providing a more accurate and complete history.
Original PR description
When HR refuses applicants in batch and sends mails, the mails are removed, because auto_delete_keep_log is set to false. It gives to HR wrong understanding that mails have not been send. Expected behavior; Don't remove refused mails, when sent in batch Forward-Port-Of: odoo/odoo#154720
This update adds a "Cancel" button to the activity plan wizard, which was missing in the recent v17 release. Users can now easily cancel their activity plan creation, reverting to the previous state without needing to use the "X" button. This improves user experience and simplifies the process of managing activity plans.
Original PR description
Restore the "Cancel" button when selecting a plan from the activity wizard. When we introduced the plan feature in v17, the "Cancel" button was forgotten. The only way for users to cancel the action is to click on the "X" button at the top right. task-3754897 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#154678
This change temporarily disables a failing test in the website's link tools to address persistent issues. The test has consistently failed due to underlying race conditions, and this action allows the test to run successfully on the automated system. A permanent fix is planned for a future commit.
Original PR description
runbot-57204 Forward-Port-Of: odoo/odoo#154679 Forward-Port-Of: odoo/odoo#154244
This update removes a confusing 'No documents to display' message from the customer portal. Because users always have access to their addresses and security/connection cards, this message was unnecessary. This change improves the overall user experience and reduces potential frustration for customers.
Original PR description
Remove `No documents to display` as there will always be at least the addresses and security/connection cards. task-id: 3629038 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#146197
This update corrects a minor issue where users were incorrectly redirected to general settings when clicking the Google and Outlook calendar sync buttons. Now, clicking these buttons will correctly direct users to the calendar settings, improving the user experience and ensuring seamless calendar synchronization. This resolves a previous navigation problem.
Original PR description
**Version:** - 17.0 **Steps to reproduce:** 1. Configure Google and Outlook Calendar and navigate to the calendar app. 2. Click on the Google and Outlook sync button, redirecting to the general settings. **Issue:** Users are now redirected to the general settings by using the Google and Outlook sync button. **Solution:** Update the `doAction` so, users will be redirected to the calendar settings. task-3731652 <hr/> I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#153581
This update fixes an issue where 'mandatory' days in the holiday calendar were displaying with an inconsistent color, causing visual problems. The changes now ensure 'mandatory' days render correctly with the calendar's background colors, providing a cleaner and more professional look. This improves the user experience when scheduling and viewing holidays.
Original PR description
"Mandatory" days use a random text color and they don't render well with the colored background colors of `.fc-today` and hovered days. The text-color has been removed on hovered mandatory days and mandatory days happening "today". The background of "fc-today" now uses the color of mandatory days when that day is mandatory. The SCSS has been cleaned up so as to not create repetitions. task-3617334 part of task-3575827 | Before | After | |----|-----| |  |  | --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#144236
2 changes
Resolved issues and error corrections
The cohort view now applies the same muted sample-data styling to its horizontal scrollbar when sample data is shown. This keeps the interface visually consistent and prevents the scrollbar from standing out unnecessarily.
Original PR description
This commit fixes an issue where the eventual horizontal scrollbar in cohort table would not receive sample data styling when needed. This would make it far too apparent due to https://github.com/odoo/odoo/pull/148138 OPW-3733829
The barcode batch transfer screen now hides the Confirm button when users open the action/settings menu where that action is not relevant. This reduces confusion and prevents users from seeing an option that does not make sense in the current view.
Original PR description
…e list views To reproduce issue: .go to barcode app .click on batch transfers .click on new .click on engine icon Expected result: confirm button hide Actual result: confirm button is not hide I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr When a user navigate from batch transfer and click on a engine icon the confirm button still showing, it's no makes sense for the current view. Now, when the user click on it, the confirm button will be hide and apear when close that menu. spec: https://drive.google.com/file/d/1UR-PtoM5CjfEi3X4p7LEpitl1_sspF-h/view task-3525776
2 changes
Resolved issues and error corrections
This update corrects an inaccurate help message in the Amazon sales integration module. The fix ensures users see the correct guidance when working with Amazon account settings, improving clarity and reducing confusion during setup and configuration.
Original PR description
Forward-Port-Of: odoo/enterprise#57011
This update corrects the VAT code in the Saudi Arabia electronic invoicing demo data to match the current requirements from ZATCA's Sandbox environment. This fix ensures that test submissions through the Sandbox portal will work properly for users testing the Saudi Arabia invoicing functionality.
Original PR description
Description of the issue/feature this PR addresses: ZATCA changed the VAT code used for submissions on Sandobx. The vat number in the l10n_sa_edi's demo data need to be updated to reflect this change. Current behavior before PR: Submissions through Sandbox do not work as the VAT code set on the demo Saudi company is different from the one the Sandbox portal expects. Desired behavior after PR is merged: Sandbox submissions should work properly once the demo data is updated. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#153851