Daily updates from Odoo
Friday, February 23, 2024
15 changes
10 changes
Resolved issues and error corrections
This update resolves a performance issue that slowed down the process of adding new messages in Odoo. By optimizing how related data is calculated, the system now inserts messages approximately twice as fast, leading to a smoother user experience. This change primarily impacts the 'mail' module.
Original PR description
Move compute of `imStatusTrackedPersonas` to its inverse field. Doing the compute on the "One" side of the relation prevents from looping and computing all values whenever there is a change in any of them. In practice, this reduces the "compute" time of the message fetch (which also fetch persona as authors of messages), reducing by approximately half the time it takes to insert these messages (depending on the number of persona it had to loop through). For example from 60ms to 30ms on my machine for message insert in "partner_1_125" (populate medium). Forward-Port-Of: odoo/odoo#154918
This update resolves an issue where the system was incorrectly summing data returned from a key function. This fix ensures accurate calculations within the stock account module, improving data reliability. No immediate user impact is expected.
Original PR description
This commit fixes summing list of dicts returned by _prepare_analytic_lines. NB: This code is not yet covered by a test use case. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#152819
This update resolves a performance issue related to how Odoo reads activity deadlines. By batching the reading process, the system now handles deadlines more efficiently, leading to faster response times. This change ensures smoother operation for users managing activities and appointments.
Original PR description
`__getitem__()` of BaseModel, reset the prefetch set of the recordset. Fix _compute_activity_date_deadline, to batched the reading of activity's deadline. Forward-Port-Of: odoo/odoo#154728 Forward-Port-Of: odoo/odoo#154159
This update resolves an issue where base users were incorrectly denied access to their own expense reports. A technical oversight in the system's design prevented them from generating these reports, resulting in an access error. This fix ensures all users, including base users, can properly create and access their expense reports.
Original PR description
Have a base user with no access to Accounting, Expenses, Employee Create an expense, input an amount Save and Create Report Access Error will raise You are not allowed to access 'Journal Entry' (account.move) records. This occurs because of a remaining field in the hr.expense.sheet form view after refactoring the model opw-3690493 Forward-Port-Of: odoo/odoo#154798 Forward-Port-Of: odoo/odoo#152288
This update resolves an issue that caused a 500 error when creating draft invoices with payment terms that include early discounts. The fix ensures the invoice preview function correctly calculates the total amount due, even when discounts are applied, preventing the error and improving invoice generation reliability.
Original PR description
Description of the issue this PR addresses: --- On obtains a 500: Internal Server Error when creating an invoice with a 2 lines payment term. Error while rendering the template…
Description of the issue this PR addresses: --- On obtains a 500: Internal Server Error when creating an invoice with a 2 lines payment term. Error while rendering the template "account.report_invoice_document". Steps to reproduce: --- - Accounting > Configuration > invoicing > Payment Terms - New > Create and save a payment term with 2 lines: - name 80/20 test - line_1 : 80% after 0 days - line_2 : 20% after 30 days - Sales > Orders > Quotations - Chose any > use payment terms 80/20 test - Save and create associated invoice > chose regular invoice - Create draft invoice > preview > 500: Internal Server Error Cause of the issue: --- The method "_get_amount_due_after_discount" called during the rendering of the template does not return a value in case self.early_discount is False. Fix: --- Return total_amount by default since no discount is applied. opw-3683708 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149934
This update quietly resolves a warning message that appeared after importing new modules into Odoo. Previously, the system attempted to update its internal graph, which was unnecessary and caused the warning. This change ensures a smoother import process without disrupting the user experience.
Original PR description
Before this PR, after having imported a module, a warning appears in the log, because it tries to update the graph which does not make sense for an imported module. This commit makes sure the warning is skipped if the module was imported. This commit can be backported to previous versions, if useful. Forward-Port-Of: odoo/odoo#155096
This update corrects a technical error preventing users from successfully verifying a partner's Peppol endpoint. The previous issue caused a system error, blocking the verification process. This fix ensures the Peppol verification feature functions correctly for all partners.
Original PR description
### Steps to reproduce * install `account_peppol` * open a partner's list view * select a contact * on the top middle, click Actions > Verify Peppol You should be met with a traceback: `AttributeError: 'bool' object has no attribute 'setdefault'` ### Cause `button_account_peppol_check_partner_endpoint` is expected to return an action or a falsy value (no action to perform). opw-3683612 Forward-Port-Of: odoo/odoo#152817
This update corrects a technical issue where translations weren't loading properly in Odoo. The team re-exported missing comments from .pot files, ensuring that translations are correctly identified and displayed for various Odoo add-ons. This improves the user experience for international customers.
Original PR description
odoo-python and odoo-javascript comments in .pot files are used to determine which translations to load. Omitting them would cause the translations not to appear. This commit goes through all .pot files and re-exports the ones where the comments have been omitted. Task-3764933. Enterprise: https://github.com/odoo/enterprise/pull/57361
This update resolves an issue where users lacked the ability to create new records with property fields if they didn't have access to the related parent record. The fix utilizes a temporary 'sudo' call to bypass access restrictions, ensuring all users can now create records with default property values.
Original PR description
When the user creates a new record having a property field, the system fetches the property definition of the parent record to retrieve the field's default values (see: `_add_default_values`). If the user lacks read access on the parent record, the user gets an access error when retrieving the property definition of the parent record. To prevent this error, we will perform a sudo call on the parent record before reading the property definition of the parent record. This allow the user to create a new record, even if they do not have access to the parent record. task-3594814 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#154651 Forward-Port-Of: odoo/odoo#146265
This update stops Odoo from automatically sending emails when a validation token is assigned to an order. Previously, this created extra notifications that weren't essential for business operations. This change improves system performance and reduces unnecessary email volume.
Original PR description
Before this commit, validation transactions would send an email when the token is assigned to the order. taskid: 3675875 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#154650 Forward-Port-Of: odoo/odoo#151773
1 change
Resolved issues and error corrections
The barcode batch transfer screen now hides the Confirm button when the user opens the settings menu. This prevents users from seeing or using an action that does not make sense in that context, making the workflow clearer.
Original PR description
To reproduce issue: .go to barcode app .click on batch transfers .click on new .click on engine icon Expected result: confirm button hide Actual result: confirm button is not hide I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr When a user navigate from batch transfer and click on a engine icon the confirm button still showing, it's no makes sense for the current view. Now, when the user click on it, the confirm button will be hide and apear when close that menu. task-3525776
4 changes
Resolved issues and error corrections
This update corrects the spacing and alignment of form fields in the Frontdesk Drinks section. Previously, an image field was causing misalignment of input fields relative to their labels. The fix adjusts the spacing settings to ensure all form elements line up properly, improving the visual consistency and usability of the form.
Original PR description
The o_field_image in the Drinks in the form view is cancelling the negative margin applied by the row class on the o_group. Using a gutter-x 0 on the o_group removes the padding allowing the inputs to be aligned with the title. This is a quickfix and the behavior of the o_field_image in a form view should be reviewed consistently across Odoo because different module seems to use their own fix for this (Ref: new task-3584778) task-3584529 | Before | | :--: | |  | After | |  |
This update removes two unnecessary guided tours from the accounting module that were providing redundant or confusing user guidance. The tours were creating sample bills and displaying unhelpful instruction bubbles that didn't add value to the user experience. This cleanup helps streamline the application and reduce maintenance burden.
Original PR description
The file `test_ui` is currently not imported. The tour is pretty useless and has been improved in 17.0. We will keep it in that version, to be sure that we don't break the equivalent tour, but we can remove in these versions (it just creates a sample bill and post it, currently). The tour `account_accountant_tour_upload_ocr_step` has been deemed useless. It pops a bubble on a button where it makes no sense, with a self-explanatory message already. Forward-Port-Of: odoo/enterprise#57120 Forward-Port-Of: odoo/enterprise#56726
This update corrects an XML identifier in the Belgian CodaBox Bridge configuration settings module. The fix ensures that the system properly recognizes and references the correct configuration element, preventing potential issues with the bank connection setup process for Belgian users.
This fix removes unnecessary warning messages that appeared in system logs after importing modules. The system was incorrectly trying to update its internal module tracking graph for imported modules, which doesn't apply to them. This change cleans up the logs and reduces confusion for system administrators.
Original PR description
Before this PR, after having imported a module, a warning appears in the log, because it tries to update the graph which does not make sense for an imported module. This commit makes sure the warning is skipped if the module was imported. This commit can be backported to previous versions, if useful.